mirror of
https://github.com/SCST-project/scst.git
synced 2026-05-29 18:00:18 +00:00
4011456a6f2a6757104f6b78d146356c77955bb2
5145 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Vladislav Bolkhovitin
|
4011456a6f |
SCST_VERSION_CODE fixed
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/3.2.x@7229 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
34cca9e432 |
Blocked revisions 7095,7097-7100,7102-7103,7105,7112-7114,7119-7124,7126-7133,7138,7140,7142,7144-7151,7155-7157,7159-7161,7164-7167,7172,7174,7180-7184,7186-7189,7191-7192,7194-7202,7204-7207 via svnmerge
........ r7095 | bvassche | 2017-02-23 18:07:29 -0800 (Thu, 23 Feb 2017) | 2 lines scst_copy_mgr: Convert comments about locking into runtime checks ........ r7097 | bvassche | 2017-02-23 23:07:41 -0800 (Thu, 23 Feb 2017) | 37 lines scst: Fix locking annotations Avoid that the following warnings are triggered: WARNING: CPU: 5 PID: 32343 at scst/src/scst_copy_mgr.c:2741 scst_cm_on_add_acg+0x12d/0x180 [scst] Call Trace: [<ffffffff812a4d23>] dump_stack+0x86/0xc3 [<ffffffff8106412b>] __warn+0xcb/0xf0 [<ffffffff8106421d>] warn_slowpath_null+0x1d/0x20 [<ffffffffa04f9b0d>] scst_cm_on_add_acg+0x12d/0x180 [scst] [<ffffffffa04b8084>] scst_alloc_add_acg+0xc4/0x280 [scst] [<ffffffffa0486b30>] scst_register_target+0x190/0x3a0 [scst] [<ffffffffa054f2de>] scst_cm_init+0xb8/0xdda [scst] [<ffffffffa054eab9>] init_scst+0xa06/0xc3f [scst] [<ffffffff8100043d>] do_one_initcall+0x3d/0x160 [<ffffffff81154ae0>] do_init_module+0x5f/0x1f1 [<ffffffff810efa69>] load_module+0x2719/0x2a50 [<ffffffff810effcc>] SYSC_finit_module+0xbc/0xf0 [<ffffffff810f001e>] SyS_finit_module+0xe/0x10 [<ffffffff8152fe40>] entry_SYSCALL_64_fastpath+0x23/0xc1 WARNING: CPU: 2 PID: 12885 at scst/src/scst_copy_mgr.c:2826 scst_cm_check_access_acg+0x180/0x1e0 [scst] Call Trace: [<ffffffff812a4d23>] dump_stack+0x86/0xc3 [<ffffffff8106412b>] __warn+0xcb/0xf0 [<ffffffff8106421d>] warn_slowpath_null+0x1d/0x20 [<ffffffffa0502b00>] scst_cm_check_access_acg+0x180/0x1e0 [scst] [<ffffffffa0502cba>] scst_cm_check_access+0x15a/0x280 [scst] [<ffffffffa05030cb>] scst_cm_parse_id_tgt_descr+0x2eb/0x590 [scst] [<ffffffffa050a1d8>] scst_cm_parse_descriptors+0x308/0xa60 [scst] [<ffffffffa04d4440>] scst_parse_descriptors+0x60/0x130 [scst] [<ffffffffa04a3c05>] scst_tgt_pre_exec+0x375/0x4a0 [scst] [<ffffffffa04ac2a9>] scst_process_active_cmd+0x439/0x740 [scst] [<ffffffffa04adbb2>] scst_cmd_thread+0x202/0x6a0 [scst] [<ffffffff810883cf>] kthread+0xef/0x110 [<ffffffff8153008f>] ret_from_fork+0x1f/0x40 ........ r7098 | bvassche | 2017-02-24 17:54:58 -0800 (Fri, 24 Feb 2017) | 18 lines scst_copy_mgr: Avoid that scst_cm_on_add_lun() triggers a kernel warning Avoid that the following warning is triggered: WARNING: CPU: 1 PID: 1282 at scst/src/scst_copy_mgr.c:2784 scst_cm_on_add_lun+0x141/0x1b0 [scst] Call Trace: dump_stack+0x86/0xc3 __warn+0xc1/0xe0 warn_slowpath_null+0x18/0x20 scst_cm_on_add_lun+0x141/0x1b0 [scst] scst_acg_add_lun+0x27f/0x370 [scst] __scst_process_luns_mgmt_store+0x589/0x5f0 [scst] scst_luns_mgmt_store_work_fn+0x22/0x30 [scst] scst_process_sysfs_works+0x7b/0x1c0 [scst] sysfs_work_thread_fn+0x11b/0x280 [scst] kthread+0x102/0x140 ret_from_fork+0x31/0x40 ........ r7099 | bvassche | 2017-02-24 17:56:30 -0800 (Fri, 24 Feb 2017) | 21 lines scst_copy_mgr: Avoid that scst_cm_check_access_acg() triggers a kernel warning Avoid that the following kernel warning is triggered: WARNING: CPU: 2 PID: 1761 at scst/src/scst_copy_mgr.c:2835 Call Trace: dump_stack+0x86/0xc3 __warn+0xc1/0xe0 warn_slowpath_null+0x18/0x20 scst_cm_check_access_acg+0x1c2/0x1d0 [scst] scst_cm_check_access+0x155/0x280 [scst] scst_cm_parse_id_tgt_descr+0x2e6/0x590 [scst] scst_cm_parse_descriptors+0x303/0xa60 [scst] scst_parse_descriptors+0x5b/0x130 [scst] scst_tgt_pre_exec+0x370/0x4a0 [scst] scst_process_active_cmd+0x455/0x770 [scst] scst_cmd_thread+0x1fb/0x690 [scst] kthread+0x102/0x140 ret_from_fork+0x31/0x40 ........ r7100 | bvassche | 2017-02-27 14:36:33 -0800 (Mon, 27 Feb 2017) | 4 lines scst_copy_mgr: Warn if LUN lookup fails It really is a bug if LUN lookup fails. ........ r7102 | bvassche | 2017-03-01 16:09:14 -0800 (Wed, 01 Mar 2017) | 5 lines scst: Coding style updates related to whitespace This patch changes whitespace only and nothing else. ........ r7103 | bvassche | 2017-03-01 16:10:24 -0800 (Wed, 01 Mar 2017) | 5 lines scst: Coding style update related to the use of the keyword 'unsigned' Use 'unsigned int' instead of 'unsigned' and 'unsigned long long' instead of 'long long unsigned'. ........ r7105 | bvassche | 2017-03-07 20:43:23 -0800 (Tue, 07 Mar 2017) | 1 line scst_lib.c: Fix indentation ........ r7112 | vlnb | 2017-04-13 16:15:17 -0700 (Thu, 13 Apr 2017) | 9 lines iscsi: fix misleading error logging in config.c This fixes four similar instances of a very misleading and confusing logging statement, which would print a "Wrong value" that had already been corrected by the check function. Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7113 | vlnb | 2017-04-13 16:16:57 -0700 (Thu, 13 Apr 2017) | 7 lines iscsi: logging improvements for iscsi_scstd.c Logging improvements for iscsi_scstd.c print more information about failures. Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7114 | vlnb | 2017-04-13 16:19:05 -0700 (Thu, 13 Apr 2017) | 5 lines scst_vdisk: logging to distinguish different cases of EINVAL Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7119 | vlnb | 2017-04-13 16:43:55 -0700 (Thu, 13 Apr 2017) | 8 lines scst: remove superfluous assignment in scst_dg_add() The "res" is unconditionally set by the call to scst_dg_sysfs_add(), so setting it to ENOMEM above that is superfluous. Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7120 | vlnb | 2017-04-13 16:45:15 -0700 (Thu, 13 Apr 2017) | 9 lines scst_vdisk: remove parentheses from DEF_DIF_FILENAME_TMPL DEF_DIF_FILENAME_TMPL should not have the parentheses; I used it in some context where that became apparent. Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7121 | vlnb | 2017-04-13 16:53:35 -0700 (Thu, 13 Apr 2017) | 10 lines scst_vdisk: move declarations inside #ifdef Move some #ifdefs to also cover declarations used only inside the #ifdef. This is to avoid compiler warnings about unused variables. Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7122 | vlnb | 2017-04-13 16:58:32 -0700 (Thu, 13 Apr 2017) | 9 lines Fix a few compiler messages issued when some extra warnings are enabled: casting const to non-const uninitialized structure members non-static local function missing enumerated switch-value cases Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7123 | vlnb | 2017-04-13 18:03:25 -0700 (Thu, 13 Apr 2017) | 8 lines Fix a few minor "extra" compiler warnings (mostly "const" issues) Add "XXX" comments in a few places about potential problems seen in SCST code, for future investigation and possible repair. Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7124 | vlnb | 2017-04-13 18:16:10 -0700 (Thu, 13 Apr 2017) | 5 lines iscsi-scst: clean up the conftest subdirectory too Reported-by: David Butterfield <dab21774@gmail.com> ........ r7126 | vlnb | 2017-04-13 18:19:06 -0700 (Thu, 13 Apr 2017) | 5 lines backport ACCESS_ONCE() before 2.6.26 Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7127 | bvassche | 2017-04-13 21:21:38 -0700 (Thu, 13 Apr 2017) | 4 lines ib_srpt: Optimize Makefile Cache conftest results and enable parallel invocation of conftests. ........ r7128 | bvassche | 2017-04-13 21:29:38 -0700 (Thu, 13 Apr 2017) | 4 lines iscsi-scst/Makefile: Optimize Makefile Cache conftest results and enable parallel invocation of conftests. ........ r7129 | bvassche | 2017-04-14 13:46:50 -0700 (Fri, 14 Apr 2017) | 1 line ib_srpt: Fix two configuration tests ........ r7130 | bvassche | 2017-04-14 13:47:26 -0700 (Fri, 14 Apr 2017) | 1 line isert-scst: Fix two configuration tests ........ r7131 | bvassche | 2017-04-14 14:38:56 -0700 (Fri, 14 Apr 2017) | 6 lines iscsi-scst/Makefile: Fix detection of whether InfiniBand is enabled Inspecting modules.symbols is fine after a kernel has been installed but not if a kernel tree has not been installed. If a kernel tree has not been installed, check the .config file. ........ r7132 | bvassche | 2017-04-14 21:10:31 -0700 (Fri, 14 Apr 2017) | 1 line iscsi-scst/Makefile: Add support for make -i ........ r7133 | bvassche | 2017-04-14 21:10:44 -0700 (Fri, 14 Apr 2017) | 1 line srpt/Makefile: Add support for make -i ........ r7138 | vlnb | 2017-04-20 17:57:10 -0700 (Thu, 20 Apr 2017) | 11 lines iscsi-scst: change local names of ioctl() and open() to not conflict Change local names of ioctl() and open() to not conflict with C library names. This isn't really a bug in a strictly kernel-resident build, but the change avoids symbol conflicts with libc when building for usermode. Signed-off-by: David Butterfield <dab21774@gmail.com> with some changes ........ r7140 | vlnb | 2017-04-20 18:04:16 -0700 (Thu, 20 Apr 2017) | 9 lines iscsi-scstd: daemon handle EOF (rc == 0) from nl_fd Daemon now handles receipt of EOF (rc == 0) from nl_fd. Probably this never happens in a real kernel build, but it does during shutdown in a usermode build and it seems like it is "generically correct" in either case. Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7142 | vlnb | 2017-04-20 18:17:53 -0700 (Thu, 20 Apr 2017) | 10 lines iscsi-scst: reset conn->rx_task in scsi_cmnd_start() for EXTRACHECKS In scsi_cmnd_start() conn->rx_task is intended to be set only during the call to _stage1_done, but there was no code to reset it. It doesn't actually matter in execution, but it was a little confusing to wonder and try to understand why it wasn't reset. Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7144 | vlnb | 2017-04-20 18:36:34 -0700 (Thu, 20 Apr 2017) | 16 lines iscsi_scst: conn_lookup() skips any conn already closing This change helped a secondary problem I had under valgrind (due to some other bug) with initiators timing out and reconnecting their sessions faster than the threads were getting cleaned up (for one thing, valgrind only ever runs one thread at a time). It seems logical that the code in conn_lookup() would want to skip any connection that's already known closing in this case, for the same reason it searches the list in reverse. And the dropping connections don't have to drop in order, so searching in reverse doesn't seem sufficient to avoid finding a wrong (stale, closing) connection structure. Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7145 | vlnb | 2017-04-21 20:04:34 -0700 (Fri, 21 Apr 2017) | 3 lines Web updates ........ r7146 | vlnb | 2017-04-21 20:19:52 -0700 (Fri, 21 Apr 2017) | 3 lines Copyright updates ........ r7147 | vlnb | 2017-04-21 20:21:07 -0700 (Fri, 21 Apr 2017) | 3 lines Web updates ........ r7148 | vlnb | 2017-04-21 20:33:13 -0700 (Fri, 21 Apr 2017) | 3 lines Web updates ........ r7149 | vlnb | 2017-04-21 20:50:03 -0700 (Fri, 21 Apr 2017) | 3 lines Web updates ........ r7150 | vlnb | 2017-04-21 20:58:24 -0700 (Fri, 21 Apr 2017) | 3 lines Web updates ........ r7151 | vlnb | 2017-04-21 21:15:21 -0700 (Fri, 21 Apr 2017) | 3 lines ql2x00t: howto update ........ r7155 | vlnb | 2017-04-28 18:00:59 -0700 (Fri, 28 Apr 2017) | 8 lines scst: add mutex_lock/unlock around scst_alloc_add_acg() The CONFIG_SCST_PROC build was calling scst_alloc_add_acg() without holding the scst_mutex. Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7156 | bvassche | 2017-05-01 13:22:56 -0700 (Mon, 01 May 2017) | 1 line scst_debug: Remove a duplicated #include directive ........ r7157 | bvassche | 2017-05-01 13:26:08 -0700 (Mon, 01 May 2017) | 3 lines Surround #include <linux/version.h> with #ifndef INSIDE_KERNEL_TREE / #endif ........ r7159 | bvassche | 2017-05-01 22:18:05 -0700 (Mon, 01 May 2017) | 1 line scst_sysfs: Fix spelling in a source code comment ........ r7160 | bvassche | 2017-05-01 22:28:29 -0700 (Mon, 01 May 2017) | 1 line qla2x00t: Convert the non-standard %Lx into %llx ........ r7161 | bvassche | 2017-05-02 07:10:22 -0700 (Tue, 02 May 2017) | 1 line scripts: Update kernel download location ........ r7164 | bvassche | 2017-05-02 11:32:56 -0700 (Tue, 02 May 2017) | 1 line scripts/generate-kernel-patch: Stop applying the put_page_callback and exec_req_fifo patches ........ r7165 | bvassche | 2017-05-02 15:32:06 -0700 (Tue, 02 May 2017) | 4 lines Fix spelling of "Ardis Technologies" Reference: http://www.ddpsan.com/support-sales/about-us. ........ r7166 | bvassche | 2017-05-03 19:36:37 -0700 (Wed, 03 May 2017) | 1 line scstadmin: Fix a few bugs in the regression test code ........ r7167 | bvassche | 2017-05-03 19:45:35 -0700 (Wed, 03 May 2017) | 1 line scst_lib: Convert a comment into a runtime check ........ r7172 | vlnb | 2017-05-10 20:57:04 -0700 (Wed, 10 May 2017) | 8 lines scst: scst_finish_cmd() not try to left-shift lba of -1 Change scst_finish_cmd() so that it does not attempt to left-shift lba when it is -1 (the error value). Left-shifting of a negative value is undefined in C. Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7174 | vlnb | 2017-05-12 20:30:07 -0700 (Fri, 12 May 2017) | 6 lines scst: add module parameter to control the copy manager auto assignment Reported-By: Guru Prasad <gp22online@gmail.com> Suggested-By: Sebastian Herbszt <herbszt@gmx.de> ........ r7180 | bvassche | 2017-05-13 20:49:39 -0700 (Sat, 13 May 2017) | 5 lines scst_vdisk: Avoid shifting left by a negative number of bits scst_calc_block_shift() can return a negative number. Hence avoid 1 << scst_calc_block_shift(). Detected by Coverity. ........ r7181 | mlx-storage | 2017-05-14 06:45:02 -0700 (Sun, 14 May 2017) | 6 lines isert-scst: fix isert connection teardown flow Synchronizing the rdma_disconnect() with the post drain wr as other ULPs like iSER do. Signed-off-by: Israel Rukshin <israelr@mellanox.com> ........ r7182 | bvassche | 2017-05-14 07:55:00 -0700 (Sun, 14 May 2017) | 1 line ib_srpt: Fix a logging statement ........ r7183 | bvassche | 2017-05-14 11:49:04 -0700 (Sun, 14 May 2017) | 4 lines isert-scst: Enable type checking for isert portal pointers This patch does not change any functionality. ........ r7184 | bvassche | 2017-05-14 11:53:01 -0700 (Sun, 14 May 2017) | 14 lines isert-scst: Avoid that shutdown sporadically hangs Waiting for other threads to release an object using code like "while (object->refcnt > 0) msleep(100)" without holding a reference on 'object' is wrong because the memory object points at may be freed before or while this loop is in progress. Hence introduce a global portal object count and wait on that count instead of waiting for the per-portal reference count to reach zero. The use-after-free was introduced in r6952 ("isert: faster release of isert_scst module"). See also https://sourceforge.net/p/scst/tickets/2/. ........ r7186 | bvassche | 2017-05-15 19:04:47 -0700 (Mon, 15 May 2017) | 1 line isert-scst: Fix a race condition that was introduced accidentally in r7184 ........ r7187 | vlnb | 2017-05-18 19:37:49 -0700 (Thu, 18 May 2017) | 8 lines scst: implement BLOCKIO devices "active" attribute Intended to be able to load on passive side as described in https://sourceforge.net/p/scst/mailman/message/35549446/ Suggested-by: Кирилл Тюшев <kirill.tyushev8@gmail.com> ........ r7188 | vlnb | 2017-05-18 19:58:23 -0700 (Thu, 18 May 2017) | 21 lines qla2x00t: Disable Out-of-order processing by default From: Quinn Tran <quinn.tran@cavium.com> Out of order(OOO) processing requires initiator, switch and target to support OOO. In today¹s environment, none of the switches support OOO. OOO requires extra buffer space which affect performance. By turning ON this feature in QLogic's FW, it delays error recovery because droped frame is treated as out of order frame. We¹re turning OFF this option of speed up error recovery. Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Quinn Tran <quinn.tran@cavium.com> Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com> Merge of mainline commit 300af14bdb28157090f0c6f89d244fda940082da EXPERIMENTAL! ........ r7189 | vlnb | 2017-05-19 19:04:16 -0700 (Fri, 19 May 2017) | 9 lines scst: compute max_transfer args as long, not int Compute max_transfer args as long, not int, to avoid overflow when max_sg_cnt=32768 and PAGE_SHIFT=16 (64K PAGE_SIZE). Note it is not only the min() call, but also the << PAGE_SHIFT needs to be long. Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7191 | vlnb | 2017-05-19 20:19:54 -0700 (Fri, 19 May 2017) | 6 lines scst: restore locking documentation comments Better to follow the common rule and always have locking expectations documented in addition to runtime checks. Partial revert of r7095. ........ r7192 | vlnb | 2017-05-19 20:29:41 -0700 (Fri, 19 May 2017) | 5 lines scst: minor cleanup Let's keep it simple without unused functionality ........ r7194 | vlnb | 2017-05-22 20:50:43 -0700 (Mon, 22 May 2017) | 91 lines scst: prevent possible memory reclaim deadlock Reported by lockdep: [ 415.813281] ================================= [ 415.817626] [ INFO: inconsistent lock state ] [ 415.821974] 4.10.12-scst-dbg #4 Tainted: G O [ 415.827360] --------------------------------- [ 415.831705] inconsistent {RECLAIM_FS-ON-W} -> {IN-RECLAIM_FS-W} usage. [ 415.838217] kswapd0/558 [HC0[0]:SC0[0]:HE1:SE1] takes: [ 415.843342] (sgv_pools_mutex){+.+.?.}, at: [<ffffffffa036d300>] __sgv_shrink+0x90/0x1d0 [scst] [ 415.852075] {RECLAIM_FS-ON-W} state was registered at: [ 415.857208] mark_held_locks+0x6c/0x90 [ 415.861034] lockdep_trace_alloc+0x8a/0xd0 [ 415.865210] kmem_cache_alloc_node+0x32/0x2f0 [ 415.869670] sgv_pool_create_node+0x186/0x2e0 [scst] [ 415.874735] sgv_pool_create+0x12/0x20 [scst] [ 415.879194] scst_sgv_pools_init+0xb9/0x3c0 [scst] [ 415.884065] __dev_user_set_opt+0x152/0x5f0 [scst_user] [ 415.889367] do_one_initcall+0x59/0x190 [ 415.893280] do_init_module+0x6a/0x230 [ 415.897106] load_module+0x591/0x830 [ 415.900758] SYSC_init_module+0xd3/0x120 [ 415.904758] SyS_init_module+0xe/0x10 [ 415.908501] entry_SYSCALL_64_fastpath+0x18/0xad [ 415.913193] irq event stamp: 3831137 [ 415.916763] hardirqs last enabled at (3831137): [<ffffffff8106ff37>] __local_bh_enable_ip+0x67/0xd0 [ 415.925878] hardirqs last disabled at (3831135): [<ffffffff8106fefe>] __local_bh_enable_ip+0x2e/0xd0 [ 415.935018] softirqs last enabled at (3831136): [<ffffffffa036c72d>] __sgv_can_be_shrunk+0x9d/0x180 [scst] [ 415.944764] softirqs last disabled at (3831134): [<ffffffffa036c6e3>] __sgv_can_be_shrunk+0x53/0x180 [scst] [ 415.954481] [ 415.954481] other info that might help us debug this: [ 415.960994] Possible unsafe locking scenario: [ 415.960994] [ 415.966899] CPU0 [ 415.969336] ---- [ 415.971774] lock(sgv_pools_mutex); [ 415.975339] <Interrupt> [ 415.977950] lock(sgv_pools_mutex); [ 415.981691] [ 415.981691] *** DEADLOCK *** [ 415.981691] [ 415.987599] 1 lock held by kswapd0/558: [ 415.991424] #0: (shrinker_rwsem){++++..}, at: [<ffffffff811ace5c>] T.1898+0x4c/0x100 [ 415.999329] [ 415.999329] stack backtrace: [ 416.003677] CPU: 2 PID: 558 Comm: kswapd0 Tainted: G O 4.10.12-scst-dbg #4 [ 416.011663] Hardware name: Dell Inc. PowerEdge R710/00NH4P, BIOS 2.2.10 11/09/2010 [ 416.019216] Call Trace: [ 416.021661] dump_stack+0x6b/0xa0 [ 416.024968] print_usage_bug+0x182/0x190 [ 416.028881] ? print_circular_bug+0x110/0x110 [ 416.033226] mark_lock_irq+0xee/0x290 [ 416.036879] mark_lock+0x113/0x1a0 [ 416.040271] mark_irqflags+0xb0/0x180 [ 416.043924] __lock_acquire+0x245/0x610 [ 416.047750] ? __lock_release+0x408/0x470 [ 416.051750] lock_acquire+0xce/0x2b0 [ 416.055343] ? __sgv_shrink+0x90/0x1d0 [scst] [ 416.059689] ? mutex_lock_nested+0x47/0x750 [ 416.063863] mutex_lock_nested+0x82/0x750 [ 416.067888] ? __sgv_shrink+0x90/0x1d0 [scst] [ 416.072236] ? put_lock_stats+0xe/0x30 [ 416.075975] ? __lock_release+0x408/0x470 [ 416.080001] ? __sgv_shrink+0x90/0x1d0 [scst] [ 416.084349] ? debug_smp_processor_id+0x17/0x20 [ 416.088868] ? put_lock_stats+0xe/0x30 [ 416.092633] ? __sgv_can_be_shrunk+0x9d/0x180 [scst] [ 416.097588] ? mark_held_locks+0x6c/0x90 [ 416.101500] ? __local_bh_enable_ip+0x67/0xd0 [ 416.105873] __sgv_shrink+0x90/0x1d0 [scst] [ 416.110047] ? __local_bh_enable_ip+0x67/0xd0 [ 416.114420] sgv_scan_shrink+0x5d/0x120 [scst] [ 416.118853] do_shrink_slab+0x19b/0x5f0 [ 416.122678] ? T.1898+0x4c/0x100 [ 416.125899] ? down_read_trylock+0x60/0x80 [ 416.129985] T.1898+0xb4/0x100 [ 416.133031] shrink_node+0x62/0xa0 [ 416.136424] balance_pgdat+0x1c8/0x2c0 [ 416.140164] kswapd+0xa0/0x2b0 [ 416.143211] ? preempt_count_sub+0x9f/0xe0 [ 416.147409] ? schedule+0x4e/0xc0 [ 416.150715] ? balance_pgdat+0x2c0/0x2c0 [ 416.154627] kthread+0x111/0x150 [ 416.157849] ? call_usermodehelper_exec_work+0xa0/0xa0 [ 416.162974] ? __kthread_init_worker+0x80/0x80 [ 416.167407] ? call_usermodehelper_exec_work+0xa0/0xa0 [ 416.172534] ? call_usermodehelper_exec_work+0xa0/0xa0 [ 416.177660] ret_from_fork+0x2e/0x40 ........ r7195 | vlnb | 2017-05-24 19:11:06 -0700 (Wed, 24 May 2017) | 8 lines iscsi-scst: cleanup There's no need to end-align the padding. Plus, it's not optimal to access front misaligned memory Reported-by: David Butterfield <dab21774@gmail.com> ........ r7196 | vlnb | 2017-05-25 19:45:47 -0700 (Thu, 25 May 2017) | 5 lines scst_vdisk: add "active" attridute to the list of BLOCKIO add device attributes This is forgotten piece to r7187 ........ r7197 | vlnb | 2017-05-30 21:01:00 -0700 (Tue, 30 May 2017) | 3 lines scst: a better version of possible memory reclaim deadlock fix r7194 ........ r7198 | vlnb | 2017-05-31 20:46:06 -0700 (Wed, 31 May 2017) | 5 lines scst: cleanup of dead code Reported-By: David Butterfield <dab21774@gmail.com> ........ r7199 | vlnb | 2017-05-31 20:49:26 -0700 (Wed, 31 May 2017) | 5 lines scst: scst_free_acg() not dereference NULL acg->tgt for proc interface Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7200 | vlnb | 2017-05-31 20:53:08 -0700 (Wed, 31 May 2017) | 11 lines iscsi-scst: fix a couple of bad-function-cast warnings This is a "marginal" warning, but there are only six of them in the SCST code and this fixes two of those. session.c:105:4: warning: cast from function call of type void * to non-matching type _Bool [-Wbad-function-cast] target.c:668:14: warning: cast from function call of type void * to non-matching type _Bool [-Wbad-function-cast] Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7201 | vlnb | 2017-05-31 21:04:45 -0700 (Wed, 31 May 2017) | 13 lines scst: remove a few unnecessary shadow declarations Remove a few "shadow" declarations that appear unnecessary and probably unintended. (These are cases where a declaration in an inner scope hides another declaration of the same name in an outer scope.) Not all shadow declarations are superfluous -- so this particular compiler warning is one that cannot be simply heeded while half asleep. But these particular ones I removed appear to be superfluous. Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7202 | vlnb | 2017-05-31 21:08:02 -0700 (Wed, 31 May 2017) | 8 lines usr: fix -Wmissing-prototypes warnings Fix all twelve [-Wmissing-prototypes] warnings by adding "static" to their declarations. Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7204 | vlnb | 2017-06-02 21:02:22 -0700 (Fri, 02 Jun 2017) | 5 lines Fix dereference beyond last sg element Reported-By: David Butterfield <dab21774@gmail.com> ........ r7205 | vlnb | 2017-06-05 21:20:09 -0700 (Mon, 05 Jun 2017) | 10 lines scst_vdisk: 'numa_node_id' signed attribute value fix The "numa_node_id" attribute reside in the scst_vdisk_dev struct as signed integer and may well be negative values (eg, -1), so move fetching it above the unsigned attributes and use kstrtoll() to retrieve the values. Signed-off-by: Marc A. Smith <marc.smith@parodyne.com> ........ r7206 | vlnb | 2017-06-06 18:13:58 -0700 (Tue, 06 Jun 2017) | 3 lines scst: update ALUA documentation (Active/Non-Optimized) ........ r7207 | vlnb | 2017-06-06 18:23:59 -0700 (Tue, 06 Jun 2017) | 3 lines scst: minor cleanup for previous commit ........ git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/3.2.x@7210 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
bb4d276a54 |
Merged revisions 7096,7101,7104,7106-7111,7115-7118,7125,7134-7137,7139,7141,7143,7152-7154,7158,7162-7163,7168-7171,7173,7175-7179,7185,7190,7193,7203,7208 via svnmerge from
svn+ssh://svn.code.sf.net/p/scst/svn/trunk ........ r7096 | bvassche | 2017-02-23 18:08:17 -0800 (Thu, 23 Feb 2017) | 4 lines scst_copy_mgr: Avoid that LUN removal triggers a BUG() Reported-by: Jinpu Wang <jinpu.wang@profitbricks.com> ........ r7101 | bvassche | 2017-03-01 07:31:59 -0800 (Wed, 01 Mar 2017) | 20 lines scst_vdisk: Avoid that LUN refresh triggers a general protection fault Avoid that triggering LUN referesh concurrently with device deletion triggers the following: general protection fault: 0000 [#1] Workqueue: events vdev_inq_changed_fn [scst_vdisk] Call Trace: _raw_spin_lock_bh+0x2b/0x30 scst_cm_update_dev+0x87/0x190 [scst] scst_dev_inquiry_data_changed+0xfb/0x1b0 [scst] vdev_inq_changed_fn+0x60/0x120 [scst_vdisk] process_one_work+0x14d/0x410 worker_thread+0x66/0x460 kthread+0xdb/0x100 ret_from_fork+0x3f/0x70 Reported-by: Jinpu Wang <jinpu.wang@profitbricks.com> Tested-by: Jinpu Wang <jinpu.wang@profitbricks.com> ........ r7104 | vlnb | 2017-03-07 20:36:45 -0800 (Tue, 07 Mar 2017) | 5 lines Linux kernel v4.10 build fix. Signed-off-by: Sebastian Herbszt <herbszt@gmx.de> ........ r7106 | bvassche | 2017-04-11 11:48:36 -0700 (Tue, 11 Apr 2017) | 4 lines ib_srpt: Ensure that the BUG_ON() argument has no side effects Reported-by: David Butterfield <dab21774@gmail.com> ........ r7107 | vlnb | 2017-04-13 15:04:07 -0700 (Thu, 13 Apr 2017) | 7 lines The argument to sleep() would get "promoted" to an integer with value zero. - sleep(0.1); + usleep(100*1000); Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7108 | vlnb | 2017-04-13 15:30:25 -0700 (Thu, 13 Apr 2017) | 6 lines create_and_open_dev() returns a (-errno), so the "if (iser_fd...)" check should detect *any* negative return value as a case when fd should be set to -1. Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7109 | vlnb | 2017-04-13 15:38:38 -0700 (Thu, 13 Apr 2017) | 8 lines Change memcpy() to strncpy() because the source name string is not guaranteed to exist as valid addressable memory beyond the NULL byte. Signed-off-by: David Butterfield <dab21774@gmail.com> with small addition to force set last byte NULL ........ r7110 | vlnb | 2017-04-13 16:02:18 -0700 (Thu, 13 Apr 2017) | 7 lines Thre is potential buffer overflow in iscsi_session_alloc() due to short computation of needed string size. Notice the "%s@%s" in the first call to sprintf(). Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7111 | vlnb | 2017-04-13 16:12:46 -0700 (Thu, 13 Apr 2017) | 8 lines iscsi: avoid a crash in iscsi_extracheck_is_rd_thread() Add an extra check in iscsi_extracheck_is_rd_thread() to avoid a crash when conn->rd_task is NULL. Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7115 | vlnb | 2017-04-13 16:37:13 -0700 (Thu, 13 Apr 2017) | 12 lines scst: fix memory leak in scst_proc_group_add() Valgrind noticed that the "name" allocated in scst_proc_group_add() was leaking. It turns out that scst_alloc_add_acg makes its own copy of the name passed to it from this code, making the string duplication done here redundant (and leaky). The change eliminates the string duplication (along with all its associated error handling logic) and simply passes the (unowned) incoming string down for duplication below. Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7116 | vlnb | 2017-04-13 16:39:14 -0700 (Thu, 13 Apr 2017) | 7 lines scst_vdisk: fix memory leak in vdisk_write_proc() Another leak valgrind popped out, this one in vdisk_write_proc(). Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7117 | vlnb | 2017-04-13 16:41:14 -0700 (Thu, 13 Apr 2017) | 9 lines scst: take scst_mutex before calling scst_del_free_acg() in exit_scst() scst_del_free_acg() does lockdep_assert_held(&scst_mutex), so we'd better take the lock before calling it. Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7118 | vlnb | 2017-04-13 16:42:51 -0700 (Thu, 13 Apr 2017) | 8 lines scst: take scst_mutex before calling scst_del_free_acg() in scst_proc_cleanup_module() Take lock before a call that ends up at the lockdep_assert_held() in scst_del_free_acg() without locking. Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7125 | vlnb | 2017-04-13 18:17:45 -0700 (Thu, 13 Apr 2017) | 6 lines extraclean does "rm tags cscope.out" Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7134 | vlnb | 2017-04-17 20:57:12 -0700 (Mon, 17 Apr 2017) | 5 lines iscsi-scst: replace strncpy() by strlcpy() Follow up for r7109: strlcpy() is more appropriate in this place. ........ r7135 | vlnb | 2017-04-17 21:02:44 -0700 (Mon, 17 Apr 2017) | 5 lines fcst: Linux kernel v4.10 build fix Signed-off-by: Sebastian Herbszt <herbszt@gmx.de> ........ r7136 | vlnb | 2017-04-17 21:06:18 -0700 (Mon, 17 Apr 2017) | 5 lines scst: avoid possible side effect with WARN_ON_ONCE() Reported-By: David Butterfield <dab21774@gmail.com> ........ r7137 | vlnb | 2017-04-18 20:44:20 -0700 (Tue, 18 Apr 2017) | 5 lines fileio_tgt: change "#if DEBUG_TM_FN_IGNORE" to "#ifdef ..." Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7139 | vlnb | 2017-04-20 18:02:25 -0700 (Thu, 20 Apr 2017) | 7 lines iscsi-scstd: replace signal() with sigaction() Replace signal() with sigaction() for validity in a multithreaded process Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7141 | vlnb | 2017-04-20 18:11:37 -0700 (Thu, 20 Apr 2017) | 7 lines scst: set file size for NULLIO in PROCFS build The file size wasn't getting set for NULLIO with /proc support Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7143 | vlnb | 2017-04-20 18:32:07 -0700 (Thu, 20 Apr 2017) | 9 lines iscsi-scst: fix ENOMEM path In an error path in iscsi_threads_pool_get(), when a new pool cannot be allocated, if there is a pool on iscsi_thread_pools_list, it passes that back as an alternative, so return zero in that case. Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7152 | bvassche | 2017-04-26 16:53:11 -0700 (Wed, 26 Apr 2017) | 5 lines scst: Introduce scst_scsi_execute() This patch does not change any functionality but makes it easier to port SCST to Linux kernel v4.11. ........ r7153 | bvassche | 2017-04-26 17:17:22 -0700 (Wed, 26 Apr 2017) | 1 line scst: Port to Linux kernel v4.11 ........ r7154 | vlnb | 2017-04-28 17:58:55 -0700 (Fri, 28 Apr 2017) | 5 lines scst: create proc/scst_threads with mode S_IRUGO, not 0 Signed-off-by: David Butterfield <dab21774@gmail.com> ........ r7158 | bvassche | 2017-05-01 14:01:33 -0700 (Mon, 01 May 2017) | 1 line scst: Kernel v4.12 build fixes ........ r7162 | bvassche | 2017-05-02 07:13:15 -0700 (Tue, 02 May 2017) | 1 line scst_lib: Fix kernel 2.6.30 build ........ r7163 | bvassche | 2017-05-02 07:23:00 -0700 (Tue, 02 May 2017) | 1 line scst: Fix build for kernels before v2.6.39 ........ r7168 | bvassche | 2017-05-03 19:56:27 -0700 (Wed, 03 May 2017) | 1 line scst: Fix build for kernels before v2.6.39 ........ r7169 | vlnb | 2017-05-05 18:31:59 -0700 (Fri, 05 May 2017) | 3 lines scst: nolockdep patch for kernel 4.9 ........ r7170 | vlnb | 2017-05-10 20:51:32 -0700 (Wed, 10 May 2017) | 3 lines qla2x00t: update to kernel 4.10 ........ r7171 | vlnb | 2017-05-10 20:52:51 -0700 (Wed, 10 May 2017) | 3 lines scst: nolockdep patch for kernel 4.10 ........ r7173 | vlnb | 2017-05-10 21:00:29 -0700 (Wed, 10 May 2017) | 7 lines fcst: Linux kernel v4.11 build fix Linux kernel v4.11 build fix. Signed-off-by: Sebastian Herbszt <herbszt@gmx.de> ........ r7175 | bvassche | 2017-05-13 17:42:24 -0700 (Sat, 13 May 2017) | 4 lines scst/include/backport.h: Remove duplicate definition of kthread_create_on_node() This patch reverts most of r7168. ........ r7176 | bvassche | 2017-05-13 17:55:39 -0700 (Sat, 13 May 2017) | 1 line scst/include/backport.h: Add a comment ........ r7177 | bvassche | 2017-05-13 19:55:24 -0700 (Sat, 13 May 2017) | 1 line scst/include/backport.h: Fix kthread_create_on_node() definition ........ r7178 | bvassche | 2017-05-13 20:06:54 -0700 (Sat, 13 May 2017) | 4 lines scst/include/backport.h: Add a kref_read() backport This patch does not change any functionality. ........ r7179 | bvassche | 2017-05-13 20:13:56 -0700 (Sat, 13 May 2017) | 4 lines scst/include/backport.h: Add a backport of rcu_dereference_protected() This patch does not change any functionality. ........ r7185 | bvassche | 2017-05-14 11:56:09 -0700 (Sun, 14 May 2017) | 14 lines scst_local: Fix a race condition Avoid that the following crash can occur: general protection fault: 0000 [#1] PREEMPT SMP RIP: 0010:scsi_is_host_device+0x7/0x20 [scsi_mod] Call Trace: scst_process_aens+0x95/0x1d0 [scst_local] scst_aen_work_fn+0x6f/0x120 [scst_local] process_one_work+0x20b/0x6c0 worker_thread+0x4e/0x4a0 kthread+0x113/0x150 ret_from_fork+0x31/0x40 ........ r7190 | vlnb | 2017-05-19 20:00:28 -0700 (Fri, 19 May 2017) | 8 lines scst: fix possible NULL dereference in TM code TM command accessing a non-existing LUN might lead NULL dereference in scst_call_dev_task_mgmt_fn_done(). Reported-By: <Ilan Steinberg <ilan.steinberg@kaminario.com>> ........ r7193 | vlnb | 2017-05-22 19:23:38 -0700 (Mon, 22 May 2017) | 5 lines qla2x00t: fix broken 4.9 kernels build Reported-By: Marc Smith <marc.smith@parodyne.com> ........ r7203 | vlnb | 2017-06-02 19:38:51 -0700 (Fri, 02 Jun 2017) | 3 lines Update to 4.11 kernels ........ r7208 | vlnb | 2017-06-12 20:58:26 -0700 (Mon, 12 Jun 2017) | 5 lines scst: Linux kernel v4.12 warning fix. Signed-off-by: Sebastian Herbszt <herbszt@gmx.de> ........ git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/3.2.x@7209 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
29b38cfd96 |
Blocked revisions 7053,7059-7061,7065-7083,7086-7090 via svnmerge
........
r7053 | vlnb | 2016-12-15 18:46:49 -0800 (Thu, 15 Dec 2016) | 3 lines
fileio_tgt: avoid warnings about casting between pointers and integers of different size
........
r7059 | vlnb | 2016-12-15 19:03:59 -0800 (Thu, 15 Dec 2016) | 3 lines
Update SVN_TAGS for 3.2.0
........
r7060 | vlnb | 2016-12-15 20:25:04 -0800 (Thu, 15 Dec 2016) | 3 lines
Web updates
........
r7061 | bvassche | 2016-12-17 04:33:45 -0800 (Sat, 17 Dec 2016) | 6 lines
ib_srpt: Revert r7050
r7050 did not change any behavior so revert it. Note for myself: in the
ib_srpt driver the port number is set by the ib_modify_qp() call in
srpt_init_ch_qp().
........
r7065 | vlnb | 2016-12-19 21:47:15 -0800 (Mon, 19 Dec 2016) | 20 lines
scst: avoid false lockdep complaints about recursive locking
In some cases SCST needs to take multiple locks recursivly, e.g. to lock
all tgt_devs in a session. For this case SCST takes those locks in their
current sort order, e.g. by LUN for tgt_devs, then releases in the
opposite order. Unfortunately, lockdep complains on such actions as
recursive locking, then disables itself. The disabling itself action is
the most unpleasant one leading to lockdep being useless after this point.
Unfortunately, nested locking annotations can't help, because after
free, then alloc again, or after LUN change (in case of tgt_devs) order
of locks can change.
So, this patch implements a way to annotate some lock and unlock actions
as "no lockdep", so lockdep will not track them. It contains related
kernel patches for some kernels.
This is a debug aid only useful only with lockdep enabled kernels.
........
r7066 | vlnb | 2016-12-19 21:49:07 -0800 (Mon, 19 Dec 2016) | 3 lines
Put_page_callback and scst_exec_req_fifo patches for RHEL5/6
........
r7067 | vlnb | 2016-12-19 21:53:48 -0800 (Mon, 19 Dec 2016) | 8 lines
iscsi-scst: add target_ip attribute
It adds target_ip attribute containing target IP address in each
/sys/kernel/scst_tgt/targets/iscsi/TARGET/sessions/INITIATOR/INITIATOR_IP subdirectory.
It's useful to simplify monitoring management utilities
........
r7068 | vlnb | 2016-12-19 21:55:19 -0800 (Mon, 19 Dec 2016) | 3 lines
Minor misc changes
........
r7069 | vlnb | 2016-12-19 22:00:43 -0800 (Mon, 19 Dec 2016) | 9 lines
iscsi-scst: add per_sess_dedicated_tgt_threads attribute in ini groups
If this attrubute is set, each iSCSI session for this initiator has
dedicated, i.e. not shared with other sessions, pool of the iscsi{wr,rd}
kernel threads.
Useful to control per-session CPU affinity to improve performance.
........
r7070 | vlnb | 2016-12-19 22:01:34 -0800 (Mon, 19 Dec 2016) | 3 lines
iscsi-scst: document thread_pid attribute
........
r7071 | vlnb | 2016-12-19 22:07:55 -0800 (Mon, 19 Dec 2016) | 7 lines
scst: improve thin provisioning support
This patch adds gen_tp_soft_threshold_reached_UA attribute for thin
provisioned devices that allows to generate THIN PROVISIONING SOFT
THRESHOLD REACHED Unit Attention.
........
r7072 | vlnb | 2016-12-19 22:10:56 -0800 (Mon, 19 Dec 2016) | 6 lines
scst: add ACA support
ACA (Auto Contingent Allegiance) is a way to handle CHECK CONDITION
status. It significantly improves performance of AIX systems.
........
r7073 | vlnb | 2016-12-19 22:14:55 -0800 (Mon, 19 Dec 2016) | 7 lines
scst: add max_tgt_dev_commands sysfs attribute
This per-device attribute allows to control maximum number of SCSI
commands any session to this device can have in flight. It makes
currently hardcoded constant be run time configurable.
........
r7074 | vlnb | 2016-12-19 22:17:11 -0800 (Mon, 19 Dec 2016) | 3 lines
scst: improve latency statistics
........
r7075 | vlnb | 2016-12-19 22:21:13 -0800 (Mon, 19 Dec 2016) | 6 lines
scst: performance improvements
This patch trying to allocate memory in per-NUMA and per-CPU manner to
(significantly) improve performance for high IOPS cases.
........
r7076 | vlnb | 2016-12-19 22:27:38 -0800 (Mon, 19 Dec 2016) | 8 lines
scst: add thread_index sysfs attribute
This attribute exports per LUN thread index assigned by
scst_add_threads(). It can be used to look up which export thread is
serving which target since this index also appears in the export thread
name. This information then could be used to set CPU affinity for those threads to improve performance.
........
r7077 | vlnb | 2016-12-19 22:28:41 -0800 (Mon, 19 Dec 2016) | 3 lines
scst: minor forwarding mode fixes
........
r7078 | vlnb | 2016-12-20 19:39:24 -0800 (Tue, 20 Dec 2016) | 3 lines
scst: document nolockdep patches
........
r7079 | vlnb | 2016-12-20 19:42:30 -0800 (Tue, 20 Dec 2016) | 3 lines
Web updates
........
r7080 | vlnb | 2016-12-21 19:07:19 -0800 (Wed, 21 Dec 2016) | 3 lines
Cleanup
........
r7081 | bvassche | 2016-12-27 12:21:53 -0800 (Tue, 27 Dec 2016) | 1 line
ib_srpt: Fix nightly build
........
r7082 | bvassche | 2016-12-27 12:23:31 -0800 (Tue, 27 Dec 2016) | 1 line
ib_srpt: Improve portability
........
r7083 | bvassche | 2016-12-27 12:25:13 -0800 (Tue, 27 Dec 2016) | 4 lines
isert-scst: Rename SCST_DIR into SCST_SYMVERS_DIR
Additionally, align shell code.
........
r7086 | bvassche | 2017-01-08 13:10:32 -0800 (Sun, 08 Jan 2017) | 2 lines
ib_srpt: Remove a local variable
........
r7087 | bvassche | 2017-01-08 13:10:54 -0800 (Sun, 08 Jan 2017) | 1 line
ib_srpt: Rename a symbolic constant
........
r7088 | bvassche | 2017-01-08 13:45:39 -0800 (Sun, 08 Jan 2017) | 2 lines
ib_srpt: Destroy SRQ before freeing the buffers posted on the SRQ
........
r7089 | bvassche | 2017-01-08 13:46:20 -0800 (Sun, 08 Jan 2017) | 2 lines
ib_srpt: Only report that SRQ creation failed if it was attempted to create an SRQ
........
r7090 | bvassche | 2017-01-10 17:16:07 -0800 (Tue, 10 Jan 2017) | 5 lines
scst: Fix a memory leak
Avoid that the memory allocated for struct scst_acn and its name is
leaked by scst_del_acg().
........
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/3.2.x@7094 d57e44dd-8a1f-0410-8b47-8ef2f437770f
|
||
|
Vladislav Bolkhovitin
|
fa495e2139 |
Merged revisions 7091-7092 via svnmerge from
svn+ssh://svn.code.sf.net/p/scst/svn/trunk ........ r7091 | vlnb | 2017-01-23 16:29:41 -0800 (Mon, 23 Jan 2017) | 5 lines Add scstadmin in the dist archive Reported by David Chen <david.chen@osnexus.com> ........ r7092 | bvassche | 2017-02-04 22:52:06 -0800 (Sat, 04 Feb 2017) | 6 lines scstadmin: Revert r7014 The immediateExit() call introduced in r7014 prevents to assign multiple values to attributes that support multiple values, e.g. 'allowed_portal'. Hence revert r7014. ........ git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/3.2.x@7093 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
3e96590f2d |
Increase reported version to 3.2.1 (321)
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/3.2.x@7064 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
78046c6c08 |
Update SVN_TAGS for 3.2.0
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/3.2.x@7058 d57e44dd-8a1f-0410-8b47-8ef2f437770fv3.2 |
||
|
Vladislav Bolkhovitin
|
55cf5a5847 |
READMEs: set 3.2.0 release number
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/3.2.x@7057 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
41f5ac2dd2 |
Merged revisions 7054 via svnmerge from
svn+ssh://svn.code.sf.net/p/scst/svn/trunk ........ r7054 | vlnb | 2016-12-15 18:49:45 -0800 (Thu, 15 Dec 2016) | 5 lines Add user space pieces to scst-dist-gzip. They now essential part of the distribution ........ git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/3.2.x@7056 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
2b71abc416 |
Switch default to release mode
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/3.2.x@7055 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
98e31f3af7 |
Blocked revisions 7040-7042,7044-7050 via svnmerge
........ r7040 | bvassche | 2016-11-30 21:06:36 -0800 (Wed, 30 Nov 2016) | 4 lines scst_mem: Fix indentation See also trunk r677. ........ r7041 | bvassche | 2016-11-30 21:07:48 -0800 (Wed, 30 Nov 2016) | 4 lines scst: Use READ_ONCE() instead of ACCESS_ONCE() This is a stylistic change only. ........ r7042 | bvassche | 2016-11-30 21:08:58 -0800 (Wed, 30 Nov 2016) | 2 lines scripts/run-regression-tests: Avoid that "make oldconfig" hangs ........ r7044 | bvassche | 2016-11-30 21:16:15 -0800 (Wed, 30 Nov 2016) | 2 lines scst_vdisk: Remove a superfluous cast ........ r7045 | bvassche | 2016-11-30 21:22:01 -0800 (Wed, 30 Nov 2016) | 1 line scst_vdisk: Remove more unneeded casts ........ r7046 | bvassche | 2016-12-01 08:18:39 -0800 (Thu, 01 Dec 2016) | 2 lines ib_srpt: Only complain if immediate data has to be copied if CONFIG_SLUB_DEBUG=n ........ r7047 | bvassche | 2016-12-01 08:19:14 -0800 (Thu, 01 Dec 2016) | 1 line ib_srpt Makefile: Follow-up for trunk r6138 ........ r7048 | bvassche | 2016-12-01 08:19:40 -0800 (Thu, 01 Dec 2016) | 1 line ib_srpt: Reduce build time ........ r7049 | bvassche | 2016-12-07 15:52:41 -0800 (Wed, 07 Dec 2016) | 5 lines ib_srpt: Simplify a debug statement It is likely that ib_device.dma_ops will be removed sooner or later. Hence make sure that the ib_srpt driver does not depend on it. ........ r7050 | bvassche | 2016-12-14 04:31:23 -0800 (Wed, 14 Dec 2016) | 1 line ib_srpt: Create QP on the RDMA port the initiator logged in to ........ git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/3.2.x@7052 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
f3558d3dae |
Merged revisions 7043 via svnmerge from
svn+ssh://svn.code.sf.net/p/scst/svn/trunk
........
r7043 | bvassche | 2016-11-30 21:10:43 -0800 (Wed, 30 Nov 2016) | 6 lines
scst.spec.in: Remove %dir /lib/modules/%{kversion}/extra
This avoids that the SCST RPM conflicts with other kernel RPMs
that install kernel modules in the "extra" directory. Reported
and suggested by Consus <consus@gmx.com>.
........
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/3.2.x@7051 d57e44dd-8a1f-0410-8b47-8ef2f437770f
|
||
|
Vladislav Bolkhovitin
|
73ba5eea90 |
Blocked revisions 7033,7035-7036 via svnmerge
........ r7033 | bvassche | 2016-11-24 09:15:14 -0800 (Thu, 24 Nov 2016) | 1 line nightly build: Update kernel versions ........ r7035 | bvassche | 2016-11-26 11:25:06 -0800 (Sat, 26 Nov 2016) | 2 lines scripts/generate-kernel-patch: Fix shellcheck warnings ........ r7036 | bvassche | 2016-11-26 11:25:30 -0800 (Sat, 26 Nov 2016) | 2 lines scripts/run-regression-tests: Disable CONFIG_STACK_VALIDATION and CONFIG_X86_X32 ........ git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/3.2.x@7039 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
2eabd72416 |
Merged revisions 7032,7034,7037 via svnmerge from
svn+ssh://svn.code.sf.net/p/scst/svn/trunk ........ r7032 | bvassche | 2016-11-24 08:53:00 -0800 (Thu, 24 Nov 2016) | 6 lines scripts/generate-kernel-patch: Revert r7022 Revert r7022 because: * Changing $kver3 into $kver is wrong for 2.x kernels. * Building include/iscsi_scst_itf_ver.h must not depend on the kernel version. ........ r7034 | bvassche | 2016-11-24 09:32:40 -0800 (Thu, 24 Nov 2016) | 7 lines iscsi-scst/Makefile: Fix INFINIBAND_ENABLED test Running "make install" ensures that the kernel config file is available in $(KDIR)/.config. However, that file is not available if $(KDIR) points at a kernel that comes from a Linux distributor. Hence change the $(INFINIBAND_ENABLED) test to check $(KDIR)/../modules.symbols. ........ r7037 | vlnb | 2016-11-29 19:06:38 -0800 (Tue, 29 Nov 2016) | 9 lines generate-kernel-patch: fix custom cross-compilation kernel case Otherwise there is non-fatal error like: No such file or directory grep: /lib/modules/<current_running_kernel>/build/.config: Permission denied This is a better version of r7022 suggested by Bart ........ git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/3.2.x@7038 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
a06fe89e8b |
Property svnmerge-blocked updated
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/3.2.x@7031 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
84c07327c4 |
Merged revisions 7012-7029 via svnmerge from
svn+ssh://svn.code.sf.net/p/scst/svn/trunk ........ r7012 | vlnb | 2016-10-17 22:00:58 -0700 (Mon, 17 Oct 2016) | 3 lines iscsi-scst: HOWTO updated ........ r7013 | bvassche | 2016-10-21 14:21:29 -0700 (Fri, 21 Oct 2016) | 2 lines scst regression tests: Unload the scst kernel module explicitly ........ r7014 | bvassche | 2016-10-21 14:54:02 -0700 (Fri, 21 Oct 2016) | 1 line scstadmin: Avoid that specifying an attribute multiple times results in an incomprehensible error message ........ r7015 | vlnb | 2016-10-21 19:19:03 -0700 (Fri, 21 Oct 2016) | 3 lines Docs updates ........ r7016 | bvassche | 2016-10-25 13:49:21 -0700 (Tue, 25 Oct 2016) | 1 line scst_user: Port to Linux kernel v4.9 ........ r7017 | bvassche | 2016-10-25 13:50:15 -0700 (Tue, 25 Oct 2016) | 4 lines ib_srpt: Cache global L_Key This patch does not change any functionality. ........ r7018 | bvassche | 2016-10-25 13:50:34 -0700 (Tue, 25 Oct 2016) | 2 lines ib_srpt: Port to Linux kernel v4.9 ........ r7019 | bvassche | 2016-10-25 15:21:46 -0700 (Tue, 25 Oct 2016) | 4 lines isert-scst: Cache L_Key This patch does not change any functionality. ........ r7020 | bvassche | 2016-10-25 15:22:07 -0700 (Tue, 25 Oct 2016) | 2 lines isert-scst: Port to Linux kernel v4.9 ........ r7021 | bvassche | 2016-10-26 14:33:50 -0700 (Wed, 26 Oct 2016) | 1 line iscsi-scst: Port to Linux kernel versions >= v4.7 ........ r7022 | vlnb | 2016-11-16 20:33:38 -0800 (Wed, 16 Nov 2016) | 7 lines generate-kernel-patch: fix custom cross-compilation kernel case Otherwise there is non-fatal error like: No such file or directory grep: /lib/modules/<current_running_kernel>/build/.config: Permission denied ........ r7023 | vlnb | 2016-11-16 20:44:48 -0800 (Wed, 16 Nov 2016) | 3 lines generate-kernel-patch: optimize generation of Makefile for qla2x00t ........ r7024 | vlnb | 2016-11-16 20:55:15 -0800 (Wed, 16 Nov 2016) | 3 lines generate-kernel-patch: optimize generation of Makefile for dev_handlers ........ r7025 | vlnb | 2016-11-16 21:06:59 -0800 (Wed, 16 Nov 2016) | 3 lines generate-kernel-patch: optimize generation of Makefile for scst ........ r7026 | vlnb | 2016-11-16 21:12:33 -0800 (Wed, 16 Nov 2016) | 3 lines generate-kernel-patch: optimize generation of Makefile for drivers/Kconfig ........ r7027 | vlnb | 2016-11-16 21:18:55 -0800 (Wed, 16 Nov 2016) | 3 lines generate-kernel-patch: optimize generation of Makefile.drivers patch ........ r7028 | vlnb | 2016-11-16 21:24:07 -0800 (Wed, 16 Nov 2016) | 3 lines generate-kernel-patch: optimize generation of Makefile for scst_local ........ r7029 | vlnb | 2016-11-22 19:45:35 -0800 (Tue, 22 Nov 2016) | 5 lines scst: fix overflows handling for tapes Reported and tested by Matthew D. Frederes <matt@bitech.biz> ........ git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/3.2.x@7030 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
7ba19d68a2 |
Blocked revisions 6934-6958,6965,6967-6968,6971-6972,6974-6975,6982-6983,6988-6989,6993,6998-7001,7003-7004 via svnmerge
........ r6934 | mlx-storage | 2016-08-17 00:17:37 -0700 (Wed, 17 Aug 2016) | 3 lines isert: make sure rdma_disconnect is called only once Signed-off-by: Israel Rukshin <israelr@mellanox.com> ........ r6935 | mlx-storage | 2016-08-17 00:27:06 -0700 (Wed, 17 Aug 2016) | 7 lines isert: fix cleaning isert_con_dev Clean pointers not to point to invalid memory. - While conn is released set conn_dev->conn to null as conn is invalid now. - While conn_dev is released set priv(conn) to null as conn_dev is invalid now. Signed-off-by: Israel Rukshin <israelr@mellanox.com> ........ r6936 | mlx-storage | 2016-08-17 00:27:11 -0700 (Wed, 17 Aug 2016) | 3 lines isert: add assertions for connection teardwon flow Signed-off-by: Israel Rukshin <israelr@mellanox.com> ........ r6937 | mlx-storage | 2016-08-17 00:27:15 -0700 (Wed, 17 Aug 2016) | 7 lines isert: fix a possible extra refcount put of isert connection On login logout stress we can start a teardown flow before connection is fully established. In this case we have one less refcount on isert connection. Signed-off-by: Israel Rukshin <israelr@mellanox.com> ........ r6938 | mlx-storage | 2016-08-17 00:27:19 -0700 (Wed, 17 Aug 2016) | 3 lines isert: change wrong dev_conn bug on Signed-off-by: Israel Rukshin <israelr@mellanox.com> ........ r6939 | mlx-storage | 2016-08-17 00:27:24 -0700 (Wed, 17 Aug 2016) | 5 lines isert: fix fops ioctl using invalid conn On teardown flow we need to set dev conn state to disconnected. Signed-off-by: Israel Rukshin <israelr@mellanox.com> ........ r6940 | mlx-storage | 2016-08-17 00:27:28 -0700 (Wed, 17 Aug 2016) | 8 lines isert: fix race between ioctl events and disconnect flow The ioctl events may arive after the isert connection has started the teardown flow. This scenario may occur on login logout stress. It may lead to NULL derefrence bugs. Signed-off-by: Israel Rukshin <israelr@mellanox.com> ........ r6941 | mlx-storage | 2016-08-17 00:27:33 -0700 (Wed, 17 Aug 2016) | 6 lines isert: fix isert conn refcount release at unreachable event On unreachable event the isert conn kref is always 2. The refcount becomes 2 after successful connect event. Signed-off-by: Israel Rukshin <israelr@mellanox.com> ........ r6942 | mlx-storage | 2016-08-17 00:27:38 -0700 (Wed, 17 Aug 2016) | 6 lines isert: fix missing refcount cleanup at error flow Before calling to rdma_accept isert kref is 2, so on failure we must decrease it twice. Signed-off-by: Israel Rukshin <israelr@mellanox.com> ........ r6943 | mlx-storage | 2016-08-17 00:27:43 -0700 (Wed, 17 Aug 2016) | 7 lines isert: add assertion if send/recv was posted after post drain After post drain we are not allowed to call post_recv or post_send, because the drain must be the last flush to let us know that we may close the conection safely. Signed-off-by: Israel Rukshin <israelr@mellanox.com> ........ r6944 | mlx-storage | 2016-08-17 00:27:48 -0700 (Wed, 17 Aug 2016) | 3 lines isert: replace kernel prints with scst macros Signed-off-by: Israel Rukshin <israelr@mellanox.com> ........ r6945 | mlx-storage | 2016-08-17 00:27:53 -0700 (Wed, 17 Aug 2016) | 11 lines isert: fix a race between timewait exit handler and poll cq Timewait exit event handler start to close iscsi conn before poll cq finish to handle all the good completions. This may lead to NULL deref at poll cq context or post recv after post drain. This commit close iscsi conn only when start getting flush. Flush is guaranteed if iscsi conn was created because when allocating iscsi conn we call post recv. Signed-off-by: Israel Rukshin <israelr@mellanox.com> ........ r6946 | mlx-storage | 2016-08-17 00:27:57 -0700 (Wed, 17 Aug 2016) | 8 lines isert: fix a race when drain wr is not the last flush We must wait for both the send and recv cqs to flush all pending work requests. To make sure that the drain will be the last flush we post a second drain work request on the recv queue. Signed-off-by: Israel Rukshin <israelr@mellanox.com> ........ r6947 | mlx-storage | 2016-08-17 00:28:02 -0700 (Wed, 17 Aug 2016) | 7 lines isert: fix isert connection kref leak at estabished event handler Fix a missing kref put when isert_conn_established return an error. By removing set bit ISERT_CONNECTION_ABORTED the connection teardown will start when recieving the flush WRs. Signed-off-by: Israel Rukshin <israelr@mellanox.com> ........ r6948 | mlx-storage | 2016-08-17 00:28:06 -0700 (Wed, 17 Aug 2016) | 6 lines isert: close isert connection earlier We want to close the connection not only when timewait exit event arrive, but also on some other events. Signed-off-by: Israel Rukshin <israelr@mellanox.com> ........ r6949 | mlx-storage | 2016-08-17 00:28:11 -0700 (Wed, 17 Aug 2016) | 3 lines isert: change dev conn_lock spinlock to mutex Signed-off-by: Israel Rukshin <israelr@mellanox.com> ........ r6950 | mlx-storage | 2016-08-17 00:28:16 -0700 (Wed, 17 Aug 2016) | 12 lines isert: fix a race between calling to rdma_disconnect and connect flow 1) The race can happen after unreachable event handler close isert connection and calling to rdma_disconnect from another thread on illegal cm_id. For example call rdma_disconnect from isert_portal_release function. 2) It is also possible to get ESTABLISHED RDMACM event while rdma_disconnect is called from another thread. In established event we need to check conn is not in teardown flow by checking the connection state with a mutex. Signed-off-by: Israel Rukshin <israelr@mellanox.com> ........ r6951 | mlx-storage | 2016-08-17 00:28:20 -0700 (Wed, 17 Aug 2016) | 7 lines isert: fix isert connection kref leak To avoid rare cases when checking ISERT_CONNECTION_EST bit may lead to kref leak, we now take the third refcount earlier before calling to rdma_accept. Signed-off-by: Israel Rukshin <israelr@mellanox.com> ........ r6952 | mlx-storage | 2016-08-17 00:28:25 -0700 (Wed, 17 Aug 2016) | 8 lines isert: faster release of isert_scst module If there is a dead connection we don't want to wait 60 seconds for the connection timeout error. So when closing the portal we close now all the connections immediately without waiting for events to arrive. Signed-off-by: Israel Rukshin <israelr@mellanox.com> ........ r6953 | mlx-storage | 2016-08-17 00:28:29 -0700 (Wed, 17 Aug 2016) | 8 lines isert: fix races between conn fops read/write and disconnect flow read/write events may arive after the isert connection has started the teardown flow. This scenario may occur on login logout stress. It may lead to NULL derefrence bugs. Signed-off-by: Israel Rukshin <israelr@mellanox.com> ........ r6954 | mlx-storage | 2016-08-17 00:28:34 -0700 (Wed, 17 Aug 2016) | 3 lines isert: add missing fd put on error flow Signed-off-by: Israel Rukshin <israelr@mellanox.com> ........ r6955 | mlx-storage | 2016-08-17 00:28:38 -0700 (Wed, 17 Aug 2016) | 8 lines isert: fix working with freed conn object isert_delete_conn_dev function checks if it needs to close the connection by checking that dev conn is not NULL. We were missing set conn to null when freeing it and that caused working with memory that was already freed. Signed-off-by: Israel Rukshin <israelr@mellanox.com> ........ r6956 | mlx-storage | 2016-08-17 00:28:43 -0700 (Wed, 17 Aug 2016) | 7 lines isert: fix isert conn cleanup when rdma_accept fails If rdma_accept fails the state of the qp is modified to error and all posted recieve buffers will be flushed and because of the flush the isert conn teardown flow will start. Signed-off-by: Israel Rukshin <israelr@mellanox.com> ........ r6957 | mlx-storage | 2016-08-17 00:28:47 -0700 (Wed, 17 Aug 2016) | 6 lines isert: add conn to portal conn list only if rdma_accept succeeded If rdma_accept() failed then we shouldn't call rdma_disconnect() on that QP as the result is unexpected. Signed-off-by: Israel Rukshin <israelr@mellanox.com> ........ r6958 | mlx-storage | 2016-08-17 00:28:52 -0700 (Wed, 17 Aug 2016) | 3 lines isert: fix redundant module put on error flow when handling connect request Signed-off-by: Israel Rukshin <israelr@mellanox.com> ........ r6965 | bvassche | 2016-08-19 21:00:46 -0700 (Fri, 19 Aug 2016) | 1 line nightly build: Update kernel versions ........ r6967 | bvassche | 2016-08-21 15:57:51 -0700 (Sun, 21 Aug 2016) | 4 lines isert-scst: Address checkpatch coding style complaints This patch does not change any functionality. ........ r6968 | bvassche | 2016-08-21 15:58:24 -0700 (Sun, 21 Aug 2016) | 1 line scst_vdisk: Use tabs instead of spaces for indentation ........ r6971 | bvassche | 2016-08-21 16:16:56 -0700 (Sun, 21 Aug 2016) | 1 line scst_vdisk: Comment out a local variable that is not used ........ r6972 | bvassche | 2016-08-21 17:04:58 -0700 (Sun, 21 Aug 2016) | 4 lines isert-scst: Convert a cast into a container_of() expression This patch does not change any functionality. ........ r6974 | bvassche | 2016-08-22 09:17:25 -0700 (Mon, 22 Aug 2016) | 1 line scst: Insert a blank line after declarations where it was missing ........ r6975 | bvassche | 2016-08-22 10:05:07 -0700 (Mon, 22 Aug 2016) | 1 line iscsi-scst: Change (signed) into (signed int) ........ r6982 | vlnb | 2016-08-30 17:47:52 -0700 (Tue, 30 Aug 2016) | 3 lines Web updates ........ r6983 | vlnb | 2016-08-30 18:07:37 -0700 (Tue, 30 Aug 2016) | 3 lines More web updates ........ r6988 | bvassche | 2016-10-03 22:24:35 -0700 (Mon, 03 Oct 2016) | 1 line scstadmin: Bump version number ........ r6989 | bvassche | 2016-10-03 22:24:49 -0700 (Mon, 03 Oct 2016) | 1 line fcst: Bump version number ........ r6993 | bvassche | 2016-10-06 17:31:52 -0700 (Thu, 06 Oct 2016) | 1 line nightly build: Update kernel versions ........ r6998 | bvassche | 2016-10-10 11:09:12 -0700 (Mon, 10 Oct 2016) | 1 line ib_srpt: Use tabs instead of spaces to indent ........ r6999 | bvassche | 2016-10-10 11:09:32 -0700 (Mon, 10 Oct 2016) | 1 line ib_srpt README: Correct default srpt_sq_size ........ r7000 | bvassche | 2016-10-10 11:09:51 -0700 (Mon, 10 Oct 2016) | 1 line ib_srpt: Rework QP failure reporting code ........ r7001 | bvassche | 2016-10-10 11:10:13 -0700 (Mon, 10 Oct 2016) | 1 line ib_srpt: Retry with a smaller send queue size if QP creation fails ........ r7003 | bvassche | 2016-10-10 11:51:06 -0700 (Mon, 10 Oct 2016) | 23 lines ib_srpt: Fix a race condition in the initialization code Initialize port information before registering the CM ID. One of the functions called by the CM handler (srpt_cm_req_recv()) namely uses the SCST target pointer so that pointer must be initialized before the CM ID is registered. This patch avoids that SRP login during ib_srpt initialization sporadically triggers the following bug: ib_srpt: Rejecting login with reason 0x10001 BUG: unable to handle kernel NULL pointer dereference at 0000000000000100 IP: [<ffffffffa09f1ccf>] srpt_cm_req_recv+0xf3f/0xf60 [ib_srpt] Call Trace: [<ffffffffa09f1dd5>] srpt_ib_cm_req_recv+0xe5/0x110 [ib_srpt] [<ffffffffa06c6fae>] cm_process_work+0x1e/0x130 [ib_cm] [<ffffffffa06c9ca8>] cm_req_handler+0x398/0x460 [ib_cm] [<ffffffffa06c9e25>] cm_work_handler+0xb5/0x208 [ib_cm] [<ffffffff8107d2fc>] process_one_work+0x16c/0x350 [<ffffffff8108002a>] worker_thread+0x17a/0x410 [<ffffffff810843f6>] kthread+0x96/0xa0 [<ffffffff8146f364>] kernel_thread_helper+0x4/0x10 ........ r7004 | bvassche | 2016-10-10 11:51:42 -0700 (Mon, 10 Oct 2016) | 2 lines ib_srpt: Enable S/G-list clustering ........ git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/3.2.x@7011 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
cb1d6bdf63 |
Merged revisions 6977,6979-6980,6984-6986,6990-6992,6994,6997,7006-7009 via svnmerge from
svn://svn.code.sf.net/p/scst/svn/trunk ........ r6977 | bvassche | 2016-08-23 08:42:41 -0700 (Tue, 23 Aug 2016) | 5 lines isert-scst: More MOFED 3.3 fixes for kernel versions >= 4.6.0 This is a slightly modified version of a patch from Israel Rukshin <israelr@mellanox.com>. ........ r6979 | vlnb | 2016-08-23 19:02:28 -0700 (Tue, 23 Aug 2016) | 5 lines scst: cleanup Reported-By: Curtis Maloney <curtis@tinbrain.net> ........ r6980 | vlnb | 2016-08-23 19:05:03 -0700 (Tue, 23 Aug 2016) | 5 lines iscsi: convert recently added BUG_ON() to EXTRACHECKS_BUG_ON() This check is rather debug check, so should belong to debug build only ........ r6984 | vlnb | 2016-09-19 20:10:30 -0700 (Mon, 19 Sep 2016) | 5 lines scst_sysfs: better return value when trying to create an acg that already exists Signed-off-by: Erez Zilber <erezzi.list@gmail.com> ........ r6985 | vlnb | 2016-09-22 20:04:16 -0700 (Thu, 22 Sep 2016) | 5 lines scst_vdisk: added parameter cluster_mode to nullio device handler Signed-off-by: Kirill Tyushev <kirill.tyushev8@gmail.com> ........ r6986 | bvassche | 2016-10-03 15:00:52 -0700 (Mon, 03 Oct 2016) | 6 lines scst/include/backport.h: Fix RHEL/CentOS 7 build RHEL 7 and CentOS 7 provide a definition of ktime_before(). Hence hide the ktime_before() definition on these Linux distro's. ........ r6990 | bvassche | 2016-10-06 12:10:00 -0700 (Thu, 06 Oct 2016) | 3 lines scst_vdisk: Rename blockio_rw_sync() into blockio_read_sync() ........ r6991 | bvassche | 2016-10-06 12:20:57 -0700 (Thu, 06 Oct 2016) | 2 lines scst: Port to Linux kernel v4.8 ........ r6992 | bvassche | 2016-10-06 17:22:47 -0700 (Thu, 06 Oct 2016) | 1 line scstadmin: Sort group and device group names alphabetically ........ r6994 | bvassche | 2016-10-06 17:45:18 -0700 (Thu, 06 Oct 2016) | 1 line scst_vdisk: Use op_is_write() instead of comparing with REQ_OP_WRITE ........ r6997 | vlnb | 2016-10-07 16:34:34 -0700 (Fri, 07 Oct 2016) | 3 lines SCST README: clarification ........ r7006 | vlnb | 2016-10-10 20:06:41 -0700 (Mon, 10 Oct 2016) | 5 lines scst: fix tapes handling with Windows initiators Reported and tested by Florian Gall <florian@enterprize.dyndns.info> ........ r7007 | vlnb | 2016-10-10 20:30:54 -0700 (Mon, 10 Oct 2016) | 3 lines fileio_tgt: fix debug output ........ r7008 | vlnb | 2016-10-11 18:27:42 -0700 (Tue, 11 Oct 2016) | 5 lines README.drbd: update to point to README.dlm for reservations sync Suggested-by: Curtis Maloney <curtis@tinbrain.net> ........ r7009 | vlnb | 2016-10-13 18:30:17 -0700 (Thu, 13 Oct 2016) | 6 lines iscsi-scst: fix false positive BUG_ON() It's false positive, because responses live in the parent request's list until last put for the parent. ........ git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/3.2.x@7010 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
Bart Van Assche
|
bce22bf957 |
ib_srpt: Merge r7003 from trunk
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/3.2.x@7005 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Bart Van Assche
|
a2d9f08cd7 |
ib_srpt: Merge r6997:7001 from trunk
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/3.2.x@7002 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
66ec1d73ab |
Blocked revisions 6969-6970,6973,6976,6978,6981 merged by Bart
........ r6969 | bvassche | 2016-08-21 15:58:45 -0700 (Sun, 21 Aug 2016) | 1 line ib_srpt: Remove trailing whitespace ........ r6970 | bvassche | 2016-08-21 15:59:16 -0700 (Sun, 21 Aug 2016) | 1 line ib_srpt: Address a checkpatch complaint about a missing space ........ r6973 | bvassche | 2016-08-21 21:28:52 -0700 (Sun, 21 Aug 2016) | 2 lines isert-scst, srpt: Fix build on systems with kernel >= 4.2.0 + MOFED 3.3 ........ r6976 | bvassche | 2016-08-22 10:05:46 -0700 (Mon, 22 Aug 2016) | 1 line ib_srpt: Change unsigned into unsigned int ........ r6978 | bvassche | 2016-08-23 08:43:25 -0700 (Tue, 23 Aug 2016) | 5 lines ib_srpt: More MOFED 3.3 fixes for kernel versions >= 4.6.0 This is a slightly modified version of a patch from Israel Rukshin <israelr@mellanox.com>. ........ r6981 | bvassche | 2016-08-28 09:27:43 -0700 (Sun, 28 Aug 2016) | 9 lines ib_srpt: Reduce default value of srpt_sq_size Reduce the default value of the srpt_sq_size kernel module parameter from 4096 to 256. This avoids on recent kernels (e.g. 4.1.0) QP creation causes swiotlb to complain about a failed allocation. Reported-by: Curtis Maloney <curtis@tinbrain.net> ........ git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/3.2.x@6996 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Bart Van Assche
|
69200308aa |
ib_srpt: Merge revisions 6932, 6969, 6970, 6973, 6976, 6978 and 6981 from trunk
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/3.2.x@6995 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Bart Van Assche
|
89089ec8e0 |
scstadmin: Fix version number
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/3.2.x@6987 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
Israel Rukshin
|
377c61ddd0 |
Merged revisions 6934-6958 from trunk
------------------------------------------------------------------------ r6934 | mlx-storage | 2016-08-17 10:17:37 +0300 (Wed, 17 Aug 2016) | 4 lines isert: make sure rdma_disconnect is called only once ------------------------------------------------------------------------ r6935 | mlx-storage | 2016-08-17 10:27:06 +0300 (Wed, 17 Aug 2016) | 8 lines isert: fix cleaning isert_con_dev ------------------------------------------------------------------------ r6936 | mlx-storage | 2016-08-17 10:27:11 +0300 (Wed, 17 Aug 2016) | 4 lines isert: add assertions for connection teardwon flow ------------------------------------------------------------------------ r6937 | mlx-storage | 2016-08-17 10:27:15 +0300 (Wed, 17 Aug 2016) | 8 lines isert: fix a possible extra refcount put of isert connection ------------------------------------------------------------------------ r6938 | mlx-storage | 2016-08-17 10:27:19 +0300 (Wed, 17 Aug 2016) | 4 lines isert: change wrong dev_conn bug on ------------------------------------------------------------------------ r6939 | mlx-storage | 2016-08-17 10:27:24 +0300 (Wed, 17 Aug 2016) | 6 lines isert: fix fops ioctl using invalid conn ------------------------------------------------------------------------ r6940 | mlx-storage | 2016-08-17 10:27:28 +0300 (Wed, 17 Aug 2016) | 9 lines isert: fix race between ioctl events and disconnect flow ------------------------------------------------------------------------ r6941 | mlx-storage | 2016-08-17 10:27:33 +0300 (Wed, 17 Aug 2016) | 7 lines isert: fix isert conn refcount release at unreachable event ------------------------------------------------------------------------ r6942 | mlx-storage | 2016-08-17 10:27:38 +0300 (Wed, 17 Aug 2016) | 7 lines isert: fix missing refcount cleanup at error flow ------------------------------------------------------------------------ r6943 | mlx-storage | 2016-08-17 10:27:43 +0300 (Wed, 17 Aug 2016) | 8 lines isert: add assertion if send/recv was posted after post drain ------------------------------------------------------------------------ r6944 | mlx-storage | 2016-08-17 10:27:48 +0300 (Wed, 17 Aug 2016) | 4 lines isert: replace kernel prints with scst macros ------------------------------------------------------------------------ r6945 | mlx-storage | 2016-08-17 10:27:53 +0300 (Wed, 17 Aug 2016) | 12 lines isert: fix a race between timewait exit handler and poll cq ------------------------------------------------------------------------ r6946 | mlx-storage | 2016-08-17 10:27:57 +0300 (Wed, 17 Aug 2016) | 9 lines isert: fix a race when drain wr is not the last flush ------------------------------------------------------------------------ r6947 | mlx-storage | 2016-08-17 10:28:02 +0300 (Wed, 17 Aug 2016) | 8 lines isert: fix isert connection kref leak at estabished event handler ------------------------------------------------------------------------ r6948 | mlx-storage | 2016-08-17 10:28:06 +0300 (Wed, 17 Aug 2016) | 7 lines isert: close isert connection earlier ------------------------------------------------------------------------ r6949 | mlx-storage | 2016-08-17 10:28:11 +0300 (Wed, 17 Aug 2016) | 4 lines isert: change dev conn_lock spinlock to mutex ------------------------------------------------------------------------ r6950 | mlx-storage | 2016-08-17 10:28:16 +0300 (Wed, 17 Aug 2016) | 13 lines isert: fix a race between calling to rdma_disconnect and connect flow ------------------------------------------------------------------------ r6951 | mlx-storage | 2016-08-17 10:28:20 +0300 (Wed, 17 Aug 2016) | 8 lines isert: fix isert connection kref leak ------------------------------------------------------------------------ r6952 | mlx-storage | 2016-08-17 10:28:25 +0300 (Wed, 17 Aug 2016) | 9 lines isert: faster release of isert_scst module ----------------------------------------------------------------------- r6953 | mlx-storage | 2016-08-17 10:28:29 +0300 (Wed, 17 Aug 2016) | 9 lines isert: fix races between conn fops read/write and disconnect flow ------------------------------------------------------------------------ r6954 | mlx-storage | 2016-08-17 10:28:34 +0300 (Wed, 17 Aug 2016) | 4 lines isert: add missing fd put on error flow ------------------------------------------------------------------------ r6955 | mlx-storage | 2016-08-17 10:28:38 +0300 (Wed, 17 Aug 2016) | 9 lines isert: fix working with freed conn object ------------------------------------------------------------------------ r6956 | mlx-storage | 2016-08-17 10:28:43 +0300 (Wed, 17 Aug 2016) | 8 lines isert: fix isert conn cleanup when rdma_accept fails ------------------------------------------------------------------------ r6957 | mlx-storage | 2016-08-17 10:28:47 +0300 (Wed, 17 Aug 2016) | 7 lines isert: add conn to portal conn list only if rdma_accept succeeded ------------------------------------------------------------------------ r6958 | mlx-storage | 2016-08-17 10:28:52 +0300 (Wed, 17 Aug 2016) | 4 lines isert: fix redundant module put on error flow when handling connect request ------------------------------------------------------------------------ git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/3.2.x@6966 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
94e0d33e4f |
Merged revisions 6930-6933,6960-6961 via svnmerge from
svn://svn.code.sf.net/p/scst/svn/trunk ........ r6930 | vlnb | 2016-08-02 19:49:31 -0700 (Tue, 02 Aug 2016) | 3 lines scst_vdisk: don't report unmap alignment, if it is equal to unmap granularity ........ r6931 | bvassche | 2016-08-08 13:52:00 -0700 (Mon, 08 Aug 2016) | 1 line scst/README.dlm: Update startup sequence information ........ r6932 | bvassche | 2016-08-09 13:18:03 -0700 (Tue, 09 Aug 2016) | 5 lines srpt/Testing.txt: Leave out --norandommap --verify and --norandommap are mutually exclusive. Hence leave out --norandommap. ........ r6933 | bvassche | 2016-08-11 11:36:48 -0700 (Thu, 11 Aug 2016) | 1 line scst/README.dlm: Correct instructions for waiting for logout ........ r6960 | vlnb | 2016-08-19 18:24:03 -0700 (Fri, 19 Aug 2016) | 3 lines scst: fix compilation on older kernels ........ r6961 | vlnb | 2016-08-19 18:33:47 -0700 (Fri, 19 Aug 2016) | 5 lines scst README: add section about VMware and Ceph RBD space reclaim ........ git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/3.2.x@6964 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
533548a7ef |
Fix svnmerge-integrated
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/3.2.x@6963 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
9a75e25b9d |
Initialized merge tracking via "svnmerge" with revisions "6928" from
svn://svn.code.sf.net/p/scst/svn/trunk git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/3.2.x@6929 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
1284dc5414 |
Version update
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/3.2.x@6926 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
d25c11ef15 |
Create 3.2.x stable branch
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/3.2.x@6925 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
f125a4e9bf |
scst: Update README.dlm
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6921 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Bart Van Assche
|
a5f67cd1f2 |
scst_dlm: Instantiate lockspace as soon as cluster mode is enabled
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6920 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Bart Van Assche
|
d41a3a3cc9 |
/etc/init.d/scst: Make this script work on recent versions of Ubuntu Linux
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6919 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
cde21c669a |
scst: small post-r6913 cleanup
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6918 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
244271120e |
iscsi-scst: increase past CmdSN window to 2048
On modern storage there might be more, than 128, commands queued, so previous CmdSN window might be too small and on unstable networks lead to infinite retries. For more infor see thread https://sourceforge.net/p/scst/mailman/message/35238904. Reported-By: Lev Vainblat <lev@zadarastorage.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6917 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Bart Van Assche
|
1a24483678 |
scst.h: Move more code to <scst/backport.h>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6916 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Bart Van Assche
|
0a3d69c31b |
scst_vdisk: Fix spelling of "reopening"
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6915 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Bart Van Assche
|
18ccf50b87 |
scst_pres: Save APTPL PR info on both nodes
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6914 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Bart Van Assche
|
e2b03a7836 |
scst_pres: Modify scst_pr_sync_device_file() function prototype
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6913 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Bart Van Assche
|
17f49dbede |
scst_dlm: Initialize reg->dlm_idx for PR information loaded from disk
This patch avoids that the following kernel warning appears while starting SCST after having loaded APTPL PR information: WARNING: scst/src/scst_dlm.c:461 scst_copy_to_dlm() Reported-by: <consus@gmx.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6912 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
ff3b499a4c |
scst: fix perf build
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6911 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
f2da0cec29 |
README.dlm: update ToDo to reflect recently discovered APTL issue
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6910 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
aea4052085 |
README.dlm update to refer to LVB truncation prevention patch
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6909 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
0c2fd8e564 |
iscsi-scst: handle a case in target_del() where the target was already freed
target_del() calls handle_iscsi_events() which may recursively call target_del(). The 1st target_del() may resume its execution after the target object was already freed. Signed-off-by: Erez Zilber <erezzi.list@gmail.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6908 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
aa18a4bcb5 |
Logginf cleanup
1. Make PR logging available in the release mode 2. Make /sys/kernel/scst_tgt/trace_level reflect currently available logging 3. Cleanup unused log levels from /sys/kernel/scst_tgt/trace_level Suggested-by: Consus <consus@gmx.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6907 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
55bb0206cd |
scst: when checking the status of the service, also check if all daemons are running
Signed-off-by: Erez Zilber <erezzi.list@gmail.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6906 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
4092e26bba |
scst: fix possible error path crash in debug mode
It could happen, if a non-pass-through dev handler erroneously returned SCST_EXEC_NOT_COMPLETED and TRAGE_DBG() statements enabled in debug mode. Reported-by: Jeff Goldszer <jeff.goldszer@alebra.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6905 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
528f5e0004 |
Makefiles/Kconfigs for kernels 4.5 and 4.6
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6904 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Vladislav Bolkhovitin
|
d4e2c4b12e |
We found this bug when we add ZFS zvol to vdisk_blockio, remove it from copy
manager, and change ALUA state. After that the zvol would be in constant busy state, even if we remove all scst modules. The problem is that blockio_on_alua_state_change_finish will unconditionally vdisk_open_fd. But for the above mentioned case, tgt_dev_cnt will be zero, so the fd is permanently leaked. We fix this by only do vdisk_open_fd when tgt_dev_cnt is not zero. Signed-off-by: Chunwei Chen <david.chen@osnexus.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6902 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Bart Van Assche
|
e7603fc7a7 |
ib_srpt: Start with comp_vector 0
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6901 d57e44dd-8a1f-0410-8b47-8ef2f437770f |
||
|
Bart Van Assche
|
da83a4a9a4 |
ib_srpt: Serialize sport->port_id accesses
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6900 d57e44dd-8a1f-0410-8b47-8ef2f437770f |