mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-05-18 19:21:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
2,759 Commits 26 Branches 11 Tags
4efdfaf368b3eefd55182ab01dfeee2329dde86c
Commit Graph

2759 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Bart Van Assche
4efdfaf368 nightly build: Add kernel 3.5 build infrastructure (merge r4460 from trunk) 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4572 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-11-03 13:29:38 +00:00
Bart Van Assche
2ae9bb3655 Update for 3.5 kernel (merge r4458 from trunk) 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4571 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-11-03 13:27:32 +00:00
Bart Van Assche
2d2df09c5a scst: Move ioctx manipulation code (merge r4254 from trunk) 
Move the code for obtaining and releasing an I/O context out of
scst_process_active_cmd() in order to improve source code
readability.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>


git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4570 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-11-03 13:22:29 +00:00
Bart Van Assche
a67be01951 scst: Fix race between closing a session and adding a LUN 
Fixes this call stack (kernel 3.2.15):
WARNING: at lib/kref.c:34 kref_get+0x2d/0x30()
Hardware name: X8ST3
Modules linked in: scst_vdisk ib_srpt scst
Pid: 2159, comm: scst_uid Tainted: G W 3.2.15-07+ #2
Call Trace:
[<ffffffff81059cba>] warn_slowpath_common+0x7a/0xb0
[<ffffffff81059d05>] warn_slowpath_null+0x15/0x20
[<ffffffff812a5d7d>] kref_get+0x2d/0x30
[<ffffffff812a46ba>] kobject_get+0x1a/0x30
[<ffffffff812a471b>] kobject_add_internal+0x4b/0x240
[<ffffffff812a4bf3>] kobject_init_and_add+0x63/0x90
[<ffffffffa001082b>] ? scst_tgt_dev_setup_threads+0xab/0x310 [scst]
[<ffffffffa001a722>] scst_tgt_dev_sysfs_create+0x42/0x80 [scst]
[<ffffffffa0010e8c>] scst_alloc_add_tgt_dev+0x31c/0x4b0 [scst]
[<ffffffffa001362e>] scst_acg_add_lun+0xfe/0x230 [scst]
[<ffffffff812b4511>] ? _kstrtoull+0x31/0x90
[<ffffffffa001777c>] scst_luns_mgmt_store_work_fn+0x29c/0x6b0 [scst]
[<ffffffffa0019634>] sysfs_work_thread_fn+0xd4/0x2e0 [scst]
[<ffffffff8107a020>] ? wake_up_bit+0x40/0x40
[<ffffffffa0019560>] ? scst_tgt_cpu_mask_show+0x20/0x20 [scst]
[<ffffffff81079ab6>] kthread+0x96/0xa0
[<ffffffff8163d7b4>] kernel_thread_helper+0x4/0x10
[<ffffffff81079a20>] ? kthread_worker_fn+0x190/0x190
[<ffffffff8163d7b0>] ? gs_change+0x13/0x13

Reported-by: Sebastian Riemer <sebastian.riemer@profitbricks.com>

(Merge r4452:4456 and r4464 from trunk).


git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4506 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-09-07 10:03:02 +00:00
Bart Van Assche
23390aca64 scst: sysfs session creation error path fix 
The attached patch prevents that a kernel oops is triggered if something
fails when adding a session to sysfs.

(Merge r4388 from trunk)


git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4451 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-08-07 13:01:19 +00:00
Bart Van Assche
fc8b2d910b scripts/rebuild-rhel-kernel-rpm: Add RHEL 6.3 support (merge from trunk) 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4444 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-07-29 16:54:53 +00:00
Bart Van Assche
c4c2555dc9 qla2x00t: Port to RHEL 6.1/6.2/6.3 (merge r4303 and r4419 from trunk) 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4442 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-07-29 16:46:58 +00:00
Bart Van Assche
5f7668e80a Merge directories scripts and nightly from trunk 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4441 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-07-29 16:28:23 +00:00
Bart Van Assche
59294a39f8 qla2x00t: Make out-of-tree build possible (backport r3910 from trunk) 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4440 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-07-29 16:26:28 +00:00
Bart Van Assche
4f57176241 qla2x00t: IRQ handlers can be called without IRQs disabled and IRQF_DISABLED 
doesn't work with IRQF_SHARED on modern kernels (merge r4100 from trunk).


git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4439 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-07-29 14:28:39 +00:00
Bart Van Assche
6ecb9f2aff qla2x00t: Fix a deadlock crash 
The symptom of the crash is that one finds the system deadlocked
spinning on scsi_qla_host_t.hardware_lock in qla2x00_enable_tgt_mode
with a stack something like this:

crash> bt
PID: 6155   TASK: ffff88006e4bc3c0  CPU: 1   COMMAND: "scst_uid"
 #0 [ffff88007b915b28] machine_kexec at ffffffff8103163b
 #1 [ffff88007b915b88] crash_kexec at ffffffff810b8e52
 #2 [ffff88007b915c58] panic at ffffffff814ed0ab
 #3 [ffff88007b915cd8] spin_bug at ffffffff8127cd46
 #4 [ffff88007b915d18] _raw_spin_lock at ffffffff8127d015
 #5 [ffff88007b915d68] _spin_lock_irqsave at ffffffff814f02e4
 #6 [ffff88007b915d88] qla2x00_enable_tgt_mode at ffffffffa047b672 [qla2xxx]
 #7 [ffff88007b915db8] q2t_host_action at ffffffffa06db6a6 [qla2x00tgt]
 #8 [ffff88007b915df8] q2t_enable_tgt at ffffffffa06db6ea [qla2x00tgt]
 #9 [ffff88007b915e18] scst_process_tgt_enable_store at ffffffffa04f102e [scst]
#10 [ffff88007b915e48] scst_tgt_enable_store_work_fn at ffffffffa04f1176 [scst]
#11 [ffff88007b915e58] scst_process_sysfs_works at ffffffffa04e8bbe [scst]
#12 [ffff88007b915e78] sysfs_work_thread_fn at ffffffffa04e8db5 [scst]
#13 [ffff88007b915ed8] kthread at ffffffff8108f976
#14 [ffff88007b915f48] kernel_thread at ffffffff8100c20a

I was pulling my hair out on this one, because with the spinlock
debugging (enhanced to capture the PID along with the task pointer), I
figured out that the task (and process) that originally locked the lock
was gone!  It got really confusing when I added more spinlock debug code
to the kernel to detect locks held in the task switching and
task/process termination paths -- and didn't catch anything terminating
with locks held!

I finally tracked the problem down to two things:

1.  When qla24xx_create_vhost creates a new virtual scsi_qla_host_t it
does it by copying the physical (aka parent) scsi_qla_host_t.  Under the
right unlucky conditions, this can happen with the hardware_lock held
(the spinlock is embedded in the structure).

2.  The code should only be locking the hardware_lock of the physical
scsi_qla_host_t, because the lock is associated with the hardware.
Unfortunately, quite a few places are not using to_qla_parent to make
sure they lock the correct lock.  One of those places is
qla2x00_enable_tgt_mode.  Along with the deadlock, this has the
potential to leave the hardware and driver structures in unpredictable
states, because the lock isn't always providing serialization.

The fix entails two things:

1. Zeroing the lock after copying the scsi_qla_host_t structure:  This
won't stop the deadlock, but will enable the spinlock debug code to
easily catch anything that misbehaves and locks the wrong lock.  I also
initialized the other locks because they could have the same problem.  I
also initialized the list heads, because they could end up holding
dangling references.  I did not initialize all pointers, because there
are quite a few that point to read only data and are OK (and I didn't
have time to research all of them).

2.  Using to_qla_parent everywhere when locking and the scsi_qla_host_t
structure might be virtual.  This is a lot of changes, but they are the
same thing over and over again.

I did not make an effort to look for scalar or pointer fields that are
being picked from the wrong structure.  That's getting to be as much
pain as merging up to the latest QLogic driver (which would have gotten
rid of this problem).

From "Robinson, Herbie" <Herbie.Robinson@stratus.com>

(Merge r4420 from trunk)


git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4438 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-07-29 14:23:58 +00:00
Bart Van Assche
d7b35cc58f qla2x00t: Add a comment (merge r4418 from trunk) 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4437 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-07-29 14:21:14 +00:00
Bart Van Assche
e28b0f09bc qla2x00t: Remove a wrong check because it could lead to skipping unlocking (merge r4380 from trunk) 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4436 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-07-29 14:19:54 +00:00
Bart Van Assche
c245707ec5 qla2x00t: With NPIV initiators being destroyed and recreated, the loop_id and/or 
the d_id of a virtual initiator may change. The current implementation not
always catches these changes, which leads to wrong virtual devices
being presented to the initiators. This can lead to i.e. corruption of LUN
content and multiple initiators writing to the same LUN, although the
LUN's access group only contains a single port.

Until a better solution is found, we schedule a session deletion for the
nexus when receiving an ELS  port logout message. That way SCST
will re-initialize both loop_id and d_id when the initiator reconnects
before the actual deletion takes place. The performance impact is
minimal (few milliseconds) and currently necessary.

Signed-off-by: Jens-U. Mozdzen <jmozdzen@nde.ag>

(Merge r3583 from trunk)


git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4435 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-07-29 14:15:30 +00:00
Bart Van Assche
e207090233 Fix race between q2t_del_sess_work_fn() and q2t_clear_tgt_db() (merge r4101 from trunk) 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4434 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-07-29 14:09:42 +00:00
Bart Van Assche
78024c12a8 qla2x00t: Fix compilation for the SLES 2.6.32.46 kernel (merge r4099 from trunk) 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4433 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-07-29 14:02:45 +00:00
Bart Van Assche
f4d3dc67cc qla2x00t: Fix delay calculation (merge r4311 from trunk) 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4432 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-07-29 13:58:07 +00:00
Bart Van Assche
5fee8af956 Merged /trunk/nightly:r4356-4405 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4429 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-07-27 16:31:50 +00:00
Bart Van Assche
5caf5bdd99 Merged /trunk/scripts:r4356-4405 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4428 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-07-27 16:30:27 +00:00
Bart Van Assche
2f527c350c scst_local: Avoid that removing vdisk_cdrom devices can trigger a deadlock 
Avoid that removing the scst_local kernel module triggers a deadlock
when one of its LUNs is a CD-ROM device. sr_block_release() invokes
scst_local_release_adapter() indirectly with sr_mutex held. So if 
scst_local_release_adapter() blocks until the scst_local session has
been freed a deadlock may be triggered if another CD-ROM device has
to be closed in order to free that session. Fix this by changing
scst_local_release_adapter() such that it does not wait until the
session unregistration has finished.

Call stacks obtained with echo w > /proc/sysrq-trigger:

SysRq : Show Blocked State
  task                        PC stack   pid father
scst_mgmtd      D ffffffff812f979d     0  5552      2 0x00000000
 ffff88003c335b30 0000000000000046 ffffffff812f979d 0000000000000002
 ffff8800171d47a0 ffff88003c335fd8 ffff88003c335fd8 ffff88003c335fd8
 ffff88003d1b0000 ffff8800171d47a0 ffff88003c335b60 ffff88003c334000
Call Trace:
 [<ffffffff812f979d>] ? sr_block_release+0x2d/0x60
 [<ffffffff812f979d>] ? sr_block_release+0x2d/0x60
 [<ffffffff814a9b19>] schedule+0x29/0x70
 [<ffffffff814a9e57>] schedule_preempt_disabled+0x27/0x40
 [<ffffffff814a79b7>] mutex_lock_nested+0x187/0x390
 [<ffffffff812f979d>] ? sr_block_release+0x2d/0x60
 [<ffffffff812f979d>] sr_block_release+0x2d/0x60
 [<ffffffff8118a1ec>] __blkdev_put+0x19c/0x1d0
 [<ffffffff8118a27d>] blkdev_put+0x5d/0x180
 [<ffffffff8118a3c8>] blkdev_close+0x28/0x30
 [<ffffffff81153633>] fput+0x103/0x280
 [<ffffffff8114fad9>] filp_close+0x69/0x90
 [<ffffffffa022ec24>] vdisk_detach_tgt+0x134/0x150 [scst_vdisk]
 [<ffffffffa02d8f2f>] scst_free_tgt_dev+0xdf/0x220 [scst]
 [<ffffffffa02d949f>] ? scst_free_session_callback+0x7f/0x170 [scst]
 [<ffffffffa02d90eb>] scst_sess_free_tgt_devs+0x7b/0x110 [scst]
 [<ffffffffa02d91de>] scst_free_session+0x5e/0x2a0 [scst]
 [<ffffffffa02d94be>] scst_free_session_callback+0x9e/0x170 [scst]
 [<ffffffffa02c6a05>] scst_global_mgmt_thread+0x2e5/0x580 [scst]
 [<ffffffff8105e850>] ? __init_waitqueue_head+0x60/0x60
 [<ffffffffa02c6720>] ? scst_register_session_non_gpl+0x20/0x20 [scst]
 [<ffffffff8105dd77>] kthread+0xb7/0xc0
 [<ffffffff814b50b4>] kernel_thread_helper+0x4/0x10
 [<ffffffff814abb30>] ? retint_restore_args+0x13/0x13
 [<ffffffff8105dcc0>] ? __init_kthread_worker+0x70/0x70
 [<ffffffff814b50b0>] ? gs_change+0x13/0x13
iscsi-scstd     D ffffffffa02b1b1f     0  5567      1 0x00000004
 ffff88003c2f59a8 0000000000000046 ffffffffa02b1b1f 0000000000000002
 ffff8800173b23d0 ffff88003c2f5fd8 ffff88003c2f5fd8 ffff88003c2f5fd8
 ffff88003d198000 ffff8800173b23d0 ffff88003c2f59d8 ffff88003c2f4000
Call Trace:
 [<ffffffffa02b1b1f>] ? scst_unregister_target+0x8f/0x450 [scst]
 [<ffffffffa02b1b1f>] ? scst_unregister_target+0x8f/0x450 [scst]
 [<ffffffff814a9b19>] schedule+0x29/0x70
 [<ffffffff814a9e57>] schedule_preempt_disabled+0x27/0x40
 [<ffffffff814a79b7>] mutex_lock_nested+0x187/0x390
 [<ffffffffa02b1b1f>] ? scst_unregister_target+0x8f/0x450 [scst]
 [<ffffffffa025c7ba>] ? __iscsi_del_attr+0xea/0x190 [iscsi_scst]
 [<ffffffffa02b1b1f>] scst_unregister_target+0x8f/0x450 [scst]
 [<ffffffffa025c7ba>] ? __iscsi_del_attr+0xea/0x190 [iscsi_scst]
 [<ffffffffa026249f>] target_destroy+0x5f/0xc0 [iscsi_scst]
 [<ffffffffa02631f2>] target_del_all+0xf2/0x2d0 [iscsi_scst]
 [<ffffffffa025c8aa>] release+0x4a/0xe0 [iscsi_scst]
 [<ffffffff81153633>] fput+0x103/0x280
 [<ffffffff8114fad9>] filp_close+0x69/0x90
 [<ffffffff8103e533>] put_files_struct+0x103/0x1c0
 [<ffffffff8103e478>] ? put_files_struct+0x48/0x1c0
 [<ffffffff8103e6b2>] exit_files+0x52/0x60
 [<ffffffff8103eb80>] do_exit+0x180/0x8e0
 [<ffffffff8104ef87>] ? get_signal_to_deliver+0xe7/0x6e0
 [<ffffffff8103f631>] do_group_exit+0x51/0xc0
 [<ffffffff8104f0bf>] get_signal_to_deliver+0x21f/0x6e0
 [<ffffffff8100223c>] do_signal+0x3c/0x580
 [<ffffffff81002805>] do_notify_resume+0x65/0xa0
 [<ffffffff812149de>] ? trace_hardirqs_on_thunk+0x3a/0x3f
 [<ffffffff814b4122>] int_signal+0x12/0x17
rmmod           D ffffffffa02b1b70     0  5714   5681 0x00000000
 ffff88000b497d48 0000000000000046 ffffffffa02b1b70 0000000000000002
 ffff88003920a3d0 ffff88000b497fd8 ffff88000b497fd8 ffff88000b497fd8
 ffff88003d17a3d0 ffff88003920a3d0 ffff88000b497d78 ffff88000b496000
Call Trace:
 [<ffffffffa02b1b70>] ? scst_unregister_target+0xe0/0x450 [scst]
 [<ffffffffa02b1b70>] ? scst_unregister_target+0xe0/0x450 [scst]
 [<ffffffff814a9b19>] schedule+0x29/0x70
 [<ffffffff814a9e57>] schedule_preempt_disabled+0x27/0x40
 [<ffffffff814a79b7>] mutex_lock_nested+0x187/0x390
 [<ffffffffa02b1b70>] ? scst_unregister_target+0xe0/0x450 [scst]
 [<ffffffffa02b1b70>] scst_unregister_target+0xe0/0x450 [scst]
 [<ffffffffa0287e51>] ? scst_local_exit+0x6b/0x21a [scst_local]
 [<ffffffff812c2d37>] ? put_device+0x17/0x20
 [<ffffffff812c3efa>] ? device_unregister+0x2a/0x60
 [<ffffffffa0285108>] __scst_local_remove_target+0xa8/0x130 [scst_local]
 [<ffffffffa0287e6a>] scst_local_exit+0x84/0x21a [scst_local]
 [<ffffffff810a40c6>] sys_delete_module+0x1a6/0x2b0
 [<ffffffff812149de>] ? trace_hardirqs_on_thunk+0x3a/0x3f
 [<ffffffff814b3de9>] system_call_fastpath+0x16/0x1b
ata_id          D ffff88003920c7a0     0  5715   5195 0x00000000
 ffff880015e97818 0000000000000046 0000000000000000 0000000000000046
 ffff88003920c7a0 ffff880015e97fd8 ffff880015e97fd8 ffff880015e97fd8
 ffff880021788000 ffff88003920c7a0 ffff880015e977f8 7fffffffffffffff
Call Trace:
 [<ffffffff814a9b19>] schedule+0x29/0x70
 [<ffffffff814a7355>] schedule_timeout+0x315/0x390
 [<ffffffff814a98e3>] ? wait_for_common+0x43/0x170
 [<ffffffff814a98e3>] ? wait_for_common+0x43/0x170
 [<ffffffff814a99c2>] wait_for_common+0x122/0x170
 [<ffffffff810705b0>] ? try_to_wake_up+0x2f0/0x2f0
 [<ffffffff814a9aed>] wait_for_completion+0x1d/0x20
 [<ffffffffa02bfad3>] scst_unregister_session+0x1a3/0x320 [scst]
 [<ffffffffa0284990>] scst_local_release_adapter+0xa0/0x140 [scst_local]
 [<ffffffff812c2f87>] device_release+0x27/0xa0
 [<ffffffff81209abb>] kobject_release+0x8b/0x1d0
 [<ffffffff8120993c>] kobject_put+0x2c/0x60
 [<ffffffff812c2d37>] put_device+0x17/0x20
 [<ffffffff812e1850>] scsi_host_dev_release+0xc0/0xe0
 [<ffffffff812c2f87>] device_release+0x27/0xa0
 [<ffffffff81209abb>] kobject_release+0x8b/0x1d0
 [<ffffffff8120993c>] kobject_put+0x2c/0x60
 [<ffffffff812c2d37>] put_device+0x17/0x20
 [<ffffffff812ea0c2>] scsi_target_dev_release+0x22/0x30
 [<ffffffff812c2f87>] device_release+0x27/0xa0
 [<ffffffff81209abb>] kobject_release+0x8b/0x1d0
 [<ffffffff8120993c>] kobject_put+0x2c/0x60
 [<ffffffff812c2d37>] put_device+0x17/0x20
 [<ffffffff812ed818>] scsi_device_dev_release_usercontext+0x118/0x130
 [<ffffffff812ed700>] ? scsi_device_cls_release+0x20/0x20
 [<ffffffff81056576>] execute_in_process_context+0x86/0xa0
 [<ffffffff812ed6dc>] scsi_device_dev_release+0x1c/0x20
 [<ffffffff812c2f87>] device_release+0x27/0xa0
 [<ffffffff81209abb>] kobject_release+0x8b/0x1d0
 [<ffffffff8120993c>] kobject_put+0x2c/0x60
 [<ffffffff812c2d37>] put_device+0x17/0x20
 [<ffffffff812df594>] scsi_device_put+0x44/0x60
 [<ffffffff812f974d>] scsi_cd_put+0x4d/0x70
 [<ffffffff812f97b1>] sr_block_release+0x41/0x60
 [<ffffffff8118a1ec>] __blkdev_put+0x19c/0x1d0
 [<ffffffff8118a27d>] blkdev_put+0x5d/0x180
 [<ffffffff8118a3c8>] blkdev_close+0x28/0x30
 [<ffffffff81153633>] fput+0x103/0x280
 [<ffffffff814a93b3>] ? __schedule+0x3c3/0x820
 [<ffffffff8114fad9>] filp_close+0x69/0x90
 [<ffffffff8114fba0>] sys_close+0xa0/0x100
 [<ffffffff814b3de9>] system_call_fastpath+0x16/0x1b

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Cc: Richard Sharpe <realrichardsharpe@gmail.com>

(Backport r4425 from trunk)


git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4427 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-07-27 16:29:05 +00:00
Bart Van Assche
afa7467c99 scst: make scst_cmd_threads_list more fine grained 
Avoid that suspending activity causes scst_init_threads() to delay.
That delay has been observed to cause "task blocked for more than ...
seconds" complaints.

Reported-by: yangfanlinux <yangfanlinux@gmail.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>

(Backport r4189 from trunk)


git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4426 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-07-27 16:26:50 +00:00
Bart Van Assche
b9692e9db1 scst: Avoid that WRITE SAME(16) triggers a length mismatch message, e.g.: 
scst: scst_parse_cmd:780:Warning: expected transfer length 512 for opcode 0x93 (handler vdisk_fileio, target iscsi) doesn't match decoded value 1048576.


git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4369 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-06-20 05:50:28 +00:00
Bart Van Assche
e85893bdf2 ib_srpt README: Fix a typo (merge r4355 from trunk) 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4361 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-06-18 17:32:28 +00:00
Bart Van Assche
dc250d6191 ib_srpt, procfs: Fix a compiler warning introduced in trunk r4260 (merge r4310 from trunk) 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4360 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-06-18 16:50:15 +00:00
Bart Van Assche
31331411e1 Avoid that the compiler warns about READ_ATTRIBUTE and WRITE_ATTRIBUTE 
already being defined in <scsi/scsi.h> on RHEL 6.0, 6.1 and 6.2 (merge r4032
from trunk).


git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4359 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-06-18 16:36:05 +00:00
Bart Van Assche
a26f6128da Merge scripts and nightly directories from trunk up to and including r4355 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4358 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-06-18 12:40:22 +00:00
Bart Van Assche
a74fa48536 Fix a kernel 3.4 compiler warning (merge r4344 from trunk) 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4357 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-06-18 12:35:35 +00:00
Bart Van Assche
463c93fe6e Add kernel 3.4 support (merge r4320 and r4321 from trunk) 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4356 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-06-18 12:24:40 +00:00
Vladislav Bolkhovitin
cdbfb0e1a9 Merge of the 2.1 branch's r4346: 
Fix for http://sourceforge.net/mailarchive/forum.php?thread_name=4FD72E89.2020807%40open-e.com&forum_name=scst-devel

Patch from Sergey Tashkinov <sergeyt1@open-e.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4347 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-06-13 19:02:12 +00:00
Vladislav Bolkhovitin
543a09ce1b Fix for http://sourceforge.net/mailarchive/forum.php?thread_name=4FD72E89.2020807%40open-e.com&forum_name=scst-devel 
Patch from Sergey Tashkinov <sergeyt1@open-e.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.1.0.x@4346 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-06-13 18:59:13 +00:00
Bart Van Assche
e30d0cbe0c ib_srpt: Make sure that a DREP is sent to the initiator if a DREQ is received while a session is being closed 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4314 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-05-23 07:43:37 +00:00
Bart Van Assche
550d50a7a1 ib_srpt: Adjust source code indentation (this is a whitespace-only change) 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4288 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-05-07 14:58:32 +00:00
Bart Van Assche
d7922d5fb3 ib_srpt: Update copyright statement 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4287 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-05-07 14:56:03 +00:00
Bart Van Assche
03223edf88 ib_srpt: Move the target port enabled check back (merge r4284 from trunk) 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4285 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-05-04 17:25:14 +00:00
Bart Van Assche
8e8018571f ib_srpt: Test earlier during login whether a port has been disabled (merge r4282 from trunk). 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4283 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-05-04 16:06:08 +00:00
Bart Van Assche
4f794143fb ib_srpt: Fix a few (theoretical ?) race conditions (merge r4278 from trunk) 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4280 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-05-03 14:22:41 +00:00
Bart Van Assche
21c4f975c8 ib_srpt: Remove a superfluous test (merge r4212 from trunk) 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4279 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-05-03 14:06:17 +00:00
Bart Van Assche
be0b4d640c ib_srpt: Handle thread creation failure properly (merge r4262:4270 from trunk). 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4271 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-05-02 15:32:26 +00:00
Vladislav Bolkhovitin
ee023587dd vcdrom: Don't oops if attaching a CD-ROM fails 
If no medium is inserted in /dev/sr0, starting SCST with the config
below triggers a kernel oops:

HANDLER vcdrom {
        DEVICE vcdrom {
                filename /dev/sr0
        }
}

Signed-off-by: Bart Van Assche <bvanassche@acm.org>

with some improvements



git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4249 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-04-30 19:23:33 +00:00
Bart Van Assche
992ea282c8 ib_srpt: Process all I/O on thread context. Avoids that "HW pending for too long" messages are generated if writing takes long (merge r4219 from trunk). 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4245 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-04-27 08:00:32 +00:00
Bart Van Assche
89a3e636c5 ib_srpt: Close active sessions when disabling a target (merge r4204 from trunk) 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4237 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-04-26 12:50:50 +00:00
Bart Van Assche
e5a1218aa0 ib_srpt: Process chained sg lists correctly (merge r4235 from trunk) 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4236 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-04-26 12:43:22 +00:00
Bart Van Assche
a271a19e2e fcst: merge r4177:4194 from trunk 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4232 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-04-25 10:06:41 +00:00
Bart Van Assche
3ee53839eb fcst: Builds again on kernel 3.0 and before (merge r4107 and r4108 from trunk) 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4231 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-04-25 10:04:37 +00:00
Bart Van Assche
cc5422a900 fcst: Introduce kfree_rcu() (merge r4106 from trunk). 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4230 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-04-25 10:01:31 +00:00
Bart Van Assche
a44c64c221 nightly build: Add 3.3 support patches (merge r4167 from trunk) 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4229 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-04-25 09:21:26 +00:00
Bart Van Assche
e277c6a32d Port to kernel 3.3 (merge r4164 from trunk). 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4228 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-04-25 09:19:06 +00:00
Bart Van Assche
d4b02d4a5f ib_srpt: Update an error message (merge r4222 from trunk). 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4227 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-04-25 09:00:14 +00:00
Bart Van Assche
04959d6c91 ib_srpt: Make sure that srpt_cm_req_recv() returns a negative value if login is refused (merged r4221 from trunk). 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4226 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-04-25 08:58:34 +00:00
Bart Van Assche
492a231d04 scripts: Merge r4204:4206 from trunk 
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4207 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-04-12 12:21:30 +00:00