Commit Graph
2741 Commits
Author SHA1 Message Date
Bart Van Assche 5caf5bdd99 Merged /trunk/scripts:r4356-4405
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4428 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-07-27 16:30:27 +00:00
Bart Van Assche 2f527c350c scst_local: Avoid that removing vdisk_cdrom devices can trigger a deadlock
Avoid that removing the scst_local kernel module triggers a deadlock
when one of its LUNs is a CD-ROM device. sr_block_release() invokes
scst_local_release_adapter() indirectly with sr_mutex held. So if 
scst_local_release_adapter() blocks until the scst_local session has
been freed a deadlock may be triggered if another CD-ROM device has
to be closed in order to free that session. Fix this by changing
scst_local_release_adapter() such that it does not wait until the
session unregistration has finished.

Call stacks obtained with echo w > /proc/sysrq-trigger:

SysRq : Show Blocked State
  task                        PC stack   pid father
scst_mgmtd      D ffffffff812f979d     0  5552      2 0x00000000
 ffff88003c335b30 0000000000000046 ffffffff812f979d 0000000000000002
 ffff8800171d47a0 ffff88003c335fd8 ffff88003c335fd8 ffff88003c335fd8
 ffff88003d1b0000 ffff8800171d47a0 ffff88003c335b60 ffff88003c334000
Call Trace:
 [<ffffffff812f979d>] ? sr_block_release+0x2d/0x60
 [<ffffffff812f979d>] ? sr_block_release+0x2d/0x60
 [<ffffffff814a9b19>] schedule+0x29/0x70
 [<ffffffff814a9e57>] schedule_preempt_disabled+0x27/0x40
 [<ffffffff814a79b7>] mutex_lock_nested+0x187/0x390
 [<ffffffff812f979d>] ? sr_block_release+0x2d/0x60
 [<ffffffff812f979d>] sr_block_release+0x2d/0x60
 [<ffffffff8118a1ec>] __blkdev_put+0x19c/0x1d0
 [<ffffffff8118a27d>] blkdev_put+0x5d/0x180
 [<ffffffff8118a3c8>] blkdev_close+0x28/0x30
 [<ffffffff81153633>] fput+0x103/0x280
 [<ffffffff8114fad9>] filp_close+0x69/0x90
 [<ffffffffa022ec24>] vdisk_detach_tgt+0x134/0x150 [scst_vdisk]
 [<ffffffffa02d8f2f>] scst_free_tgt_dev+0xdf/0x220 [scst]
 [<ffffffffa02d949f>] ? scst_free_session_callback+0x7f/0x170 [scst]
 [<ffffffffa02d90eb>] scst_sess_free_tgt_devs+0x7b/0x110 [scst]
 [<ffffffffa02d91de>] scst_free_session+0x5e/0x2a0 [scst]
 [<ffffffffa02d94be>] scst_free_session_callback+0x9e/0x170 [scst]
 [<ffffffffa02c6a05>] scst_global_mgmt_thread+0x2e5/0x580 [scst]
 [<ffffffff8105e850>] ? __init_waitqueue_head+0x60/0x60
 [<ffffffffa02c6720>] ? scst_register_session_non_gpl+0x20/0x20 [scst]
 [<ffffffff8105dd77>] kthread+0xb7/0xc0
 [<ffffffff814b50b4>] kernel_thread_helper+0x4/0x10
 [<ffffffff814abb30>] ? retint_restore_args+0x13/0x13
 [<ffffffff8105dcc0>] ? __init_kthread_worker+0x70/0x70
 [<ffffffff814b50b0>] ? gs_change+0x13/0x13
iscsi-scstd     D ffffffffa02b1b1f     0  5567      1 0x00000004
 ffff88003c2f59a8 0000000000000046 ffffffffa02b1b1f 0000000000000002
 ffff8800173b23d0 ffff88003c2f5fd8 ffff88003c2f5fd8 ffff88003c2f5fd8
 ffff88003d198000 ffff8800173b23d0 ffff88003c2f59d8 ffff88003c2f4000
Call Trace:
 [<ffffffffa02b1b1f>] ? scst_unregister_target+0x8f/0x450 [scst]
 [<ffffffffa02b1b1f>] ? scst_unregister_target+0x8f/0x450 [scst]
 [<ffffffff814a9b19>] schedule+0x29/0x70
 [<ffffffff814a9e57>] schedule_preempt_disabled+0x27/0x40
 [<ffffffff814a79b7>] mutex_lock_nested+0x187/0x390
 [<ffffffffa02b1b1f>] ? scst_unregister_target+0x8f/0x450 [scst]
 [<ffffffffa025c7ba>] ? __iscsi_del_attr+0xea/0x190 [iscsi_scst]
 [<ffffffffa02b1b1f>] scst_unregister_target+0x8f/0x450 [scst]
 [<ffffffffa025c7ba>] ? __iscsi_del_attr+0xea/0x190 [iscsi_scst]
 [<ffffffffa026249f>] target_destroy+0x5f/0xc0 [iscsi_scst]
 [<ffffffffa02631f2>] target_del_all+0xf2/0x2d0 [iscsi_scst]
 [<ffffffffa025c8aa>] release+0x4a/0xe0 [iscsi_scst]
 [<ffffffff81153633>] fput+0x103/0x280
 [<ffffffff8114fad9>] filp_close+0x69/0x90
 [<ffffffff8103e533>] put_files_struct+0x103/0x1c0
 [<ffffffff8103e478>] ? put_files_struct+0x48/0x1c0
 [<ffffffff8103e6b2>] exit_files+0x52/0x60
 [<ffffffff8103eb80>] do_exit+0x180/0x8e0
 [<ffffffff8104ef87>] ? get_signal_to_deliver+0xe7/0x6e0
 [<ffffffff8103f631>] do_group_exit+0x51/0xc0
 [<ffffffff8104f0bf>] get_signal_to_deliver+0x21f/0x6e0
 [<ffffffff8100223c>] do_signal+0x3c/0x580
 [<ffffffff81002805>] do_notify_resume+0x65/0xa0
 [<ffffffff812149de>] ? trace_hardirqs_on_thunk+0x3a/0x3f
 [<ffffffff814b4122>] int_signal+0x12/0x17
rmmod           D ffffffffa02b1b70     0  5714   5681 0x00000000
 ffff88000b497d48 0000000000000046 ffffffffa02b1b70 0000000000000002
 ffff88003920a3d0 ffff88000b497fd8 ffff88000b497fd8 ffff88000b497fd8
 ffff88003d17a3d0 ffff88003920a3d0 ffff88000b497d78 ffff88000b496000
Call Trace:
 [<ffffffffa02b1b70>] ? scst_unregister_target+0xe0/0x450 [scst]
 [<ffffffffa02b1b70>] ? scst_unregister_target+0xe0/0x450 [scst]
 [<ffffffff814a9b19>] schedule+0x29/0x70
 [<ffffffff814a9e57>] schedule_preempt_disabled+0x27/0x40
 [<ffffffff814a79b7>] mutex_lock_nested+0x187/0x390
 [<ffffffffa02b1b70>] ? scst_unregister_target+0xe0/0x450 [scst]
 [<ffffffffa02b1b70>] scst_unregister_target+0xe0/0x450 [scst]
 [<ffffffffa0287e51>] ? scst_local_exit+0x6b/0x21a [scst_local]
 [<ffffffff812c2d37>] ? put_device+0x17/0x20
 [<ffffffff812c3efa>] ? device_unregister+0x2a/0x60
 [<ffffffffa0285108>] __scst_local_remove_target+0xa8/0x130 [scst_local]
 [<ffffffffa0287e6a>] scst_local_exit+0x84/0x21a [scst_local]
 [<ffffffff810a40c6>] sys_delete_module+0x1a6/0x2b0
 [<ffffffff812149de>] ? trace_hardirqs_on_thunk+0x3a/0x3f
 [<ffffffff814b3de9>] system_call_fastpath+0x16/0x1b
ata_id          D ffff88003920c7a0     0  5715   5195 0x00000000
 ffff880015e97818 0000000000000046 0000000000000000 0000000000000046
 ffff88003920c7a0 ffff880015e97fd8 ffff880015e97fd8 ffff880015e97fd8
 ffff880021788000 ffff88003920c7a0 ffff880015e977f8 7fffffffffffffff
Call Trace:
 [<ffffffff814a9b19>] schedule+0x29/0x70
 [<ffffffff814a7355>] schedule_timeout+0x315/0x390
 [<ffffffff814a98e3>] ? wait_for_common+0x43/0x170
 [<ffffffff814a98e3>] ? wait_for_common+0x43/0x170
 [<ffffffff814a99c2>] wait_for_common+0x122/0x170
 [<ffffffff810705b0>] ? try_to_wake_up+0x2f0/0x2f0
 [<ffffffff814a9aed>] wait_for_completion+0x1d/0x20
 [<ffffffffa02bfad3>] scst_unregister_session+0x1a3/0x320 [scst]
 [<ffffffffa0284990>] scst_local_release_adapter+0xa0/0x140 [scst_local]
 [<ffffffff812c2f87>] device_release+0x27/0xa0
 [<ffffffff81209abb>] kobject_release+0x8b/0x1d0
 [<ffffffff8120993c>] kobject_put+0x2c/0x60
 [<ffffffff812c2d37>] put_device+0x17/0x20
 [<ffffffff812e1850>] scsi_host_dev_release+0xc0/0xe0
 [<ffffffff812c2f87>] device_release+0x27/0xa0
 [<ffffffff81209abb>] kobject_release+0x8b/0x1d0
 [<ffffffff8120993c>] kobject_put+0x2c/0x60
 [<ffffffff812c2d37>] put_device+0x17/0x20
 [<ffffffff812ea0c2>] scsi_target_dev_release+0x22/0x30
 [<ffffffff812c2f87>] device_release+0x27/0xa0
 [<ffffffff81209abb>] kobject_release+0x8b/0x1d0
 [<ffffffff8120993c>] kobject_put+0x2c/0x60
 [<ffffffff812c2d37>] put_device+0x17/0x20
 [<ffffffff812ed818>] scsi_device_dev_release_usercontext+0x118/0x130
 [<ffffffff812ed700>] ? scsi_device_cls_release+0x20/0x20
 [<ffffffff81056576>] execute_in_process_context+0x86/0xa0
 [<ffffffff812ed6dc>] scsi_device_dev_release+0x1c/0x20
 [<ffffffff812c2f87>] device_release+0x27/0xa0
 [<ffffffff81209abb>] kobject_release+0x8b/0x1d0
 [<ffffffff8120993c>] kobject_put+0x2c/0x60
 [<ffffffff812c2d37>] put_device+0x17/0x20
 [<ffffffff812df594>] scsi_device_put+0x44/0x60
 [<ffffffff812f974d>] scsi_cd_put+0x4d/0x70
 [<ffffffff812f97b1>] sr_block_release+0x41/0x60
 [<ffffffff8118a1ec>] __blkdev_put+0x19c/0x1d0
 [<ffffffff8118a27d>] blkdev_put+0x5d/0x180
 [<ffffffff8118a3c8>] blkdev_close+0x28/0x30
 [<ffffffff81153633>] fput+0x103/0x280
 [<ffffffff814a93b3>] ? __schedule+0x3c3/0x820
 [<ffffffff8114fad9>] filp_close+0x69/0x90
 [<ffffffff8114fba0>] sys_close+0xa0/0x100
 [<ffffffff814b3de9>] system_call_fastpath+0x16/0x1b

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Cc: Richard Sharpe <realrichardsharpe@gmail.com>

(Backport r4425 from trunk)


git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4427 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-07-27 16:29:05 +00:00
Bart Van Assche afa7467c99 scst: make scst_cmd_threads_list more fine grained
Avoid that suspending activity causes scst_init_threads() to delay.
That delay has been observed to cause "task blocked for more than ...
seconds" complaints.

Reported-by: yangfanlinux <yangfanlinux@gmail.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>

(Backport r4189 from trunk)


git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4426 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-07-27 16:26:50 +00:00
Bart Van Assche b9692e9db1 scst: Avoid that WRITE SAME(16) triggers a length mismatch message, e.g.:
scst: scst_parse_cmd:780:Warning: expected transfer length 512 for opcode 0x93 (handler vdisk_fileio, target iscsi) doesn't match decoded value 1048576.


git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4369 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-06-20 05:50:28 +00:00
Bart Van Assche e85893bdf2 ib_srpt README: Fix a typo (merge r4355 from trunk)
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4361 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-06-18 17:32:28 +00:00
Bart Van Assche dc250d6191 ib_srpt, procfs: Fix a compiler warning introduced in trunk r4260 (merge r4310 from trunk)
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4360 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-06-18 16:50:15 +00:00
Bart Van Assche 31331411e1 Avoid that the compiler warns about READ_ATTRIBUTE and WRITE_ATTRIBUTE
already being defined in <scsi/scsi.h> on RHEL 6.0, 6.1 and 6.2 (merge r4032
from trunk).


git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4359 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-06-18 16:36:05 +00:00
Bart Van Assche a26f6128da Merge scripts and nightly directories from trunk up to and including r4355
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4358 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-06-18 12:40:22 +00:00
Bart Van Assche a74fa48536 Fix a kernel 3.4 compiler warning (merge r4344 from trunk)
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4357 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-06-18 12:35:35 +00:00
Bart Van Assche 463c93fe6e Add kernel 3.4 support (merge r4320 and r4321 from trunk)
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4356 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-06-18 12:24:40 +00:00
Vladislav Bolkhovitin cdbfb0e1a9 Merge of the 2.1 branch's r4346:
Fix for http://sourceforge.net/mailarchive/forum.php?thread_name=4FD72E89.2020807%40open-e.com&forum_name=scst-devel

Patch from Sergey Tashkinov <sergeyt1@open-e.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4347 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-06-13 19:02:12 +00:00
Vladislav Bolkhovitin 543a09ce1b Fix for http://sourceforge.net/mailarchive/forum.php?thread_name=4FD72E89.2020807%40open-e.com&forum_name=scst-devel
Patch from Sergey Tashkinov <sergeyt1@open-e.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.1.0.x@4346 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-06-13 18:59:13 +00:00
Bart Van Assche e30d0cbe0c ib_srpt: Make sure that a DREP is sent to the initiator if a DREQ is received while a session is being closed
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4314 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-23 07:43:37 +00:00
Bart Van Assche 550d50a7a1 ib_srpt: Adjust source code indentation (this is a whitespace-only change)
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4288 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-07 14:58:32 +00:00
Bart Van Assche d7922d5fb3 ib_srpt: Update copyright statement
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4287 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-07 14:56:03 +00:00
Bart Van Assche 03223edf88 ib_srpt: Move the target port enabled check back (merge r4284 from trunk)
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4285 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-04 17:25:14 +00:00
Bart Van Assche 8e8018571f ib_srpt: Test earlier during login whether a port has been disabled (merge r4282 from trunk).
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4283 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-04 16:06:08 +00:00
Bart Van Assche 4f794143fb ib_srpt: Fix a few (theoretical ?) race conditions (merge r4278 from trunk)
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4280 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-03 14:22:41 +00:00
Bart Van Assche 21c4f975c8 ib_srpt: Remove a superfluous test (merge r4212 from trunk)
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4279 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-03 14:06:17 +00:00
Bart Van Assche be0b4d640c ib_srpt: Handle thread creation failure properly (merge r4262:4270 from trunk).
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4271 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-02 15:32:26 +00:00
Vladislav Bolkhovitin ee023587dd vcdrom: Don't oops if attaching a CD-ROM fails
If no medium is inserted in /dev/sr0, starting SCST with the config
below triggers a kernel oops:

HANDLER vcdrom {
        DEVICE vcdrom {
                filename /dev/sr0
        }
}

Signed-off-by: Bart Van Assche <bvanassche@acm.org>

with some improvements



git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4249 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-04-30 19:23:33 +00:00
Bart Van Assche 992ea282c8 ib_srpt: Process all I/O on thread context. Avoids that "HW pending for too long" messages are generated if writing takes long (merge r4219 from trunk).
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4245 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-04-27 08:00:32 +00:00
Bart Van Assche 89a3e636c5 ib_srpt: Close active sessions when disabling a target (merge r4204 from trunk)
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4237 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-04-26 12:50:50 +00:00
Bart Van Assche e5a1218aa0 ib_srpt: Process chained sg lists correctly (merge r4235 from trunk)
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4236 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-04-26 12:43:22 +00:00
Bart Van Assche a271a19e2e fcst: merge r4177:4194 from trunk
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4232 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-04-25 10:06:41 +00:00
Bart Van Assche 3ee53839eb fcst: Builds again on kernel 3.0 and before (merge r4107 and r4108 from trunk)
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4231 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-04-25 10:04:37 +00:00
Bart Van Assche cc5422a900 fcst: Introduce kfree_rcu() (merge r4106 from trunk).
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4230 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-04-25 10:01:31 +00:00
Bart Van Assche a44c64c221 nightly build: Add 3.3 support patches (merge r4167 from trunk)
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4229 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-04-25 09:21:26 +00:00
Bart Van Assche e277c6a32d Port to kernel 3.3 (merge r4164 from trunk).
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4228 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-04-25 09:19:06 +00:00
Bart Van Assche d4b02d4a5f ib_srpt: Update an error message (merge r4222 from trunk).
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4227 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-04-25 09:00:14 +00:00
Bart Van Assche 04959d6c91 ib_srpt: Make sure that srpt_cm_req_recv() returns a negative value if login is refused (merged r4221 from trunk).
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4226 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-04-25 08:58:34 +00:00
Bart Van Assche 492a231d04 scripts: Merge r4204:4206 from trunk
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4207 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-04-12 12:21:30 +00:00
Bart Van Assche 3535eada10 scripts: Merge r3737:4204 from trunk
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4205 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-04-12 11:50:41 +00:00
Bart Van Assche b3d8507430 ib_srpt: Workaround for an openSUSE 12.1 compiler bug (see also http://bugzilla.novell.com/show_bug.cgi?id=756235 - merged r4201 from trunk)
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4204 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-04-10 15:28:13 +00:00
Bart Van Assche 0735535126 ib_srpt: Make sure that pre-RTU requests are processed before post-RTU requests (merge trunk r4200).
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4203 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-04-10 15:07:37 +00:00
Bart Van Assche 7caca49529 ib_srpt: Update ChangeLog (merged r4197 from trunk)
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4198 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-04-07 09:15:33 +00:00
Bart Van Assche 6734a08da5 ib_srpt: Disallow new logins during module removal (merged r4146 from trunk)
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4196 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-04-07 08:53:57 +00:00
Bart Van Assche 9869575cc2 ib_srpt: Unregister sessions properly / fix RTU race (merged r4192 and r4193
from trunk).


git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4195 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-04-07 08:49:41 +00:00
Bart Van Assche 0d8b8df7e9 ib_srpt: Fix QP use-after-free triggered by SRP logout (merge r4139 from trunk).
Fixed this by destroying cm_id before QP instead of after. The following
messages were logged if the use-after-free occurred:

mlx4_core 0000:08:00.0: command 0x19 failed: fw status = 0x9
ib_srpt: ***ERROR***: srpt_init_ch_qp() failed (-9)
ib_srpt: ***ERROR***: rejected SRP_LOGIN_REQ because creating a new RDMA channel failed.
ib_srpt: Rejecting login with reason 0x10001


git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4140 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-02-18 10:43:05 +00:00
Bart Van Assche ffcf6bc9a1 scstadmin: Replace scstadmin/scstadmin by a soft link if it is a regular file. This is a workaround for a bug in the "Download tarball" functionality of the SourceForge website (merge r4129 from trunk).
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4130 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-02-15 10:03:54 +00:00
Bart Van Assche d663c8d47d SCST core and iSCSI-SCST: Port to RHEL / CentOS / SL 5.7 (merged r4111 and r4112 from trunk)
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4126 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-02-13 19:23:52 +00:00
Bart Van Assche 55ea8b70c1 iscsi-scstd: Make sure that the buffer allocated for nl_read() is large enough (merged r4109 and r4110 from trunk)
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4125 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-02-13 19:22:01 +00:00
Bart Van Assche 985d0e7c4d fcst: Add missing #include <linux/module.h> (merged r4065 from trunk)
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4124 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-02-13 19:18:39 +00:00
Vladislav Bolkhovitin ccffee2682 Version updated to 2.2.1-pre
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4103 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-01-26 05:43:06 +00:00
Vladislav Bolkhovitin c2cba76bcd Merge of the trunk's r4017:
Improve release mode TM logging to simplify imvestigations



git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4102 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-01-26 05:23:25 +00:00
Bart Van Assche 4e34d7a4f4 ib_srpt: Update version
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4098 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-01-25 21:02:44 +00:00
Bart Van Assche e3f9a946b6 Make ib_srpt build again
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4097 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-01-25 20:50:59 +00:00
Bart Van Assche b1321b7d11 Add kernel 3.2 support / iSCSI-SCST netlink change (merge r4077, r4078 and r4080 from trunk)
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4096 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-01-25 20:10:27 +00:00
Bart Van Assche 3c7a7fc28d ib_srpt: Prepare 2.2.0 release
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4095 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-01-25 19:22:40 +00:00
Bart Van Assche a3fe2c4a59 scst_local: Fix a recently introduced compiler warning (merged r3804 from trunk)
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4094 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-01-25 19:18:10 +00:00