mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-05-17 10:41:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
3,524 Commits 26 Branches 11 Tags
5dcbbc5aaa1addfa0cf5cbbe7c085010a33f33cc
Commit Graph

3524 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Vladislav Bolkhovitin
5dcbbc5aaa Cleanup 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4743 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2013-01-17 21:13:12 +00:00
Vladislav Bolkhovitin
61f58f5792 Minor logging fixes 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4742 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2013-01-16 02:04:05 +00:00
Vladislav Bolkhovitin
f5beb91d8b Version updated 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4741 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2013-01-16 00:55:38 +00:00
Vladislav Bolkhovitin
bd7c893f04 Multiple makefiles: autodetect SCST include directory 
It is cumbersome to change SCST_INC_DIR and SCST_DIR in each Makefile
before and after a release. Hence modify the Makefiles such that these
paths are detected automatically.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4740 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2013-01-16 00:12:38 +00:00
Vladislav Bolkhovitin
c6d247254c scst_local: Remove a superfluous include path 
Target drivers must not include header files from the SCST source
code directory. Hence remove -I$(SCST_DIR) from the compiler flags.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4739 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2013-01-16 00:08:44 +00:00
Vladislav Bolkhovitin
844071da62 vdisk_blockio: Make Windows 2003 FORMAT succeed 
Reported-by: scst niko <scst.niko@gmail.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4738 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2013-01-16 00:04:42 +00:00
Bart Van Assche
571d2a977b nightly build: Update kernel versions 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4736 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2013-01-13 18:34:10 +00:00
Bart Van Assche
2005f20144 scstadmin: Correct release-archive target 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4734 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2013-01-13 17:52:31 +00:00
Bart Van Assche
58d0a4e1f2 fileio: Add release-archive target 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4733 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2013-01-13 17:51:48 +00:00
Bart Van Assche
14a4b165d8 scstadmin: Add release-archive target 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4732 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2013-01-13 17:48:15 +00:00
Mark Buechler
3fa995bb29 Truncate config file instead of deleting it before writing. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4728 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2013-01-11 17:59:51 +00:00
Vladislav Bolkhovitin
9226ba652c scst, SCSI pass-through: Do not complain unnecessarily about max_hw_sectors 
cmd->bufflen is in bytes so it has to be divided by the sector size before
being compared with queue_max_hw_sectors(). Other changes included in this
patch:
* Print the "rc" error code as a signed integer instead of as an unsigned
  hex number.
* Change "(int)rc" into "rc". The cast isn't necessary because rc has type
  int.
* Insert a "0x" prefix in front of the SCSI CDB opcode.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4727 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2013-01-09 01:42:10 +00:00
Vladislav Bolkhovitin
ae6485796d Targets should be deleted after all its sessions deleted 
Each session on delete is looking for each target.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4726 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2013-01-09 01:38:05 +00:00
Bart Van Assche
c3910d8367 Build fix for Grsecurity (e.g. Gentoo-Hardened) 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4724 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2013-01-07 15:29:21 +00:00
Bart Van Assche
82fcc41287 /etc/init.d/scst: Change one tab into a space 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4686 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2013-01-06 09:32:40 +00:00
Bart Van Assche
97e8aa1f08 /etc/init.d/scst: Introduce character classes 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4685 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2013-01-06 09:32:00 +00:00
Bart Van Assche
88376b1577 /etc/init.d/scst: Revert r4151 and hence restore r4023 since this setting is needed again for openSUSE 12.2 systems 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4684 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2013-01-06 09:14:39 +00:00
Vladislav Bolkhovitin
563e7c248c Avoid that scst_abort_cmd() triggers a false positive in Coverity 
Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4682 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2013-01-05 02:54:08 +00:00
Bart Van Assche
c70fad0839 Revert r4678 because it was incomplete 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4681 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2013-01-04 09:43:52 +00:00
Vladislav Bolkhovitin
ddae1f7a63 Fix incorrect duplicate connection sysfs entry detection 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4680 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2013-01-04 03:08:29 +00:00
Vladislav Bolkhovitin
e7e9101efd Automate release archive generation 
This patch makes it easier to generate the release archives that
can be downloaded from http://scst.sourceforge.net/downloads.html.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4679 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2013-01-04 00:29:30 +00:00
Vladislav Bolkhovitin
59affce667 scst pr: Use get_unaligned_be64() and put_unaligned_be64() 
Clean up the code for converting to and from the be64 data type as follows:
* Change get_unaligned((__be64 *)p) into get_unaligned_be64(p).
* Change put_unaligned(value, (__be64 *)p) into put_unaligned_be64(value, p).

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4678 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2013-01-04 00:10:35 +00:00
Bart Van Assche
8fe7638e44 scripts/generate-release-archive: Set executable property 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4677 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2013-01-03 17:57:01 +00:00
Bart Van Assche
9dcf4d3036 ib_srpt: Move functionality for creating a release archive into scripts/generate-release-archive 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4676 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2013-01-03 17:46:01 +00:00
Bart Van Assche
3c7920b48e ib_srpt: Defer reenabling interrupts until after completion processing finished 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4675 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2013-01-03 09:19:09 +00:00
Vladislav Bolkhovitin
d03c8b7729 scst: Simplify __scst_get_buf() and __scst_get_sg_page() 
Signed-off-by: Bart Van Assche <bvanassche@acm.org>

with some further simplifications



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4673 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-12-31 23:48:03 +00:00
Vladislav Bolkhovitin
df5faa838e scst: Simplify the data buffer tracing code 
Signed-off-by: Bart Van Assche <bvanassche@acm.org>




git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4672 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-12-28 23:39:19 +00:00
Vladislav Bolkhovitin
e2245ce384 scst_vdisk: Include device name in EOD error message 
Include the device name in the end-of-device error message to make it
easy to find out which device this message applies to.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4671 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-12-28 23:31:12 +00:00
Vladislav Bolkhovitin
874f8d5943 Fix possible crash if misbehaving dev handler tries to set too big response data len. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4670 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-12-28 23:20:07 +00:00
Vladislav Bolkhovitin
3f77da8c4d Fix ILI handling to have full 32 bits handling 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4669 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-12-28 23:19:13 +00:00
Vladislav Bolkhovitin
da3337faae scst: Avoid truncating requests larger than 512 KB 
Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4668 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-12-28 03:13:13 +00:00
Vladislav Bolkhovitin
3d0f5096fb Resurrect Emulex, since it resurrected SCST support 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4667 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-12-28 02:51:42 +00:00
Vladislav Bolkhovitin
b08857591c Micro-optimize scst_adjust_sg() and scst_restore_sg_buff() 
Micro-optimize scst_adjust_sg() and scst_restore_sg_buff() by replacing
two variables (orig_sg and orig_sg_entry, a pointer and an integer) by
one variable (orig_sg_entry, a pointer to a scatterlist element). This
allows to eliminate one assignment in scst_adjust_sg() and one read in
scst_restore_sg_buff().

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4666 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-12-28 02:43:10 +00:00
Bart Van Assche
4963e2a4c9 ib_srpt: Avoid that max_compl_time_ms is zero due to an integer overflow 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4662 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-12-21 12:04:19 +00:00
Bart Van Assche
0121fc8a55 ib_srpt: Update Testing.txt 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4661 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-12-21 12:02:53 +00:00
Vladislav Bolkhovitin
1f600fcc91 scst_local: Fix bug in error path 
device_unregister() invokes scst_local_release_adapter() and hence unregisters
the session. Avoid that it is attempted a second time to unregister the
session which would result in a crash.

[3656]: scst: scst_unregister_target:680:Target local for template scst_local unregistered successfully
[3656]: scst: scst_unregister_target_template:457:Target template scst_local unregistered successfully
[3655]: scst_unregister_session:6795:Unregistering session ffff8800071a0000 (wait 0)
general protection fault: 0000 [#1] SMP
Modules linked in: iscsi_scst(O) scst_vdisk(O) scst(O) ntfs vfat msdos fat ext3 jbd ext2 brd netconsole configfs isofs ib_iser rdma_cm ib_cm iw_cm ib_sa ib_mad ib_core ib_addr iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi joydev hid_generic binfmt_misc usbhid hid intel_agp psmouse intel_gtt processor agpgart microcode i2c_piix4 button lp parport ext4 mbcache jbd2 floppy ata_piix zlib_deflate libcrc32c [last unloaded: scst_local]
CPU 1
Pid: 3655, comm: scsi_id Tainted: G           O 3.6.5-debug+ #1 Bochs Bochs
RIP: 0010:[<ffffffffa0221a74>]  [<ffffffffa0221a74>] scst_pre_rx_mgmt_cmd+0x64/0x210 [scst]
RSP: 0018:ffff88000304d598  EFLAGS: 00010246
RAX: 6b6b6b6b6b6b6b6b RBX: 0000000000000001 RCX: 0000000000000000
RDX: 0000000000000001 RSI: 000000000000000a RDI: ffff8800071a0000
RBP: ffff88000304d5c8 R08: 0000000000000002 R09: 0000000000000000
R10: 000000000000c81d R11: 0000000000000000 R12: ffff8800071a0000
R13: 000000000000000a R14: 0000000000000000 R15: ffff880000000000
FS:  00007fb6fe8c6700(0000) GS:ffff88003e000000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
CR2: 00007f2169286bd0 CR3: 000000001cd26000 CR4: 00000000000006e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
Process scsi_id (pid: 3655, threadinfo ffff88000304c000, task ffff88003d9a0000)
Stack:
 0000000000000000 0000000000000282 ffff88000304d650 0000000000000000
 ffff8800071a0000 dead4ead00000000 ffff88000304d638 ffffffffa0221fdf
 0000000000000004 0000000000000000 ffff88000304d5f8 ffffffffa025d6a3
Call Trace:
 [<ffffffffa0221fdf>] scst_rx_mgmt_fn+0x7f/0x3a0 [scst]
 [<ffffffffa025d6a3>] ? spin_unlock_irqrestore.constprop.0+0x13/0x20 [scst]
 [<ffffffffa025d825>] ? debug_print_with_prefix+0x165/0x1f0 [scst]
 [<ffffffffa022acaa>] scst_rx_mgmt_fn_lun.constprop.34+0x4a/0x60 [scst]
 [<ffffffffa022adf1>] scst_unregister_session+0x131/0x320 [scst]
 [<ffffffff812bfce7>] ? device_release+0x27/0xa0
 [<ffffffff8120450b>] ? kobject_release+0x8b/0x1d0
 [<ffffffff8120438c>] ? kobject_put+0x2c/0x60
 [<ffffffff812bfa97>] ? put_device+0x17/0x20
 [<ffffffff812de820>] ? scsi_host_dev_release+0xc0/0xe0
 [<ffffffff812bfce7>] ? device_release+0x27/0xa0
 [<ffffffff8120450b>] ? kobject_release+0x8b/0x1d0
 [<ffffffff8120438c>] ? kobject_put+0x2c/0x60
 [<ffffffff812bfa97>] ? put_device+0x17/0x20
 [<ffffffff812e7102>] ? scsi_target_dev_release+0x22/0x30
 [<ffffffff812bfce7>] ? device_release+0x27/0xa0
 [<ffffffff8120450b>] ? kobject_release+0x8b/0x1d0
 [<ffffffff8120438c>] ? kobject_put+0x2c/0x60
 [<ffffffff812bfa97>] ? put_device+0x17/0x20
 [<ffffffff812ea858>] ? scsi_device_dev_release_usercontext+0x108/0x120
 [<ffffffff812ea750>] ? scsi_device_cls_release+0x20/0x20
 [<ffffffff8105a996>] ? execute_in_process_context+0x86/0xa0
 [<ffffffff812ea72c>] ? scsi_device_dev_release+0x1c/0x20
 [<ffffffff812bfce7>] ? device_release+0x27/0xa0
 [<ffffffff8120450b>] ? kobject_release+0x8b/0x1d0
 [<ffffffff8120438c>] ? kobject_put+0x2c/0x60
 [<ffffffff812bfa97>] ? put_device+0x17/0x20
 [<ffffffff812dc534>] ? scsi_device_put+0x44/0x60
 [<ffffffff812f685d>] ? scsi_cd_put+0x4d/0x70
 [<ffffffff812f69b0>] ? sr_block_open+0xd0/0x120
 [<ffffffff81184389>] ? __blkdev_get+0xe9/0x4a0
 [<ffffffff81183bb4>] ? bd_acquire+0x24/0xf0
 [<ffffffff81184a90>] ? blkdev_get+0x350/0x350
 [<ffffffff81184793>] ? blkdev_get+0x53/0x350
 [<ffffffff81156a72>] ? complete_walk+0x52/0x140
 [<ffffffff81184a90>] ? blkdev_get+0x350/0x350
 [<ffffffff814ac49b>] ? _raw_spin_unlock+0x2b/0x50
 [<ffffffff81184a90>] ? blkdev_get+0x350/0x350
 [<ffffffff81184afc>] ? blkdev_open+0x6c/0x90
 [<ffffffff81148fb6>] ? do_dentry_open.isra.19+0x216/0x2a0
 [<ffffffff81149062>] ? finish_open+0x22/0x40
 [<ffffffff8115a62e>] ? do_last+0x72e/0xe20
 [<ffffffff811572d8>] ? inode_permission+0x18/0x50
 [<ffffffff8115737b>] ? link_path_walk+0x6b/0x930
 [<ffffffff8115add6>] ? path_openat+0xb6/0x4a0
 [<ffffffff81097c9d>] ? trace_hardirqs_on+0xd/0x10
 [<ffffffff8115b5d2>] ? do_filp_open+0x42/0xa0
 [<ffffffff814ac49b>] ? _raw_spin_unlock+0x2b/0x50
 [<ffffffff81168802>] ? alloc_fd+0xd2/0x120
 [<ffffffff8114a150>] ? do_sys_open+0x100/0x1e0
 [<ffffffff8114a251>] ? sys_open+0x21/0x30
 [<ffffffff814b5029>] ? system_call_fastpath+0x16/0x1b
Code: 00 00 65 48 8b 04 25 80 ba 00 00 8b b0 94 01 00 00 48 c7 c2 a0 b8 26 a0 31 c0 48 c7 c7 45 e0 27 a0 e8 23 15 28 e1 49 8b 44 24 08 <48> 8b 40 30 48 83 78 50 00 0f 84 52 01 00 00 83 fb 01 19 ff 81

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4658 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-12-20 02:32:25 +00:00
Vladislav Bolkhovitin
55a596b073 Fix missed locking 
Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4657 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-12-20 02:26:28 +00:00
Vladislav Bolkhovitin
5fe3432935 scst_get_unique_sess_name(): Handle out-of-memory properly 
Return NULL instead of triggering a NULL pointer dereference if out
of memory. Detected by Coverity.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4656 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-12-20 02:20:24 +00:00
Vladislav Bolkhovitin
47db473269 Remove a superfluous pair of braces 
Avoid that checkpatch v3.7 reports the following warning:

WARNING: braces {} are not necessary for any arm of this statement

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4655 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-12-20 02:17:23 +00:00
Bart Van Assche
0d0b4e5af1 nightly build: Add kernel 3.7 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4654 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-12-19 07:37:32 +00:00
Bart Van Assche
4b08a03293 nightly build: Update kernel versions 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4653 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-12-18 17:04:45 +00:00
Bart Van Assche
0fd03d44b1 srpt/Testing.txt: Limit to 80 columns 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4652 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-12-18 09:51:08 +00:00
Bart Van Assche
12313bf114 nightly build: Add kernel 3.7 patches 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4647 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-12-18 08:54:50 +00:00
Bart Van Assche
2a50de2e4e iscsi-scst: Build fix for kernels 3.6.1..3.6.10 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4646 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-12-18 08:22:05 +00:00
Vladislav Bolkhovitin
299c407697 Update for kernel 3.7 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4645 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-12-17 23:09:58 +00:00
Vladislav Bolkhovitin
d178fa8da9 qla2x00t: Avoid reading uninitialized memory 
Reported-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4644 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-12-13 21:28:10 +00:00
Vladislav Bolkhovitin
df9b760738 PR: Compute scope field correctly 
Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4643 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-12-13 21:08:29 +00:00
Vladislav Bolkhovitin
c7c0672b51 Fir corner case handling in vdisk_attach_tgt() 
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Reported-by: Sebastian Riemer <sebastian.riemer@profitbricks.com>
Tested-by: Sebastian Riemer <sebastian.riemer@profitbricks.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4642 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-12-13 21:06:17 +00:00
Vladislav Bolkhovitin
e9ce622422 scst, persistent reservations: Fix a locking error 
Avoid that a command like sg_raw -r256 /dev/sda 5e 04 00 00 00 00 00 20 00 00
triggers the following error messages on a kernel with PROVE_LOCKING enabled:

=====================================
[ BUG: bad unlock balance detected! ]
3.7.0-rc5-debug+ #1 Tainted: G           O
-------------------------------------
disk010_1/9985 is trying to release lock (&dev->dev_pr_mutex) at:
[<ffffffff814b742e>] mutex_unlock+0xe/0x10
but there are no more locks to release!

other info that might help us debug this:
no locks held by disk010_1/9985.

stack backtrace:
Pid: 9985, comm: disk010_1 Tainted: G           O 3.7.0-rc5-debug+ #1
Call Trace:
 [<ffffffff8109598e>] print_unlock_inbalance_bug+0xfe/0x110
 [<ffffffff81098bc6>] lock_release+0x1f6/0x260
 [<ffffffff814b734a>] __mutex_unlock_slowpath+0x9a/0x170
 [<ffffffff814b742e>] mutex_unlock+0xe/0x10
 [<ffffffffa02d7d0f>] scst_pr_write_unlock+0x4f/0xd0 [scst]
 [<ffffffffa02db83c>] scst_persistent_reserve_in_local+0x2cc/0x470 [scst]
 [<ffffffffa02d99bf>] scst_do_local_exec+0x15f/0x1c0 [scst]
 [<ffffffffa02e35d0>] scst_exec_check_blocking+0xd0/0x2c0 [scst]
 [<ffffffffa02e3955>] scst_exec_check_sn+0x195/0x2f0 [scst]
 [<ffffffffa02e5249>] scst_process_active_cmd+0x549/0x780 [scst]
 [<ffffffffa02e5509>] scst_do_job_active+0x89/0x1a0 [scst]
 [<ffffffffa02e5883>] scst_cmd_thread+0x183/0x310 [scst]
 [<ffffffff81063ccd>] kthread+0xed/0x100
 [<ffffffff814c2aac>] ret_from_fork+0x7c/0xb0

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4641 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-12-12 00:09:11 +00:00
Vladislav Bolkhovitin
ed9ac5b9de Cleanup 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4640 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-12-11 02:57:16 +00:00