Commit Graph
8576 Commits
Author SHA1 Message Date
Gleb Chesnokov 5ee3f376b6 qla2x00t-32gbit: Fix crash in NVMe abort path
System crash was seen when I/O was run against an NVMe target and aborts
were occurring.

Crash stack is:

    -- relevant crash stack --
    BUG: kernel NULL pointer dereference, address: 0000000000000010
    :
    #6 [ffffae1f8666bdd0] page_fault at ffffffffa740122e
       [exception RIP: qla_nvme_abort_work+339]
       RIP: ffffffffc0f592e3  RSP: ffffae1f8666be80  RFLAGS: 00010297
       RAX: 0000000000000000  RBX: ffff9b581fc8af80  RCX: ffffffffc0f83bd0
       RDX: 0000000000000001  RSI: ffff9b5839c6c7c8  RDI: 0000000008000000
       RBP: ffff9b6832f85000   R8: ffffffffc0f68160   R9: ffffffffc0f70652
       R10: ffffae1f862ffdc8  R11: 0000000000000300  R12: 000000000000010d
       R13: 0000000000000000  R14: ffff9b5839cea000  R15: 0ffff9b583fab170
       ORIG_RAX: ffffffffffffffff   CS: 0010  SS: 0018
    #7 [ffffae1f8666be98] process_one_work at ffffffffa6aba184
    #8 [ffffae1f8666bed8] worker_thread at ffffffffa6aba39d
    #9 [ffffae1f8666bf10] kthread at ffffffffa6ac06ed

The crash was due to a stale SRB structure access after it was aborted.
Fix the issue by removing stale access.

Link: https://lore.kernel.org/r/20210908164622.19240-5-njavali@marvell.com
Fixes: 2cabf10dbbe3 ("scsi: qla2xxx: Fix hang on NVMe command timeouts")
Cc: stable@vger.kernel.org
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Arun Easi <aeasi@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[ commit e6e22e6cc296 upstream ]
2022-01-19 23:16:04 +03:00
Gleb Chesnokov bc3f572c65 qla2x00t-32gbit: Check for firmware capability before creating QPair
Add firmware capability check of multiQ specifically for ISP25XX before
creating qpair.

Link: https://lore.kernel.org/r/20210908164622.19240-4-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[ commit 8192817efbc3 upstream ]
2022-01-19 23:16:04 +03:00
Gleb Chesnokov ea0fa0822c qla2x00t-32gbit: Display 16G only as supported speeds for 3830c card
This card is unique and doesn't support lower speeds, hence update the fdmi
field to display 16G only.

Link: https://lore.kernel.org/r/20210908164622.19240-3-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[ commit 52cca50d35f8 upstream ]
2022-01-19 23:16:04 +03:00
Gleb Chesnokov 9c3e39e3d0 qla2x00t-32gbit: Backport the BSG code
Backport the BSG code that was introduced in the previous commit.
2022-01-19 23:16:04 +03:00
Gleb Chesnokov b6734a2eb1 qla2x00t-32gbit: Add support for mailbox passthru
This interface will allow user space applications to send a mailbox command
to the firmware.

Link: https://lore.kernel.org/r/20210908164622.19240-2-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Bikash Hazarika <bhazarika@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[ commit 9e1c3206960f upstream ]
2022-01-19 23:16:04 +03:00
Gleb Chesnokov 4082402a73 qla2x00t-32gbit: Remove support for RHEL6
The SCST has dropped support for RHEL6 since SCST v3.6.
2022-01-19 23:16:04 +03:00
Chesnokov Gleb 60338c1d15 github: Improve the listing of modified files for the Mailing list action
Use --stat option instead of --name-only for the 'Get list of files' step,
as it also provides stats on modified files.
2022-01-17 04:51:53 +03:00
Chesnokov Gleb be99c4abca scst/include/backport.h: Remove WQ_NON_REENTRANT definition
Remove this macro since it is no longer needed after support
was dropped for kernels before 3.10.
2022-01-17 04:51:53 +03:00
Chesnokov Gleb 365c1365b4 Bump the minimal kernel version requirements 2022-01-13 17:26:37 +03:00
Chesnokov Gleb 721d7ea63e qla2x00t-32gbit: Remove support for kernel versions before 3.10
The SCST has dropped support for kernels older than 3.10.0 (RHEL 7 / Centos 7) since SCST v3.6.
2022-01-13 17:26:37 +03:00
Chesnokov Gleb 8aec03276a qla2x00t: Remove support for kernel versions before 3.10
The SCST has dropped support for kernels older than 3.10.0 (RHEL 7 / Centos 7) since SCST v3.6.
2022-01-13 17:26:37 +03:00
Chesnokov Gleb 0a05b57009 fcst: Remove support for kernel versions before 3.10
The SCST has dropped support for kernels older than 3.10.0 (RHEL 7 / Centos 7) since SCST v3.6.
2022-01-13 17:26:37 +03:00
Chesnokov Gleb 165285b64b ib_srpt: Remove support for kernel versions before 3.10
The SCST has dropped support for kernels older than 3.10.0 (RHEL 7 / Centos 7) since SCST v3.6.
2022-01-13 17:26:37 +03:00
Chesnokov Gleb 41943ed156 iscsi-scst: Remove support for kernel versions before 3.10
The SCST has dropped support for kernels older than 3.10.0 (RHEL 7 / Centos 7) since SCST v3.6.
2022-01-13 17:26:37 +03:00
Chesnokov Gleb c5766b27da scst_local: Remove support for kernel versions before 3.10
The SCST has dropped support for kernels older than 3.10.0 (RHEL 7 / Centos 7) since SCST v3.6.
2022-01-13 17:26:37 +03:00
Chesnokov Gleb 5e2f40e301 scst_copy_mgr: Remove support for kernel versions before 3.10
The SCST has dropped support for kernels older than 3.10.0 (RHEL 7 / Centos 7) since SCST v3.6.
2022-01-13 17:26:37 +03:00
Chesnokov Gleb 9bc5622f63 scst_targ: Remove support for kernel versions before 3.10
The SCST has dropped support for kernels older than 3.10.0 (RHEL 7 / Centos 7) since SCST v3.6.
2022-01-13 17:26:37 +03:00
Chesnokov Gleb dc11986cd2 scst_vdisk: Remove support for kernel versions before 3.10
The SCST has dropped support for kernels older than 3.10.0 (RHEL 7 / Centos 7) since SCST v3.6.
2022-01-13 17:26:37 +03:00
Chesnokov Gleb 1fd799f3ab dev_handlers: Remove support for kernel versions before 3.10
The SCST has dropped support for kernels older than 3.10.0 (RHEL 7 / Centos 7) since SCST v3.6
2022-01-13 17:26:37 +03:00
Chesnokov Gleb 0a1b23a453 scst_dlm: Remove support for kernel versions before 3.10
The SCST has dropped support for kernels older than 3.10.0 (RHEL 7 / Centos 7) since SCST v3.6.
2022-01-13 17:26:37 +03:00
Chesnokov Gleb 488aaeed71 scst_lib: Remove support for kernel versions before 3.10
The SCST has dropped support for kernels older than 3.10.0 (RHEL 7 / Centos 7) since SCST v3.6.
2022-01-13 17:26:37 +03:00
Chesnokov Gleb c6906d2ac2 scst: Remove support for kernel versions before 3.10
The SCST has dropped support for kernels older than 3.10.0 (RHEL 7 / Centos 7) since SCST v3.6.
2022-01-13 17:26:37 +03:00
Chesnokov Gleb 87e6796403 scst/include/backport.h: Remove support for kernel versions before 3.10
The SCST has dropped support for kernels older than 3.10.0 (RHEL 7 / Centos 7) since SCST v3.6.
2022-01-13 17:26:37 +03:00
Chesnokov Gleb 3543d6ce87 nightly build: Update kernel versions 2022-01-12 14:06:54 +03:00
Chesnokov Gleb 85846aa2e1 Update stable branch version for github Mailing list action 2022-01-12 14:06:54 +03:00
Chesnokov Gleb 64a8485fe7 Bump the version number to 3.7.0-pre
These changes have been generated by running the following command:

$ scripts/update-version 3 7 0-pre
2022-01-11 16:37:34 +03:00
Chesnokov Gleb db4a95cfaf scripts/update-version: Also update the qla2x00t-32gbit version number
Update the Q2T_VERSION_STRING for the qla2x00t-32gbit driver.

Fixes: 0b3aad05 ("scripts/update-version: Also update the qla2x00t-32gbit version number")
2022-01-11 16:37:34 +03:00
Chesnokov Gleb afb52bc788 Add a list of files per commit for github Mailing list action 2022-01-11 14:19:57 +03:00
Bart Van Assche ff09b47b1a Makefile: Include the debian directory in the source code archive v3.6 2022-01-02 20:27:28 -08:00
Bart Van Assche 490abadac2 scripts/list-source-files: Improve the exclusion filter
Also exclude the files generated by the kernel v5.15 build system.
Additionally, sort the output and fix shellcheck warnings.
2022-01-02 20:27:28 -08:00
Bart Van Assche dd8bef0f4c nightly build: Update kernel versions 2022-01-01 20:15:20 -08:00
Bart Van Assche 250588cb36 www: Update the version number from 3.5 to 3.6
Additionally, change the link to the SourceForge download page into a link
to the github tags page. That page has "Download ZIP" and "Download tar.gz"
buttons.
2021-12-29 19:29:35 -08:00
Bart Van Assche 9c5406664a Bump the version number to 3.6.0
These changes have been generated by running the following command:

$ scripts/update-version 3 6 0
2021-12-29 19:19:14 -08:00
Bart Van Assche 1f0c29575d scst/ChangeLog: Mention that the iSER target driver is now compatible with hardened usercopy 2021-12-22 20:15:05 -08:00
Bart Van Assche a00d813a03 www: Change 'SCST Git' into 'SCST Git repository'
Additionally, remove the reference to the SVN repository from the FCoE
driver documentation.
2021-12-22 20:06:03 -08:00
Bart Van Assche 2f0a5426d0 qla2x00t/doc/qla2x00t-howto.html: Make this document HTML-compliant 2021-12-22 20:03:06 -08:00
Bart Van Assche 47f5a89f3e qla2x00t/doc/Makefile: Add to repository 2021-12-22 20:02:45 -08:00
Chesnokov Gleb efe085fb0d www: Update SCST repository link
We are migrating to GitHub, so update SCST repository link
to the new git repository.
2021-12-22 19:34:11 +03:00
Chesnokov Gleb 1a7f2dd9ce www/downloads.html: Update the information about repository
We are migrating to GitHub, so update the information about the new
git repository.
2021-12-22 19:34:11 +03:00
Chesnokov Gleb e807b8e466 INSTALL.md: Update dkms packages information 2021-12-21 14:23:06 +03:00
Chesnokov Gleb e9c9cc8b6a Makefile: Introduce the 'make rpm-dkms'
For convenience, there is a lack of opportunity to build
the SCST dkms and scstadmin packages in a one command.

Introduce the 'make rpm-dkms' command that in similar way to 'make rpm'
builds SCST dkms rpm packages and then builds scstadmin rpm packages.
2021-12-21 14:23:06 +03:00
Bart Van Assche f1a0222f2b INSTALL.md: Use markdown formatting 2021-12-19 20:09:02 -08:00
Bart Van Assche f9e7878ddf INSTALL.md: Restrict to 80 columns 2021-12-19 20:07:29 -08:00
Bart Van Assche e9df0ad95b www: Improve HTML conformance
Change &amp into &amp;. Insert &nbsp; in empty spans. Add summary="" to
tables. Change height="..." into style="height: ..." for table data.
2021-12-19 20:06:24 -08:00
Bart Van Assche 6dd60c4bb1 www/Makefile: Add this file to the repository
Make it easy to check HTML-compliance of the SCST website.
2021-12-19 20:06:24 -08:00
Gilbert StandenandBart Van Assche 53d5d68f01 Update INSTALL.md 2021-12-19 20:04:34 -08:00
Bart Van Assche 39f5c343b8 scst/ChangeLog: Summarize the changes for the upcoming 3.6 release 2021-12-17 15:51:20 -08:00
Chesnokov Gleb 50d607a336 isert-scst: Enable copying to user space from isert_cmnd_cache
This patch fixes warning with call trace that occurs during
copy_to_user() from isert_read():

usercopy: Kernel memory exposure attempt detected from SLUB object 'sgv-clust-64K' (offset 200, size 48)!
------------[ cut here ]------------
kernel BUG at mm/usercopy.c:99!
...
RIP: 0010:usercopy_abort+0x7b/0x7d
Call Trace:
 __check_heap_object+0xdf/0x110
 __check_object_size.part.0+0x128/0x150
 __check_object_size+0x1c/0x20
 isert_read+0x10b/0x380 [isert_scst]
 ? security_file_permission+0x96/0x160
 vfs_read+0x9f/0x190
 ksys_read+0x67/0xe0
 __x64_sys_read+0x19/0x20
 do_syscall_64+0x61/0xb0
 ? __x64_sys_sendto+0x24/0x30
 ? do_syscall_64+0x6e/0xb0
 ? exit_to_user_mode_prepare+0x37/0xb0
 ? syscall_exit_to_user_mode+0x27/0x50
 ? do_syscall_64+0x6e/0xb0
 ? asm_exc_page_fault+0x8/0x30
 entry_SYSCALL_64_after_hwframe+0x44/0xae

Signed-off-by: Morozov Ilia <morozov.i@raidix.com>
2021-12-16 00:43:44 +03:00
Chesnokov Gleb 475970f66a Minor fixes for the previous commit 2021-12-16 00:43:44 +03:00
Chesnokov Gleb 1efde3fe98 Revert "scst: Enable copying to user space from an SGV cache"
This reverts commit 0c4f769c0e.
2021-12-16 00:43:44 +03:00