Bart Van Assche
69743a4fda
qla2x00t-32gbit: Fix IOPS drop seen in some adapters
...
Removing the response queue processing in the send path is showing IOPS
drop. Add back the process_response_queue() call in the send path.
Link: https://lore.kernel.org/r/20210329085229.4367-2-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com >
Signed-off-by: Arun Easi <aeasi@marvell.com >
Signed-off-by: Nilesh Javali <njavali@marvell.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
[ commit bcafad6c2d520df42c86f28357d639deac15bad7 upstream ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9401 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-05-15 22:28:25 +00:00
Bart Van Assche
a5b92ce245
qla2x00t-32gbit: Check kzalloc() return value
...
Instead of crashing if kzalloc() fails, make qla2x00_get_host_stats()
return -ENOMEM.
Link: https://lore.kernel.org/r/20210320232359.941-8-bvanassche@acm.org
Fixes: dbf1f53cfd23 ("scsi: qla2xxx: Implementation to get and manage host, target stats and initiator port")
Cc: Himanshu Madhani <himanshu.madhani@oracle.com >
Cc: Saurav Kashyap <skashyap@marvell.com >
Cc: Nilesh Javali <njavali@marvell.com >
Cc: Quinn Tran <qutran@marvell.com >
Cc: Mike Christie <michael.christie@oracle.com >
Cc: Daniel Wagner <dwagner@suse.de >
Cc: Lee Duncan <lduncan@suse.com >
Reviewed-by: Daniel Wagner <dwagner@suse.de >
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com >
Acked-by: Saurav Kashyap <skashyap@marvell.com >
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
[ commit e5406d8ad4a1659f4d4d1b39fe203855c4eaef2d upstream ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9400 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-05-15 22:27:13 +00:00
Bart Van Assche
0b7340af60
qla2x00t-32gbit: Simplify qla8044_minidump_process_control()
...
This patch fixes the following Coverity complaint:
CID 177490 (#1 of 1): Unused value (UNUSED_VALUE)
assigned_value: Assigning value from opcode & 0xffffff7fU to opcode
here, but that stored value is overwritten before it can be used.
Link: https://lore.kernel.org/r/20210320232359.941-6-bvanassche@acm.org
Cc: Quinn Tran <qutran@marvell.com >
Cc: Mike Christie <michael.christie@oracle.com >
Reviewed-by: Daniel Wagner <dwagner@suse.de >
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com >
Reviewed-by: Lee Duncan <lduncan@suse.com >
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
[ commit a20821e3f4719458a888af634c10c286365ecd6f upstream ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9399 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-05-15 22:26:10 +00:00
Bart Van Assche
aef48f0501
qla2x00t-32gbit: Fix endianness annotations
...
Fix all recently introduced endianness annotation issues.
Link: https://lore.kernel.org/r/20210320232359.941-4-bvanassche@acm.org
Cc: Quinn Tran <qutran@marvell.com >
Cc: Mike Christie <michael.christie@oracle.com >
Reviewed-by: Daniel Wagner <dwagner@suse.de >
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com >
Reviewed-by: Lee Duncan <lduncan@suse.com >
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
[ commit 37ce4f3531d4a38f3f598fab45d80be5b46aee3c upstream ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9398 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-05-15 22:24:34 +00:00
Bart Van Assche
fb4f59a7c6
qla2x00t-32gbit: Constify struct qla_tgt_func_tmpl
...
Since the target function pointers are not modified at runtime, declare the
data structure with the target function pointers const.
Link: https://lore.kernel.org/r/20210320232359.941-3-bvanassche@acm.org
Cc: Quinn Tran <qutran@marvell.com >
Cc: Mike Christie <michael.christie@oracle.com >
Reviewed-by: Daniel Wagner <dwagner@suse.de >
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com >
Reviewed-by: Lee Duncan <lduncan@suse.com >
Signed-off-by: Bart Van Assche <bvanassche@acm.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
[ commit 634b9774d335020e2cd55950a6c1242e7e3bd1e7 upstream ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9397 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-05-15 22:23:27 +00:00
Bart Van Assche
b23a4fffc6
qla2x00t-32gbit: Fix broken #endif placement
...
Only half of the file is under include guard because terminating #endif
is placed too early.
Link: https://lore.kernel.org/r/YE4snvoW1SuwcXAn@localhost.localdomain
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com >
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
[ commit 5999b9e5b1f8a2f5417b755130919b3ac96f5550 upstream ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9396 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-05-15 22:21:02 +00:00
Bart Van Assche
adeb0e3b01
qla2x00t-32gbit: Use dma_pool_zalloc()
...
Use dma_pool_zalloc() instead of dma_pool_alloc() and memset().
Link: https://lore.kernel.org/r/1615603275-14303-1-git-send-email-wangqing@vivo.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com >
Signed-off-by: Wang Qing <wangqing@vivo.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
[ commit 720efdd23f963612d0a8c7072293aff119c6f915 upstream ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9395 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-05-15 22:19:37 +00:00
Bart Van Assche
966e499270
qla2x00t-32gbit: Fix a couple of misdocumented functions
...
Fixes the following W=1 kernel build warning(s):
drivers/scsi/qla2xxx/qla_target.c:6476: warning: expecting prototype for qla_tgt_lport_register(). Prototype was for qlt_lport_register() instead
drivers/scsi/qla2xxx/qla_target.c:6546: warning: expecting prototype for qla_tgt_lport_deregister(). Prototype was for qlt_lport_deregister() instead
Link: https://lore.kernel.org/r/20210312094738.2207817-12-lee.jones@linaro.org
Cc: Nilesh Javali <njavali@marvell.com >
Cc: GR-QLogic-Storage-Upstream@marvell.com
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com >
Cc: "Martin K. Petersen" <martin.petersen@oracle.com >
Cc: Vladislav Bolkhovitin <vst@vlnb.net >
Cc: Nathaniel Clark <nate@misrule.us >
Cc: "Nicholas A. Bellinger" <nab@kernel.org >
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
[ commit dc49ab48a77c48b3334ec57c2163f92721b06b5e upstream ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9394 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-05-15 22:15:35 +00:00
Bart Van Assche
7768af7b3f
qla2x00t-32gbit: Fix incorrectly named function qla8044_check_temp()
...
Fixes the following W=1 kernel build warning(s):
drivers/scsi/qla2xxx/qla_nx2.c:2038: warning: expecting prototype for qla4_8xxx_check_temp(). Prototype was for qla8044_check_temp() instead
Link: https://lore.kernel.org/r/20210312094738.2207817-11-lee.jones@linaro.org
Cc: Nilesh Javali <njavali@marvell.com >
Cc: GR-QLogic-Storage-Upstream@marvell.com
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com >
Cc: "Martin K. Petersen" <martin.petersen@oracle.com >
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
[ commit a736e44904422ade7af4ac50c64f58617ae4b7ba upstream ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9393 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-05-15 22:14:07 +00:00
Bart Van Assche
696b85fe84
qla2x00t-32gbit: Fix a couple of misnamed functions
...
Fixes the following W=1 kernel build warning(s):
drivers/scsi/qla2xxx/qla_mr.c:525: warning: expecting prototype for qlafx00_warm_reset(). Prototype was for qlafx00_soc_cpu_reset() instead
drivers/scsi/qla2xxx/qla_mr.c:2869: warning: expecting prototype for qlafx00x_mbx_completion(). Prototype was for qlafx00_mbx_completion() instead
Link: https://lore.kernel.org/r/20210312094738.2207817-9-lee.jones@linaro.org
Cc: Nilesh Javali <njavali@marvell.com >
Cc: GR-QLogic-Storage-Upstream@marvell.com
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com >
Cc: "Martin K. Petersen" <martin.petersen@oracle.com >
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
[ commit 381095668d51387657e456e2962f0bcc3e1044e3 upstream ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9392 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-05-15 20:36:27 +00:00
Bart Van Assche
853ea68d85
qla2x00t-32gbit: Fix some incorrect formatting/spelling issues
...
Fixes the following W=1 kernel build warning(s):
drivers/scsi/qla2xxx/qla_gs.c:1259: warning: expecting prototype for qla2x00_snd_rft_id(). Prototype was for qla2x00_sns_rft_id() instead
drivers/scsi/qla2xxx/qla_gs.c:1492: warning: expecting prototype for qla2x00_prep_ct_req(). Prototype was for qla2x00_prep_ct_fdmi_req() instead
drivers/scsi/qla2xxx/qla_gs.c:1596: warning: expecting prototype for perform HBA attributes registration(). Prototype was for qla2x00_hba_attributes() instead
drivers/scsi/qla2xxx/qla_gs.c:1851: warning: expecting prototype for perform Port attributes registration(). Prototype was for qla2x00_port_attributes() instead
drivers/scsi/qla2xxx/qla_gs.c:2284: warning: expecting prototype for perform RPRT registration(). Prototype was for qla2x00_fdmi_rprt() instead
Link: https://lore.kernel.org/r/20210303144631.3175331-24-lee.jones@linaro.org
Cc: Nilesh Javali <njavali@marvell.com >
Cc: GR-QLogic-Storage-Upstream@marvell.com
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com >
Cc: "Martin K. Petersen" <martin.petersen@oracle.com >
[ commit f11c8b42423f3b32c30bd985333e7378226b832d upstream ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9391 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-05-15 20:35:09 +00:00
Bart Van Assche
df9671d11c
Update the Subversion global-ignores property
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9390 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-05-15 20:34:10 +00:00
Bart Van Assche
0640b6ba49
qla2x00t-32gbit: Replace __qla2x00_marker()'s missing underscores
...
Fixes the following W=1 kernel build warning(s):
drivers/scsi/qla2xxx/qla_iocb.c:508: warning: expecting prototype for qla2x00_marker(). Prototype was for __qla2x00_marker() instead
Link: https://lore.kernel.org/r/20210303144631.3175331-16-lee.jones@linaro.org
Cc: Nilesh Javali <njavali@marvell.com >
Cc: GR-QLogic-Storage-Upstream@marvell.com
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com >
Cc: "Martin K. Petersen" <martin.petersen@oracle.com >
Cc: linux-scsi@vger.kernel.org
Acked-by: Nilesh Javali <njavali@marvell.com >
Signed-off-by: Lee Jones <lee.jones@linaro.org >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
[ commit 52bb80f18def787e98a9f97a7cabbe71e4879996 upstream ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9389 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-05-15 20:33:29 +00:00
Bart Van Assche
cc8e39d81b
qla2x00t-32gbit: Minimize diffs with upstream
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9388 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-05-15 20:31:02 +00:00
Bart Van Assche
1b7fe6422c
scst_vdisk: Convert several comments into lockdep_assert_held() statements
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9387 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-05-15 02:33:31 +00:00
Bart Van Assche
e7a705fcd8
scst_vdisk, vdisk_blockio: Fix the resync_size functionality
...
Fixes: https://github.com/bvanassche/scst/issues/36
Fixes: df4c250b8d ("scst_vdisk: Port to Linux kernel v5.11")
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9386 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-05-14 04:54:39 +00:00
Bart Van Assche
5910f8da1e
scst: Fix the build against the UEK 8 kernel
...
Reported-by: Abrakhin Andrey <Abrakhin.A@raidix.com >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9385 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-04-29 17:47:55 +00:00
Bart Van Assche
f2fad1f2e6
nightly build: Add the latest UEK kernel
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9384 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-04-29 17:44:54 +00:00
Bart Van Assche
c5e515b702
Address checkpatch complaints about duplicated words
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9383 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-04-29 03:15:01 +00:00
Bart Van Assche
43e096c8d1
nightly build: Update kernel versions
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9382 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-04-28 15:54:17 +00:00
Bart Van Assche
f59fe00eb1
scst: Enable the kernel scheduler in scst_wait_for_tgt_devs()
...
This patch should fix the following bug:
INFO: rcu_sched self-detected stall on CPU ...
...
scst_wait_for_tgt_devs()
Reported-by: Chesnokov Gleb <Chesnokov.G@raidix.com >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9381 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-04-14 20:35:40 +00:00
Bart Van Assche
9ad346b84e
scst_vdisk: Complete port to Linux kernel v5.12
...
This is a variant of a patch provided by Mark Ruijter.
Fixes: https://github.com/bvanassche/scst/issues/34
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9380 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-04-14 20:31:39 +00:00
Bart Van Assche
095d255719
iscsi-scst: Fix a kernel-doc header
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9379 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-04-14 20:29:52 +00:00
Bart Van Assche
8159ce2531
scst: Suppress a kernel-doc warning
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9378 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-04-14 20:12:20 +00:00
Bart Van Assche
0a6056cc82
scst, scst_vdisk: Revert "Simplify the code for querying the vdisk filename"
...
Revert this commit since it can cause a deadlock as follows:
- scst_assign_dev_handler() obtains scst_mutex and calls
scst_devt_dev_sysfs_del(). The scst_remove_files() call in the latter
function waits until all dev->dev_kobj sysfs callbacks have finished.
- vdev_sysfs_filename_show() obtains a dev->dev_kobj reference.
- vdev_sysfs_process_get_filename() tries to lock scst_mutex but deadlocks
because scst_assign_dev_handler() is holding scst_mutex.
Fixes: 457d6fceed ("scst, scst_vdisk: Simplify the code for querying the vdisk filename")
Reported-by: Lev Vainblat <lev@zadarastorage.com >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9375 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-04-13 03:16:09 +00:00
Bart Van Assche
d8988e34c0
fcst: Fix a kernel-doc header
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9374 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-04-13 03:14:05 +00:00
Bart Van Assche
a3a78b8013
scst: Port to Linux kernel v5.12
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9373 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-04-07 03:46:01 +00:00
Bart Van Assche
3749cf3427
qla2x00t-32gbit: Minimize diffs with upstream
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9372 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-28 16:55:40 +00:00
Bart Van Assche
0e2c596c02
qla2x00t-32gbit: Fix the CentOS 7.8 build
...
Signed-off-by: Chesnokov Gleb <Chesnokov.G@raidix.com >
[ bvanassche: modified qla_nvme changes ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9371 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-28 14:45:06 +00:00
Bart Van Assche
9369b29f1c
fcst: Add a comment that explains which commits modified the FC API
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9370 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-28 14:43:16 +00:00
Bart Van Assche
3a83346fba
scripts/specialize-patch: Clamp sublevel to 255
...
See also Linux kernel commit 9b82f13e7ef3 ("kbuild: clamp SUBLEVEL to 255";
v5.12-rc1).
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9369 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-28 14:42:20 +00:00
Bart Van Assche
291a8e3dc5
nightly build: Update kernel versions
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9368 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-27 03:26:04 +00:00
Bart Van Assche
833d83a48f
scst: Add support for SERVICE ACTION IN(12)
...
HP LTO 3 and later and Oracle/STK T10000 tape drives support the READ MEDIA
SERIALNO command, one of the SERVICE ACTION IN(12) commands.
Signed-off-by: Rob Turk <robtu@rtist.nl >
[ bvanassche: wrote patch description ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9367 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-23 16:18:03 +00:00
Bart Van Assche
ebf837baae
qla2x00t-32gbit: Revert "Make sure that aborted commands are freed"
...
Calling vha->hw->tgt.tgt_ops->free_cmd() from qlt_xmit_response() is wrong
and may trigger a kernel crash. Hence revert this patch.
Reported-by: Chesnokov Gleb <Chesnokov.G@raidix.com >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9366 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-16 04:01:27 +00:00
Bart Van Assche
91c5e9f91f
Set svn:global-ignores property
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9365 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 04:16:07 +00:00
Bart Van Assche
b41f8a8dcb
.gitignore: Add *.gcno
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9364 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 04:06:56 +00:00
Bart Van Assche
620e35e138
qla2x00t-32gbit: Minimize diffs with upstream
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9363 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 04:06:16 +00:00
Bart Van Assche
fe4a05b87c
qla2x00t-32gbit: Minimize diffs with upstream
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9362 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 03:43:26 +00:00
Bart Van Assche
b4d69388f3
qla2x00t-32gbit: Minimize diffs with upstream
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9361 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 03:41:36 +00:00
Bart Van Assche
20d21065d4
qla2x00t-32gbit: Minimize diffs with upstream
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9360 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 03:40:02 +00:00
Bart Van Assche
8e51d021ec
qla2xxx-32gbit: Implementation to get and manage host, target stats and initiator port
...
This statistics will help in debugging process and checking specific error
counts. It also provides a capability to isolate the port or bring it out
of isolation.
Link: https://lore.kernel.org/r/20210111093134.1206-2-njavali@marvell.com
Reported-by: kernel test robot <lkp@intel.com >
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com >
Signed-off-by: Saurav Kashyap <skashyap@marvell.com >
Signed-off-by: Nilesh Javali <njavali@marvell.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
[ commit dbf1f53cfd238090c69f92725b91208b97eb53fe upstream ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9359 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 03:39:19 +00:00
Bart Van Assche
78bc3baee2
qla2x00t-32gbit: Minimize diffs with upstream
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9358 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 03:29:13 +00:00
Bart Van Assche
fdc180ec66
qla2xxx: Remove redundant NULL check
...
Fix below warnings reported by coccicheck:
./drivers/scsi/qla2xxx/qla_init.c:3371:2-7: WARNING: NULL check before some freeing functions is not needed.
./drivers/scsi/qla2xxx/qla_init.c:7855:5-10: WARNING: NULL check before some freeing functions is not needed.
./drivers/scsi/qla2xxx/qla_init.c:7916:2-7: WARNING: NULL check before some freeing functions is not needed.
./drivers/scsi/qla2xxx/qla_init.c:8113:4-18: WARNING: NULL check before some freeing functions is not needed.
./drivers/scsi/qla2xxx/qla_init.c:8174:2-7: WARNING: NULL check before some freeing functions is not needed.
Link: https://lore.kernel.org/r/1611306174-92627-1-git-send-email-abaci-bugfix@linux.alibaba.com
Reported-by: Abaci Robot <abaci@linux.alibaba.com >
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com >
Signed-off-by: Yang Li <abaci-bugfix@linux.alibaba.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
[ commit 18c05faf8ab14913c8144108661efa8f17b10b5b upstream ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9357 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 03:13:39 +00:00
Bart Van Assche
c5a5f47060
qla2xxx-32gbit: Remove unnecessary NULL check
...
The list iterator can't be NULL so this check is not required. Removing
the check silences a Smatch warning about inconsistent NULL checking.
drivers/scsi/qla2xxx/qla_dfs.c:371 qla_dfs_tgt_counters_show()
error: we previously assumed 'fcport' could be null (see line 372)
Link: https://lore.kernel.org/r/YAkaaSrhn1mFqyHy@mwanda
Acked-by: Saurav Kashyap <skashyap@marvell.com >
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
[ commit c750a9c9c59a85843d447910a27da21c5bcf600a upstream ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9356 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 03:12:51 +00:00
Bart Van Assche
69edc03f79
qla2xxx-32gbit: Assign boolean values to a bool variable
...
Fix the following coccicheck warnings:
./drivers/scsi/qla2xxx/qla_isr.c:780:2-18: WARNING: Assignment
of 0/1 to bool variable.
Link: https://lore.kernel.org/r/1611127919-56551-1-git-send-email-abaci-bugfix@linux.alibaba.com
Reported-by: Abaci Robot <abaci@linux.alibaba.com >
Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
[ commit 71311be1cd3e2dfd75381ef8840a88ac79256ca1 upstream ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9355 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 03:12:07 +00:00
Bart Van Assche
fca3497c59
qla2xxx-32gbit: fc_remote_port_chkready() returns a SCSI result value
...
fc_remote_port_chkready() returns a SCSI result value, not the port
status. Fix the value returned when the remote port isn't set.
Link: https://lore.kernel.org/r/20210113090500.129644-34-hare@suse.de
Reviewed-by: Christoph Hellwig <hch@lst.de >
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com >
Signed-off-by: Hannes Reinecke <hare@suse.de >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
[ commit 6098c3005d5a39c39331ca6c3d9fa7525247166c upstream ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9354 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 03:11:35 +00:00
Bart Van Assche
3a8b79eb3d
qla2x00t-32gbit: Fix description for parameter ql2xenforce_iocb_limit
...
Parameter ql2xenforce_iocb_limit is enabled by default.
Link: https://lore.kernel.org/r/20210118184922.23793-1-ematsumiya@suse.de
Fixes: 89c72f4245a8 ("scsi: qla2xxx: Add IOCB resource tracking")
Reviewed-by: Daniel Wagner <dwagner@suse.de >
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com >
Signed-off-by: Enzo Matsumiya <ematsumiya@suse.de >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
[ commit aa2c24e7f415e9c13635cee22ff4e15a80215551 upstream ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9353 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 03:11:02 +00:00
Bart Van Assche
404e3da31a
qla2xxx-32gbit: Update version to 10.02.00.105-k
...
Link: https://lore.kernel.org/r/20210111093134.1206-8-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com >
Signed-off-by: Nilesh Javali <njavali@marvell.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
[ commit dc0d9b12b8a74f5435097ebc7aafca76ba9cda7a upstream ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9352 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 03:10:24 +00:00
Bart Van Assche
d097336055
qla2x00t-32gbit: Enable NVMe CONF (BIT_7) when enabling SLER
...
Enable NVMe confirmation bit in PRLI.
Link: https://lore.kernel.org/r/20210111093134.1206-7-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com >
Signed-off-by: Saurav Kashyap <skashyap@marvell.com >
Signed-off-by: Nilesh Javali <njavali@marvell.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
[ commit ffa018e3a5b4a8d53dd2400fb60b5150588b57d7 upstream ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9351 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 03:09:49 +00:00
Bart Van Assche
5869874f10
qla2x00t-32gbit: Fix mailbox Ch erroneous error
...
Mailbox Ch/dump ram extend expects mb register 10 to be set. If not
set/clear, firmware can pick up garbage from previous invocation of this
mailbox. Example: mctp dump can set mb10. On subsequent flash read which
use mailbox cmd Ch, mb10 can retain previous value.
Link: https://lore.kernel.org/r/20210111093134.1206-6-njavali@marvell.com
Cc: stable@vger.kernel.org
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com >
Signed-off-by: Quinn Tran <qutran@marvell.com >
Signed-off-by: Nilesh Javali <njavali@marvell.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
[ commit 044c218b04503858ca4e17f61899c8baa0ae9ba1 upstream ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9350 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 03:09:15 +00:00