Commit r7084 removed all users of MOFED_MAJOR. Hence also remove the
code that sets that variable. Note: MOFED_MINOR was never used in any
.c file.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7363 d57e44dd-8a1f-0410-8b47-8ef2f437770f
Ensure that MOFED is detected correctly on Debian systems on which the rpm
command has been installed ("alien" package).
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7362 d57e44dd-8a1f-0410-8b47-8ef2f437770f
See scst_max_cmd_mem module parameter for more info. Allows to avoid 2
global atomic variables on the fast path, hence get better multi-queue
performance.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7346 d57e44dd-8a1f-0410-8b47-8ef2f437770f
The system is running an iSCSI write test with header and data digests
enabled. On the command that resulted in the assert, all of the write
data was sent as immediate and unsolicited. The unsolicited data
consisted of a single DataOut PDU and it was the iscsi_cmnd resource
allocated for receiving the unsolicited DataOut that caused the assert,
not the iscsi_cmnd resource tracking the iSCSI write command. As the
Recv thread is finishing up with the iscsi_cmnd struct for receiving the
final unsolicited DataOut, SCST is call the iscsi_pre_exec function to
restart the command and this routine will process the DataOut
iscsi_cmnd as it is queued onto the rx_digest_list of the iscsi_cmnd for
Write.
ffff8a984150c600 is the iscsi_cmnd allocated to track the iSCSI Write command
ffff8a984150d680 is the iscsi_cmnd allocated for receiving the Data-out PDU
In the logs below, recv thread 3677 just completed receiving the unsolicited DataOut.
[ 977.563046] [3677]: do_recv:808:nr_segs 0, bytes_left 0, res 196608
[ 977.563048] [31728]: iscsi_make_conn_rd_active:351:conn ffff8a97d0df1600, rd_state 2, rd_data_ready 1
[ 977.563065] [3677]: do_recv:808:nr_segs 0, bytes_left 0, res 4
[ 977.563069] [31728]: iscsi_make_conn_rd_active:351:conn ffff8a97d0df1600, rd_state 2, rd_data_ready 1
[ 977.563076] [3677]: cmnd_rx_end:3475:cmnd ffff8a984150d680, opcode 5
[ 977.563078] [31728]: iscsi_make_conn_rd_active:351:conn ffff8a97d0df1600, rd_state 2, rd_data_ready 1
[ 977.563081] [3677]: cmnd_rx_end:3478:Updated last_rcv_time 4295644274
[ 977.563091] [3677]: data_out_end:2455:cmnd ffff8a984150d680, req ffff8a984150c600
[ 977.563093] [3677]: cmd_add_on_rx_ddigest_list:820:Adding RX ddigest cmd ffff8a984150d680 to digest list of req ffff8a984150c600
[ 977.563096] [3677]: cmnd_get:764:cmnd ffff8a984150d680, new cmnd->ref_cnt 2
Here we see no more data is pending to be received on this write, so
iscsi_restart_cmnd is called by recv thread which should trigger SCST to
start processing the command:
[ 977.563106] [3677]: data_out_end:2495:req ffff8a984150c600, FINAL 80, outstanding_r2t 0, r2t_len_to_receive 0, r2t_len_to_send 0
[ 977.563108] [3677]: req_del_from_write_timeout_list:141:Deleting cmd ffff8a984150c600 from conn ffff8a97d0df1600 write_timeout_list
[ 977.563111] [3677]: cmnd_remove_data_wait_hash:1606:Deleting cmnd ffff8a984150c600 from the hash (ITT 1e230400)
SCST thread 24654 calls the pre execute routine which verifies the data
digest on immediate and unsolicited data:
[ 977.563157] [24654]: iscsi_pre_exec:1917:Checking digest of RX ddigest cmd ffff8a984150c600
[ 977.563161] [24654]: digest_data:125:req ffff8a984150c600, idx 0, count 16, sg_cnt 64, size 65536, offset 0
[ 977.563170] [24654]: digest_rx_data:219:RX data digest OK for cmd ffff8a984150c600
[ 977.563173] [3677]: cmnd_put:775:cmnd ffff8a984150c600, new ref_cnt 2
[ 977.563176] [24654]: cmd_del_from_rx_ddigest_list:830:Deleting RX digest cmd ffff8a984150c600 from digest list
Recv thread calls pre release on iscsi_cmnd allocated for unsolicited
DataOut PDU:
[ 977.563178] [3677]: req_cmnd_pre_release:820:req ffff8a984150d680
[ 977.563181] [24654]: cmnd_put:775:cmnd ffff8a984150c600, new ref_cnt 1
SCST thread 24654 processing data digest on unsolicited DataOut PDU.
Here we have two threads accessing the same iscsi_cmnd struct. SCST
thread will set on_rx_digest_list flag to 0. Recv thread will set
release_called flag to 1.
[ 977.563184] [24654]: iscsi_pre_exec:1917:Checking digest of RX ddigest cmd ffff8a984150d680
[ 977.563186] [24654]: cmd_del_from_rx_ddigest_list:830:Deleting RX digest cmd ffff8a984150d680 from digest list
[ 977.563189] [24654]: cmnd_put:775:cmnd ffff8a984150d680, new ref_cnt 0
[ 977.563191] [3677]: conn_get:868:conn ffff8a97d0df1600, new conn_ref_cnt 4
[ 977.563194] [24654]: cmnd_done:589:cmnd ffff8a984150d680
[ 977.563196] BUG at ./iscsi-scst/kernel/iscsi.c:598 (cmnd->on_rx_digest_list)
[ 977.563212] ------------[ cut here ]------------
[ 977.563215] kernel BUG at ./iscsi-scst/kernel/iscsi.c:598!
Reported and analyzed by Adam Hutchinson <ajhutchin@gmail.com>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7338 d57e44dd-8a1f-0410-8b47-8ef2f437770f
Additionally, remove the 'inline' keyword from these two functions
because today's compilers are better than humans at deciding which
functions should be inlined and which ones not. This patch avoids
that building the qla2x00t driver on RHEL 7.4 triggers two compiler
warnings.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7336 d57e44dd-8a1f-0410-8b47-8ef2f437770f
An example:
# scstadmin -noprompt -handler vdisk_fileio -close_dev diskf0
Collecting current configuration: done.
-> Making requested changes.
Device 'diskf0' is currently in use by the following:
Driver Target Group Lun
---------- ----------------------- ----- ----
iscsi iqn.2012-06.be.bva:tgt1 61
scst_local disks 1
FATAL: Received the following error:
Device 'diskf0' still in use, aborting. Use -force to override.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7334 d57e44dd-8a1f-0410-8b47-8ef2f437770f
An example:
# scstadmin -noprompt -handler vdisk_fileio -close_dev diskf0
Collecting current configuration: done.
-> Making requested changes.
Device 'diskf0' is currently in use by the following:
Driver Target Group Lun
--------------------------------------------
iscsi iqn.2012-06.be.bva:tgt1 61
scst_local disks 1
FATAL: Received the following error:
Device 'diskf0' still in use, aborting. Use -force to override.
This patch is based on a proposal from Dzmitry Kotsikau.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7332 d57e44dd-8a1f-0410-8b47-8ef2f437770f
Trunk r7327 restored the 'dummy' attribute for the vdisk_nullio handler
and hence changed the outcome of test 07. Update the expected output.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7331 d57e44dd-8a1f-0410-8b47-8ef2f437770f
Management datagrams (MADs) are not supported for SR-IOV VFs. That
is why srpt_refresh_port() fails for SR-IOV VFs. Make it easier to
use SR-IOV VFs by only logging an error message if MAD handler
registration fails.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7317 d57e44dd-8a1f-0410-8b47-8ef2f437770f
Management datagrams (MADs) are not supported for SR-IOV VFs. That
is why srpt_refresh_port() fails for SR-IOV VFs. Make it easier to
use SR-IOV VFs by only logging an error message if MAD handler
registration fails.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7315 d57e44dd-8a1f-0410-8b47-8ef2f437770f
