Commit Graph
380 Commits
Author SHA1 Message Date
Vladislav Bolkhovitin 85ea152e0c [PATCH] scst: Remove casts from INIT_DELAYED_WORK() statements
This is a source code cleanup patch that does not change any functionality.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5221 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-01-22 02:57:49 +00:00
Bart Van Assche 0e99ba02b5 qla2x00t: SLES 11 SP3 build fix
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5190 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-01-10 07:54:10 +00:00
Bart Van Assche f5a8248cb7 nightly build: Add kernel 3.12 build infrastructure
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5164 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-12-19 08:07:15 +00:00
Vladislav Bolkhovitin 27c21ff385 qla2x00t: Update and refine howto
Some users think these instructions are not valid for Linux 3.x kernels
since there are examples in this document referring to a 2.6.x kernel.
Hence update the examples.

Explain how to discover initiator port WWNs since this is nontrivial for
novice users.

Update the SourceForge SVN SCST URL since it changed a few months ago.

Move the qla2xxx module unload step to after the system reboot. Performing
that step after the reboot even though that module has already been
blacklisted is necessary because at that time initrd has not yet been
rebuilt and hence a reboot can cause that module to be reloaded from initrd.

The steps for building and installing SCST itself have been reduced from
four commands into a single command.

The sample scst.conf file is now generated - local FC port WWNs are
discovered automatically.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5135 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-11-22 05:43:47 +00:00
Vladislav Bolkhovitin 7fd3d9da4e Relax this FW overload message
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5021 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-10-04 04:52:26 +00:00
Vladislav Bolkhovitin 7502f47dad Fix small possible race in sessions management
In q2t_del_sess_work_fn() session can get ready to be destroyed before
hardware_lock is taken

From Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5020 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-10-04 02:17:43 +00:00
Vladislav Bolkhovitin 1342a944db Fix recently discovered races in sessions management
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5018 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-10-03 04:24:39 +00:00
Bart Van Assche dad77aead4 nightly build: Add kernel 3.11 build infrastructure
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5006 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-09-28 16:04:47 +00:00
Vladislav Bolkhovitin e3b9d00d97 qla2x00t: Simplify q2t_create_sess()
Replace a kmalloc() and sprintf() call by a kasprintf() call. This
patch does not change any functionality.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4998 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-09-11 22:44:04 +00:00
Bart Van Assche b103dd9949 qla2x00t: Fix q2t_close_session()
The "force_close" sysfs attribute remains to exist for some time
after q2t_close_session() finished. Avoid that q2t_close_session()
invokes q2t_sess_put() more than once by removing a session from
the session list before returning. Avoid that that disabling a
target after q2t_close_session() has been invoked triggers a call
of q2t_sess_put(). Avoid that triggering the "force_close" sysfs
attribute after a target has been disabled triggers an additional
call of q2t_sess_put().


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4944 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-09 16:19:56 +00:00
Bart Van Assche 89e96c6495 nightly build: Add kernel 3.10 support infrastructure
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4919 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-07-22 18:35:37 +00:00
Vladislav Bolkhovitin 6e31fd8306 Relax and cleanup HARDWARE ERROR sense usage
HARDWARE ERROR sense is very strong considered be "internal failure", so
might lead to serios initiator side issues up to disconnect from device. In
many cases WRITE or READ ERROR sense can be used instead. All remaining
usages must be logged.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4911 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-07-04 02:46:49 +00:00
Bart Van Assche 11fdb1bf29 nightly build: Add kernel 3.9 build infrastructure
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4855 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-05-18 16:04:24 +00:00
Vladislav Bolkhovitin 2093dd7561 Make it possible to forcibly close SRP and FC sessions via sysfs
That patch contains the following changes:
* Move the code for creating a "close_sess" sysfs attribute from iscsi-scst to
  the SCST core such that it becomes available for other target drivers. This
  does not change the functionality of iscsi-scst.
* Add code in ib_srpt and qla2x00t to allow a session to be forcibly closed from
  user space.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>




git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4852 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-05-18 00:52:46 +00:00
Vladislav Bolkhovitin 4ce549b875 qla2x00t: Avoid dereferencing a NULL pointer
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4843 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-04-27 05:11:17 +00:00
Vladislav Bolkhovitin 0339bb8905 This change causes "make -C <dir> clean" to work. Also, use SUBDIRS=...
instead of M=... because of consistency with the rest of the Makefile.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4829 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-03-29 01:19:24 +00:00
Vladislav Bolkhovitin ef5fe3dcd0 Correct sg_next_inline() misuse.
Previously sg_next_inline() didn't check if this sg is last.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4822 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-03-27 01:12:02 +00:00
Vladislav Bolkhovitin e38c450819 sess and tgt structures are read-mostly, so don't need cache alignment
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4816 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-03-26 21:34:53 +00:00
Vladislav Bolkhovitin 2cadcc2c64 Cache alignment review
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4809 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-03-23 01:38:31 +00:00
Vladislav Bolkhovitin 65ada2c9f0 Fix crash if on 24xx+ handle can't be translated to cmd
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4806 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-03-19 23:49:56 +00:00
Vladislav Bolkhovitin 369863f015 Allow install SCST in any location
Currently the install location of SCST is pretty much hard coded into 
the Makefiles to be /usr/local.

I am custom building a system for ZFS & SCST and I want to install in 
/usr instead of /usr/local.

Currently I am doing a “find . -name Makefile -exec sed -i 's:/usr/local:/usr:g'
{} \;” to accommodate this.

This patch fixes it.

From Sietse van Zanen <sietse@wizdom.nu>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4791 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-03-08 21:25:45 +00:00
Vladislav Bolkhovitin b9c0b9d92d Another micro-optimization: cache align all fast path structures
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4785 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-03-04 23:51:16 +00:00
Vladislav Bolkhovitin ae8e9ef049 Micro-optimization: allow target drivers to prealloc scst_cmd + update qla2x00t to use this facility
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4779 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-03-02 00:52:26 +00:00
Vladislav Bolkhovitin a0ee2a2396 qla2x00t: Clean up DMA address computation code
The expression "sg_dma_address(prm->sg)" occurs several times in several
pieces of code that compute a DMA address. Make these pieces of code
somewhat easier to read by storing the DMA address in a temporary variable
called "dma_addr".

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4778 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-02-28 20:29:11 +00:00
Bart Van Assche 52f0d63ee6 nightly build: Add kernel 3.8 support files
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4769 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-02-23 13:47:51 +00:00
Vladislav Bolkhovitin 79bf4e77c6 Update for 3.8 kernels
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4768 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-02-23 00:44:56 +00:00
Vladislav Bolkhovitin 10ca1d2f20 Copyrights updated
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4767 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-02-20 02:05:29 +00:00
Vladislav Bolkhovitin a98e10a13f Make qla2x00t support sg-chaining
Suggested by Nikolai Kopanygin <nikolai.kopanygin@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4760 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-02-16 03:55:11 +00:00
Vladislav Bolkhovitin cd32115d6c Patch from Lukasz Jurewicz <lukasz.jurewicz@gmail.com> updating URL to QLogic firmware
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4759 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-02-16 03:23:32 +00:00
Vladislav Bolkhovitin ebc43696ff Backport mainline commit a55aac79de0ea6fc52d35f535867b6573a5ff0f8:
[SCSI] qla2xxx: Propagate up abort failures



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4754 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-02-05 00:05:54 +00:00
Vladislav Bolkhovitin b3908d7447 Wrong task attribute isn't error, so warning message should be issued instead
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4753 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-02-04 23:55:34 +00:00
Vladislav Bolkhovitin 92a296b9e5 qla2x00t: Avoid that an SRR for a command without data triggers a kernel oops
Avoid that the following kernel oops is triggered as the result of
cable pulling:

------------[ cut here ]------------
kernel BUG at /usr/src/linux-3.0.51-0.7.9/include/asm-generic/dma-mapping-common.h:51!
invalid opcode: 0000 [#1] SMP
CPU 0

Pid: 5791, comm: kworker/0:1 Tainted: P           N
3.0.51-0.7.9-default #1 HP ProLiant DL380p Gen8
RIP: 0010:[<ffffffffa03312a7>]  [<ffffffffa03312a7>]
q2t_pci_map_calc_cnt+0x87/0x120 [qla2x00tgt]
RSP: 0018:ffff8807ad879cf0  EFLAGS: 00010202
RAX: ffff880fbfa00960 RBX: 0000000000000009 RCX: ffff880fbfa00960
RDX: 0000000000000000 RSI: 0000000000000009 RDI: ffff880fbfa00960
RBP: ffff8807ad879d40 R08: 0000000000000000 R09: dead000000200200
R10: dead000000100100 R11: ffffffff81020000 R12: ffffffff81a13880
R13: 0000000000000009 R14: ffff88100f172090 R15: ffff880fbfa00840
FS:  0000000000000000(0000) GS:ffff88083fa00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
CR2: 00007f74cf266020 CR3: 0000000001a03000 CR4: 00000000000406f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
Process kworker/0:1 (pid: 5791, threadinfo ffff8807ad878000, task
ffff88074ae801c0)
Stack:
 0000000300000000 ffff88100eb18670 00000000ffffffff ffff88100eb18670
 ffff8807ad879d40 ffff880744b331c8 ffff88080673ca00 ffffffffa03348bc
 0000000000000000 0000000000000000 ffff880744b331c8 ffff88080673ca00
Call Trace:
 [<ffffffffa03348bc>] __q2t_rdy_to_xfer+0x8c/0x1c0 [qla2x00tgt]
 [<ffffffffa033672d>] q2t_handle_srr_work+0x1ed/0x210 [qla2x00tgt]
 [<ffffffff810743cc>] process_one_work+0x16c/0x350
 [<ffffffff81076eba>] worker_thread+0x17a/0x410
 [<ffffffff8107b1e6>] kthread+0x96/0xa0
 [<ffffffff8144db44>] kernel_thread_helper+0x4/0x10
Code: 4d 85 e4 0f 84 a8 00 00 00 45 85 ed 7e 16 4c 89 ff 31 db 90 83
c3 01 e8 58 2b f2 e0 41 39 dd 48 89 c7 7f f0 83 7c 24 04 02 76 04 <0f>
0b eb fe 45 31 c0 8b 4c 24 04 44 89 ea 4c 89 fe 4c 89 f7 41
RIP  [<ffffffffa03312a7>] q2t_pci_map_calc_cnt+0x87/0x120 [qla2x00tgt]
 RSP <ffff8807ad879cf0>
---[ end trace e93624bd6aa42d19 ]---

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4747 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-01-25 01:20:37 +00:00
Vladislav Bolkhovitin bd7c893f04 Multiple makefiles: autodetect SCST include directory
It is cumbersome to change SCST_INC_DIR and SCST_DIR in each Makefile
before and after a release. Hence modify the Makefiles such that these
paths are detected automatically.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4740 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-01-16 00:12:38 +00:00
Vladislav Bolkhovitin e7e9101efd Automate release archive generation
This patch makes it easier to generate the release archives that
can be downloaded from http://scst.sourceforge.net/downloads.html.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4679 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-01-04 00:29:30 +00:00
Bart Van Assche 12313bf114 nightly build: Add kernel 3.7 patches
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4647 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-12-18 08:54:50 +00:00
Vladislav Bolkhovitin d178fa8da9 qla2x00t: Avoid reading uninitialized memory
Reported-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4644 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-12-13 21:28:10 +00:00
Vladislav Bolkhovitin ed9ac5b9de Cleanup
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4640 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-12-11 02:57:16 +00:00
Vladislav Bolkhovitin 0bf88c8f96 Let's do attributes creation in a generic way
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4638 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-12-04 01:43:22 +00:00
Vladislav Bolkhovitin eb0fcbb1ef Explicit confirmations and abort ISP attributes don't make sense on virtual targets
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4637 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-12-03 23:29:36 +00:00
Bart Van Assche d3dc18dacb qla2x00t: Fix spelling in a source code comment
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4607 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-11-08 10:46:34 +00:00
Vladislav Bolkhovitin a698883844 Switch to the new and preferred approach for printing kernel messages
From: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4558 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-10-10 03:01:34 +00:00
Bart Van Assche b2567396f8 nightly build: Add kernel 3.6 support patches
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4539 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-10-02 08:17:58 +00:00
Vladislav Bolkhovitin 1a8577c59c Update for 3.6 kernels
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4538 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-10-01 22:10:47 +00:00
Vladislav Bolkhovitin 44ca9139d7 All CTIO_TYPE7 status mode 1 data are little endian
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4529 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-09-27 22:34:21 +00:00
Vladislav Bolkhovitin 7b1f00d2cb Increase version to -pre2. Pre1 was staying for too long.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4519 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-09-14 01:33:58 +00:00
Vladislav Bolkhovitin 8ce28aaba2 Avoid that enabling a target too quickly triggers a crash
The sysfs attributes of a target can be accessed before scst_tgt.tgt_priv
has been set. Avoid that such an access triggers a crash.

Symptom:
BUG: unable to handle kernel NULL pointer dereference at 000000000000004c
IP: [<ffffffffa1345848>] iscsi_is_target_enabled+0x8/0x20 [iscsi_scst]
PGD 150a4c067 PUD 13cacb067 PMD 0
Oops: 0000 [#1] SMP
CPU 1
Modules linked in: zfs(P) iscsi_scst(O) scst_vdisk(O) scst(O) zcommon(P) znvpair(P) zavl(P) zunicode(P) spl(O) [last unloaded: zfs]
Pid: 3974, comm: scst_uid1864 Tainted: P           O 3.2.23-zfsiscsi-std-ipv6-64 #3 Supermicro X6DVA/X6DVA
RIP: 0010:[<ffffffffa1345848>]  [<ffffffffa1345848>] iscsi_is_target_enabled+0x8/0x20 [iscsi_scst]
RSP: 0018:ffff88015071ddc0  EFLAGS: 00010282
RAX: 0000000000000000 RBX: ffff880181fdaa00 RCX: ffff88012d41f380
RDX: ffff88015071c010 RSI: 0000000000000000 RDI: ffff880181fdaa00
RBP: ffff88015071ddc0 R08: 0000000000000000 R09: 0000000000000001
R10: 0000000000000001 R11: 0000000000000001 R12: ffffffffa134a608
R13: 0000000000000000 R14: 0000000000000129 R15: ffffffffa134a4c0
FS:  0000000000000000(0000) GS:ffff88019fc80000(0000)
knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
CR2: 000000000000004c CR3: 0000000151927000 CR4: 00000000000006e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
Process scst_uid1864 (pid: 3974, threadinfo ffff88015071c000, task ffff880194d57500)
Stack:
 ffff88015071de10 ffffffffa12ee89a 00000000fffffffc 01ff88015071de98
 ffff88015071de80 ffff8801932a48d8 00000000fffffffc ffff88015071de98
 ffff88015071de80 ffff880194d57500 ffff88015071de30 ffffffffa12f582e
Call Trace:
 [<ffffffffa12ee89a>] __scst_is_relative_target_port_id_unique+0x6a/0xc0 [scst]
 [<ffffffffa12f582e>] gen_relative_target_port_id+0x6e/0xd0 [scst]
 [<ffffffffa12fdb8a>] scst_tgt_enable_store_work_fn+0x3a/0xe0 [scst]
 [<ffffffffa12f9397>] sysfs_work_thread_fn+0xc7/0x2e0 [scst]
 [<ffffffffa12f92d0>] ? scst_tgtt_release+0x20/0x20 [scst]
 [<ffffffffa12f92d0>] ? scst_tgtt_release+0x20/0x20 [scst]
 [<ffffffff810b44f6>] kthread+0x96/0xa0
 [<ffffffff81b8ed74>] kernel_thread_helper+0x4/0x10
 [<ffffffff810b4460>] ? kthread_worker_fn+0x180/0x180
 [<ffffffff81b8ed70>] ? gs_change+0xb/0xb
Code: 42 c8 74 0f 39 78 48 75 ea c9 c3 0f 1f 84 00 00 00 00 00 31 c0 c9 c3 66 66 66 2e 0f 1f 84 00 00 00 00 00 48 8b 47 48 55 48 89 e5 <0f> b6 40 4c c9 83 e0 01 c3 66 66 66 66 66 66 2e 0f 1f 84 00 00
RIP  [<ffffffffa1345848>] iscsi_is_target_enabled+0x8/0x20 [iscsi_scst]
 RSP <ffff88015071ddc0>
CR2: 000000000000004c
---[ end trace 6311d4069703be07 ]---

Reported-by: Etienne Dechamps <e-t172@akegroup.org>
Signed-off-by: Bart Van Assche <bvanassche@acm.org> with some modifications



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4515 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-09-12 22:13:43 +00:00
Vladislav Bolkhovitin f7fd6bbce0 qla2x00t: Display a clear error message if the kernel is too old
For the people who try to build this driver before reading
qla2x00t/qla2x00-target/README.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4510 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-09-11 01:26:48 +00:00
Vladislav Bolkhovitin 396dcf6294 It isn't a error and can happen in normal circumstances
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4497 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-08-29 20:45:26 +00:00
Vladislav Bolkhovitin 7efac456a3 qla2x00t: Remove a superfluous cast
Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4487 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-08-27 21:51:10 +00:00
Vladislav Bolkhovitin dd37831c06 qla2x00t: Keep smatch happy
Smatch reports two warnings on the qla2x00t code:
* sess->local being tested while sess can be NULL.
* The code after the out_unreg_target2x label is only necessary in the procfs build.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4486 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-08-27 21:50:15 +00:00