Commit Graph

6440 Commits

Author SHA1 Message Date
Bart Van Assche
87d64c162d scst: Unbreak the build for RHEL 6 / CentOS 6
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8610 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-09 01:33:25 +00:00
Bart Van Assche
7b8c92e151 scst: Fix latency measurements if multiple commands are processed simultaneously by a single thread
Signed-off-by: Lev Vainblat <lev@zadarastorage.com>
[ bvanassche: reordered scst_cmd members ]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8608 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-06 23:52:51 +00:00
Bart Van Assche
8df56e2ea3 scripts/sign-modules: Fix module signing for Debian
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8607 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-06 23:24:06 +00:00
Bart Van Assche
23f7283906 scst/include/scst.h: Reduce the size of struct scst_cmd
Reduce the size of struct scst_cmd by reordering its structure members such
that there are two holes less in this data structure. This change has been
verified with the help of the 'pahole' tool.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8606 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-06 22:10:31 +00:00
Bart Van Assche
b4f893a009 Update Subversion ignore lists
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8605 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-06 21:39:25 +00:00
Bart Van Assche
20be212509 Update Subversion ignore lists
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8604 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-06 21:37:43 +00:00
Bart Van Assche
ea2d6ac0d9 scst/include/backport.h: Sort alphabetically
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8603 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-06 21:31:20 +00:00
Bart Van Assche
3d5a5078ca contributing.html: Remove information about already implemented features
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8602 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-06 00:01:20 +00:00
Bart Van Assche
cb73881c46 www: Update copyright footer
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8601 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-05 23:36:37 +00:00
Bart Van Assche
821116f242 www/downloads.html: Remove links to binary versions of SCST 1.0.1
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8600 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-05 23:34:56 +00:00
Bart Van Assche
ed68f1cb43 nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8599 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-05 21:34:55 +00:00
Bart Van Assche
b33060cdd8 nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8598 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-09-30 01:03:27 +00:00
Bart Van Assche
982e33160f scripts/specialize-patch: Fix a gawk warning
gawk: scripts/specialize-patch:329: (FILENAME=- FNR=26) warning: regexp escape sequence `\&' is not a known regexp operator



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8597 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-09-29 23:13:49 +00:00
Bart Van Assche
9add460430 Suppress module signing error messages
Suppress the following error messages:

- SSL error:02001002:system library:fopen:No such file or directory: crypto/bio/bss_file.c:72
- SSL error:2006D080:BIO routines:BIO_new_file:no such file: crypto/bio/bss_file.c:79
sign-file: certs/signing_key.pem: No such file or directory

 


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8596 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-09-29 22:33:03 +00:00
Bart Van Assche
06ee7ca41d Makefile: Unbreak the RPM build process
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8595 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-09-29 22:10:46 +00:00
Bart Van Assche
eb03ee602b iscsi-scst/Makefile: Fix a syntax error that was introduced in r8593
Reported-by: Rob Turk <robtu@rtist.nl>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8594 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-09-29 22:09:05 +00:00
Bart Van Assche
84725029ce scst: Add support for signing SCST kernel modules
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8593 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-09-29 04:42:40 +00:00
Bart Van Assche
a4a0317e58 .gitignore: Add
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8592 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-09-29 04:41:03 +00:00
Bart Van Assche
088d743229 scst: Port to CentOS 8
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8591 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-09-26 04:41:21 +00:00
Bart Van Assche
8b67ce61c6 qla2x00t-32gbit: Fix a compiler warning introduced by the previous commit
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8590 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-09-25 15:30:33 +00:00
Bart Van Assche
c081f0f982 qla2x00t-32gbit: Fix the build against kernel versions before v4.10
Fixes: 849adf540b ("qla2x00t-32gbit: Backport to kernel v4.9"; r8105)
Reported-by: Andri L. Vicko <andri_vicko@outlook.com>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8589 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-09-25 15:22:49 +00:00
Bart Van Assche
be309a2e31 scst: Port to SLES 15
Fixes: https://sourceforge.net/p/scst/tickets/29/.

Untested.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8588 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-09-25 03:33:46 +00:00
Bart Van Assche
842253f87e scst: Port to RHEL 7.7
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8586 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-09-24 21:44:01 +00:00
Bart Van Assche
4037b5d115 nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8585 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-09-16 13:40:12 +00:00
Bart Van Assche
6b80bb4ca6 scst/ChangeLog: Document changes included in SCST v3.2
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8584 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-09-15 01:10:50 +00:00
Bart Van Assche
51469f6d2f www/downloads.html: Update SCST git mirror URL
Replace the URL of a no longer maintained git mirror by the URL of a maintained
git mirror.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8583 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-09-15 00:48:19 +00:00
Bart Van Assche
f6371c5d5e Makefiles: Run depmod also on Ubuntu systems after module installation
Fixes: e902f79ecf ("kernel module installation: Skip "depmod" when building an RPM"; r5612)



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8582 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-09-15 00:29:55 +00:00
Bart Van Assche
feff5380c8 nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8581 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-09-13 01:36:58 +00:00
Bart Van Assche
0ce7c75782 qla2x00t-32gbit/qla2x00-target/README: Update this file
Bring this README file in sync with the recently checked in changes.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8580 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-09-07 03:58:30 +00:00
Bart Van Assche
35cd068962 scst_vdisk: Set REQ_PRIO for SCSI commands marked as head-of-queue
REQ_PRIO requests preempt others in the CFQ I/O scheduler. REQ_META marks
metadata requests for blktrace.

Reported-by: Lev Vainblat <lev@zadarastorage.com>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8579 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-09-07 03:55:23 +00:00
Bart Van Assche
1821c5a2de scst/include/backport.h: Fix kvmalloc() backport for RHEL 7
The kvmalloc function was added in RHEL 7.5. So the backport is
needed for RHEL 7.4 and older. _COMPAT_LINUX_MM_H is checked as
well to avoid a conflict with the appropriate backport in MOFED.

Signed-off-by: Sergey Gorenko <sergeygo@mellanox.com>

[ bvanassche: fixed spelling in commit message ]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8578 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-09-07 03:43:59 +00:00
Bart Van Assche
12e87680fd nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8577 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-09-07 01:45:44 +00:00
Bart Van Assche
410c462405 scst_copy_mgr: Fix copy manager LUN wraparound
This patch has been provided by Alexander Sinditskiy. See also
https://sourceforge.net/p/scst/tickets/27/.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8575 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-09-06 03:38:38 +00:00
Bart Van Assche
df08f74e7e qla2x00t-32gbit: Fix a format string in a debug message
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8574 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-08-26 00:48:03 +00:00
Bart Van Assche
cae4c3ce24 qla2x00t-32gbit: Use %<n>phC where appropriate.
This patch reverts commit d20be1897c ("qla2x00t-32gbit: Avoid using the
format specifier %*phC") / r8166.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8573 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-08-26 00:44:52 +00:00
Bart Van Assche
d17134bc20 qla2x00t-32gbit: Complain loudly if attempting to build against an unsupported kernel
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8572 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-08-26 00:26:42 +00:00
Bart Van Assche
9267f92ba5 scripts/generate-kernel-patch: Only select new QLogic driver for kernel versions >= 3.15
A recent change (.cmd_size in the SCSI host template) increased the
minimal kernel version required for qla2x00t-32gbit. Update
scripts/generate-kernel-patch.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8571 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-08-26 00:25:58 +00:00
Bart Van Assche
1d2a50ecaa scripts/run-regression-tests: Suppress several gcc 9 compiler warnings
Suppress several gcc 9 compiler warnings for kernel versions before v5.1.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8570 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-08-26 00:24:45 +00:00
Bart Van Assche
7a7f467adc qla2x00t-32gbit: Fix a race condition
This patch fixes the following kernel complaint:

WARNING: CPU: 7 PID: 16514 at kernel/workqueue.c:3031 __flush_work.cold+0x1f/0x29
Workqueue: qla2xxx_wq qla2x00_iocb_work_fn [qla2xxx_scst]
RIP: 0010:__flush_work.cold+0x1f/0x29
Call Trace:
 flush_work+0x14/0x20
 qla24xx_do_nack_work+0x84/0x150 [qla2xxx_scst]
 qla2x00_do_work+0x50b/0x17e0 [qla2xxx_scst]
 qla2x00_iocb_work_fn+0x96/0x100 [qla2xxx_scst]
 process_one_work+0x56d/0xac0
 worker_thread+0x7a/0x5d0
 kthread+0x1bc/0x210
 ret_from_fork+0x24/0x30



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8569 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-08-26 00:24:07 +00:00
Bart Van Assche
521c0261ec iscsi-scst/conftest/bad_wr_mod: Fix a Coverity complaint
Fix the following Coverity complaint:

CID 326815 (#1 of 1): Explicit null dereferenced (FORWARD_NULL)
2. var_deref_model: Passing null pointer qp to ib_post_recv, which dereferences it.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8568 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-08-25 22:55:48 +00:00
Bart Van Assche
59641c1d5f scst: Fix a memory leak
Fix the following Coverity complaint:

CID 344744 (#1 of 1): Resource leak (RESOURCE_LEAK)5. leaked_storage: Variable sioc going out of scope leaks the storage it points to.




git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8567 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-08-25 22:55:20 +00:00
Bart Van Assche
9e0914d470 scst_vdisk: Fix a Coverity complaint about integer overflow
Fix the following Coverity complaint:

CID 347914 (#1 of 1): Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN)overflow_before_widen: Potentially overflowing expression blocks << cmd->dev->block_shift - 9 with type uint32_t (32 bits, unsigned) is evaluated using 32-bit arithmetic, and then used in a context that expects an expression of type sector_t (64 bits, unsigned).
    
To avoid overflow, cast blocks to type sector_t.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8566 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-08-25 22:54:55 +00:00
Bart Van Assche
8f033f3f9d scst: Backport scsi_cmd_priv()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8565 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-08-25 22:54:15 +00:00
Bart Van Assche
c205138e87 scripts: Fix multiple shellcheck warnings
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8564 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-08-25 22:51:57 +00:00
Bart Van Assche
ee24c6bab2 nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8563 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-08-25 14:02:33 +00:00
Bart Van Assche
0dc0a43a08 qla2x00t-32gbit: Minimize diffs with trunk
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8562 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-08-25 03:21:06 +00:00
Bart Van Assche
7970005b40 qla2x00t-32gbit: Check sp->fcport->deleted again in qla2xxx_eh_abort()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8561 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-08-25 03:11:04 +00:00
Bart Van Assche
787bd29c97 qla2xxx: Fix a NULL pointer dereference
BUG: KASAN: null-ptr-deref in qla24xx_handle_plogi_done_event+0x134/0x9f0 [qla2xxx]
Read of size 4 at addr 00000000000000a0 by task swapper/2/0

CPU: 2 PID: 0 Comm: swapper/2 Not tainted 5.2.0-dbg+ #1
Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011
Call Trace:
 <IRQ>
 dump_stack+0x8a/0xd6
 __kasan_report.cold+0x5/0x41
 kasan_report+0x16/0x20
 __asan_load4+0x7e/0x80
 qla24xx_handle_plogi_done_event+0x134/0x9f0 [qla2xxx]
 qla2x00_els_dcmd2_sp_done+0x15f/0x230 [qla2xxx]
 qla24xx_els_ct_entry+0x3b3/0x610 [qla2xxx]
 qla24xx_process_response_queue+0x514/0x10e0 [qla2xxx]
 qla24xx_msix_rsp_q+0x80/0x100 [qla2xxx]
 __handle_irq_event_percpu+0x72/0x450
 handle_irq_event_percpu+0x74/0xf0
 handle_irq_event+0x5e/0x8f
 handle_edge_irq+0x13a/0x320
 handle_irq+0x30/0x40
 do_IRQ+0x91/0x190
 common_interrupt+0xf/0xf
 </IRQ>
RIP: 0010:default_idle+0x31/0x230

[ commit d1436e456b840162eb4d162f99055d2adb79a566 upstream ]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8560 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-08-25 03:09:55 +00:00
Bart Van Assche
134a9fec1a qla2x00t-32gbit: Cleanup trace buffer initialization
Avoid code duplication between qla2x00_alloc_offload_mem() and
qla2x00_alloc_fw_dump() by moving the FCE and EFT buffer allocation and
initialization to separate functions. Cleanly track failure and success by
making sure that the ha->eft, ha->fce and respective eft_dma, fce_dma
members are set if and only if the buffers are properly allocated and
initialized. Avoid pointless buffer reallocation.  Eliminate some goto
statements. Make sure the fce_enabled flag is cleared when the FCE buffer
is freed.

[ commit 3cf92f4bfccbb3e378cd86dc46e09c2bc18cda26 upstream ]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8559 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-08-25 03:08:18 +00:00
Bart Van Assche
51d92beed3 qla2x00t-32gbit: qla2x00_alloc_fw_dump: set ha->eft
In qla2x00_alloc_fw_dump(), an existing EFT buffer (e.g. from previous
invocation of qla2x00_alloc_offload_mem()) is freed.  The buffer is then
re-allocated, but without setting the eft and eft_dma fields to the new
values.

[ commit edbd56472a636ab396f5ee6783e8438fa725a6ee upstream ]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8558 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-08-25 03:07:02 +00:00