mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-08-20 14:16:31 +00:00
Code Issues Packages Projects Releases Wiki Activity
3,091 Commits 27 Branches 11 Tags
8dc9d5c439fdbf561dd092bd84a7006c425513ca
Commit Graph
1050 Commits
Author SHA1 Message Date
Bart Van Assche 39b6c43d45 scst: Fix value of FMTDATA bitmask 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4159 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-03-08 08:24:12 +00:00
Vladislav Bolkhovitin cc07f3904e The FORMAT UNIT has an optional data-out buffer with unspecified length. 
Make sure that SCST parses this command correctly.

Reported-by: Leonid Podolny <leonid.podolny@xtremio.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4158 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-03-07 19:52:50 +00:00
Vladislav Bolkhovitin a095641495 Make LUN removal work again. This is a fix for r4137. 
Reported-by: Riccardo <r.bicelli@gmail.com>

Signed-off-by: Bart Van Assche <bvanassche@acm.org>




git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4157 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-03-07 19:51:15 +00:00
Vladislav Bolkhovitin 7d1ba6a2b0 VERIFY(6) is a tape command. T10 has never defined a VERIFY(6) command 
for disk or CD-ROM devices, so make sure scst_vdisk rejects it.

+

added the corresponding cleanups in scst_lib.c and fileio/common.c + updated scst_scsi_op_table

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4156 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-03-07 19:50:10 +00:00
Vladislav Bolkhovitin 91a790b57d Eliminate three data members from struct vdisk_cmd_params. 
Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4155 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-03-07 19:34:27 +00:00
Vladislav Bolkhovitin c83af071b6 Looks like current kernels are more fair, so we can try to increase SCST_MAX_TGT_DEV_COMMANDS to please QD hungry initiators 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4154 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-03-05 21:21:22 +00:00
Vladislav Bolkhovitin 6f228ecb71 Correct misleading SCST_CMD_ABORTED description. 
Noticed by Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4148 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-02-27 22:59:10 +00:00
Vladislav Bolkhovitin 50120c37b3 scst_cmd_aborted() is a bad and ambiguous name. Rename it to scst_cmd_aborted_on_xmit() and create a new version, which truly reflects its semantic. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4143 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-02-24 02:24:06 +00:00
Vladislav Bolkhovitin f2387d7956 Convert strict_strtoul() and simple_strtoul() into kstrtoul() or sscanf() 
Recent versions of the checkpatch script complain about strict_strtoul()
and simple_strtoul(), so convert calls to these functions into a call to
kstrtoul() or sscanf(). Convert loops that scan for the
next-(non-)whitespace character into a call to scst_get_next_lexem().
Make __scst_process_luns_mgmt_store() a little more strict by checking
for extraneous parameters past the last argument. Fix the value "res"
returned for the SCST_TRACE_ACTION_VALUE processing code.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4137 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-02-18 03:01:43 +00:00
Vladislav Bolkhovitin ab25cb45dc Micro-optimize scst_calc_block_shift() 
Replace a loop by a single instruction, namely bsr (bit scan reverse).
From the disassembler output of scst_calc_block_shift() on an x86_64
system:

   0x0000000000001493 <+35>:    bsr    %edx,%ecx

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4134 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-02-17 01:43:21 +00:00
Bart Van Assche 5eb3a85948 scst/src/scst_lib.c: Remove a trailing whitespace 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4132 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-02-16 10:27:18 +00:00
Vladislav Bolkhovitin 293c2f3abd Slightly modified patch from Bart Van Assche <bvanassche@acm.org> cleaning VERIFY commands processing 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4131 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-02-15 22:32:05 +00:00
Vladislav Bolkhovitin c9b149c5ce Let's stay on the safe side away from gcc bugs and separate ints and bitfields with another access rules 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4127 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-02-13 22:35:52 +00:00
Vladislav Bolkhovitin 6a34f10d81 Cleanup suggested by Bart Van Assche <bvanassche@acm.org> 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4118 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-02-10 02:12:15 +00:00
Bart Van Assche c31ac7c591 scst: Port to RHEL 5.7 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4111 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-02-04 16:40:33 +00:00
Bart Van Assche 10bcf70cc6 Add files necessary for 3.2 nightly build 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4078 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-01-19 07:58:37 +00:00
Vladislav Bolkhovitin 9da517bae1 Update for kernel 3.2. Netlink part in iSCSI-SCST done by Bart Van Assche <bvanassche@acm.org> 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4077 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-01-18 23:48:02 +00:00
Vladislav Bolkhovitin f9126313e8 Better don't decode vendor opcode 0x24 for block devices, because the 
current decoding is incorrect anyway.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4072 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-01-15 00:09:03 +00:00
Vladislav Bolkhovitin 9e8b08cd40 Avoid that the compiler warns about READ_ATTRIBUTE and WRITE_ATTRIBUTE 
already being defined in <scsi/scsi.h> on RHEL 6.0, 6.1 and 6.2.

BSD-signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4032 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-12-28 03:54:03 +00:00
Vladislav Bolkhovitin 76dc7d207a Improve release mode TM logging to simplify imvestigations 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4017 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-12-19 21:30:18 +00:00
Bart Van Assche ccb249a8cd Spelling fix: change one occurrence of "ratational" into "rotational". 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3991 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-12-15 10:33:27 +00:00
Bart Van Assche 4dbdee210d Spelling fix: change one occurrence of "ratational" into "rotational". 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3990 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-12-15 10:32:24 +00:00
Bart Van Assche 64a9ec4768 Spelling fix: change one occurrence of "ritational" into "rotational". 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3989 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-12-15 10:31:26 +00:00
Vladislav Bolkhovitin 5dea6c0aa6 Minor addition recommended by Daniel Fernandes <dfernandes1978@hotmail.com> 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3980 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-12-13 02:13:56 +00:00
Vladislav Bolkhovitin 7872837b6b Replace list_entry((a)->next, b, c) by list_first_entry(a, b, c). 
BSD-signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3965 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-12-10 03:50:24 +00:00
Vladislav Bolkhovitin fda3b6b327 Minor logging improvement 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3964 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-12-08 23:49:52 +00:00
Vladislav Bolkhovitin f173a9133c Micro-optimize the page count computations in scst_mem.c by 
rewriting these computations such that branch instructions are avoided.

BSD-signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3963 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-12-08 00:06:24 +00:00
Vladislav Bolkhovitin cd2d549a0b Avoid converting back and forth between int and enum 
BSD-signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3962 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-12-08 00:00:06 +00:00
Vladislav Bolkhovitin 882d414719 Makes scst_vdisk build again on RHEL 5.x. 
BSD-signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3961 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-12-07 23:58:59 +00:00
Vladislav Bolkhovitin 63a6094cad Eliminate the blockio / fileio / nullio if-statements in 
vdisk_do_job() and the READ/WRITE functions called from that
function. Convert the opcode switch in vdisk_*do_job() to an
array with function pointers.

The function vdisk_exec_verify() only works for file I/O, so
rename it into fileio_exec_verify().

BSD-signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3957 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-12-07 02:29:14 +00:00
Vladislav Bolkhovitin 69d8c2fbd7 Change __attribute__((packed)) into __packed and 
__attribute__((aligned(x))) into __aligned(x) in kernel code since
checkpatch complains about the former.

BSD-signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3952 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-12-06 03:02:13 +00:00
Vladislav Bolkhovitin 5cc78efff5 According to SPC-4 in the PERSISTENT RESERVE IN full status descriptor 
the format of byte 13 is defined as follows:
- The most significant four bits are SCOPE field.
- The least significant four bits are the TYPE field.
Make sure that that byte is filled in according to the specification.

BSD-Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3950 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-12-02 02:46:33 +00:00
Vladislav Bolkhovitin ae55aa9e36 The only two values passed into the last two arguments of blockio_exec_rw() 
are 0 and 1. Change their argument type from int to bool.

BSD-signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3949 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-12-02 02:42:21 +00:00
Vladislav Bolkhovitin 0af423256f Micro-optimize the code for CDB parsing in several device handlers. 
BSD-signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3948 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-12-02 02:41:15 +00:00
Vladislav Bolkhovitin 4a3988e274 Use get_unaligned_be16() for reading the two bytes specifying the buffer length 
to allow the compiler to generate better code for reading these two bytes.

BSD-signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3947 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-12-02 02:39:43 +00:00
Vladislav Bolkhovitin f8c3b26620 disk_work.result is set by disk_cmd_done() and read by disk_exec(). 
Since there is a complete_all() / wait_for_completion() pair between both
accesses the volatile keyword is not necessary here.

BSD-signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3945 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-12-02 02:24:41 +00:00
Vladislav Bolkhovitin 152a2ad8c1 Avoid that the checkpatch.pl script as included in Linux kernel 3.1 
complains about min((int)(a), (int)(b)) that should be changed into
min_t(int, (a), (b)).

BSD-signed-off-by: Bart Van Assche <bvanassche@acm.org>




git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3944 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-12-02 02:14:59 +00:00
Vladislav Bolkhovitin 59019ae405 Use get/put_unaligned() instead of open coding these such that the 
compiler can generate better code.

As an example, the get_unaligned_be24() function used in the
implementation of READ_6, WRITE_6 and VERIFY_6 together with
"& 0x1f0000" is inlined by the compiler and is translated as
follows on an x86_64 system (2031616 equals 0x1f0000):

        movl    0(%r13), %r11d
        bswapl  %r11d
        andl    $2031616, %r11d

Also eliminate a conditional branch instruction from get_trans_len_1_256().

BSD-Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3943 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-12-01 03:36:15 +00:00
Vladislav Bolkhovitin 33891c34fa In the function scst_mgmt_translate_lun() the variable tgt_dev is 
used as a loop variable and is used inside that loop only.
Hence it is not necessary to initialize it to NULL.

BSD-Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3942 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-12-01 03:31:30 +00:00
Vladislav Bolkhovitin 295adebc0f Use get/put_unaligned_be<n>(...) instead of 
get/put_unaligned(cpu_to_be<n>(...)).

BSD-Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3941 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-12-01 03:28:39 +00:00
Vladislav Bolkhovitin a2dcbab715 Fixes problem reported by Lev Vainblat <lev@zadarastorage.com>: 
The access to the session sysfs during logout may lead to the kernel oops. In iscsi_unreg_sess_done() the iscsi_session is freed, so scst_sess->tgt_priv (that previously pointed to the iscsi_session) becomes stale. The session is still accessible in sysfs until scst_sess_sysfs_del() call, but accessing to the session via sysfs may return invalid values or crash the kernel:

$ cat /sys/kernel/scst_tgt/targets/iscsi/T1/sessions/iqn.2011-04.com.zadarastorage:316:vc-0/sid
10000123d0200

[  178.769460] iscsi-scst[895] logout_exec[2718]: Logout received from initiator iqn.2011-04.com.zadarastorage:316:vc-0
[  178.769482] iscsi-scst[897] cmnd_tx_end[2900]: Closing connection at initiator's iqn.2011-04.com.zadarastorage:316:vc-0 request
[  178.769546] scst: TM fn 6
[  178.769623] scst: TM fn 6 finished, status 0
[  178.770075] scst[1645] scst_cmd_thread[4379]: Processing thread D10_0 (PID 1645) finished
[  178.770111] scst[1646] scst_cmd_thread[4379]: Processing thread D10_1 (PID 1646) finished
[  178.770131] scst[1647] scst_cmd_thread[4379]: Processing thread D10_2 (PID 1647) finished
[  178.770150] scst[1648] scst_cmd_thread[4379]: Processing thread D10_3 (PID 1648) finished
[  178.770168] scst[1649] scst_cmd_thread[4379]: Processing thread D10_4 (PID 1649) finished
[  178.770186] scst[1650] scst_cmd_thread[4379]: Processing thread D10_5 (PID 1650) finished
[  178.770204] scst[1651] scst_cmd_thread[4379]: Processing thread D10_6 (PID 1651) finished
[  178.770223] scst[1652] scst_cmd_thread[4379]: Processing thread D10_7 (PID 1652) finished

$ cat /sys/kernel/scst_tgt/targets/iscsi/T1/sessions/iqn.2011-04.com.zadarastorage:316:vc-0/sid
0

$ echo 1> /sys/kernel/scst_tgt/targets/iscsi/T1/sessions/iqn.2011-04.com.zadarastorage:316:vc-0/force_close

[  193.150420] iscsi-scst[1555] iscsi_sess_force_close[389]: Deleting session 0 with initiator (null) (ffff880078316000)
[  193.150461] BUG: unable to handle kernel NULL pointer dereference at           (null)
[  193.150545] IP: [<ffffffffa034d034>] iscsi_sess_force_close+0xc4/0x170 [iscsi_scst]
[  193.150628] PGD 78218067 PUD 79666067 PMD 0
[  193.150678] Oops: 0000 [#1] SMP
[  193.150716] last sysfs file: /sys/kernel/scst_tgt/targets/iscsi/T1/sessions/iqn.2011-04.com.zadarastorage:316:vc-0/force_close
[  193.150824] CPU 0
[  193.150844] Modules linked in: ib_iser rdma_cm ib_cm iw_cm ib_sa ib_mad ib_core ib_addr iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi dm_iostat scst_vdisk iscsi_scst scst libcrc32c nfsd psmouse exportfs serio_raw virtio_ball   oon nfs lockd fscache nfs_acl auth_rpcgss i2c_piix4 sunrpc lp parport floppy raid10 raid456 async_pq async_xor xor async_memcpy async_raid6_recov ixgbevf raid6_pq async_tx raid1 raid0 multipath linear [last unloaded: scsi_transport_is   csi]
[  193.151359]
[  193.151377] Pid: 1555, comm: bash Not tainted 2.6.38-8-server #42-Ubuntu Bochs Bochs
[  193.151456] RIP: 0010:[<ffffffffa034d034>]  [<ffffffffa034d034>] iscsi_sess_force_close+0xc4/0x170 [iscsi_scst]
[  193.151556] RSP: 0018:ffff88007a247e28  EFLAGS: 00010287
[  193.151604] RAX: 000000000000007f RBX: fffffffffffffe30 RCX: 000000000003ffff
[  193.153372] RDX: 0000000000000000 RSI: 0000000000000086 RDI: 0000000000000246
[  193.155115] RBP: ffff88007a247e68 R08: 0000000000000036 R09: 000000000000b874
[  193.156878] R10: 0000000000000000 R11: 0000000000000001 R12: ffff8800783170a0
[  193.158640] R13: ffff88007a247fd8 R14: ffff88007828c4a0 R15: ffff880078573600
[  193.160112] FS:  00007f9d23092720(0000) GS:ffff88007fc00000(0000) knlGS:0000000000000000
[  193.160112] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  193.160112] CR2: 0000000000000000 CR3: 00000000787e6000 CR4: 00000000000006f0
[  193.160112] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[  193.160112] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
[  193.160112] Process bash (pid: 1555, threadinfo ffff88007a246000, task ffff88007828c4a0)
[  193.160112] Stack:
[  193.160112]  0000000000000000 ffff880078316000 0000000000000000 0000000000000000
[  193.160112]  ffff880078316000 0000000000000001 ffff8800370ea5a0 ffffffffa02de9c0
[  193.160112]  ffff88007a247e88 ffffffffa034d138 ffff880078573620 ffff88007a247f48
[  193.160112] Call Trace:
[  193.160112]  [<ffffffffa034d138>] iscsi_sess_force_close_store+0x58/0xd0 [iscsi_scst]
[  193.160112]  [<ffffffffa02bf31c>] scst_store+0x1c/0x20 [scst]
[  193.160112]  [<ffffffff811d35f1>] sysfs_write_file+0xd1/0x160
[  193.160112]  [<ffffffff811652e6>] vfs_write+0xc6/0x180
[  193.160112]  [<ffffffff81165601>] sys_write+0x51/0x90
[  193.160112]  [<ffffffff8100bfc2>] system_call_fastpath+0x16/0x1b
[  193.160112] Code: 1f 84 00 00 00 00 00 f6 05 ea ef 00 00 08 75 68 48 89 df be 03 00 00 00 e8 ca d3 ff ff 48 8b 9b d0 01 00 00 48 81 eb d0 01 00 00 <48> 8b 83 d0 01 00 00 0f 18 08 48 8d 83 d0 01 00 00 4c 39 e0 75
[  193.160112] RIP  [<ffffffffa034d034>] iscsi_sess_force_close+0xc4/0x170 [iscsi_scst]
[  193.160112]  RSP <ffff88007a247e28>
[  193.160112] CR2: 0000000000000000
[  193.200380] ---[ end trace 1988466f0a8da036 ]---



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3940 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-11-29 22:00:23 +00:00
Vladislav Bolkhovitin a309a526f0 Check error code of path_lookup() on pre-39 kernels. Suggested by Lev Vainblat <lev@zadarastorage.com> 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3939 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-11-23 02:53:09 +00:00
Vladislav Bolkhovitin 2ff0f44c4c Avoid that a warning like the one below is triggered when adding 
a nullio, fileio or blockio device with a name that already exists:

WARNING: at fs/sysfs/dir.c:481 sysfs_add_one+0x95/0xd0()
sysfs: cannot create duplicate filename '/kernel/scst_tgt/devices/disk09'
Call Trace:
warn_slowpath_common+0x72/0xa0
? sysfs_add_one+0x95/0xd0
? sysfs_add_one+0x95/0xd0
warn_slowpath_fmt+0x33/0x40
sysfs_add_one+0x95/0xd0
create_dir+0x61/0xa0
sysfs_create_dir+0x71/0xb0
kobject_add_internal+0x9b/0x250
? kvasprintf+0x41/0x50
kobject_init_and_add+0x39/0x60
scst_dev_sysfs_create+0x6e/0x250 [scst]
scst_register_virtual_device+0x1f4/0x3e0 [scst]
vdev_nullio_add_device+0x14f/0x1c0 [scst_vdisk]
? vdisk_add_nullio_device+0x5a/0x110 [scst_vdisk]
vdisk_add_nullio_device+0xf1/0x110 [scst_vdisk]
? scst_check_grab_devt_ptr.clone.0+0xa8/0x170 [scst]
scst_process_devt_mgmt_store+0xa9/0x2a0 [scst]
? spin_unlock.clone.11+0x12/0x20 [scst]
scst_devt_mgmt_store_work_fn+0x13/0x20 [scst]
scst_process_sysfs_works+0x7f/0x170 [scst]
? spin_lock.clone.10+0x12/0x20 [scst]
sysfs_work_thread_fn+0x103/0x270 [scst]
? wake_up_bit+0x30/0x30
? prepare_to_wait_exclusive_head.clone.16+0x60/0x60 [scst]
kthread+0x84/0x90
? __init_kthread_worker+0x60/0x60
kernel_thread_helper+0x6/0x10

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3938 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-11-23 02:35:44 +00:00
Vladislav Bolkhovitin b579b06531 Instead of repeating the same name lookup several times, use vdev_find() 
where appropriate.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3937 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-11-23 02:34:09 +00:00
Vladislav Bolkhovitin 55e2ab6c6d Report target name when session assigned to security group 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3935 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-11-23 02:14:38 +00:00
Bart Van Assche baf5c259bc regtests: Add files necessary for Linux kernel 3.1 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3929 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-11-17 09:24:12 +00:00
Vladislav Bolkhovitin 57193ecabc Those patches were mistakenly generated for patch -p0. Fix it. Thanks 
Bart Van Assche for reporting it.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3926 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-11-16 19:21:30 +00:00
Vladislav Bolkhovitin 95f29de215 Fix incorrect attach_tgt() errors processing in the sysfs build reported by David Pineau <dav.pineau@gmail.com> 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3923 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-11-16 01:53:27 +00:00
Vladislav Bolkhovitin 6523575472 Fixes reporting to BLOCKIO devices fsync() errors, noticed by Bart Van Assche 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3922 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-11-16 00:04:57 +00:00
Vladislav Bolkhovitin 1e547f1aae Fixes possible NULL cmd dereference in vdisk_fsync() noticed by Bart Van 
Assche + possible calls of VERIFY commands for BLOCKIO devices



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3921 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-11-16 00:00:40 +00:00