mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-05-18 03:01:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,662 Commits 26 Branches 11 Tags
8f8ea536e06d9e2d2fe191e5e460ab7da06f22bd
Commit Graph

1662 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Vladislav Bolkhovitin
8f8ea536e0 - Logging cleanup 
- Added debug facility to catch possible data corruption case.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1827 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-15 12:45:31 +00:00
Bart Van Assche
402306e3e0 Relaxed send-queue-full error handling. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1826 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-14 18:37:42 +00:00
Bart Van Assche
7a0a6fb86e Made srpt_srq_size configurable as a kernel module parameter. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1825 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-14 18:28:09 +00:00
Bart Van Assche
fe81f9766c Changed two PRINT_INFO() messages that reported that the send queue was full into PRINT_ERROR() messages, and renamed a few variables. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1824 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-14 17:22:52 +00:00
Vladislav Bolkhovitin
82dca1c438 Web updates 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1823 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-14 14:16:36 +00:00
Vladislav Bolkhovitin
48d762e5cb Fix handling of host templates with NULL names 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1822 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-14 13:31:39 +00:00
Vladislav Bolkhovitin
571df65257 Fixing broken perf build 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1821 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-14 12:57:39 +00:00
Mark Buechler
bd48c8f119 - Check for non-existent devices and warn/remove them from read config. 
- Error out if a target doesn't exist to prevent removing potentially
  good running config.
- Be sure to remove luns and initiators before the group they're in.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1820 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-13 19:12:44 +00:00
Bart Van Assche
e7c082ac23 Implemented several source code refinements that do not affect functionality. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1819 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-13 18:36:08 +00:00
Mark Buechler
4e9f58c279 - Fixed driver/target attribute setting as well as dynamic attribute 
adding and deleting. I must have been low on meds the first time
  I wrote those.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1818 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-13 18:27:36 +00:00
Mark Buechler
9e11c29d06 - Fix handling of /dev paths. 
- Check for device paths which have a '/' in checkConfiuration().



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1817 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-13 15:15:11 +00:00
Vladislav Bolkhovitin
6527947abb Fix "‘wrap’ may be used uninitialized" warning 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1816 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-13 12:24:13 +00:00
Vladislav Bolkhovitin
8437061902 Don't allow to create devices with '/' in names 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1815 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-13 12:11:52 +00:00
Vladislav Bolkhovitin
e8f6cfd143 Remove wrong "Unexpected block size" messages 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1814 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-13 11:50:27 +00:00
Vladislav Bolkhovitin
d3847b031e Make SG IO count limitation messages less annoying 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1813 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-13 11:48:49 +00:00
Bart Van Assche
47a5c6072c Fixed a bug in the command abortion code. E.g. the following kernel message could be generated when unloading ib_srpt while I/O was ongoing: 
------------[ cut here ]------------
WARNING: at /home/bart/software/scst/srpt/src/ib_srpt.c:1063 srpt_reset_ioctx+0x15b/0x170 [ib_srpt]()
Hardware name: P5Q DELUXE
Modules linked in: [ ... ]
Pid: 20709, comm: disk011_4 Tainted: G        W  2.6.34-scst #1
Call Trace:
 [<ffffffff81048dbb>] warn_slowpath_common+0x7b/0xc0
 [<ffffffff81048e14>] warn_slowpath_null+0x14/0x20
 [<ffffffffa050772b>] srpt_reset_ioctx+0x15b/0x170 [ib_srpt]
 [<ffffffff81048dcf>] ? warn_slowpath_common+0x8f/0xc0
 [<ffffffffa0507773>] srpt_on_free_cmd+0x33/0x60 [ib_srpt]
 [<ffffffffa0480a0b>] scst_free_cmd+0xab/0x460 [scst]
 [<ffffffffa046dd38>] scst_finish_cmd+0x178/0x300 [scst]
 [<ffffffffa0470ed4>] scst_process_active_cmd+0x134/0x640 [scst]
 [<ffffffffa0471dac>] scst_process_redirect_cmd+0x2bc/0x3f0 [scst]
 [<ffffffffa047247a>] scst_tgt_cmd_done+0x6a/0x100 [scst]
 [<ffffffffa0508dec>] srpt_xmit_response+0x11c/0x210 [ib_srpt]
 [<ffffffffa046b53c>] scst_xmit_response+0x13c/0x560 [scst]
 [<ffffffffa0470efb>] scst_process_active_cmd+0x15b/0x640 [scst]
 [<ffffffffa047149d>] scst_do_job_active+0xbd/0x180 [scst]
 [<ffffffffa0471806>] scst_cmd_thread+0x1c6/0x4b0 [scst]
 [<ffffffff8103e960>] ? default_wake_function+0x0/0x20
 [<ffffffffa0471640>] ? scst_cmd_thread+0x0/0x4b0 [scst]
 [<ffffffff810683e6>] kthread+0x96/0xa0
 [<ffffffff81003d94>] kernel_thread_helper+0x4/0x10
 [<ffffffff8103dcb1>] ? finish_task_switch+0x51/0xb0
 [<ffffffff81344dac>] ? _raw_spin_unlock_irq+0x1c/0x40
 [<ffffffff813458ad>] ? restore_args+0x0/0x30
 [<ffffffff81068350>] ? kthread+0x0/0xa0
 [<ffffffff81003d90>] ? kernel_thread_helper+0x0/0x10
---[ end trace 84b1e00ea2ac6651 ]---


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1812 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-10 18:27:59 +00:00
Bart Van Assche
008841b622 Minor optimization: merged a srpt_get_cmd_state() and srpt_set_cmd_state() call. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1811 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-10 07:17:30 +00:00
Vladislav Bolkhovitin
75411305f1 Partial commit of patch from Bart Van Assche <bvanassche@acm.org> which suppresses the sparse warnings triggered by scst_pres.c. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1810 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-09 19:48:55 +00:00
Vladislav Bolkhovitin
3c411a5ba7 Fix for bug reported by Mark Buechler <mark.buechler@gmail.com> when wrong wildcard attribute can be deleted 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1809 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-09 19:05:55 +00:00
Bart Van Assche
66ccc6d619 Reverted r1806 and fixed a race condition that could cause data corruption. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1808 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-09 18:12:24 +00:00
Bart Van Assche
45bbbbba5f Improved I/O stress test. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1807 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-09 18:04:23 +00:00
Bart Van Assche
cdd65273e9 Applied a temporary fix for data corruption that could occur when multiple initiators were accessing data on a multicore target system. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1806 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-08 18:29:52 +00:00
Mark Buechler
10339ef259 - Fixed empty CREATE_ATTRIBUTES. 
- Added version requirement to SCST::SCST.
- Added support for deleting of dynamic attributes.
- Fixed support for changing non-dynamic attributes.
- Fixed (sorta) vcdrom handler.

Still possibly broken:

- Adding/deleting dynamic attributes is a bit broken in my
  SCST tree for some reason. I suspect this may be fixed
  in a later svn commit.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1805 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-07 18:12:40 +00:00
Bart Van Assche
8297ce5c41 Updated kernel versions. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1804 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-06 10:41:33 +00:00
Bart Van Assche
cf6fb97164 Made sure that the source file scst_pres.c is compiled too. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1803 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-05 16:17:36 +00:00
Bart Van Assche
2e07133917 Converted a WARN_ON() statement into PRINT_INFO(). 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1802 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-04 20:11:47 +00:00
Bart Van Assche
936f080310 Fixed a race condition that could cause SRP commands to be processed out of 
order on a multicore system. Also, split send and receive completion queues
such that the amount of code that is executed under spinlock and with IRQs
disabled is minimal.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1801 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-04 19:44:33 +00:00
Bart Van Assche
4438a65592 Fixed grammar in a source code comment. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1800 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-06-30 18:54:29 +00:00
Vladislav Bolkhovitin
f63533f5c6 The patch below fixes / suppresses all SCST core related endianness warnings 
reported by sparse.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1799 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-06-29 11:56:46 +00:00
Vladislav Bolkhovitin
07b012ca56 [PATCH] Session reference count logic error in Qlogic target 
When double session is found in q2t_create_sess the session object is updated, 
but after exiting from the function, if the session is not NULL the reference 
counter is decrement, become zero and then the session is deleted. 
As done while making a local session we need here to increment the reference 
count by calling to q2t_sess_get, because at exiting we call to q2t_sess_put. 
 
Signed-off-by: Gal Rosen <galr@storwize.com> 



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1798 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-06-29 10:33:41 +00:00
Bart Van Assche
3375930bad Cleanup. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1797 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-06-28 19:03:40 +00:00
Bart Van Assche
58e0bbd491 Whitespace-only changes for checkpatch. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1796 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-06-28 18:35:38 +00:00
Bart Van Assche
2e0703275d SRPT with thread=0 works again (was broken by r1714, the merge of the persistent reservation branch to the trunk). 
Added more consistency checks.

git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1795 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-06-28 18:23:28 +00:00
Vladislav Bolkhovitin
fdbb5fcc7f Minor cleanups 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1794 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-06-28 18:07:11 +00:00
Vladislav Bolkhovitin
13dea2fd6a - Fix possible buffer overflow in the iSNS code. 
- Cleanups.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1793 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-06-28 18:03:10 +00:00
Bart Van Assche
c7369b432b Micro-optimized srpt_completion(). 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1792 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-06-26 10:42:06 +00:00
Vladislav Bolkhovitin
54c98834cd BE changes to keep sparse happy pointed out by Bart Van Assche <bvanassche@acm.org> 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1791 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-06-25 18:14:13 +00:00
Bart Van Assche
e61d66a0c0 Whitespace-only changes to fix recently introduced checkpatch complaints. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1790 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-06-25 18:00:39 +00:00
Vladislav Bolkhovitin
bb21149a73 Fix possible crash if AEN is sent to a being shutdown session, because after unreg_done_fn() called the target driver's part of the session 
should be already freed.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1789 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-06-25 17:25:18 +00:00
Vladislav Bolkhovitin
8d4d13fdb1 Fix cdb_len handling to avoid crashes on attempts to copy negative cdb_len bytes + minor scst_user residual fix 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1788 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-06-25 17:05:36 +00:00
Vladislav Bolkhovitin
a15199e2ed The patch below fixes / suppresses all iscsi-scst related endianness warnings 
reported by sparse (make C=2 CF=-D__CHECK_ENDIAN__ iscsi).

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>

with some improvements



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1787 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-06-25 11:47:28 +00:00
Vladislav Bolkhovitin
07818cf573 Docs update 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1786 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-06-25 10:24:24 +00:00
Vladislav Bolkhovitin
0d21ef4e23 Fix for wrong endianness in scst_cmd_set_tgt_sn() call. Reported by Phil White <phil@scalecomputing.com> 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1785 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-06-25 10:23:20 +00:00
Vladislav Bolkhovitin
9f5938cccc It's better to perform target redirection only for allowed initiators. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1784 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-06-24 18:58:25 +00:00
Vladislav Bolkhovitin
af5e8e3f79 Web updates 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1783 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-06-24 18:44:54 +00:00
Vladislav Bolkhovitin
82141783f8 Patch from Ido Benda <Ido.Benda@kaminario.com> fixing a small bug in PR read keys which causes the last key to be omitted. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1782 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-06-24 18:21:54 +00:00
Vladislav Bolkhovitin
eb16bf9163 Implement qlini_mode qla2xxx module parameter with ini_mode_force_reverse sysfs attribute instead of CONFIG_SCSI_QLA2XXX_TARGET_DISABLE_INI_MODE compile-time option for better flexibility. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1781 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-06-24 18:03:27 +00:00
Vladislav Bolkhovitin
78edc5afb9 Various cleanups and fixes after some errors injection tests. Particularly: 
- ISCSI preliminary completed commands handling fixes
 - Write residuals cleanups and fixes
 - Interface to handle residuals and received from initiators data changed
 - BIDI cleanups and fixes.
 - All BIDI IN fields and functions renamed to OUT to be in line with the in-kernel convention

+ 

Docs updated



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1780 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-06-23 13:57:35 +00:00
Bart Van Assche
e730fac09d Fixed sparse warnings. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1779 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-06-18 19:29:19 +00:00
Bart Van Assche
0efa1826b0 Fixed a compiler warning. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1778 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-06-17 17:44:29 +00:00