This patch makes it possible to build the ib_srpt driver against a kernel
before v5.1 + latest MOFED.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8655 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This patch makes it possible to build the ib_srpt driver against a kernel
before v4.21 + latest MOFED.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8653 d57e44dd-8a1f-0410-8b47-8ef2f437770f
In shutdown/reboot paths, the timer is not stopped:
qla2x00_shutdown
pci_device_shutdown
device_shutdown
kernel_restart_prepare
kernel_restart
sys_reboot
This causes lockups (on powerpc) when firmware config space access calls
are interrupted by smp_send_stop later in reboot.
Fixes: e30d1756480dc ("[SCSI] qla2xxx: Addition of shutdown callback handler.")
Link: https://lore.kernel.org/r/20191024063804.14538-1-npiggin@gmail.com
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Acked-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[ commit d3566abb1a1e7772116e4d50fb6a58d19c9802e5 upstream ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8651 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This patch fixes issue with Gen7 adapter in a blade environment where one
of the ports will not be detected by driver. Firmware expects mailbox 11 to
be set or cleared by driver for newer ISP.
Following message is seen in the log file:
[ 18.810892] qla2xxx [0000:d8:00.0]-1820:1: **** Failed=102 mb[0]=4005 mb[1]=37 mb[2]=20 mb[3]=8
[ 18.819596] cmd=2 ****
[mkp: typos]
Link: https://lore.kernel.org/r/20191022193643.7076-2-hmadhani@marvell.com
Signed-off-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[ commit c2ff2a36eff60efb5e123c940115216d6bf65684 upstream ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8649 d57e44dd-8a1f-0410-8b47-8ef2f437770f
Commit 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not called
from the completion path") introduced the WARN_ON_ONCE in
qla2x00_status_cont_entry(). The assumption was that there is only one
status continuations element. According to the firmware documentation it is
possible that multiple status continuations are emitted by the firmware.
Fixes: 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not called from the completion path")
Link: https://lore.kernel.org/r/20190927073031.62296-1-dwagner@suse.de
Cc: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Daniel Wagner <dwagner@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[ commit 9bc6157f5fd0e898c94f3018d088a3419bde0d8f upstream ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8646 d57e44dd-8a1f-0410-8b47-8ef2f437770f
Print if fwdt template is present or not, only when
ql2xextended_error_logging is enabled.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8639 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This patch updates log message which indicates number of vectors used by
the driver instead of displaying failure to get maximum requested
vectors. Driver will always request maximum vectors during
initialization. In the event driver is not able to get maximum requested
vectors, it will adjust the allocated vectors. This is normal and does not
imply failure in driver.
Signed-off-by: Himanshu Madhani <hmadhani@marvell.com>
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
Reviewed-by: Lee Duncan <lduncan@suse.com>
Link: https://lore.kernel.org/r/20190830222402.23688-2-hmadhani@marvell.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[ commit da48b82425b8bf999fb9f7c220e967c4d661b5f8 upstream ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8633 d57e44dd-8a1f-0410-8b47-8ef2f437770f
If HBA initialization fails unexpectedly (exiting via probe_failed:), we
may fail to free vha->gnl.l. So that we don't attempt to double free, set
this pointer to NULL after a free and check for NULL at probe_failed: so we
know whether or not to call dma_free_coherent.
Signed-off-by: Bill Kuzeja <william.kuzeja@stratus.com>
Acked-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[ commit 26fa656e9a0cbccddf7db132ea020d2169dbe46e upstream ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8630 d57e44dd-8a1f-0410-8b47-8ef2f437770f
In qla2x00_alloc_fcport(), fcport is assigned to NULL in the error
handling code on line 4880:
fcport = NULL;
Then fcport is used on lines 4883-4886:
INIT_WORK(&fcport->del_work, qla24xx_delete_sess_fn);
INIT_WORK(&fcport->reg_work, qla_register_fcport_fn);
INIT_LIST_HEAD(&fcport->gnl_entry);
INIT_LIST_HEAD(&fcport->list);
Thus, possible null-pointer dereferences may occur.
To fix these bugs, qla2x00_alloc_fcport() directly returns NULL
in the error handling code.
These bugs are found by a static analysis tool STCheck written by us.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Acked-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[ commit e82f04ec6ba91065fd33a6201ffd7cab840e1475 upstream ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8629 d57e44dd-8a1f-0410-8b47-8ef2f437770f
Surrounding IS_ERR(...) with unlikely() is redundant. Remove the redundant
unlikely() annotations.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8623 d57e44dd-8a1f-0410-8b47-8ef2f437770f
These drivers have not been updated in a significant way since 2010.
Additionally, these drivers fail to build against recent kernel versions.
I think this means that nobody is using these drivers. Hence remove these
drivers from the trunk.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8622 d57e44dd-8a1f-0410-8b47-8ef2f437770f
Since the driver in the qla2x00t-32gbit directory supersedes the driver from
the QLogic git tree, remove all references to the latter.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8620 d57e44dd-8a1f-0410-8b47-8ef2f437770f
