Commit Graph

5068 Commits

Author SHA1 Message Date
Vladislav Bolkhovitin
9ead865f6a Cleanup
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6862 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-04-20 03:44:21 +00:00
Vladislav Bolkhovitin
7219595e5c iscsi-scst: fix 2 minor main Makefile issues
1. Fix build of progs and mods targets, if iscsi_scst_itf_ver.h does not exist
2. Fix small race for parallel build of "all" target, when iscsi_scst_itf_ver.h
   not yet built, when progs or mods target need it



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6861 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-04-20 03:17:16 +00:00
Vladislav Bolkhovitin
9cd57cf50f Cleanup
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6860 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-04-20 02:48:28 +00:00
Bart Van Assche
dc28d934d3 scst.spec.in: Disable executable flag again for kernel modules
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6859 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-04-12 13:47:58 +00:00
Bart Van Assche
d619407d16 scst: Kernel v4.6-rc3 build fix
See also patch "mm: drop PAGE_CACHE_* and page_cache_{get,release}
definition".


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6858 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-04-11 19:59:59 +00:00
Bart Van Assche
dec1b4a12d scstadmin: Leave out "r" from RPM revision number
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6857 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-04-09 03:11:52 +00:00
Bart Van Assche
e3988e8c92 scst.spec.in: Enable .debug generation for .ko files
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6856 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-04-09 03:05:39 +00:00
Bart Van Assche
76cd77d64a scst.spec.in: Leave out 'r' from revision number
RPM version comparison works correctly with numbers but not if the
revision starts with 'r'. Hence leave out the 'r'.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6855 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-04-09 03:04:09 +00:00
Bart Van Assche
b34cf85d83 scst_sysfs: Report LUN replacement failure correctly
This is a follow-up for r6834.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6854 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-27 22:44:44 +00:00
Bart Van Assche
520b66677d scst: Fix RHEL 5 build
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6853 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-27 17:26:50 +00:00
Bart Van Assche
86816401fa scst: Move more backports from scst_debug.h into backport.h
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6852 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-27 17:09:46 +00:00
Bart Van Assche
30c98e92cd scst_local: Address checkpatch warnings
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6851 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-27 16:57:04 +00:00
Bart Van Assche
30f362caa3 scst: Address more checkpatch warnings
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6850 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-27 16:56:50 +00:00
Bart Van Assche
3990a6ccd4 iscsi-scstd: Insert a blank line after declarations
Additionally, surround complex values with parentheses, declare static
char arrays const and change C++ comments into C comments.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6849 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-27 16:24:59 +00:00
Bart Van Assche
c477b5f99c iscsi-scstd: Fix more checkpatch complaints about whitespace
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6848 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-27 16:16:06 +00:00
Bart Van Assche
2681ed8bcb iscsi-scstd: Fix checkpatch complaints about whitespace
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6847 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-27 16:10:45 +00:00
Bart Van Assche
3ab98d8174 iscsi-scst: Fix checkpatch complaints about whitespace
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6846 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-27 16:10:26 +00:00
Bart Van Assche
4dfb9d10c7 fcst: Change "signed" into "signed int"
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6845 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-27 15:57:41 +00:00
Bart Van Assche
45a032c357 fcst: Remove a CVS keyword marker
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6844 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-27 15:57:03 +00:00
Bart Van Assche
d4fc2435ec scst_mem: Remove a superfluous cast
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6843 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-27 15:55:41 +00:00
Bart Van Assche
b109098efe ib_srpt: Fix checkpatch complaints about missing spaces
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6842 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-27 15:52:41 +00:00
Bart Van Assche
7289593aff scst: Fix checkpatch complaints about using spaces for indentation instead of tabs
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6841 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-27 15:50:21 +00:00
Bart Van Assche
8695583ee9 ib_srpt: Reduce CPU load caused by stopping a large number of sessions
Avoid that stopping a large number of SRPT sessions causes a high
context switch frequency and hence a high CPU load.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6840 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-24 17:15:23 +00:00
Bart Van Assche
63768c8715 ib_srpt: Fix a debug message
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6839 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-24 17:14:49 +00:00
Bart Van Assche
3a7a5e7289 scst_vdisk: Fix handling of vdisk_cmd_params::iv
Avoid that the iv pointer can become a dangling pointer for
vdisk_fileio devices. Freeing iv without resetting iv_count
makes it namely possible that iv will be used after the memory
that pointer points at has been freed.
    
For vdisk_blockio devices, call vdisk_on_free_cmd_params() to
free the iv pointer.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6838 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-24 17:14:29 +00:00
Bart Van Assche
fef250eb90 scst_vdisk: Introduce vdisk_on_free_cmd_params()
This patch does not change any functionality.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6837 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-24 17:13:46 +00:00
Bart Van Assche
4f10d6254e scst_vdisk: Remove superfluous semicolons
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6836 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-24 17:13:06 +00:00
Bart Van Assche
eff3021fb5 scst: Port to Linux kernel v4.6
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6835 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-24 04:08:12 +00:00
Bart Van Assche
cf459edf68 scst: Move LUN replacement code to scst_lib
Move the code for LUN replacement from scst_sysfs.c into scst_lib.c.
This patch reduces code duplication by calling __scst_acg_del_lun()
from inside the LUN reassignment code. This patch does not change
any functionality.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6834 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-18 23:10:39 +00:00
Bart Van Assche
da3b803d81 scst_lib: Introduce __scst_acg_del_lun()
This patch does not change any functionality.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6833 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-18 23:10:10 +00:00
Bart Van Assche
7d1a007256 scst_sysfs: Separate LUN addition from LUN replacement code
This patch does not change any functionality but makes
__scst_process_luns_mgmt_store() easier to read.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6832 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-18 23:09:39 +00:00
Bart Van Assche
af8f462071 ib_srpt: Revert r6822
Revision 6822 triggers a race condition, hence revert it.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6831 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-18 17:00:39 +00:00
Bart Van Assche
8aa0ecf666 scripts/generate-patched-kernel: Fix list-source-files path
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6830 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-11 04:06:34 +00:00
Vladislav Bolkhovitin
3d28ef3f0a scst_vdisk: warning clarification
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6828 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-11 03:27:53 +00:00
Vladislav Bolkhovitin
f59e86a659 This limits target group state changes to only apply to targets local to the host.
This prevents the devices being blocked offline by changes to non-local targets.

Signed-off-by: Adrian Saul <adrian.saul@tpgtelecom.com.au>

with some minor corrections



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6827 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-11 03:10:04 +00:00
Vladislav Bolkhovitin
740ad417db scst: some more debug tracing on the pass-through path
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6826 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-10 05:25:55 +00:00
Vladislav Bolkhovitin
c12cdbf860 qla2x00t: decrease severity of 2 log messages
Those messages don't necessare mean any error. Some harmless race
conditions between the target driver and FW can lead to them as well.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6825 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-10 05:00:01 +00:00
Bart Van Assche
8e2996b74a scst_vdisk: Fix kfree() argument in vdev_size_store() error path
The wrong variable is freed in the vdev_size_store() error path.
Pass 'new_size' instead of 'buf' to kfree().

Signed-off-by: Sebastian Parschauer <sebastian.riemer@profitbricks.com>
[ bvanassche: edited patch description ]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6824 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-08 18:24:23 +00:00
Vladislav Bolkhovitin
f21aac581f scst: make NULLIO use per-initiator threads
To increase peformance by decreasing locks contention with multiple
CPU cores between multiple threads in the global pool.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6823 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-04 03:49:23 +00:00
Bart Van Assche
69471744d8 ib_srpt: Reduce command processing latency
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6822 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-02 19:56:41 +00:00
Vladislav Bolkhovitin
83d0cb0f46 iscsi-scst: fix possible recursive locking
cmnd_done() called from cmnd_put() can take cmd_list_lock, so it must
not be called under it.

Reported and tested by David Chen <david.chen@osnexus.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6821 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-02 04:13:42 +00:00
Bart Van Assche
068bc3f41e scst: Fix scst_resume_activity()
Avoid that the following crash is triggered under memory pressure:

 PID: 12622  TASK: ffff88042069a040  CPU: 2   COMMAND: "scst_uid"
  #0 [ffff88040daebaa0] machine_kexec at ffffffff8103b60b
  #1 [ffff88040daebb00] crash_kexec at ffffffff810c99e2
  #2 [ffff88040daebbd0] oops_end at ffffffff8152e1c0
  #3 [ffff88040daebc00] die at ffffffff81010f5b
  #4 [ffff88040daebc30] do_general_protection at ffffffff8152dcb2
  #5 [ffff88040daebc60] general_protection at ffffffff8152d485
     [exception RIP: __scst_resume_activity+531]
     RIP: ffffffffa05ccbd3  RSP: ffff88040daebd10  RFLAGS: 00010046
     RAX: 0000000000000063  RBX: dead000000100100  RCX: 0000000000000000
     RDX: ffffffffa067c8a0  RSI: 0000000000000046  RDI: 0000000000000046
     RBP: ffff88040daebd30   R8: 000000001c1471e6   R9: 6320746d676d2065
     R10: 766974636120666f  R11: 2064616568206f74  R12: ffff88068fea73a8
     R13: ffff88068fea73a8  R14: ffff88040daebe08  R15: ffff88043a7eaab0
     ORIG_RAX: ffffffffffffffff  CS: 0010  SS: 0018
  #6 [ffff88040daebd18] mutex_lock at ffffffff8152af9e
  #7 [ffff88040daebd38] scst_resume_activity at ffffffffa05ccc6d [scst]
  #8 [ffff88040daebd48] scst_unregister_virtual_device at ffffffffa05ce18c [scst]
  #9 [ffff88040daebd88] vdev_del_device at ffffffffa07ca1c0 [scst_vdisk]
 #10 [ffff88040daebdb8] vdisk_del_device at ffffffffa07ca4bf [scst_vdisk]
 #11 [ffff88040daebde8] scst_process_devt_mgmt_store at ffffffffa0605ab9 [scst]
 #12 [ffff88040daebe38] scst_devt_mgmt_store_work_fn at ffffffffa0605af6 [scst]
 #13 [ffff88040daebe48] scst_process_sysfs_works at ffffffffa0601c5f [scst]
 #14 [ffff88040daebe78] sysfs_work_thread_fn at ffffffffa0601e97 [scst]
 #15 [ffff88040daebee8] kthread at ffffffff8109e78e
 #16 [ffff88040daebf48] kernel_thread at ffffffff8100c28a
    
Reported-by: Ashok Ramu <ashok.ramu@actifio.com>
Reported-by: Boris Protopopov <boris.protopopov@actifio.com>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6818 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-01 17:39:37 +00:00
Vladislav Bolkhovitin
ca246c4a50 scst: Follow up for r6804
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6817 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-02-24 01:47:02 +00:00
Vladislav Bolkhovitin
dd3f46fd28 stpgd: Fix compilation in perf mode
Reported-by: TomK <tk@mdevsys.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6815 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-02-24 01:01:54 +00:00
Vladislav Bolkhovitin
97c5259476 Revert r6813 in (experimental) attempt to stay SPC complying
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6814 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-02-23 04:34:24 +00:00
Bart Van Assche
f27b1f9cc3 scst_tg: Restore Linux and ESXi interoperability
Linux and ESXi expect that target ports in one of the ALUA states
standby or unavailable are able to process commands like TEST UNIT
READY, READ CAPACITY, RESERVE and RELEASE. This patch partially
reverts r6802.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6813 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-02-22 04:13:53 +00:00
Vladislav Bolkhovitin
f029978199 scst: fix potential buffer overflow + cleanup
Reported-by: Bart Van Assche <bart.vanassche@sandisk.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6812 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-02-19 03:35:26 +00:00
Vladislav Bolkhovitin
a1b613af75 iscsi-scst: clarify comment
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6811 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-02-19 03:12:53 +00:00
Bart Van Assche
7a58722e73 scst_vdisk: Rate-limit block I/O error messages
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6810 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-02-18 22:18:08 +00:00
Vladislav Bolkhovitin
69834314b6 web: Gentoo HOWTO update
Suggested by calypso2k@poczta.fm



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6809 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-02-18 03:29:33 +00:00