Bart Van Assche
a25f11b67e
Merge branch 'svn-trunk' into master
2020-10-04 16:40:49 -07:00
Bart Van Assche
1b2bdd56b5
nightly build: Update kernel versions
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9170 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-10-02 02:35:39 +00:00
Bart Van Assche
d5a4e31b51
Merge branch 'svn-trunk' into master
2020-09-26 17:08:46 -07:00
Vladislav Bolkhovitin
de7a490d4a
Minor web fix
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9169 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-23 19:38:11 +00:00
Bart Van Assche
adfc655139
Merge branch 'svn-trunk' into master
2020-09-19 10:01:38 -07:00
Bart Van Assche
59f38038ab
iscsi-scst: Remove an obsolete comment
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9168 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-19 17:01:31 +00:00
Bart Van Assche
98789dce86
Merge branch 'svn-trunk' into master
2020-09-19 09:28:13 -07:00
Bart Van Assche
741d1d38dc
scst: Partially revert r9166
...
Apparently the RHEL 8.2 gcc compiler reports an error if
__attribute__((fallthrough)) is used outside a switch statement. Hence this
patch that converts some of these annotations back into comments.
Reported-by: Rob Turk <robtu@rtist.nl >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9167 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-19 00:28:44 +00:00
Bart Van Assche
8768de190e
Merge branch 'svn-trunk' into master
2020-09-16 10:21:33 -07:00
Bart Van Assche
186798cec4
Use the fallthrough macro instead of a comment
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9166 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-16 14:28:36 +00:00
Bart Van Assche
570a36ffd2
scripts/checkpatch: Only analyze kernel source code
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9165 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-16 14:27:44 +00:00
Bart Van Assche
86f7a85268
Merge branch 'svn-trunk' into master
2020-09-15 20:02:48 -07:00
Bart Van Assche
5969e85967
nightly build: Update kernel versions
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9164 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-16 03:02:36 +00:00
Bart Van Assche
5cb5aed0aa
Merge branch 'svn-trunk' into master
2020-09-15 20:00:03 -07:00
Bart Van Assche
4933f27d8d
scst: Make scst/include/backport.h again compatible with MOFED
...
Fix the following build failure on RHEL 7 + MOFED 5.0:
In file included from <command-line>:0:0:
/usr/src/ofa_kernel/default/include/linux/compat-2.6.h:40:29: warning: "__GCC4_has_attribute___fallthrough__" is not defined [-Wundef]
# define __has_attribute(x) __GCC4_has_attribute_##x
^
/usr/src/packages/BUILD/scst-3.5.0.7946/iscsi-scst/kernel/isert-scst/../../../scst/include/backport.h:250:5: note: in expansion of macro '__has_attribute'
#if __has_attribute(__fallthrough__)
Reported-by: Chesnokov Gleb <Chesnokov.G@raidix.com >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9163 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-16 02:59:28 +00:00
Bart Van Assche
10c5f1d332
Merge branch 'svn-trunk' into master
2020-09-14 20:47:47 -07:00
Bart Van Assche
443c7ec5d9
scstadmin: Make argument checking more systematic
...
Additionally, suppress warning messages about 'length(undefined)' on RHEL 6.x.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9162 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-15 03:47:40 +00:00
Bart Van Assche
9d9ae0f153
scst: Restore compatibility with gcc 4.x (RHEL 7.x)
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9161 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-15 03:44:03 +00:00
Bart Van Assche
85fed6fa4a
scst: Restore compatibility with RHEL 6.x
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9160 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-15 03:43:05 +00:00
Bart Van Assche
dbeb45d02a
Merge branch 'svn-trunk' into master
2020-09-14 19:45:36 -07:00
Bart Van Assche
4023bdadbd
scstadmin: Fix a Perl warning
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9159 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-14 18:00:55 +00:00
Bart Van Assche
15ca9935fd
Merge branch 'svn-trunk' into master
2020-09-13 19:14:20 -07:00
Bart Van Assche
6d60231631
scstadmin: Support passing an empty string to set*Attribute()
...
Validate the $value argument of set functions with defined() instead of
length(). Append a newline to the end of $value before writing it into
a sysfs attribute to make sure something gets written if $value eq "".
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9158 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-14 01:56:26 +00:00
Bart Van Assche
7e3fe7a80e
scstadmin: Fix the readOnly() subroutine
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9157 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-14 01:54:26 +00:00
Bart Van Assche
c121a6ded8
scstadmin: Adjust source code formatting
...
Remove a single space that follows a unary negation operator.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9156 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-14 01:53:27 +00:00
Bart Van Assche
db842294dc
Merge branch 'svn-trunk' into master
2020-09-13 16:30:15 -07:00
Bart Van Assche
7e012f4a80
scstadmin: Improve error reporting
...
Report "Failed to set a SCST attribute" instead of "SCST attribute specified
is static" if modifying of an attribute fails.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9155 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-13 23:29:44 +00:00
Bart Van Assche
40152cbac4
Merge branch 'svn-trunk' into master
2020-09-13 16:19:40 -07:00
Bart Van Assche
3825bf2093
scstadmin Makefile: Show diff if a regression test fails
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9154 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-13 22:42:19 +00:00
Bart Van Assche
8e387c4d6b
Merge branch 'svn-trunk' into master
2020-09-13 15:16:10 -07:00
Bart Van Assche
95993cd9fd
scstadmin/scstadmin.sysfs/scst-1.0.0/t/07-scstadmin-args.t: Filter out ib_srpt
...
The scstadmin output for the ib_srpt driver depends on whether or not an
RDMA HCA is present and also on the port GUIDs. Hence filter out the
ib_srpt data.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9153 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-13 22:16:05 +00:00
Bart Van Assche
b99156e013
Merge branch 'svn-trunk' into master
2020-09-12 20:24:41 -07:00
Bart Van Assche
8d3c1cf3a2
scstadmin: Use length($var) to test whether an argument has been specified
...
This patch fixes a bug by making it again possible to use "0" as e.g. the
name of an SCST device group. See also commit 858f50e4d3 ("scstadmin:
Improve robustness").
Reported-by: Pavel Klevtsov
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9152 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-13 03:20:47 +00:00
Bart Van Assche
a3266ca8f2
scstadmin: Remove support for the "new" sysfs interface
...
Around 2011 a sysfs-tree-changes branch was created in the SourceForge
repository because Greg KH asked to rework the SCST sysfs interface. That
interface is called the "new" sysfs interface. The current and only used
API is called the "old" sysfs interface. Since the "new" sysfs interface
never had any users other than myself, remove support for that interface.
See also commit a66cbc4115 ("scstadmin: Add support for the sysfs
interface provided by the code on the sysfs-tree-changes branch").
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9151 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-13 03:12:26 +00:00
Bart Van Assche
b1d6e4c92e
Merge branch 'svn-trunk' into master
2020-09-04 21:22:06 -07:00
Bart Van Assche
ad546b1e68
scst: Add support for wildcard matching to the copy manager
...
Reported-by: L <514005989@qq.com >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9150 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-05 04:21:56 +00:00
Bart Van Assche
15a463c052
Merge branch 'svn-trunk' into master
2020-08-29 14:19:50 -07:00
Bart Van Assche
bd3aa5d4a5
iscsi-scst: Port to Linux kernel v5.9
...
In Linux kernel v5.9 use of the KERNEL_SOCKPTR() function is mandatory
when calling setsockopt(). Implement that function for kernels before v5.9.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9149 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-29 21:16:47 +00:00
Bart Van Assche
2548b749ac
Merge branch 'svn-trunk' into master
2020-08-29 09:11:47 -07:00
Bart Van Assche
10ede52dd9
nightly build: Update kernel versions
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9148 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-29 16:11:39 +00:00
Bart Van Assche
ac08491d6a
scst/include/backport.h: Backport the fallthrough macro
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9147 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-29 16:11:31 +00:00
Bart Van Assche
86b03322a2
Merge branch 'svn-trunk' into master
2020-08-29 09:07:07 -07:00
Bart Van Assche
bb63af5901
qla2xxx: Fix wrong return value in qla_nvme_register_hba()
...
On an error exit path, a negative error code should be returned instead of
a positive return value.
Link: https://lore.kernel.org/r/20200802111530.5020-1-tianjia.zhang@linux.alibaba.com
Fixes: 8777e4314d39 ("scsi: qla2xxx: Migrate NVME N2N handling into state machine")
Cc: Quinn Tran <quinn.tran@cavium.com >
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
See also upstream commit ca4fb89a3d714a770e9c73c649da830f3f4a5326.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9146 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-29 16:04:14 +00:00
Bart Van Assche
d3c5f58492
qla2x00t-32gbit: Fix wrong return value in qlt_chk_unresolv_exchg()
...
In the case of a failed retry, a positive value EIO is returned here. I
think this is a typo error. It is necessary to return an error value.
[mkp: caller checks != 0 but the rest of the file uses -Exxx so fix this up
to be consistent]
Link: https://lore.kernel.org/r/20200802111528.4974-1-tianjia.zhang@linux.alibaba.com
Fixes: 0691094ff3f2 ("scsi: qla2xxx: Add logic to detect ABTS hang and response completion")
Cc: Quinn Tran <quinn.tran@cavium.com >
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
See also upstream commit bbf2d06a9d767718bfe6028d6288c03edb98554a.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9145 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-29 16:03:37 +00:00
Bart Van Assche
75687c6513
qla2x00t-32gbit: Remove redundant variable initialization
...
The initialization value of `rc` is wrong. It is unnecessary to initialize
`rc` variables, so remove its initialization operation.
Link: https://lore.kernel.org/r/20200802111527.4928-1-tianjia.zhang@linux.alibaba.com
Fixes: 84905dfe78d2 ("scsi: qla2xxx: Fix TMF and Multi-Queue config")
Cc: Quinn Tran <quinn.tran@cavium.com >
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
See also upstream commit 8905cbdae986515c5a4dcd71889672235478f189.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9144 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-29 16:02:48 +00:00
Bart Van Assche
735be2120c
qla2x00t-32gbit: Fix the size used in a 'dma_free_coherent()' call
...
Update the size used in 'dma_free_coherent()' in order to match the one
used in the corresponding 'dma_alloc_coherent()'.
[mkp: removed memset() hunk that has already been addressed]
Link: https://lore.kernel.org/r/20200802110721.677707-1-christophe.jaillet@wanadoo.fr
Fixes: 4161cee52df8 ("[SCSI] qla4xxx: Add host statistics support")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
See also upstream commit 650b323c8e7c3ac4830a20895b1d444fd68dd787.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9143 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-29 16:02:06 +00:00
Bart Van Assche
9b6e29baff
qla2x00t-32gbit: Remove pci-dma-compat wrapper API
...
Link: https://lore.kernel.org/r/24627a86cf1e67fd229bc323316523d1ba0811f9.1596045683.git.usuraj35@gmail.com
Signed-off-by: Suraj Upadhyay <usuraj35@gmail.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
See also upstream commit 8d1f1ffaeb27ca81ea0dd24e238015efee7b5924.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9142 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-29 16:01:22 +00:00
Bart Van Assche
22ca3580da
qla2x00t-32gbit: Remove superfluous memset()
...
Fixes coccicheck warning:
./drivers/scsi/qla2xxx/qla_mbx.c:4928:15-33: WARNING: dma_alloc_coherent use in els_cmd_map already zeroes out memory, so memset is not needed
dma_alloc_coherent() already zeroes out memory so memset() is not needed.
Link: https://lore.kernel.org/r/1596079918-41115-3-git-send-email-liheng40@huawei.com
Signed-off-by: Li Heng <liheng40@huawei.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
See also upstream commit bef93fbfcf4ae9ecaa50e38d32cf6b8dbce4a797.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9141 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-29 16:00:15 +00:00
Bart Van Assche
f872ffa8a9
iscsi-scst/kernel/isert-scst/Kbuild: Fix the isert-scst build
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9140 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-29 15:52:09 +00:00
Bart Van Assche
d923eed64b
qla2x00t-32gbit: Use fallthrough pseudo keyword
...
Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.
[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org >
See also upstream commit dca93232b361d260413933903cd4bdbd92ebcc7f.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9139 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-29 15:47:45 +00:00