4036 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Yan Burman	bb7f5caef2	Merged revisions 5875,5878-5895,5903-5905,5910,5912-5914,5928-5929,5931-5991 via svnmerge from ... svn+ssh://yanb123@svn.code.sf.net/p/scst/svn/trunk ........ r5875 | bvassche | 2014-11-16 19:58:07 +0200 (Sun, 16 Nov 2014) | 1 line nightly build: Update kernel versions ........ r5878 | bvassche | 2014-11-19 02:17:41 +0200 (Wed, 19 Nov 2014) | 1 line srpt/Makefile: Add double quotes around a path ........ r5879 | bvassche | 2014-11-19 02:20:20 +0200 (Wed, 19 Nov 2014) | 1 line scripts/generate-release-archive: Accept an optional list of file names ........ r5880 | bvassche | 2014-11-22 13:12:29 +0200 (Sat, 22 Nov 2014) | 1 line nightly build: Update kernel versions ........ r5881 | bvassche | 2014-11-24 19:59:14 +0200 (Mon, 24 Nov 2014) | 4 lines ib_srpt: Add support for HCA's that do not support SRQ Based on a patch provided by Parav Pandit <Parav.Pandit@Emulex.Com> ........ r5882 | vlnb | 2014-11-26 09:02:17 +0200 (Wed, 26 Nov 2014) | 3 lines Update for kernels 3.17.x ........ r5883 | bvassche | 2014-11-26 10:05:09 +0200 (Wed, 26 Nov 2014) | 1 line Add kernel 3.17 build infrastructure ........ r5884 | bvassche | 2014-11-26 10:07:08 +0200 (Wed, 26 Nov 2014) | 1 line nightly build: Add kernel 3.17 ........ r5885 | bvassche | 2014-11-26 10:16:44 +0200 (Wed, 26 Nov 2014) | 6 lines Fix kernel 3.17 checkpatch warnings about 'long long unsigned' Avoid that checkpatch reports the following warning: WARNING: type 'long long unsigned' should be specified in 'unsigned long long' order. ........ r5886 | bvassche | 2014-11-26 15:38:52 +0200 (Wed, 26 Nov 2014) | 1 line Build fixes for RHEL 6.6 kernel 2.6.32-504 ........ r5887 | bvassche | 2014-11-26 16:39:51 +0200 (Wed, 26 Nov 2014) | 1 line ib_srpt: Make the send queue full messages more informational ........ r5888 | bvassche | 2014-11-26 18:25:57 +0200 (Wed, 26 Nov 2014) | 1 line scripts/specialize-patch: Support blanks around numbers inside parentheses ........ r5889 | bvassche | 2014-11-26 21:42:10 +0200 (Wed, 26 Nov 2014) | 1 line scripts/specialize-patch: Reduce noise in nightly build output ........ r5890 | vlnb | 2014-11-27 06:36:33 +0200 (Thu, 27 Nov 2014) | 3 lines Cleanup ........ r5891 | bvassche | 2014-11-27 17:18:58 +0200 (Thu, 27 Nov 2014) | 1 line scst.h: Add uintptr_t ........ r5892 | bvassche | 2014-11-27 17:19:21 +0200 (Thu, 27 Nov 2014) | 1 line ib_srpt: Add support for immediate data ........ r5893 | bvassche | 2014-11-27 17:24:17 +0200 (Thu, 27 Nov 2014) | 1 line ib_srpt: Log reject reason ........ r5894 | bvassche | 2014-11-27 17:29:29 +0200 (Thu, 27 Nov 2014) | 1 line ib_srpt: Rework the max_sge computation changes from r5795 ........ r5895 | bvassche | 2014-11-28 11:16:37 +0200 (Fri, 28 Nov 2014) | 1 line scst: Add scripts/rebuild-rhel-kernel-rpm to the SCST release archive ........ r5903 | bvassche | 2014-12-03 13:50:06 +0200 (Wed, 03 Dec 2014) | 4 lines scripts/rebuild-rhel-kernel-rpm: Fix an error message Reported-by: Hiroyuki Sato <hiroysato@gmail.com> ........ r5904 | bvassche | 2014-12-03 19:06:57 +0200 (Wed, 03 Dec 2014) | 1 line iscsi-scst/kernel/patches/rhel/put_page_callback-2.6.32-504.patch: Add ........ r5905 | bvassche | 2014-12-03 19:07:31 +0200 (Wed, 03 Dec 2014) | 1 line scripts/rebuild-rhel-kernel-rpm: Add support for RHEL 6.6 ........ r5910 | bvassche | 2014-12-04 13:50:58 +0200 (Thu, 04 Dec 2014) | 1 line scripts/generate-kernel-patch: Swap two filters ........ r5912 | bvassche | 2014-12-04 14:19:56 +0200 (Thu, 04 Dec 2014) | 4 lines /etc/init.d/scst: Exit with status code 0 upon 'start' if already running Reported-by: Dimitar Tanev <dimitar@linuxdevgroup.org> ........ r5913 | vlnb | 2014-12-05 01:41:52 +0200 (Fri, 05 Dec 2014) | 3 lines FORMAT commands should be strictly serialized ........ r5914 | vlnb | 2014-12-05 01:43:51 +0200 (Fri, 05 Dec 2014) | 3 lines Oops, fix for the previous commit ........ r5928 | vlnb | 2014-12-06 07:02:27 +0200 (Sat, 06 Dec 2014) | 3 lines Web updates ........ r5929 | bvassche | 2014-12-09 14:33:16 +0200 (Tue, 09 Dec 2014) | 1 line rpm build: Add support for qla2x00t driver in QLogic git repository ........ r5931 | vlnb | 2014-12-11 06:27:17 +0200 (Thu, 11 Dec 2014) | 3 lines Docs update ........ r5932 | vlnb | 2014-12-11 06:34:36 +0200 (Thu, 11 Dec 2014) | 8 lines scst_vdisk: Increase virtual device name length This change makes integration with OpenStack easier since OpenStack GUIDs are 36 characters long: 32 hex characters and four dashes. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5933 | vlnb | 2014-12-11 06:38:04 +0200 (Thu, 11 Dec 2014) | 11 lines vdisk_blockio: Report invalid scatterlists It is possible for a target driver to pass a scatterlist via scst_cmd_set_tgt_sg() that is valid for the vdisk_fileio handler but not for the vdisk_blockio handler. Complain loudly if an invalid scatterlist is passed to vdisk_blockio because such scatterlists cause silent data corruption with most Linux block drivers. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5934 | bvassche | 2014-12-11 14:31:03 +0200 (Thu, 11 Dec 2014) | 1 line scst_vdisk: Follow-up for r5932 ........ r5935 | bvassche | 2014-12-11 14:37:02 +0200 (Thu, 11 Dec 2014) | 1 line ib_srpt: Log P_Key during login ........ r5936 | bvassche | 2014-12-12 11:29:42 +0200 (Fri, 12 Dec 2014) | 1 line scripts/generate-kernel-patch: Include scst_pg.sgml instead of sgv_cache.sgml ........ r5937 | bvassche | 2014-12-12 11:34:55 +0200 (Fri, 12 Dec 2014) | 1 line doc/scst_pg.sgml: Remove trailing whitespace ........ r5938 | bvassche | 2014-12-17 09:48:40 +0200 (Wed, 17 Dec 2014) | 1 line nightly build: Update kernel versions ........ r5939 | vlnb | 2014-12-19 05:50:58 +0200 (Fri, 19 Dec 2014) | 3 lines Fallback to the old qla driver if the git one not detected ........ r5940 | vlnb | 2014-12-19 05:55:14 +0200 (Fri, 19 Dec 2014) | 7 lines Replace in cases, where sporadic failures are possible, HARDWARE ERROR by INTERNAL TARGET FAILURE, which is retriable (some OS'es don't retry HARDWARE ERROR) Reported and suggested by Shahar Salzman <shahar.salzman@kaminario.com> ........ r5941 | vlnb | 2014-12-20 05:48:07 +0200 (Sat, 20 Dec 2014) | 7 lines scst_vdisk: Only accept NAA IDs allowed by SPC See also paragraph 7.8.6.6 NAA designator format in SPC-4. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5942 | vlnb | 2014-12-20 05:49:23 +0200 (Sat, 20 Dec 2014) | 11 lines scst_vdisk: Remove superfluous llseek() calls vfs_read() and vfs_write() ignore the file offset set by llseek(). Hence remove the llseek() calls that occur just before vfs_read() and vfs_write(). See also the implementation in the Linux kernel of the pread64() and pwrite64() system calls for examples of code that uses vfs_read() and vfs_write(). Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5943 | bvassche | 2014-12-22 14:28:13 +0200 (Mon, 22 Dec 2014) | 1 line Source code spelling fix: Equivilant -> Equivalent ........ r5944 | bvassche | 2014-12-22 14:28:56 +0200 (Mon, 22 Dec 2014) | 1 line Source code spelling fix: accesss -> access ........ r5945 | bvassche | 2014-12-22 14:29:51 +0200 (Mon, 22 Dec 2014) | 1 line Source code spelling fix: addres -> address ........ r5946 | bvassche | 2014-12-22 14:31:08 +0200 (Mon, 22 Dec 2014) | 1 line Source code spelling fix: authentification -> authentication ........ r5947 | bvassche | 2014-12-22 14:32:30 +0200 (Mon, 22 Dec 2014) | 1 line Source code comment spelling fix: explicitely -> explicitly ........ r5948 | bvassche | 2014-12-22 14:33:06 +0200 (Mon, 22 Dec 2014) | 1 line Source code comment spelling fix: hander -> handler ........ r5949 | bvassche | 2014-12-22 14:33:37 +0200 (Mon, 22 Dec 2014) | 1 line Source code comment spelling fix: loosing -> losing ........ r5950 | bvassche | 2014-12-22 14:35:00 +0200 (Mon, 22 Dec 2014) | 1 line Spelling fix: occured -> occurred ........ r5951 | bvassche | 2014-12-22 14:35:51 +0200 (Mon, 22 Dec 2014) | 1 line Source code comment spelling fix: refering -> referring ........ r5952 | bvassche | 2014-12-22 14:36:47 +0200 (Mon, 22 Dec 2014) | 1 line Spelling fix: shrinked -> shrunk ........ r5953 | bvassche | 2014-12-22 15:08:34 +0200 (Mon, 22 Dec 2014) | 1 line Spelling fix: choosen -> chosen ........ r5954 | bvassche | 2014-12-22 15:09:20 +0200 (Mon, 22 Dec 2014) | 1 line Spelling fix: existant -> existent ........ r5955 | bvassche | 2014-12-22 15:10:41 +0200 (Mon, 22 Dec 2014) | 1 line Update for kernel 3.18 ........ r5956 | bvassche | 2014-12-22 15:15:55 +0200 (Mon, 22 Dec 2014) | 1 line Spelling fix: immediatelly -> immediately ........ r5957 | bvassche | 2014-12-24 16:28:36 +0200 (Wed, 24 Dec 2014) | 1 line nightly build: Add kernel 3.18 ........ r5958 | bvassche | 2014-12-29 14:14:52 +0200 (Mon, 29 Dec 2014) | 1 line scst_lib: Convert spaces into tabs (reported by checkpatch) ........ r5959 | bvassche | 2015-01-06 15:25:28 +0200 (Tue, 06 Jan 2015) | 1 line scst_calc_block_shift: Log block shift and sector size upon mismatch ........ r5960 | bvassche | 2015-01-07 11:20:06 +0200 (Wed, 07 Jan 2015) | 4 lines scst_local: Fix unique per session sas address Signed-off-by: Sebastian Herbszt <herbszt@gmx.de> ........ r5961 | bvassche | 2015-01-09 14:23:25 +0200 (Fri, 09 Jan 2015) | 4 lines scst_sysfs: return EINVAL on too big LUN Signed-off-by: Sebastian Herbszt <herbszt@gmx.de> ........ r5962 | bvassche | 2015-01-10 17:52:57 +0200 (Sat, 10 Jan 2015) | 1 line nightly build: Update kernel versions ........ r5963 | bvassche | 2015-01-13 10:42:28 +0200 (Tue, 13 Jan 2015) | 10 lines scst: Switch to thread context before executing a reservation command Persistent reservation commands need thread context because scst_pr_is_cmd_allowed() locks the PR mutex. Reservation commands either need BH or thread context. Hence switch from atomic to thread context before processing such commands. Reported-by: Shahar Salzman <shahar.salzman@kaminario.com> Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5964 | bvassche | 2015-01-13 10:51:08 +0200 (Tue, 13 Jan 2015) | 5 lines scst_parse_unmap_descriptors(): Avoid using GFP_KERNEL in atomic context Reported-by: Shahar Salzman <shahar.salzman@kaminario.com> Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5965 | bvassche | 2015-01-13 10:55:46 +0200 (Tue, 13 Jan 2015) | 68 lines qla2x00t: Copy entire SCST sense buffer to q2x ctio There seems to be a bug in passing sense information to QLA HBAs, where the last 2 bytes of the sense data (ASC, ASCQ) are not copied to the low level sense buffer. We encountered this in ESX, which relies on these 2 bytes to parse the MISCOMPARE sense code (0xE1, 0x1D, 0x00). Bellow is a simple test to recreate this issue, but during vMotion operations (where VMs are moved from one host to another), this may cause the operation to fail leaving the VM in an inconsistent state. The test I ran to verify that we are indeed missing the bytes is the following: 1. Create a SCST based device 2. Expose the device to 2 ESX hosts 3. Format the device as VMFS5, create a test directory 4. From both hosts, I start writing to this directory (no VMs involved, just write normal files) At this stage, both ESX hosts try to take access to the directory. The VMFS filesystem contains a per-directory lock which is managed by COMPARE AND WRITE command. Each ESX will attempt to change the VMFS lock location from unlocked to locked to create the new file. Obviously there are bound to be failures (which are equivalent to programming locking conflicts), these are reported by the MISCOMPARE sense code. Upon these MISCOMPARE errors, the host will re-try taking the lock until it succeeds, and will then proceed to perform the write operation on the directory. Due to the bug in copying the sense buffer from the SCST core to the QLA ctio, instead of the full sense code, only the key (0xE) is sent, and ESX does not know how to handle it resulting in IO error. Here are the errors as they appear on the command line: /vmfs/volumes/54a297c4-ca5af1cc-7f94-002219d20f28/ats_test # ./open_close_test-esx2.sh ./open_close_test-esx2.sh: line 8: can't create ats_fileoptest-esx2_1.txt: Input/output error ./open_close_test-esx2.sh: line 8: can't create ats_fileoptest-esx2_21.txt: Input/output error ./open_close_test-esx2.sh: line 8: can't create ats_fileoptest-esx2_110.txt: Input/output error ./open_close_test-esx2.sh: line 8: can't create ats_fileoptest-esx2_111.txt: Input/output error In the /var/log/vmkernel.log, we can see that the sense information is missing (0xE, 0x0, 0x0) instead of (0xE, 0x1D, 0x0). 2014-12-30T12:13:20.714Z cpu6:33519)ScsiDeviceIO: 2338: Cmd(0x412e84f957c0) 0x89, CmdSN 0x234d from world 519051 to dev "eui.0024f400d5020007" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0xe 0x0 0x0. 2014-12-30T12:13:20.766Z cpu6:33519)ScsiDeviceIO: 2338: Cmd(0x412e84f91d00) 0x89, CmdSN 0x2350 from world 519051 to dev "eui.0024f400d5020007" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0xe 0x0 0x0. 2014-12-30T12:13:20.766Z cpu6:33519)ScsiDeviceIO: 2338: Cmd(0x412e80449fc0) 0x89, CmdSN 0x234f from world 519051 to dev "eui.0024f400d5020007" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0xe 0x0 0x0. This patch fixes this issue, the test will run without a problem with the fix (no IO errors, all the files are properly written to the directory). Signed-off-by: Shahar Salzman <shahar.salzman@kaminario.com> Reviewed-by: Eran Mann <eran.mann@kaminario.com> [bvanassche: simplified implementation] Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5966 | bvassche | 2015-01-13 11:38:09 +0200 (Tue, 13 Jan 2015) | 5 lines qla2x00t: Register for RSCNs in target mode The QLogic firmware and qla2xxx do not register for RSCNs in target-only mode, so do that explicitly. ........ r5967 | bvassche | 2015-01-14 10:06:12 +0200 (Wed, 14 Jan 2015) | 1 line scst_targ: Use tabs instead of spaces for indentation (detected by checkpatch) ........ r5968 | bvassche | 2015-01-15 10:58:39 +0200 (Thu, 15 Jan 2015) | 4 lines scst_targ: Avoid triggering a kernel panic if dev_user_parse() returns SCST_CMD_STATE_STOP Reported-by: Ilan Steinberg <ilan.steinberg@kaminario.com> ........ r5969 | vlnb | 2015-01-16 03:21:10 +0200 (Fri, 16 Jan 2015) | 3 lines Fix READ BUFFER and WRITE BUFFER commands ........ r5970 | vlnb | 2015-01-16 05:16:26 +0200 (Fri, 16 Jan 2015) | 3 lines Follow up for r5968 ........ r5971 | vlnb | 2015-01-16 05:53:29 +0200 (Fri, 16 Jan 2015) | 5 lines Report during user devices unjam LUN NOT SUPPORTED sense Reported-By: shahar.salzman <shahar.salzman@kaminario.com> ........ r5972 | bvassche | 2015-01-16 15:01:58 +0200 (Fri, 16 Jan 2015) | 2 lines scst.spec.in: Rename variable kver into kversion ........ r5973 | bvassche | 2015-01-16 15:12:22 +0200 (Fri, 16 Jan 2015) | 2 lines scst.spec.in: Pass kernel version via RPM-variable %{kversion} instead of shell variable ${KVER} ........ r5974 | bvassche | 2015-01-16 15:16:06 +0200 (Fri, 16 Jan 2015) | 6 lines scst.spec.in: Determine version number correctly on a koji server This patch has been tested on a koji build server and also on four different RPM-based distributions (CentOS 7, Fedora 20, openSuSE 13.2 and SLES 11 SP3). ........ r5975 | bvassche | 2015-01-16 18:12:38 +0200 (Fri, 16 Jan 2015) | 1 line scst.spec.in: Leave out kernel version from RPM name ........ r5976 | bvassche | 2015-01-16 18:20:10 +0200 (Fri, 16 Jan 2015) | 1 line scst.spec.in: Add DKMS support ........ r5977 | vlnb | 2015-01-20 06:18:07 +0200 (Tue, 20 Jan 2015) | 3 lines Revert r5964 as not needed ........ r5978 | vlnb | 2015-01-20 06:20:13 +0200 (Tue, 20 Jan 2015) | 3 lines Revert r5963 as not needed ........ r5979 | bvassche | 2015-01-20 17:04:23 +0200 (Tue, 20 Jan 2015) | 13 lines scst: Rework SCSI pass-through support for kernel versions >= 2.6.30 Changes in this patch: - Rework the SCSI pass-through code such that for kernel versions >= 2.6.30 the scst_exec_req_fifo patch is no longer needed. - Modify the pass-through code such that blk_rq_append_bio() is only called for kernel version 2.6.30. For later kernel versions blk_make_request() is called instead. - Rework scst_scsi_exec_async(). - Add debug tracing of SCSI pass-through result status. - Add a lockdep_assert_held() call in scsi_end_async(). ........ r5980 | bvassche | 2015-01-20 19:13:13 +0200 (Tue, 20 Jan 2015) | 1 line nightly build: Update kernel versions ........ r5981 | vlnb | 2015-01-21 06:15:42 +0200 (Wed, 21 Jan 2015) | 3 lines Follow up for r5979 ........ r5982 | vlnb | 2015-01-21 06:20:53 +0200 (Wed, 21 Jan 2015) | 5 lines Fix returning changeable values for caching mode page Reported by Consus <consus@gmx.com> ........ r5983 | bvassche | 2015-01-21 15:11:56 +0200 (Wed, 21 Jan 2015) | 1 line scst.h: Fix a sparse warning for kernels 2.6.29..2.6.31 ........ r5984 | vlnb | 2015-01-22 07:03:17 +0200 (Thu, 22 Jan 2015) | 9 lines [PATCH] scst_local: Fix bidirectional command support scsi_setup_cmnd() sets sc_data_direction to DMA_TO_DEVICE for bidirectional commands. Hence test SCpnt->request->next_rq instead of sc_data_direction to figure out whether or not a command is bidirectional. Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> ........ r5985 | vlnb | 2015-01-22 07:06:45 +0200 (Thu, 22 Jan 2015) | 12 lines [PATCH] scst_main: Suppress a checkpatch warning triggered by INIT_CACHEP{,_ALIGN} Avoid that checkpatch v3.18 reports the following warning for these two macros: WARNING: Macros with flow control statements should be avoided This patch does not change any functionality. Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> ........ r5986 | vlnb | 2015-01-22 07:09:17 +0200 (Thu, 22 Jan 2015) | 9 lines scst_vdisk: Micro-optimize vdisk_caching_pg This patch does not change any behavior but micro-optimizes vdisk_caching_pg(). Declaring the array caching_pg[] const reduces 11 bytes from the assembler code of this function. Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> ........ r5987 | vlnb | 2015-01-22 07:10:42 +0200 (Thu, 22 Jan 2015) | 10 lines scst: Suppress a smatch warning in vdisk_unmap_range() Avoid that the static source code analysis tool 'smatch' reports the following warning: vdisk_unmap_range() warn: should 'blocks << cmd->dev->block_shift' be a 64 bit type? Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> ........ r5988 | vlnb | 2015-01-22 07:13:59 +0200 (Thu, 22 Jan 2015) | 27 lines scst_vdisk: Fix zero-copy read for tmpfs For some filesystems, e.g. tmpfs, address_space.readpage is NULL. Disable zero-copy reading for such filesystems. See also shmem_aops in mm/shmem.c. See also inode_init_always() and empty_aops in fs/inode.c. This patch avoids that the following call trace is triggered: BUG: unable to handle kernel NULL pointer dereference at (null) Call Trace: [<ffffffffa0547d66>] prepare_read+0x106/0x1d0 [scst_vdisk] [<ffffffffa0547f20>] fileio_alloc_data_buf+0xf0/0x330 [scst_vdisk] [<ffffffffa046fc9b>] scst_prepare_space+0x9b/0x6e0 [scst] [<ffffffffa047d4d5>] scst_process_active_cmd+0x545/0x840 [scst] [<ffffffffa047dad2>] scst_cmd_init_done+0x302/0x5d0 [scst] [<ffffffffa0563ab2>] scst_cmd_init_stage1_done.constprop.37+0x12/0x20 [iscsi_scst] [<ffffffffa056a9ea>] scsi_cmnd_start+0x25a/0x550 [iscsi_scst] [<ffffffffa056b4a8>] cmnd_rx_start+0x148/0x1a0 [iscsi_scst] [<ffffffffa056e4f8>] process_read_io+0x3b8/0x800 [iscsi_scst] [<ffffffffa056ea07>] scst_do_job_rd+0xc7/0x220 [iscsi_scst] [<ffffffffa056efed>] istrd+0x16d/0x2e0 [iscsi_scst] [<ffffffff81079efd>] kthread+0xed/0x110 [<ffffffff817227fc>] ret_from_fork+0x7c/0xb0 Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> ........ r5989 | vlnb | 2015-01-24 07:37:57 +0200 (Sat, 24 Jan 2015) | 5 lines scst_local: Rework data direction detection code Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> ........ r5990 | bvassche | 2015-01-26 13:32:32 +0200 (Mon, 26 Jan 2015) | 1 line ib_srpt: Detect Mellanox OFED 2.3 correctly ........ r5991 | vlnb | 2015-01-28 07:07:46 +0200 (Wed, 28 Jan 2015) | 3 lines Cleanups ........ git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5993 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2015-01-28 12:12:32 +00:00
Yan Burman	e6e1752b8f	isert: Do not crash kernel if userspace has a bug ... Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5901 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-11-30 08:17:29 +00:00
Yan Burman	5c1d9a4501	isert: Stop timer as soon as we so that in busy system we don't rely on userspace ... Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5900 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-11-30 08:17:24 +00:00
Yan Burman	03548dbc24	isert: Do not fail with cards that support small number of WR per QP ... This fixes an issue with ConnectIB Reported-by: Eric Millbrandt <eric.millbrandt@cacheio.com> Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5899 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-11-30 08:17:18 +00:00
Yan Burman	083634586a	isert: Document isert_nr_devs parameter ... Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5898 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-11-30 08:17:13 +00:00
Yan Burman	a105745c4c	isert: Make sure we don't call dma_unmap on memory we already unmapped ... Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5897 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-11-30 08:17:09 +00:00
Yan Burman	bd70a2eb27	isert: Fix race between disconnect handler and read by iscsi-scstd ... Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5896 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-11-30 08:17:02 +00:00
Yan Burman	1238c3e88c	isert: Add missing copyright notice ... Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5876 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-11-17 08:46:33 +00:00
Yan Burman	6c2a375768	Merged revisions 5833-5835,5844,5847-5856 via svnmerge from ... svn+ssh://yanb123@svn.code.sf.net/p/scst/svn/trunk ........ r5833 | bvassche | 2014-10-07 08:02:20 +0200 (Tue, 07 Oct 2014) | 1 line nightly build: Update kernel versions ........ r5834 | bvassche | 2014-10-10 18:36:24 +0200 (Fri, 10 Oct 2014) | 1 line nightly build: Update kernel versions ........ r5835 | bvassche | 2014-10-10 18:36:59 +0200 (Fri, 10 Oct 2014) | 1 line nightly build: Update kernel versions ........ r5844 | vlnb | 2014-10-17 04:13:17 +0200 (Fri, 17 Oct 2014) | 3 lines iSER web updates ........ r5847 | vlnb | 2014-10-17 04:22:23 +0200 (Fri, 17 Oct 2014) | 19 lines scst_vdisk: Remove a superfluous cast The 'iov_base' member of 'struct iovec' is declared in <uapi/linux/uio.h> with type 'void __user *'. Adding an integer to a void pointer has the same effect as adding an integer to a char pointer in the C language. This means that it is safe to remove the cast in front of the eiv->iov_base pointer. Please note that a similar construct already exists in the iSCSI target driver. From the nthread.c source file: iop->iov_base += rest; iop->iov_len -= rest; This patch does not change any functionality. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5848 | vlnb | 2014-10-17 04:24:07 +0200 (Fri, 17 Oct 2014) | 12 lines scst_vdisk: Reduce number of casts Since 'address' points at kernel space memory, change its type from uint8_t __user * into uint8_t *. This change reduces the number of casts between uint8_t __user * to uint8_t * in fileio_exec_write(). This patch does not change any functionality. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5849 | vlnb | 2014-10-17 04:30:12 +0200 (Fri, 17 Oct 2014) | 10 lines scst_vdisk, MODE SELECT(10): Interpret both bytes of the BLOCK DESCRIPTOR LENGTH field While the BLOCK DESCRIPTOR LENGTH field spans a single byte in the Mode parameter header(6), the size of this field in the Mode parameter header(10) is two bytes. Interpret both bytes while executing a MODE SELECT(10) command. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5850 | vlnb | 2014-10-17 04:32:28 +0200 (Fri, 17 Oct 2014) | 8 lines scst/README: Document the lun<X> sysfs attributes The sessions/<sess>/lun<X> sysfs attribute "active_commands" is not yet documented. Hence add documentation for that sysfs attribute. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5851 | vlnb | 2014-10-17 04:35:01 +0200 (Fri, 17 Oct 2014) | 12 lines scst, iscsi-scst: Add thread_pid attribute For SCST devices with a short name determining which SCST command threads serve a given LUN requires an (expensive) walk of the process table. For SCST devices with a long name it is not possible to determine unambiguously which command threads serve a given LUN. Hence add a thread_pid sysfs attribute that makes it easy to figure out which command threads serve a LUN. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5852 | bvassche | 2014-10-18 10:56:23 +0200 (Sat, 18 Oct 2014) | 5 lines iscsi-scst: Make iscsi_thread_pool locking more fine-grained Protect iscsi_thread_pool.threads_list via tp_mutex instead of scst_mutex. ........ r5853 | bvassche | 2014-10-24 09:12:39 +0200 (Fri, 24 Oct 2014) | 1 line nightly build: Update kernel versions ........ r5854 | bvassche | 2014-11-01 10:30:20 +0200 (Sat, 01 Nov 2014) | 1 line nightly build: Update kernel versions ........ r5855 | vlnb | 2014-11-15 03:44:06 +0200 (Sat, 15 Nov 2014) | 3 lines Ease severity of reporting unsupported REPORT LUNS SELECT REPORT value ........ r5856 | vlnb | 2014-11-15 03:55:27 +0200 (Sat, 15 Nov 2014) | 3 lines Report RX data digest failures by default ........ git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5873 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-11-16 13:51:38 +00:00
Yan Burman	a37e20d3c3	isert: Remove extra paranoid check ... Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5872 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-11-16 13:25:14 +00:00
Yan Burman	6b3d77bc37	isert: Fix page leak if alloc_page fails ... Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5871 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-11-16 13:25:01 +00:00
Yan Burman	28781d1545	isert: Fix potential overrun detected by coverity ... Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5870 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-11-16 13:24:50 +00:00
Yan Burman	091bc739a7	isert: Silence coverity false positive ... Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5869 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-11-16 13:24:38 +00:00
Yan Burman	9236ef4ef8	isert: Do not leak workqueues if ib_create_cq failed ... Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5868 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-11-16 13:24:27 +00:00
Yan Burman	7716502b38	isert: Document performance considerations for iSER ... Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5867 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-11-16 13:24:15 +00:00
Yan Burman	270559b509	isert: Fix use-after-free when killing iscsi-scstd ... Our portal may be destroyed while there are connections alive. This means we are doing list_del() from list_head that no longer exists Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5866 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-11-16 13:24:04 +00:00
Yan Burman	88339b14dd	isert: Remove unused field ... Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5865 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-11-16 13:23:54 +00:00
Yan Burman	06fc2591ae	isert: Fix crash on device removal when iscsi-scstd is started with explicit address ... Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5864 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-11-16 13:23:43 +00:00
Yan Burman	6a258d3629	isert: Make sure we decrement CQ QP counters if QP creation fails ... Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5863 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-11-16 13:23:31 +00:00
Yan Burman	f784590bb8	isert: Fix closing devices when connection allocation fails ... We need to dereference isert_device structures whether we created them or not if connection creation fails Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5862 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-11-16 13:23:20 +00:00
Yan Burman	348224a808	isert: Warn user of potential compilation issue ... Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5861 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-11-16 13:23:09 +00:00
Yan Burman	679f7487db	isert: Add support for rdma_cm private data as required by Annex A12 of the IB spec ... Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5860 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-11-16 13:22:58 +00:00
Yan Burman	2cfd09c8de	isert: Fix resource leak upon unreachable event ... Unreachable event caused by crash of initiator while in connection establishment flow, would cause leak of connections. Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5859 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-11-16 13:22:42 +00:00
Vladislav Bolkhovitin	9b679522d0	Docs cleanups and updates ... git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5845 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-10-17 02:16:08 +00:00
Yan Burman	6b38638e71	isert: Remove unneeded if in the fast path ... Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5842 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-10-13 12:33:30 +00:00
Yan Burman	dc27d29167	isert: Fix small memory leak on module unload ... We were leaking portal structure upon module unload Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5841 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-10-13 12:33:20 +00:00
Yan Burman	e15fe7a755	isert: Raise the number of concurrent login requests we can handle to 127 ... Also update documentation to reflect current limitations Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5840 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-10-13 12:33:07 +00:00
Yan Burman	c8c0246d54	isert: Micro-optimization: Use unlikely() macro in appropriate places ... Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5839 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-10-13 12:32:52 +00:00
Yan Burman	2277551e22	isert: Make sure we do dma_unmap on RDMA memory upon flushes ... Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5838 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-10-13 12:32:41 +00:00
Yan Burman	4a8e4c0af9	isert: Use req_cmnd_release_force for PDU errors ... Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5837 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-10-13 12:32:31 +00:00
Yan Burman	1b147726a6	isert: Fix a minor style issue ... Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5836 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-10-13 12:32:19 +00:00
Yan Burman	69104309ac	Merged revisions 5820-5821,5827,5829 via svnmerge from ... svn+ssh://yanb123@svn.code.sf.net/p/scst/svn/trunk ........ r5820 | bvassche | 2014-09-30 13:07:38 +0200 (Tue, 30 Sep 2014) | 4 lines scst_local: Restore support for detecting LUN 16383 via a sequential scan Reported-by: Sebastian Herbszt <herbszt@gmx.de> ........ r5821 | vlnb | 2014-10-02 05:19:10 +0200 (Thu, 02 Oct 2014) | 3 lines Small doc improvements ........ r5827 | bvassche | 2014-10-03 14:23:34 +0200 (Fri, 03 Oct 2014) | 1 line scripts/generate-kernel-patch: Only generate scst_itf_ver.h if needed ........ r5829 | bvassche | 2014-10-03 14:26:14 +0200 (Fri, 03 Oct 2014) | 20 lines scst_mem: Fix a memory leak triggered by the scst_user driver Avoid that the following memory leak can occur: - sgv_pool_alloc() is called with SGV_POOL_RETURN_OBJ_ON_ALLOC_FAIL set, with neither SGV_POOL_NO_ALLOC_ON_CACHE_MISS nor SGV_POOL_ALLOC_NO_CACHED set and with 'size' such that sgv_max_local_pages < pages_to_alloc <= pool->max_cached_pages. - sgv_get_obj() and sgv_alloc_arrays() succeed. - sgv_alloc_sg_entries() fails. - sgv_get_obj() returns the SGV object with no buffers. - A call to sgv_pool_free() adds this object to the recycle list. - sgv_pool_alloc() is called a second time with the same parameters. - sgv_get_obj() retrieves the object that was previously added to the recycle list. - sgv_alloc_arrays() is called and overwrites the obj->sg_entries pointer although it still points at allocated memory, resulting in a memory leak. Reported-by: Shahar Salzman <shahar.salzman@kaminario.com> ........ git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5832 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-10-05 06:12:59 +00:00
Yan Burman	f704a4afee	Merged revisions 5785-5786,5793-5796,5798,5801-5802,5804-5806,5808,5810-5811,5814,5816-5817 via svnmerge from ... svn+ssh://yanb123@svn.code.sf.net/p/scst/svn/trunk ........ r5785 | bvassche | 2014-09-09 14:09:20 +0300 (Tue, 09 Sep 2014) | 9 lines scst_local: Change max_lun into SCST_MAX_LUN (16383) Today SCST does not support LUN numbers >= 16384. Additionally, there is a bug in older Linux initiator systems that prevents proper handling of LUN numbers >= 2**32. See also Hannes Reinecke, scsi_scan: Fixup scsilun_to_int(), June 25, 2014 (commit ID d9e5d6183715e691b37afd3785c311d05cd1338d). Hence set max_lun to 16383. ........ r5786 | bvassche | 2014-09-09 14:27:27 +0300 (Tue, 09 Sep 2014) | 6 lines scst_local: Set max_id to 1 The value 0 is not valid for the max_id member of struct Scsi_Host. Signed-off-by: Sebastian Herbszt <herbszt@gmx.de> ........ r5793 | bvassche | 2014-09-10 14:42:54 +0300 (Wed, 10 Sep 2014) | 1 line scstadmin: Sync saved configuration files ........ r5794 | bvassche | 2014-09-10 14:44:14 +0300 (Wed, 10 Sep 2014) | 2 lines scstadmin test 06-cont-on-err.t: Filter out scstadmin version number ........ r5795 | bvassche | 2014-09-10 15:18:09 +0300 (Wed, 10 Sep 2014) | 1 line ib_srpt: Add max_sge_delta kernel module parameter ........ r5796 | bvassche | 2014-09-10 15:20:30 +0300 (Wed, 10 Sep 2014) | 1 line ib_srpt: Update Subversion ignore lists ........ r5798 | bvassche | 2014-09-12 14:16:35 +0300 (Fri, 12 Sep 2014) | 1 line fcst/Makefile: Add release-archive target ........ r5801 | bvassche | 2014-09-12 14:20:16 +0300 (Fri, 12 Sep 2014) | 1 line fcst: Change version number from 0.3 into 3.1.0-pre ........ r5802 | vlnb | 2014-09-13 04:13:29 +0300 (Sat, 13 Sep 2014) | 3 lines Fix autofinding SCST headers in fileio_tgt ........ r5804 | vlnb | 2014-09-13 04:35:12 +0300 (Sat, 13 Sep 2014) | 3 lines Web updates ........ r5805 | vlnb | 2014-09-13 04:37:12 +0300 (Sat, 13 Sep 2014) | 3 lines Update root README to use symlink instead of bind mount for QLogic git driver integration ........ r5806 | bvassche | 2014-09-15 15:30:43 +0300 (Mon, 15 Sep 2014) | 1 line ib_srpt: Make "make -j<n> install" work for n >= 2 if "make all" has not been run first ........ r5808 | bvassche | 2014-09-16 14:06:00 +0300 (Tue, 16 Sep 2014) | 6 lines scst/src/Makefile: Make "make install" without prior "make" work Avoid that MOD_VERS and MODS_VERS evaluate to an empty string. Reported-by: Yan Burman <yanb@mellanox.com> ........ r5810 | bvassche | 2014-09-17 13:54:25 +0300 (Wed, 17 Sep 2014) | 1 line scst_vdisk: Insert a blank line ........ r5811 | bvassche | 2014-09-17 13:56:40 +0300 (Wed, 17 Sep 2014) | 14 lines vdisk_blockio: Make large COMPARE AND WRITE requests work for stacked block devices Stacked block devices impose weird restrictions on S/G-lists. Hence make the COMPARE AND WRITE implementation independent of these restrictions. Additionally, reduce the MAXIMUM COMPARE AND WRITE LENGTH limit from 0xff (no limit) to 0xfe to reduce the maximum amount of memory allocated during a COMPARE AND WRITE. Also serialize COMPARE AND WRITE operations, fix the offset reported for miscompares and fix the start offset of the region that is synchronized if the FUA bit has been set. Reported-by: Vishal Tripathi <vishal.tripathi@calsoftinc.com> ........ r5814 | bvassche | 2014-09-18 10:08:49 +0300 (Thu, 18 Sep 2014) | 1 line nightly build: Update kernel versions ........ r5816 | vlnb | 2014-09-20 09:31:43 +0300 (Sat, 20 Sep 2014) | 3 lines Web updates ........ r5817 | bvassche | 2014-09-28 21:54:04 +0200 (Sun, 28 Sep 2014) | 1 line scripts/rebuild-rhel-kernel-rpm: Enable put_page_callback patch for RHEL 7 ........ git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5819 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-09-29 08:31:12 +00:00
Yan Burman	7bc8357709	isert: Fix checkpatch whitespace errors ... Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5797 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-09-11 10:06:03 +00:00
Yan Burman	08c58c92ea	isert: Improve IO processing latency while closing connections ... Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5791 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-09-10 08:53:11 +00:00
Yan Burman	d9872582b4	isert: Rename static version of isert_conn_free() to make its name unique ... We had two functions called isert_conn_free() a static one and a global one. Rename the static one so that it will be less confusing while reading the code. Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5790 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-09-10 08:53:05 +00:00
Yan Burman	c682d02ebf	isert: Fix possible deadlock when calling cancel_work_sync() on the workqueue we are running from ... Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5789 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-09-10 08:53:00 +00:00
Yan Burman	914b9d4f4f	isert: Remove a leftover comment from the old days ... Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5788 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-09-10 08:52:54 +00:00
Yan Burman	760b4a55b7	isert: Fix deadlock that can be caused by calling flush_workqueue() from within that same workqueue ... We no longer need to do flush of the workqueue, since we cleanup when all flushes are done now Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5787 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-09-10 08:52:44 +00:00
Yan Burman	3c47e99157	Merged revisions 5769,5779 via svnmerge from ... svn+ssh://yanb123@svn.code.sf.net/p/scst/svn/trunk ........ r5769 | bvassche | 2014-09-04 15:56:48 +0300 (Thu, 04 Sep 2014) | 1 line ib_srpt: Bump driver version from 3.0.0-pre to 3.1.0-pre ........ r5779 | bvassche | 2014-09-06 09:30:46 +0300 (Sat, 06 Sep 2014) | 1 line nightly build: Update kernel versions ........ git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5783 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-09-07 13:51:58 +00:00
Yan Burman	00ad4d0209	isert: Cleanup iscsi connection as soon as possible to allow lower session reinstate times ... Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5781 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-09-07 13:39:18 +00:00
Yan Burman	c4fd1dc2ed	isert: Make sure we wait for all flushes to finish ... We wait untill all flushes finish by posting a special send WR with zero sized sge, and wait for it to flush. Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5780 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-09-07 13:39:12 +00:00
Yan Burman	66b51069b3	Merged revisions 5740,5744-5745,5751-5755,5758,5760,5762,5764 via svnmerge from ... svn+ssh://yanb123@svn.code.sf.net/p/scst/svn/trunk ........ r5740 | vlnb | 2014-08-28 04:26:11 +0300 (Thu, 28 Aug 2014) | 11 lines scst_lib: Fix READ POSITION parsing For code 08h (EXTENDED FORM) minimal response length is 32, see table "READ POSITION data format, extended form". In SSC-[2,3] table "READ POSITION service action codes" requests minimum response lenght 28 bytes, but it is an apparent typo, because the actual data format is 32 bytes long. In SSC-4 it is fixed. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5744 | bvassche | 2014-09-02 09:33:32 +0300 (Tue, 02 Sep 2014) | 4 lines scripts/rebuild-rhel-kernel-rpm: Fix for invocation from current directory Reported-by: Hiroyuki Sato <hiroysato@gmail.com> ........ r5745 | bvassche | 2014-09-02 09:35:06 +0300 (Tue, 02 Sep 2014) | 1 line scripts/generate-patched-kernel: Fix for invocation from current directory ........ r5751 | bvassche | 2014-09-03 13:23:51 +0300 (Wed, 03 Sep 2014) | 4 lines scst: Build fix for hex_to_bin() for RHEL 6.1 and later Reported-by: Yan Burman <yanb@mellanox.com> ........ r5752 | bvassche | 2014-09-03 13:47:16 +0300 (Wed, 03 Sep 2014) | 1 line scst.h: Make vzalloc() available on RHEL 6.0 ........ r5753 | bvassche | 2014-09-03 13:50:52 +0300 (Wed, 03 Sep 2014) | 1 line scst: Refine r5751, the hex_to_bin() build fix for RHEL >= 6.1 ........ r5754 | bvassche | 2014-09-03 13:58:03 +0300 (Wed, 03 Sep 2014) | 1 line scst_vdisk: RHEL 6.0 build fix ........ r5755 | bvassche | 2014-09-03 14:00:55 +0300 (Wed, 03 Sep 2014) | 1 line scst_vdisk: Follow-up for r5754 ........ r5758 | bvassche | 2014-09-03 16:43:23 +0300 (Wed, 03 Sep 2014) | 1 line scst.h: RHEL 5.10 build fix ........ r5760 | bvassche | 2014-09-03 16:52:16 +0300 (Wed, 03 Sep 2014) | 1 line scst.h: RHEL 5.10 build fix ........ r5762 | bvassche | 2014-09-03 17:00:14 +0300 (Wed, 03 Sep 2014) | 1 line scst.h: Fix definition of __aligned() ........ r5764 | bvassche | 2014-09-03 17:24:52 +0300 (Wed, 03 Sep 2014) | 1 line scst_vdisk: Use parentheses around && inside || ........ git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5767 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-09-04 06:36:01 +00:00
Yan Burman	262e8b4db0	isert: Remove an unused variable ... Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5743 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-09-01 12:34:33 +00:00
Yan Burman	9246693e87	Allow SCST to load on kernels that have LIO target with iSER compiled ... Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5741 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-08-31 11:35:24 +00:00
Yan Burman	d7e6569b1a	Merged revisions 5667-5670,5672-5686,5698,5700-5722,5724-5737 via svnmerge from ... svn+ssh://yanb123@svn.code.sf.net/p/scst/svn/trunk ........ r5667 | bvassche | 2014-07-08 18:11:58 +0300 (Tue, 08 Jul 2014) | 1 line nightly build: Update kernel versions ........ r5668 | vlnb | 2014-07-10 04:00:29 +0300 (Thu, 10 Jul 2014) | 3 lines Make SCST interface compatibility more robust ........ r5669 | bvassche | 2014-07-10 09:17:57 +0300 (Thu, 10 Jul 2014) | 1 line scst/Makefile: Create /var/lib/scst/vdev_mode_pages while installing SCST ........ r5670 | bvassche | 2014-07-10 09:18:58 +0300 (Thu, 10 Jul 2014) | 1 line scst.spec.in: Create /var/lib/scst/pr and /var/lib/scst/vdev_mode_pages when installing the SCST RPM ........ r5672 | bvassche | 2014-07-10 15:29:59 +0300 (Thu, 10 Jul 2014) | 2 lines scripts/rebuild-rhel-kernel-rpm: Move code for downloading a RHEL (clone) RPM into a separate file ........ r5673 | bvassche | 2014-07-11 09:48:49 +0300 (Fri, 11 Jul 2014) | 1 line scripts/generate-kernel-patch: Also generate scst-itf-ver.h ........ r5674 | bvassche | 2014-07-11 10:54:19 +0300 (Fri, 11 Jul 2014) | 1 line scripts/generate-kernel-patch: Remove trailing whitespace ........ r5675 | vlnb | 2014-07-12 03:53:46 +0300 (Sat, 12 Jul 2014) | 3 lines BLOCKIO microoptimization: use per-device biosets ........ r5676 | bvassche | 2014-07-13 10:15:05 +0300 (Sun, 13 Jul 2014) | 1 line nightly build: Update kernel versions ........ r5677 | vlnb | 2014-07-16 06:27:20 +0300 (Wed, 16 Jul 2014) | 3 lines Install scst_itf_ver.h as well ........ r5678 | bvassche | 2014-07-16 08:35:40 +0300 (Wed, 16 Jul 2014) | 1 line scst-devel rpm: Include /usr/include/scst/scst_itf_ver.h ........ r5679 | bvassche | 2014-07-16 11:29:16 +0300 (Wed, 16 Jul 2014) | 6 lines ib_srpt: Fix Mellanox OFED build Use the proper include directory when building against Mellanox OFED. Do not require to remove /lib/modules/$(KVER)/kernel/drivers/infiniband before building ib_srpt. ........ r5680 | bvassche | 2014-07-18 12:27:41 +0300 (Fri, 18 Jul 2014) | 1 line srpt/Makefile: Remove a superfluous assignment statement ........ r5681 | bvassche | 2014-07-18 12:28:22 +0300 (Fri, 18 Jul 2014) | 1 line srpt/Makefile: SLES + Mellanox OFED build fix ........ r5682 | bvassche | 2014-07-18 12:30:25 +0300 (Fri, 18 Jul 2014) | 1 line srpt/README: Fix SLES patch instructions ........ r5683 | vlnb | 2014-07-19 06:54:33 +0300 (Sat, 19 Jul 2014) | 11 lines iscsi-scst: Handle data buffers with non-zero offset correctly Start at the proper offset in the receive buffer if sg[0].offset != 0. Return the proper data to the initiator if sg[0].offset != 0. This patch reworks trunk r5281, "iscsi-scst: fix offset calculation", February 13, 2014. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5684 | vlnb | 2014-07-19 07:08:30 +0300 (Sat, 19 Jul 2014) | 10 lines scst: Clean up scst_process_active_cmd() Since inside scst_process_active_cmd() cmd->state can only change after cmd has been added back to the command list it is safe to perform the cmd->state check without holding the command list lock. Hence move the perform the cmd->state check without holding the command list lock. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5685 | vlnb | 2014-07-19 07:11:39 +0300 (Sat, 19 Jul 2014) | 7 lines scst: Introduce scst_set_thr_cpu_mask() This patch does not change any functionality. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5686 | vlnb | 2014-07-19 07:13:24 +0300 (Sat, 19 Jul 2014) | 8 lines scst_vdisk: Micro-optimize the zero-copy check Only evaluate the SCSI command type if virt_dev->zero_copy has been set instead of always checking the SCSI command type. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5698 | bvassche | 2014-07-20 11:37:58 +0300 (Sun, 20 Jul 2014) | 1 line nightly build: Update kernel versions ........ r5700 | vlnb | 2014-07-22 02:04:18 +0300 (Tue, 22 Jul 2014) | 3 lines Web updates ........ r5701 | vlnb | 2014-07-22 03:22:06 +0300 (Tue, 22 Jul 2014) | 8 lines scst: Make scst_cmd_threads.threads_list locking more fine-grained Introduce a new synchronization object, namely scst_cmd_threads.thr_lock, to protect scst_cmd_threads.threads_list. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5702 | vlnb | 2014-07-23 05:00:06 +0300 (Wed, 23 Jul 2014) | 7 lines Prevent possible collisions between saved PR and mode pages backup files From now on '.' is illegal character in SCST device names Reported-by Ken Raeburn <raeburn@permabit.com> ........ r5703 | vlnb | 2014-07-23 05:49:50 +0300 (Wed, 23 Jul 2014) | 5 lines Review of host_status handling (pass-through mode) Inspired by Dave Butler <tears.the@gmail.com> and Bart Van Assche <bvanassche@acm.org> ........ r5704 | vlnb | 2014-07-26 03:04:51 +0300 (Sat, 26 Jul 2014) | 3 lines Internal REQUEST SENSE: NO SENSE is also valid sense ........ r5705 | vlnb | 2014-07-29 02:11:14 +0300 (Tue, 29 Jul 2014) | 3 lines Print initiator and target in the abort messages ........ r5706 | vlnb | 2014-07-30 05:27:10 +0300 (Wed, 30 Jul 2014) | 3 lines Minor logging improvements ........ r5707 | vlnb | 2014-07-30 05:52:26 +0300 (Wed, 30 Jul 2014) | 3 lines Follow up for r5704: NO SENSE is also valid sense ........ r5708 | vlnb | 2014-07-30 05:53:07 +0300 (Wed, 30 Jul 2014) | 3 lines Minor fix ........ r5709 | bvassche | 2014-08-06 20:40:30 +0300 (Wed, 06 Aug 2014) | 1 line nightly build: Update kernel versions ........ r5710 | bvassche | 2014-08-07 10:20:08 +0300 (Thu, 07 Aug 2014) | 1 line RHEL 7: Add scst_exec_req_fifo and put_page_callback patches ........ r5711 | bvassche | 2014-08-07 11:12:22 +0300 (Thu, 07 Aug 2014) | 1 line Rename the two RHEL 7 scst_exec_req_fifo patches ........ r5712 | bvassche | 2014-08-07 11:38:19 +0300 (Thu, 07 Aug 2014) | 1 line scripts/rebuild-rhel-kernel-rpm: Add RHEL 7 support ........ r5713 | bvassche | 2014-08-08 13:37:17 +0300 (Fri, 08 Aug 2014) | 1 line nightly build: Update kernel versions ........ r5714 | bvassche | 2014-08-09 14:02:19 +0300 (Sat, 09 Aug 2014) | 1 line scripts/rebuild-rhel-kernel-rpm: Install more prerequisites ........ r5715 | bvassche | 2014-08-15 10:49:07 +0300 (Fri, 15 Aug 2014) | 1 line nightly build: Update kernel versions ........ r5716 | vlnb | 2014-08-16 02:44:33 +0300 (Sat, 16 Aug 2014) | 3 lines Fix blockio bioset for older kernels, which need explicit bio destructors ........ r5717 | vlnb | 2014-08-20 00:52:31 +0300 (Wed, 20 Aug 2014) | 3 lines Update for kernels 3.16 ........ r5718 | vlnb | 2014-08-20 05:24:08 +0300 (Wed, 20 Aug 2014) | 12 lines Fix Coverity warning of q2t_ctio_to_cmd() dead code Coverity warns that 'handle == Q2T_SKIP_HANDLE' can never occur, because code preceding the test has masked out a handle bit that would be required for the test to succeed. Fix that by extending Q2T_SKIP_HANDLE to incorporate CTIO_INTERMEDIATE_HANDLE_MARK as well. Reported-by: Steven J. Magnani <steve@digidescorp.com> ........ r5719 | bvassche | 2014-08-20 09:55:04 +0300 (Wed, 20 Aug 2014) | 1 line nightly build: Add kernel 3.16 nightly build infrastructure ........ r5720 | bvassche | 2014-08-20 09:57:04 +0300 (Wed, 20 Aug 2014) | 1 line nightly build: Add kernel version 3.16.1 ........ r5721 | vlnb | 2014-08-21 08:17:47 +0300 (Thu, 21 Aug 2014) | 5 lines Fix incorrect address computation during receive PDUs preparations Found and fix suggested by Кирилл Тюшев <kirill.tyushev8@gmail.com> ........ r5722 | vlnb | 2014-08-21 08:18:43 +0300 (Thu, 21 Aug 2014) | 3 lines Integration of the QLogic git's qla2x00t into the SCST tree ........ r5724 | bvassche | 2014-08-22 10:19:55 +0300 (Fri, 22 Aug 2014) | 9 lines Fix a kernel 3.16 checkpatch complaint about trailing semicolons Avoid that the checkpatch tool included in Linux kernel v3.16 reports the following warning: macros should not use a trailing semicolon This patch does not change any functionality. ........ r5725 | bvassche | 2014-08-25 14:36:33 +0300 (Mon, 25 Aug 2014) | 1 line ib_srpt: Kernel v3.17 build fix ........ r5726 | bvassche | 2014-08-25 14:41:55 +0300 (Mon, 25 Aug 2014) | 1 line ib_srpt: Log QPN next to session name ........ r5727 | bvassche | 2014-08-25 14:46:43 +0300 (Mon, 25 Aug 2014) | 6 lines ib_srpt: Speed up kernel driver unloading after a cable pull When unloading the ib_srpt kernel module, instead of waiting until all connected queue pairs have left the TimeWait state, destroy these queue pairs immediately. ........ r5728 | bvassche | 2014-08-25 15:50:19 +0300 (Mon, 25 Aug 2014) | 8 lines ib_srpt: Make the completion vector configurable Allow a set of completion vectors to be associated with each InfiniBand HCA port and allocate the completion vector for each session in a round-robin fashion from the per-port set. This helps to spread the InfiniBand interrupt workload over multiple CPU's, at least if different InfiniBand MSI-X vectors are associated with different CPU's. ........ r5729 | vlnb | 2014-08-26 06:21:07 +0300 (Tue, 26 Aug 2014) | 7 lines scst_vdisk: Make vdisk_sup_vpd() easier to extend This patch doesn't change any functionality. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5730 | vlnb | 2014-08-26 06:44:23 +0300 (Tue, 26 Aug 2014) | 12 lines scst_vdisk: Make EUI-64 and NAA IDs configurable Make the SCSI device identification page (83h) EUI-64 and NAA IDs configurable. If neither the eui64_id nor the naa_id sysfs attribute has been set, export the first eight bytes of the t10_dev_id as an EUI-64 ID. If the NAA ID but not the EUI-64 ID has been set, report the NAA ID only. If both IDs have been set, report both. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5731 | bvassche | 2014-08-26 12:56:54 +0300 (Tue, 26 Aug 2014) | 1 line scstadmin: Avoid that the Perl interpreter prints a warning message about using an undefined variable on Fedora systems ........ r5732 | vlnb | 2014-08-27 05:41:40 +0300 (Wed, 27 Aug 2014) | 9 lines iscsi-scst: Build fix for IPV6=n Ensure that iscsi-scst builds properly against a kernel with CONFIG_IPV6=n. Reported by Igor Novgorodov <igor@novg.net> on June 7, 2014. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5733 | vlnb | 2014-08-27 05:42:35 +0300 (Wed, 27 Aug 2014) | 9 lines scst_pres: Make a few error messages more clear Make it possible to figure out what went wrong from inspecting the system log only by mentioning the incorrect filename in the system log. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5734 | vlnb | 2014-08-27 05:43:50 +0300 (Wed, 27 Aug 2014) | 8 lines scst: Remove set_cpus_allowed() invocations Since scst.h contains a backport of the definition of set_cpus_allowed_ptr(), the set_cpus_allowed() invocations are superfluous. Hence remove these. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5735 | vlnb | 2014-08-27 05:55:28 +0300 (Wed, 27 Aug 2014) | 8 lines iscsi-scst: Micro-optimize cmnd_prepare_recv_pdu() Instead of adding sg[idx].offset to addr and immediately subtracting sg[idx].offset again, leave out both arithmetic operations. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5736 | vlnb | 2014-08-27 06:00:44 +0300 (Wed, 27 Aug 2014) | 5 lines scst/include/scst.h: Document on_abort_cmd() further Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5737 | bvassche | 2014-08-27 09:33:02 +0300 (Wed, 27 Aug 2014) | 1 line scst_vdisk: Build fix for kernel 3.1.x ........ git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5738 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-08-27 13:26:02 +00:00
Yan Burman	e4c7d430c1	Merged revisions 5536-5539,5543,5545,5547,5555,5557-5558,5560-5563,5566-5575,5577-5579,5581-5590,5592-5598,5600-5603,5605-5622,5624-5631,5647-5651,5654,5657-5659,5661-5662 via svnmerge from ... svn+ssh://yanb123@svn.code.sf.net/p/scst/svn/trunk ........ r5536 | vlnb | 2014-05-22 06:06:46 +0300 (Thu, 22 May 2014) | 3 lines Version changed to 3.1.0-pre1 ........ r5537 | vlnb | 2014-05-22 06:18:27 +0300 (Thu, 22 May 2014) | 3 lines Web updates ........ r5538 | bvassche | 2014-05-22 10:16:04 +0300 (Thu, 22 May 2014) | 1 line nightly build: Update kernel versions ........ r5539 | vlnb | 2014-05-23 05:20:35 +0300 (Fri, 23 May 2014) | 9 lines vdisk_nullio: Add "read_zero" attribute Add an attribute called "read_zero" to vdisk_nullio devices that controls whether or not READs from a vdisk_nullio device return zeroed data buffers. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5543 | bvassche | 2014-05-23 10:33:53 +0300 (Fri, 23 May 2014) | 1 line RHEL 7 build fixes ........ r5545 | bvassche | 2014-05-23 11:36:36 +0300 (Fri, 23 May 2014) | 1 line scripts/rebuild-rhel-kernel-rpm: Add RHEL 7 RC support ........ r5547 | vlnb | 2014-05-24 06:10:34 +0300 (Sat, 24 May 2014) | 3 lines Optimize read_zero functionality ........ r5555 | bvassche | 2014-05-27 14:59:11 +0300 (Tue, 27 May 2014) | 5 lines qla2x00t: Documentation / source code comment / log messages spelling fix Change a few occurrences of "conformation" into "confirmation". See also the QLogic 2500 Series Firmware Interface Specification. ........ r5557 | vlnb | 2014-05-30 03:42:34 +0300 (Fri, 30 May 2014) | 5 lines Small code reorganization. No functionality changed ........ r5558 | vlnb | 2014-05-30 06:00:07 +0300 (Fri, 30 May 2014) | 3 lines Logging fixes ........ r5560 | bvassche | 2014-06-02 18:31:50 +0300 (Mon, 02 Jun 2014) | 1 line Makefile: Only report which RPMs have been built if "make rpm" is run as a non-privileged user ........ r5561 | bvassche | 2014-06-03 09:04:47 +0300 (Tue, 03 Jun 2014) | 1 line nightly build: Update kernel versions ........ r5562 | vlnb | 2014-06-04 04:54:21 +0300 (Wed, 04 Jun 2014) | 3 lines Decrease max WRITE SAME length for better latencies ........ r5563 | vlnb | 2014-06-04 05:16:51 +0300 (Wed, 04 Jun 2014) | 3 lines Enforce limit on max unmap LBAs ........ r5566 | bvassche | 2014-06-04 18:14:22 +0300 (Wed, 04 Jun 2014) | 1 line ib_srpt: Fix an error message ........ r5567 | bvassche | 2014-06-04 18:17:59 +0300 (Wed, 04 Jun 2014) | 1 line ib_srpt: Avoid triggering a SCSI command timeout after login ........ r5568 | bvassche | 2014-06-05 09:34:19 +0300 (Thu, 05 Jun 2014) | 1 line scst_vdisk: Build fix for kernel versions <= 2.6.32 ........ r5569 | bvassche | 2014-06-05 09:46:57 +0300 (Thu, 05 Jun 2014) | 1 line scst_vdisk: Fix a kernel version < 2.6.38 compiler warning ........ r5570 | vlnb | 2014-06-06 06:20:26 +0300 (Fri, 06 Jun 2014) | 8 lines scst_lib: Fix a compiler warning triggered by the WRITE SAME implementation Avoid for release builds that the compiler reports that the variable 'ws_sg_cnt' is not used. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5571 | vlnb | 2014-06-06 06:22:14 +0300 (Fri, 06 Jun 2014) | 7 lines nullio_exec_read(): Fix kunmap() argument The argument of kunmap() is of type struct page *. Detected by smatch. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5572 | vlnb | 2014-06-06 06:24:03 +0300 (Fri, 06 Jun 2014) | 11 lines scst: Leave out FSF mail address This avoids that the following checkpatch complaint is triggered: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5573 | vlnb | 2014-06-06 06:26:55 +0300 (Fri, 06 Jun 2014) | 10 lines scst: Make lockdep_assert_held() easier to use The lockdep_assert_held() macro is a convenient debugging tool. However, it is inconvenient to surround each invocation of that macro by an #ifdef/#endif pair. Hence make it easier to use this macro with older kernel versions. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5574 | vlnb | 2014-06-07 00:59:24 +0300 (Sat, 07 Jun 2014) | 3 lines Use limits.discard_zeroes_data to set LBPRZ ........ r5575 | bvassche | 2014-06-07 13:46:49 +0300 (Sat, 07 Jun 2014) | 1 line nightly build: Update kernel versions ........ r5577 | bvassche | 2014-06-10 17:16:14 +0300 (Tue, 10 Jun 2014) | 1 line ib_srpt: Make the test for IB_EVENT_GID_CHANGE support more robust ........ r5578 | bvassche | 2014-06-10 17:49:59 +0300 (Tue, 10 Jun 2014) | 1 line ib_srpt: Make IB_EVENT_GID_CHANGE test independent of the OFED detection code ........ r5579 | bvassche | 2014-06-11 13:02:15 +0300 (Wed, 11 Jun 2014) | 1 line ib_srpt: RHEL 5 build fix ........ r5581 | bvassche | 2014-06-11 18:27:06 +0300 (Wed, 11 Jun 2014) | 1 line regression tests: Sync with a recent sysfs change ........ r5582 | bvassche | 2014-06-11 18:27:48 +0300 (Wed, 11 Jun 2014) | 1 line regression tests: Sort hash keys before comparing ........ r5583 | bvassche | 2014-06-11 18:41:01 +0300 (Wed, 11 Jun 2014) | 1 line nightly build: Update kernel versions ........ r5584 | vlnb | 2014-06-11 22:33:18 +0300 (Wed, 11 Jun 2014) | 8 lines scst: RHEL 5 build fix Avoid that building the scst kernel module fails on RHEL 5 due to a missing kvasprintf() implementation. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5585 | vlnb | 2014-06-11 22:38:10 +0300 (Wed, 11 Jun 2014) | 11 lines scst: Remove unused variables Avoid that building scst with W=1 triggers compiler warnings about variables that are set but not used. See also the documentation of the gcc compiler flag -Wunused-but-set-variable. This patch does not change any functionality. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5586 | vlnb | 2014-06-11 22:39:51 +0300 (Wed, 11 Jun 2014) | 9 lines scst_lib: Introduce additional temporary variables Make the code slightly easier to read by introducing temporary variables for the expressions 'tgt_dev->sess' and 'sess->tgt->tgtt'. This patch does not change any functionality. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5587 | vlnb | 2014-06-11 23:57:03 +0300 (Wed, 11 Jun 2014) | 10 lines scst: Add support for 64-bit LUNs The datatype of scsi_device.lun will be changed from u32 into u64 in the near future. Update SCST accordingly. These changes have been implemented such that these are compatible with 32-bit and 64-bit LUNs. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5588 | vlnb | 2014-06-12 00:00:16 +0300 (Thu, 12 Jun 2014) | 9 lines scst_local: Support LUN numbers >= 16384 Add support for 32-bit LUN numbers. As soon as the patches that add 64-bit LUN support are upstream this patch will also make 64-bit LUN support available in scst_local. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5589 | vlnb | 2014-06-12 00:42:08 +0300 (Thu, 12 Jun 2014) | 8 lines scst: Clean up __scst_resume_activity() Move all management commands from scst_delayed_mgmt_cmd_list to the active command list during resume instead of only the first one. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5590 | vlnb | 2014-06-12 01:07:00 +0300 (Thu, 12 Jun 2014) | 9 lines scst: Introduce scst_lookup_tgt_dev() This patch does not change any functionality. Signed-off-by: Bart Van Assche <bvanassche@acm.org> with some improvements ........ r5592 | bvassche | 2014-06-12 11:38:45 +0300 (Thu, 12 Jun 2014) | 7 lines scst.h: Move definition of swap() Make sure that the definition of swap() is guarded by "#if LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 29)" only instead of "#if LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 28)" and "#if LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 29)". ........ r5593 | bvassche | 2014-06-12 12:15:50 +0300 (Thu, 12 Jun 2014) | 1 line nightly build: Update kernel versions ........ r5594 | bvassche | 2014-06-12 14:33:00 +0300 (Thu, 12 Jun 2014) | 1 line ib_srpt: Set MOFED include path correctly if MOFED has been installed with --add-kernel-support ........ r5595 | bvassche | 2014-06-12 16:38:38 +0300 (Thu, 12 Jun 2014) | 1 line ib_srpt: Make non-OFED build work again ........ r5596 | vlnb | 2014-06-13 07:52:18 +0300 (Fri, 13 Jun 2014) | 16 lines scst: Switch from the cpu_*() to the cpumask_*() API The cpus_*() functions were deprecated via patch "cpumask: introduce new API, without changing anything" (November 2008, commit ID 2d3854a37e8b). Hence switch from the cpus_*() API to the cpumask_*() API. This patch has the intended side effect of not adding the "[key]" property to cpumask sysfs attributes that contain the default cpumask. The current code namely reads uninitialized bits on systems where nr_cpu_ids < NR_CPUS because cpus_equal() compares more bits than those that were set by cpumask_copy(). Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5597 | vlnb | 2014-06-13 08:03:17 +0300 (Fri, 13 Jun 2014) | 3 lines Forgotten versions updated ........ r5598 | bvassche | 2014-06-13 09:55:23 +0300 (Fri, 13 Jun 2014) | 1 line ib_srpt: Make one_target_per_port the default mode ........ r5600 | vlnb | 2014-06-14 01:24:06 +0300 (Sat, 14 Jun 2014) | 9 lines scst: Avoid that W=1 triggers complaints about unused variables Avoid that building scst with W=1 triggers compiler warnings about variables that are set but not used. See also the documentation of the gcc compiler flag -Wunused-but-set-variable. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5601 | vlnb | 2014-06-14 01:31:42 +0300 (Sat, 14 Jun 2014) | 8 lines scst_local: Add close_session() callback function This is useful for triggering the session reassignment code via the scst_local driver. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5602 | vlnb | 2014-06-14 02:57:26 +0300 (Sat, 14 Jun 2014) | 8 lines scst_pr_read_reservation(): Initialize returned buffer Avoid that this function returns an uninitialized buffer to the initiator if buffer_size < 8. Detected by Coverity. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5603 | vlnb | 2014-06-14 02:58:28 +0300 (Sat, 14 Jun 2014) | 5 lines scst: Help Coverity recognize that vmalloc(0) returns NULL Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5605 | bvassche | 2014-06-14 20:10:58 +0300 (Sat, 14 Jun 2014) | 1 line fcst: Remove an unused variable ........ r5606 | bvassche | 2014-06-14 20:17:56 +0300 (Sat, 14 Jun 2014) | 5 lines fcst: Move exch_done() calls into ft_cmd_done() This patch ensures that exch_done() gets called if an fcst callback returns SCST_TGT_RES_FATAL_ERROR. ........ r5607 | bvassche | 2014-06-14 20:18:34 +0300 (Sat, 14 Jun 2014) | 10 lines fcst: Handle frame send failures properly Retry sending XFER_RDY, data and response frames if the network driver reports that sending failed (-ENOMEM) instead of reporting a kernel warning (WARN_ON(1)). If sending XFER_RDY or data frames failed for another reason, report this to the initiator as a write error (ASC = 03; ASCQ = 00 which stands for PERIPHERAL DEVICE WRITE FAULT). If sending a response frame failed with another error code than -ENOMEM, do not send a response. ........ r5608 | vlnb | 2014-06-17 03:50:46 +0300 (Tue, 17 Jun 2014) | 10 lines scst: Make access control group removal behavior configurable SCST rejects removal of an access control group with one or more sessions with error code -EBUSY. Make it easy to change this behavior into forcibly closing sessions when an access control group is removed. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5609 | bvassche | 2014-06-17 09:37:08 +0300 (Tue, 17 Jun 2014) | 1 line nightly build: Update kernel versions ........ r5610 | vlnb | 2014-06-19 06:51:48 +0300 (Thu, 19 Jun 2014) | 3 lines Update for 3.15 kernels ........ r5611 | bvassche | 2014-06-19 10:09:53 +0300 (Thu, 19 Jun 2014) | 1 line nightly build: Add kernel 3.15 build infrastructure ........ r5612 | bvassche | 2014-06-19 15:48:25 +0300 (Thu, 19 Jun 2014) | 1 line kernel module installation: Skip "depmod" when building an RPM ........ r5613 | vlnb | 2014-06-20 07:00:41 +0300 (Fri, 20 Jun 2014) | 8 lines scst: Convert a loop to keep smatch happy Avoid that smatch reports the following warning: scst_init_session() info: loop could be replaced with if statement. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5614 | vlnb | 2014-06-20 07:02:00 +0300 (Fri, 20 Jun 2014) | 13 lines iscsi-scst: Suppress a compiler warning Avoid that the following compiler warning is reported when compiling iscsi-scst: chap.c: In function 'chap_rand': chap.c:348:5: warning: ignoring return value of 'read', declared with attribute warn_unused_result [-Wunused-result] (void)read(fd, &r, sizeof(r)); ^ Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5615 | vlnb | 2014-06-20 07:03:40 +0300 (Fri, 20 Jun 2014) | 5 lines scst, iscsi-scst: Fix RHEL 5 compilation warnings Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5616 | vlnb | 2014-06-20 07:05:11 +0300 (Fri, 20 Jun 2014) | 10 lines scst: Exclude certain locking code from static analysis Loops with locking statements and also lock and unlock statements guarded by an if-statement trigger false positive warnings when analyzing the SCST code with smatch and/or sparse. Hence exclude such code from static analysis. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5617 | vlnb | 2014-06-20 07:09:11 +0300 (Fri, 20 Jun 2014) | 10 lines scst: Avoid that sparse complains about unreachable code Remove the code after BUG() statements to avoid that smatch complains about unreachable code. Hide the spin_unlock() statements before BUG() statements for static analysis tools to avoid that sparse complains about locking imbalances. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5618 | vlnb | 2014-06-20 07:10:40 +0300 (Fri, 20 Jun 2014) | 12 lines Change BUG_ON(1) into BUG() With CONFIG_BUG=y both BUG() and BUG_ON(1) halt the system. However, with CONFIG_BUG=n BUG() halts the system but BUG_ON(1) not. To avoid such subtleties, change BUG_ON(1) into BUG(). See also patch Josh Triplett, "bug: Make BUG() always stop the machine", 7 April 2014 (commit ID a4b5d580e07875f9be29f62a57c67fbbdbb40ba2). Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5619 | bvassche | 2014-06-20 08:56:36 +0300 (Fri, 20 Jun 2014) | 1 line nightly build: Add kernel version 3.15.1 ........ r5620 | vlnb | 2014-06-24 07:45:08 +0300 (Tue, 24 Jun 2014) | 9 lines scst_vdisk: Split vdisk_exec_inquiry() Make vdisk_exec_inquiry() easier to read by moving the code for the implementation of each VPD page into a separate function. This patch does not change any functionality. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5621 | bvassche | 2014-06-24 16:32:18 +0300 (Tue, 24 Jun 2014) | 1 line ib_srpt: Complain if another ib_srpt.ko kernel module already exists ........ r5622 | bvassche | 2014-06-24 16:33:23 +0300 (Tue, 24 Jun 2014) | 2 lines ib_srpt: Set SCSI residual fields in SRP_CMD reply ........ r5624 | bvassche | 2014-06-25 14:50:40 +0300 (Wed, 25 Jun 2014) | 1 line nightly build: Use http instead of ftp for downloading kernel source code ........ r5625 | vlnb | 2014-06-26 00:38:19 +0300 (Thu, 26 Jun 2014) | 5 lines scst_debug.h: Make EXTRACHECKS_*_ON() statements visible to Coverity Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5626 | vlnb | 2014-06-27 02:26:25 +0300 (Fri, 27 Jun 2014) | 10 lines scst_vdisk: Three more put_unaligned_*() conversions Convert three more *(__be16 *)p = cpu_to_be16(v) statements into put_unaligned_be16(v, p) since the latter is easier to read. Also convert one "cmd->dev" into "dev" expression. This patch does not change any functionality. Signed-off-by: Bart Van Assche <bvanassche@acm.org> ........ r5627 | bvassche | 2014-06-27 13:32:02 +0300 (Fri, 27 Jun 2014) | 1 line nightly build: Update kernel versions ........ r5628 | bvassche | 2014-06-28 22:56:36 +0300 (Sat, 28 Jun 2014) | 1 line ib_srpt: Remove existing ib_srpt.ko kernel modules before installation ........ r5629 | bvassche | 2014-06-28 22:58:44 +0300 (Sat, 28 Jun 2014) | 6 lines scst_vdisk: Fix 32-bit build Avoid 64-bit modulo computations since these result in undefined symbol errors on 32-bit systems (__moddi3 / __umoddi3). Support sizes >= 2**32 bytes on 32-bit systems. ........ r5630 | bvassche | 2014-06-28 23:00:22 +0300 (Sat, 28 Jun 2014) | 1 line scst.spec.in: Follow-up for r5628 ........ r5631 | bvassche | 2014-06-28 23:15:45 +0300 (Sat, 28 Jun 2014) | 1 line scst_local: Avoid that session deletion triggers a kernel warning ........ r5647 | bvassche | 2014-06-30 10:18:53 +0300 (Mon, 30 Jun 2014) | 1 line scst: Build fix for Linux kernel versions 2.6.33 and 2.6.34 ........ r5648 | bvassche | 2014-06-30 10:28:18 +0300 (Mon, 30 Jun 2014) | 1 line scst: Build fix for kernel versions <= 2.6.31 ........ r5649 | bvassche | 2014-06-30 11:40:23 +0300 (Mon, 30 Jun 2014) | 6 lines scst_vdisk: Fix a checkpatch warning Address the following checkpatch warning: char * array declaration might be better as static const ........ r5650 | bvassche | 2014-06-30 11:52:06 +0300 (Mon, 30 Jun 2014) | 1 line nightly build: Correct a kernel version ........ r5651 | bvassche | 2014-06-30 12:18:41 +0300 (Mon, 30 Jun 2014) | 1 line nightly build: Correct a kernel version ........ r5654 | bvassche | 2014-07-01 09:38:13 +0300 (Tue, 01 Jul 2014) | 6 lines scst_vdisk: Fix a checkpatch warning Avoid that checkpatch reports the following warning: WARNING: static const char * array should probably be static const char * const ........ r5657 | bvassche | 2014-07-01 19:46:12 +0300 (Tue, 01 Jul 2014) | 1 line nightly build: Update kernel versions ........ r5658 | bvassche | 2014-07-03 11:36:48 +0300 (Thu, 03 Jul 2014) | 1 line scripts/kernel-functions: Handle 3.x.0 kernel versions correctly ........ r5659 | bvassche | 2014-07-03 11:42:08 +0300 (Thu, 03 Jul 2014) | 1 line scripts/generate-patched-kernel: Clean up ........ r5661 | bvassche | 2014-07-04 08:39:28 +0300 (Fri, 04 Jul 2014) | 1 line Make scripts/kernel-functions again compatible with 2.6.x kernels ........ r5662 | bvassche | 2014-07-06 11:02:28 +0300 (Sun, 06 Jul 2014) | 1 line scripts/run-regression-tests: Add command-line option -4 (disable IPv6) ........ git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5666 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-07-07 10:36:05 +00:00
Yan Burman	6432ad6263	isert: Fix discovery over RDMA ... Commit r5655: isert: Handle login pdu reception in more robust way Broke discovery over RDMA. Fix it, as well as tidy up a few error prints in that area Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5660 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-07-03 12:43:16 +00:00
Yan Burman	cb54772490	isert: Allow working with initiators that have more RDMA resources than us ... Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5656 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-07-01 12:05:57 +00:00
Yan Burman	426ff54331	isert: Handle login pdu reception in more robust way ... Properly handle case when login PDU is received before logi response has been sent Signed-off-by: Yan Burman <yanb@mellanox.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5655 d57e44dd-8a1f-0410-8b47-8ef2f437770f	2014-07-01 12:05:46 +00:00