follows:
- Building the QLogic target driver is possible by following the instructions
in qla2x00t/qla2x00-target/README.
- Some but not all of the qla2x00-target code is included in the output of
scripts/generate-kernel-patch. This is unfortunate because it is the output
of this script that is posted to the LKML each time SCST is submitted for
review.
- Most of the qla2x00-target code is checked during the nightly build by
checkpatch. None of the qla2x00-target code is checked during the nightly
build by sparse.
The patch below makes sure that all of the qla2x00-target code is included in
the generate-kernel-patch output and also that all of the qla2x00-target code
is checked during the nightly build by both checkpatch and sparse. This has
been realized by including the diff of the linux-2.6.26.8/drivers/scsi/qla2xxx
source files and the source files in qla2x00t/*[ch] as individual patches under
qla2x00t/in-tree-patches. These patches are generated from downloaded
linux-2.6.26.8 sources and the sources in the SCST SVN repository.
The next step is to fix the checkpatch and sparse warnings triggered by the
qla2x00-target code and to port the latest qla2xxx patches to the SCST
qla2x00t implementation.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1189 d57e44dd-8a1f-0410-8b47-8ef2f437770f
1. Incorrect task management response delivery (with patch)
2. Possible use of non-initialized variable
3. Incorrect size of port_data_t and mb[8] for MBC_PORT_NODE_NAME_LIST
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1179 d57e44dd-8a1f-0410-8b47-8ef2f437770f
- WARNING: labels should not be indented
- WARNING: braces {} are not necessary for single statement blocks
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1174 d57e44dd-8a1f-0410-8b47-8ef2f437770f
- ERROR: space required before the open parenthesis '('
- ERROR: "(foo*)" should be "(foo *)"
- ERROR: "foo * bar" should be "foo *bar"
- ERROR: code indent should use tabs where possible
Verified that the output of svn diff -x -w is empty for this commit.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1171 d57e44dd-8a1f-0410-8b47-8ef2f437770f
- ERROR: else should follow close brace '}'
- ERROR: open brace '{' following struct go on the same line
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1169 d57e44dd-8a1f-0410-8b47-8ef2f437770f
- 2 ERROR: code indent should use tabs where possible
- 2 ERROR: trailing whitespace
Verified that the output of svn diff -x -w is empty for this commit.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1168 d57e44dd-8a1f-0410-8b47-8ef2f437770f
from the qla2xxx driver source code in the 2.6.26 kernel. Verified
that the output of svn diff -x -w is empty for this commit.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1165 d57e44dd-8a1f-0410-8b47-8ef2f437770f
- New scst_user option sgv_disable_clustered_pool added
- fileio_tgt updated to use those new facilities
- Scst_user docs updated
- sgv_pool_get() and sgv_pool_put() made exported
- AENs sense buffer override fixed
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1159 d57e44dd-8a1f-0410-8b47-8ef2f437770f
SRPT_STATE_NEW are now aborted properly too. Until now aborting an
SCST command that had state SRPT_STATE_NEW triggered a sBUG_ON()
statement in scst_tgt_cmd_done().
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1153 d57e44dd-8a1f-0410-8b47-8ef2f437770f
- ERROR: open brace '{' following struct go on the same line
- ERROR: return is not a function, parentheses are not required
- ERROR: that open brace { should be on the previous line
- WARNING: %Ld/%Lu are not-standard C, use %lld/%llu
- WARNING: braces {} are not necessary for single statement blocks
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1150 d57e44dd-8a1f-0410-8b47-8ef2f437770f
to prevent an infinite loop. Since we're using rand() here,
it's possible we could exit the loop with no unique name.
However, this is pretty unlikely considering thousands
if temp group names would have to already exist.
- Fail out if we can't come up with a temp group name and just
use the original specified.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1143 d57e44dd-8a1f-0410-8b47-8ef2f437770f
Bart Van Assche
Vladislav Bolkhovitin
Mark Buechler