Commit Graph

3733 Commits

Author SHA1 Message Date
Vladislav Bolkhovitin
c282b7964e Simplify, fix and improve commands ordering
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4972 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-15 05:47:32 +00:00
Vladislav Bolkhovitin
24238e4654 Cleanup
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4971 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-15 05:43:27 +00:00
Vladislav Bolkhovitin
f8f2580fcd From: Benjamin Black <Benjamin.Black@Emulex.Com>
There is not a way to specify an attribute that applies to only one
target or target driver. This patch provides such an interface.

Copyright (C) 2013  Emulex.  All rights reserved.

This software is provided as-is, without any express or implied warranty.  In
no event will Emulex be held liable for any damages arising from the use of
this software. Permission is granted to anyone to use this software for any
purpose, including commercial applications, and to alter it and redistribute it
freely. If you use this software in a product, an acknowledgment in the
product documentation would be appreciated, but is not required. This notice
may be removed from any source code distribution that includes all or any part
of the original software.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4970 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-15 05:34:33 +00:00
Bart Van Assche
886ae66326 fcst: Avoid triggering CRC errors at the initiator side
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4969 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-13 18:43:56 +00:00
Bart Van Assche
80ba881d46 fcst: Fix ft_abort_cmd()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4968 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-13 18:43:26 +00:00
Bart Van Assche
e6610624ae fcst: Report FC send errors
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4967 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-13 18:41:38 +00:00
Bart Van Assche
6c5328df1d fcst: Use proper length variable for bidir commands in ft_recv_write_data()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4966 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-13 18:41:17 +00:00
Bart Van Assche
76cc1e8857 fcst: Always report FC exchange errors
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4965 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-13 18:40:34 +00:00
Bart Van Assche
c71c844c21 fcst: Eliminate ft_cmd.serial
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4964 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-13 18:40:00 +00:00
Bart Van Assche
07569ed62d fcst: Micro-optimize ft_cmd_free()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4963 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-13 18:39:37 +00:00
Bart Van Assche
2381497291 fcst: Suppress a lockdep complaint
===============================
 [ INFO: suspicious RCU usage. ]
 3.10.0-rc1-debug+ #1 Tainted: G           O
 -------------------------------
fcst/ft_sess.c:194 suspicious rcu_dereference_protected() usage!
    
other info that might help us debug this:
    
rcu_scheduler_active = 1, debug_locks = 0
1 lock held by fcoethread/2/7942:
 #0:  (rcu_read_lock){.+.+..}, at: [<ffffffffa035ee30>] rcu_lock_acquire.constprop.14+0x0/0x30 [fcst]

stack backtrace:
CPU: 2 PID: 7942 Comm: fcoethread/2 Tainted: G           O 3.10.0-rc1-debug+ #1
Hardware name: Bochs Bochs, BIOS Bochs 01/01/2007
 0000000000000001 ffff88003b191c28 ffffffff81525a11 ffff88003b191c58
 ffffffff810a20ad ffff880039b7d1e8 ffff88003690c400 000000000000067a
 ffff880039b7cb88 ffff88003b191c80 ffffffffa035f67b ffff880039b7cb88
Call Trace:
 [<ffffffff81525a11>] dump_stack+0x19/0x1b
 [<ffffffff810a20ad>] lockdep_rcu_suspicious+0xfd/0x130
 [<ffffffffa035f67b>] ft_sess_get.isra.7+0x12b/0x150 [fcst]
 [<ffffffffa035f6e2>] ft_recv+0x42/0x100 [fcst]
 [<ffffffffa026edb2>] fc_lport_recv_req+0x272/0x2f0 [libfc]
 [<ffffffffa0268c3b>] fc_exch_recv+0x61b/0xdc0 [libfc]
 [<ffffffffa025f306>] fcoe_percpu_receive_thread+0x386/0x5f0 [fcoe]
 [<ffffffff8106d34b>] kthread+0xdb/0xe0
 [<ffffffff815357ac>] ret_from_fork+0x7c/0xb0



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4962 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-13 18:39:14 +00:00
Bart Van Assche
e506bd990d fcst: Fix a race condition
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4961 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-13 18:37:45 +00:00
Bart Van Assche
e41c3bf328 fcst: Fix a lockdep warning
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4960 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-13 18:37:23 +00:00
Bart Van Assche
cf8d18cba8 fcst: Remove ft_prlo() function header and a comment
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4959 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-13 18:37:00 +00:00
Bart Van Assche
049aab6dce fcst: Update a debug statement in ft_prli()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4958 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-13 18:36:32 +00:00
Bart Van Assche
62059912bf fcst: Remove two comments from ft_prli_locked()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4957 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-13 18:36:08 +00:00
Bart Van Assche
50c4c8ded9 fcst: Remove superfluous initialization from ft_sess_get()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4956 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-13 18:35:45 +00:00
Bart Van Assche
5fd500a4e9 fcst: Include version number in module description
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4955 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-13 18:35:09 +00:00
Bart Van Assche
812c33d403 fcst: Update ft_send_resp_code() function header
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4954 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-13 18:34:43 +00:00
Bart Van Assche
54b4717ffa fcst: Inline ft_send_xfer_rdy_off()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4953 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-13 18:34:19 +00:00
Bart Van Assche
c555196073 fcst: Update ft_send_response() comment header
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4952 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-13 18:33:51 +00:00
Bart Van Assche
c2cbc9fec7 fcst: Move a member variable in struct ft_sess
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4951 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-13 18:33:18 +00:00
Bart Van Assche
a578373d4e fcst: Add more debugging code in ft_sess_put()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4950 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-13 18:32:41 +00:00
Vladislav Bolkhovitin
ce2d1a93a4 Cleanup
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4949 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-13 01:43:04 +00:00
Bart Van Assche
af34653b31 nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4948 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-12 18:24:00 +00:00
Vladislav Bolkhovitin
efd6a88bba Cleanup
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4947 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-10 04:17:25 +00:00
Vladislav Bolkhovitin
f0edde2465 Emulex web updates
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4946 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-10 04:08:10 +00:00
Vladislav Bolkhovitin
f438811634 Cleanup
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4945 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-10 02:29:30 +00:00
Bart Van Assche
b103dd9949 qla2x00t: Fix q2t_close_session()
The "force_close" sysfs attribute remains to exist for some time
after q2t_close_session() finished. Avoid that q2t_close_session()
invokes q2t_sess_put() more than once by removing a session from
the session list before returning. Avoid that that disabling a
target after q2t_close_session() has been invoked triggers a call
of q2t_sess_put(). Avoid that triggering the "force_close" sysfs
attribute after a target has been disabled triggers an additional
call of q2t_sess_put().


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4944 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-09 16:19:56 +00:00
Vladislav Bolkhovitin
6de8805015 Updates for target drivers supporting both physical and virtual targets
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4943 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-06 22:20:49 +00:00
Bart Van Assche
f94393b43c scstadmin: Enable targets after the ALUA configuration has been restored
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4942 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-04 18:16:51 +00:00
Bart Van Assche
2c67878832 scstadmin: Add ALUA attribute support
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4941 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-04 18:15:28 +00:00
Bart Van Assche
e0dccf4f90 nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4937 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-04 17:34:35 +00:00
Bart Van Assche
ae088692a4 nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4936 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-03 19:25:06 +00:00
Bart Van Assche
8a1dad384f scripts/generate-kernel-patch: Follow-up for r4932
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4935 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-03 19:19:08 +00:00
Bart Van Assche
08afc26627 fcst: Do not define kref_get_unless_zero() if backported through stable tree
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4934 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-03 18:06:32 +00:00
Bart Van Assche
69b6db5f43 scripts/specialize-patch: Add support for shift operator in preprocessor expressions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4933 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-03 18:05:18 +00:00
Bart Van Assche
ce636f3fc7 scripts/generate-kernel-patch: Pass full kernel version to scripts/specialize-patch
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4932 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-03 18:03:55 +00:00
Bart Van Assche
1b94eecde7 fcst: Revert r4889 because it was wrong
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4931 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-03 15:14:19 +00:00
Vladislav Bolkhovitin
4347530168 Cleanup
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4930 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-03 01:26:32 +00:00
Vladislav Bolkhovitin
24262cfcd1 Revert r4922, because it isn't fully correct
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4929 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-08-02 07:01:33 +00:00
Bart Van Assche
5d6b0142a8 scstadmin: Fix parsing names of multi-valued attributes
When defining e.g. more than ten CHAP users in scst.conf, scstadmin
only saves the first then CHAP users. Make sure that scstadmin saves
all information defined in sysfs.

Reported-by: Artur Piechocki <artur.piechocki@open-e.com>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4928 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-07-30 10:49:02 +00:00
Bart Van Assche
dfe644834c scstadmin: Save multi-valued attributes sorted
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4927 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-07-30 10:41:15 +00:00
Bart Van Assche
75f9be4b34 iscsi-scst: Spelling fix - change dublicate into duplicate
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4926 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-07-29 10:43:00 +00:00
Bart Van Assche
8b0230b152 ib_srpt: Introduce srpt_init_tgt()
This patch does not change any functionality.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4925 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-07-29 07:08:14 +00:00
Bart Van Assche
bcfec543b9 nightly build: Add kernel 3.10
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4924 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-07-27 08:17:40 +00:00
Vladislav Bolkhovitin
e90730014c Cleanup: cdb_len was just checked a couple of lines above
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4923 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-07-27 01:12:22 +00:00
Vladislav Bolkhovitin
7a1bb6544c Fix out of SN commands handling
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4922 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-07-27 01:11:10 +00:00
Vladislav Bolkhovitin
2e9540c902 Update for kernel 3.10
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4921 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-07-25 23:38:31 +00:00
Vladislav Bolkhovitin
5b1ee63f2f Make ALUA commands filtering more CPU cache friendly
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4920 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-07-23 02:22:01 +00:00