Commit Graph

7876 Commits

Author SHA1 Message Date
Bart Van Assche
c86e77e3de Merge branch 'svn-trunk' 2020-08-02 20:39:07 -07:00
Bart Van Assche
f397c9558c Fix scst-dkms-rpm build for EL mainline kernels
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9105 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-03 03:39:01 +00:00
Bart Van Assche
f0214a59bb Fix rpm build for EL mainline kernels
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9104 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-03 03:38:01 +00:00
Bart Van Assche
db5448f2ec Merge branch 'svn-trunk' 2020-08-02 20:37:25 -07:00
Bart Van Assche
8f70a32bd3 Merge pull request #28 from dodexahedron/master
Fix RPM builds on EL mainline kernels
2020-08-02 20:36:11 -07:00
Bart Van Assche
2bafc3bd51 scst: Fix three potential integer overflows
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9103 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-03 03:29:33 +00:00
dodexahedron
5a2b284329 Fix rpm build for EL mainline kernels 2020-08-02 20:18:36 -07:00
dodexahedron
af55e8d9b3 Fix scst-dkms-rpm build for EL mainline kernels 2020-08-02 20:17:21 -07:00
Bart Van Assche
0aed574e88 scripts/generate-kernel-patch: Make this script appropriate for the trunk and 3.4.x branches
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9098 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-03 02:56:37 +00:00
Bart Van Assche
cbf092f815 Merge branch 'svn-trunk' 2020-08-02 15:55:59 -07:00
Bart Van Assche
c973152d8d qla2x00t, qla2x00t-32gbit: Remove unused code
This was detected by the clang compiler.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9096 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-02 22:55:54 +00:00
Bart Van Assche
9bef06a02f Merge branch 'svn-trunk' 2020-08-02 15:54:47 -07:00
Bart Van Assche
c22a2d11b1 iscsi-scst: Fix the CONFIG_IPV6=n build
See also https://github.com/bvanassche/scst/issues/23.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9095 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-02 22:54:39 +00:00
Bart Van Assche
b1331f9a90 qla2x00t-32gbit: Fix the RHEL / CentOS 8.2 build
This patch has been tested against kernel version 4.18.0-193.14.2.el8_2.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9094 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-02 21:54:29 +00:00
Bart Van Assche
3fd6a8c93c nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9093 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-02 21:53:42 +00:00
Bart Van Assche
ca607d88dd qla2x00t-32gbit: Change two fxdisc_entry_fx00 members from a scalar into an array
This patch does not change any functionality but suppresses a Coverity
warning.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9092 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-02 21:53:19 +00:00
Bart Van Assche
757b42c2ba qla2x00t: Fix two buffer overflows
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9091 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-02 21:22:13 +00:00
Bart Van Assche
1b5e2eb482 isert-scst: Fail login if max_sge is too small
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9090 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-02 21:21:38 +00:00
Bart Van Assche
ecea60a694 Make it possible to build SCST with clang
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9089 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-02 21:19:24 +00:00
Bart Van Assche
4762af5cec Merge branch 'svn-trunk' 2020-07-28 19:05:40 -07:00
Bart Van Assche
454c3fb81f Fix the qla2x00t-32gbit build on CentOS 8.2
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9087 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-29 01:59:10 +00:00
Bart Van Assche
d630389413 Merge branch 'svn-trunk' 2020-07-26 16:59:27 -07:00
Bart Van Assche
93c7dae589 nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9086 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-26 23:53:39 +00:00
Bart Van Assche
32aa14938d Merge branch 'svn-trunk' 2020-07-26 16:53:02 -07:00
Bart Van Assche
86d602973b iscsi-scst: Make this kernel module again independent of (M)OFED
This patch reverts f58c8248dd ("iscst-scst: Fix the OFED build"). This
patch partially reverts bd3355500a ("iscsi-scst, srpt: Rename the
PRE_CFLAGS variable into CONFTEST_FLAGS").


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9085 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-26 23:52:40 +00:00
Bart Van Assche
ebb024ff68 scst/include/backport.h: Backport qla2x00t-32gbit to older kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9084 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-26 23:51:54 +00:00
Bart Van Assche
5106544817 Merge branch 'svn-trunk' 2020-07-25 20:35:01 -07:00
Bart Van Assche
f58c8248dd iscst-scst: Fix the OFED build
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9083 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-26 03:34:55 +00:00
Bart Van Assche
bd3355500a iscsi-scst, srpt: Rename the PRE_CFLAGS variable into CONFTEST_FLAGS
The latter name reflects better the role of this variable. Remove the
CPPFLAGS assignment from srpt/src/Kbuild because it is not useful.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9082 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-26 03:34:35 +00:00
Bart Van Assche
214628043e qla2x00t: Remove a useless assignment
This was detected by the clang compiler.

Fixes: c006b05884 ("Update of the initiator driver to one from kernel 2.6.26. Sorry, the prior kernels not supported anymore, but backport patches are welcome.") # r473.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9081 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-26 03:33:03 +00:00
Bart Van Assche
93c2711530 iscsi-scst, srpt: Modify the message that reports which kernel headers are used
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9080 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-26 03:31:02 +00:00
Bart Van Assche
1c53adafe5 Merge branch 'svn-trunk' 2020-07-25 20:04:10 -07:00
Bart Van Assche
7cfc811542 Rename srpt/src/Makefile into srpt/src/Kbuild
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9079 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-26 02:58:29 +00:00
Bart Van Assche
bad54e8981 Merge branch 'svn-trunk' 2020-07-25 19:53:59 -07:00
Bart Van Assche
856bd8c1a1 configure tests: Rename Makefiles into Kbuild
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9078 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-26 02:52:51 +00:00
Bart Van Assche
fb0913e9fa Merge branch 'svn-trunk' 2020-07-25 17:58:29 -07:00
Bart Van Assche
2029062924 iscsi-scst, ib_srpt: Add a MODULE_LICENSE() to the configure tests
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9077 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-26 00:53:52 +00:00
Bart Van Assche
203d427368 iscsi-scst/kernel/isert-scst/Kbuild: Revert r9075 because it triggers duplicate symbol warnings on x86
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9076 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-26 00:49:48 +00:00
Bart Van Assche
9dda1ab49e Merge branch 'svn-trunk' 2020-07-25 07:47:36 -07:00
Bart Van Assche
770ffb6553 qla2x00t-32gbit: Address a set of sparse warnings
Fix the following sparse warnings:

drivers/scsi/qla2xxx/qla_isr.c:881:23: warning: restricted __le16 degrades to integer
drivers/scsi/qla2xxx/qla_isr.c:881:23: warning: cast to restricted __le16

Link: https://lore.kernel.org/r/20200715043358.21668-1-njavali@marvell.com
Signed-off-by: Shyam Sundar <ssundar@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

See also commit 58101f1504ad9b36e34533ec1fb01a8de80aa6d6 upstream.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9075 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-25 14:47:24 +00:00
Bart Van Assche
7b375842e9 qla2x00t-32gbit: Fix two recently introduced build errors
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9074 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-25 14:45:27 +00:00
Bart Van Assche
4f36320d77 ib_srpt, iscsi-scst: Add the configure tests necessary for building against kernel v5.8
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9073 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-25 14:42:04 +00:00
Bart Van Assche
e675bc7b0a qla2x00t-32gbit: SAN congestion management implementation
* Firmware Initialization with SCM enabled based on NVRAM setting and
  firmware support (About Firmware).

* Enable PUREX and add support for fabric performance impact
  notification (FPIN) handling.

* Allocate a default PUREX item for each vha to handle memory allocation
  failures in ISR.

Link: https://lore.kernel.org/r/20200630102229.29660-3-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Reviewed-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Shyam Sundar <ssundar@marvell.com>
Signed-off-by: Arun Easi <aeasi@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

See also commit 9f2475fe7406b8ef5f97099c4980021344872d9f upstream.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9072 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-25 14:37:22 +00:00
Bart Van Assche
786c8d6fd3 qla2x00t-32gbit: Change in PUREX to handle FPIN ELS requests
SAN Congestion Management generates ELS pkts whose size can vary and be >
64 bytes. Change the PUREX handling code to support non-standard ELS pkt
size.

Link: https://lore.kernel.org/r/20200630102229.29660-2-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Shyam Sundar <ssundar@marvell.com>
Signed-off-by: Arun Easi <aeasi@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

See also commit 62e9dd177732843ae6c5b9d2ed61e7c9538fa276 upstream.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9071 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-25 14:35:24 +00:00
Bart Van Assche
977661eb0e qla2x00t-32gbit: Introduce a function for computing the debug message prefix
Instead of repeating the code for generating a debug message prefix six
times, introduce a function for computing the debug message prefix.

Link: https://lore.kernel.org/r/20200629225454.22863-10-bvanassche@acm.org
Cc: Nilesh Javali <njavali@marvell.com>
Cc: Quinn Tran <qutran@marvell.com>
Cc: Himanshu Madhani <himanshu.madhani@oracle.com>
Cc: Martin Wilck <mwilck@suse.com>
Cc: Roman Bolshakov <r.bolshakov@yadro.com>
Reviewed-by: Daniel Wagner <dwagner@suse.de>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

See also upstream commit e7019c95c40daf8e8a9fa1d5f36eabce2eb8ef6b.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9070 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-25 14:29:24 +00:00
Bart Van Assche
38ed627b73 qla2x00t-32gbit: Make qla2x00_restart_isp() easier to read
Instead of using complicated control flow to only have one return statement
at the end of qla2x00_restart_isp(), return an error status as soon as it
is known that this function will fail.

Link: https://lore.kernel.org/r/20200629225454.22863-9-bvanassche@acm.org
Cc: Nilesh Javali <njavali@marvell.com>
Cc: Quinn Tran <qutran@marvell.com>
Cc: Himanshu Madhani <himanshu.madhani@oracle.com>
Cc: Martin Wilck <mwilck@suse.com>
Cc: Roman Bolshakov <r.bolshakov@yadro.com>
Reviewed-by: Daniel Wagner <dwagner@suse.de>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

See also commit f85a299f5ec55c82403cd2bc4aeaaedebfcf5ef6 upstream.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9069 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-25 14:22:07 +00:00
Bart Van Assche
b7f0ee3cde qla2x00t-32gbit: Fix a Coverity complaint in qla2100_fw_dump()
'cnt' can exceed the size of the risc_ram[] array. Prevent that Coverity
complains by rewriting an address calculation expression. This patch fixes
the following Coverity complaint:

CID 337803 (#1 of 1): Out-of-bounds read (OVERRUN)
109. overrun-local: Overrunning array of 122880 bytes at byte offset 122880
by dereferencing pointer &fw->risc_ram[cnt].

Link: https://lore.kernel.org/r/20200629225454.22863-8-bvanassche@acm.org
Cc: Nilesh Javali <njavali@marvell.com>
Cc: Quinn Tran <qutran@marvell.com>
Cc: Himanshu Madhani <himanshu.madhani@oracle.com>
Cc: Martin Wilck <mwilck@suse.com>
Cc: Roman Bolshakov <r.bolshakov@yadro.com>
Reviewed-by: Daniel Wagner <dwagner@suse.de>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

See also commit 57fec9f24e580d8fe4219ee89572f49758e62c75 upstream.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9068 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-25 14:21:25 +00:00
Bart Van Assche
41d7c4e1fd qla2x00t-32gbit: Make __qla2x00_alloc_iocbs() initialize 32 bits of request_t.handle
The request_t 'handle' member is 32-bits wide, hence use wrt_reg_dword().
Change the cast in the wrt_reg_byte() call to make it clear that a regular
pointer is casted to an __iomem pointer.

Note: 'pkt' points to I/O memory for the qlafx00 adapter family and to
coherent memory for all other adapter families.

This patch fixes the following Coverity complaint:

CID 358864 (#1 of 1): Reliance on integer endianness (INCOMPATIBLE_CAST)
incompatible_cast: Pointer &pkt->handle points to an object whose effective
type is unsigned int (32 bits, unsigned) but is dereferenced as a narrower
unsigned short (16 bits, unsigned). This may lead to unexpected results
depending on machine endianness.

Link: https://lore.kernel.org/r/20200629225454.22863-7-bvanassche@acm.org
Fixes: 8ae6d9c7eb10 ("[SCSI] qla2xxx: Enhancements to support ISPFx00.")
Cc: Nilesh Javali <njavali@marvell.com>
Cc: Quinn Tran <qutran@marvell.com>
Cc: Himanshu Madhani <himanshu.madhani@oracle.com>
Cc: Martin Wilck <mwilck@suse.com>
Cc: Roman Bolshakov <r.bolshakov@yadro.com>
Reviewed-by: Daniel Wagner <dwagner@suse.de>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

See also commit f8f12bda53eae87ca2dea42b36d19e48c9851b9f upstream.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9067 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-25 14:20:47 +00:00
Bart Van Assche
82ae3e17f4 qla2x00t-32gbit: Remove a superfluous cast
Remove an unnecessary cast because it prevents the compiler to perform type
checking.
    
Link: https://lore.kernel.org/r/20200629225454.22863-6-bvanassche@acm.org
Cc: Nilesh Javali <njavali@marvell.com>
Cc: Quinn Tran <qutran@marvell.com>
Cc: Himanshu Madhani <himanshu.madhani@oracle.com>
Cc: Martin Wilck <mwilck@suse.com>
Cc: Roman Bolshakov <r.bolshakov@yadro.com>
Reviewed-by: Daniel Wagner <dwagner@suse.de>
Reviewed-by: Shyam Sundar <ssundar@marvell.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

See also commit 9bb013584a5ea18dfae89e33ded130cae08eb135 upstream.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9066 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-25 14:19:55 +00:00
Bart Van Assche
6c298568e9 qla2x00t-32gbit: Initialize 'n' before using it
The following code:
   
	qla82xx_rom_fast_read(ha, 0, &n)

only initializes 'n' if it succeeds. Since 'n' may be reported in a debug
message even if no ROM reads succeeded, initialize 'n' to zero.

This patch fixes the following sparse warning:

qla_nx.c:1218: qla82xx_pinit_from_rom() error: uninitialized symbol 'n'.

Link: https://lore.kernel.org/r/20200629225454.22863-5-bvanassche@acm.org
Cc: Nilesh Javali <njavali@marvell.com>
Cc: Quinn Tran <qutran@marvell.com>
Cc: Himanshu Madhani <himanshu.madhani@oracle.com>
Cc: Martin Wilck <mwilck@suse.com>
Cc: Roman Bolshakov <r.bolshakov@yadro.com>
Reviewed-by: Daniel Wagner <dwagner@suse.de>
Reviewed-by: Shyam Sundar <ssundar@marvell.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

See also commit 67668b5b13c7ba12f212d4b9067e54354ce5360b upstream.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9065 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-25 14:19:14 +00:00