Commit Graph

567 Commits

Author SHA1 Message Date
Vladislav Bolkhovitin
e54c3872bc Update to initiator driver from 2.6.27
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@578 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-20 18:58:53 +00:00
Vladislav Bolkhovitin
d908081912 - SGV cache related parameters moved from scst.h to scst_sgv.h
- Minor updates



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@577 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-20 17:05:08 +00:00
Vladislav Bolkhovitin
371e083d06 Prevent memory leaks in error paths by deferring
allocation until we have checked for errors. Also, fix the host ID
(target #) to be one larger than the max target ID for the host. Also,
reduce the number of outstanding commands per LUN to 1 (although this
might not be needed). Also scst_lcl_ini_driver_template flags cleanup.

Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>
Signed-off-by: Vladislav Bolkhovitin <vst@vlnb.net>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@576 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-19 11:37:45 +00:00
Vladislav Bolkhovitin
7edb4c0c72 Fix for memory overwrite-after-free bug in scst_local
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@575 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-19 10:55:58 +00:00
Vladislav Bolkhovitin
31c2ada297 The patch below implements the following modifications for
scripts/run-regression-tests:
- Adds a description about what the script does.
- Added command-line option -c which allows to specify which directory to use
  as cache for kernel tar balls and patch files.
- More error checking.
- scst_local is now included in all the tests.
- Swapped the order of two test steps, namely compiling the whole tree and
  running sparse. This way the output of the sparse tool is available a lot
  sooner.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@574 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-18 18:47:09 +00:00
Vladislav Bolkhovitin
bad0bad3da The patch below fixes two categories of checkpatch
complaints on scst_local, namely "line over 80 columns" and "use tabs to indent
instead of spaces".

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@573 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-18 18:45:13 +00:00
Vladislav Bolkhovitin
ec7d33e537 Log level for "Warning: expected transfer length X for opcode Y" changed to be disabled by default for release build
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@572 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-18 18:42:09 +00:00
Vladislav Bolkhovitin
e882fcec37 The patch below fixes sparse warnings about int / unsigned int mismatches in
the iscsi-scst source code.

This patch has been verified by reviewing it carefully and by verifying the
output files of the command scripts/run-regression-tests -k 2.6.27.6.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@571 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-18 18:23:08 +00:00
Vladislav Bolkhovitin
caa419d49d Cleanup
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@570 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-13 16:14:06 +00:00
Vladislav Bolkhovitin
b0c6d9a561 The patch below fixes many checkpatch warnings triggered by the iSCSI kernel
code, mainly about lines that exceeded 80 columns. As you can see in the patch
below most lines that were too long have been split, but some code has also
been moved into helper functions in order to keep the code readable. No
functionality has been changed.

This patch has been verified as follows:
- Reread the patch carefully.
- Verified that the iSCSI target kernel module still loads.
- Verified the output generated by scripts/run-regression-tests -k 2.6.27.5.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>

with some modifications



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@569 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-12 18:49:18 +00:00
Vladislav Bolkhovitin
190e00f6d2 Here is the patch to fix problems with scst_local and 2.6.24 or earlier (tested by building under 2.6.24).
Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>

This line, and those below, will be ignored--

M    trunk/scst_local/scst_local.c



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@568 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-11 12:04:52 +00:00
Vladislav Bolkhovitin
47422bf856 Added possibility to coexist if both target driver and dev handler need custom memory allocation. Direct consequences:
1. scst_local can work with scst_user's devices

2. scst_user now compatible with iscsi-scst if put_page_callback not applied

+ some cosmetics



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@567 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-11 11:56:18 +00:00
Vladislav Bolkhovitin
e967b30f95 Small cleanup of unused code
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@566 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-10 17:23:23 +00:00
Vladislav Bolkhovitin
95c93b2626 Depecated scst_cmd_get_tgt_resp_flags() removed
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@565 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-10 17:21:09 +00:00
Vladislav Bolkhovitin
2177758f82 Fixes warning:
trunk/scst_local/scst_local.c:907: warning: initialization from incompatible pointer type



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@564 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-10 17:11:48 +00:00
Vladislav Bolkhovitin
6822e4f6cf Added proposed patch to solve SG IO count limitation issue in pass-through mode. It allows SGV cache do allocation
of pages with order > 0, i.e. more than 1 page per SG entry. Web and doc updated correspondingly.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@563 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-07 18:47:17 +00:00
Vladislav Bolkhovitin
3842a0af02 Make SWP and TAS parameters changable in vdisk handler.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@562 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-06 12:06:58 +00:00
Vladislav Bolkhovitin
55153a772c Attached is a patch that I think makes scst_local properly handle multiple targets per host.
Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@561 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-05 18:56:31 +00:00
Vladislav Bolkhovitin
27dc521710 Cleanup: one more __GFP_NOFAIL removed
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@560 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-01 11:45:26 +00:00
Vladislav Bolkhovitin
b748ebde74 Small optimization
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@559 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-31 18:56:01 +00:00
Vladislav Bolkhovitin
06905f3e57 Follow-up improvements to r556
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@558 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-31 16:17:08 +00:00
Vladislav Bolkhovitin
3379376993 - Fixed incorrect SCST state used on error path
- Small cleanups
 - ToDo entry added


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@557 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-31 11:16:47 +00:00
Vladislav Bolkhovitin
90c831b838 Cleanup removing usage of in_atomic(). Particularly, now target drivers and dev handlers need to explicitly supply preferred execution context in scst_cmd_done() and scst_tgt_cmd_done().
WARNING! This commit changes external SCST interface, so it can break compilation of your out of SCST SVN tree target driver or dev handler. To fix it, simply supply the preferred exection context to scst_cmd_done() and/or scst_tgt_cmd_done().

Thanks to Bart Van Assche <bart.vanassche@gmail.com> for pointing on it.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@556 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-31 10:49:25 +00:00
Vladislav Bolkhovitin
c89dae4cb4 The patch below fixes the following:
* Lots of checkpatch warnings about lines over 80 characters.
* Checkpatch errors about code indent should use tabs where possible (same issues as reported by Dotan Barak).
* One checkpatch warning about braces {} are not necessary for single statement blocks.
* Sparse warnings about missing declarations.
* Sparse warnings about using 0 instead of NULL.

This patch has been verified by reviewing it carefully and by verifying the
output files of the command scripts/run-regression-tests -k 2.6.27.3.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>

With changes



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@555 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-30 20:17:42 +00:00
Vladislav Bolkhovitin
0b3215695d The patch below fixes the checkpatch warnings for source files in the
directory scst/include about lines that exceed 80 columns.

This patch has been verified by rereading the patch carefully, and by verifying
that SCST source code still compiles fine.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@554 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-30 19:11:04 +00:00
Vladislav Bolkhovitin
3d4486cfb9 The patch below fixes a few more warnings about lines that exceed 80 columns.
This patch has been verified by rereading the patch carefully, and by verifying
that SCST source code still compiles fine.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@553 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-30 18:59:23 +00:00
Vladislav Bolkhovitin
75d2a4b1a2 The patch below adds the first version of a script that runs regression tests
to the SCST source tree. All tests are run in an automated fashion, but result
interpretation is not yet completely automated.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@552 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-30 12:43:20 +00:00
Vladislav Bolkhovitin
0b2be958e9 The patch below makes the srpt driver compile against the 2.6.27 kernel
headers.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
Acked-by: Vu Pham <vu@mellanox.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@551 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-30 12:34:48 +00:00
Vladislav Bolkhovitin
b35c83dbe2 Fixes wrong sess_count decrement on session registration failure
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@549 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-30 12:22:48 +00:00
Vladislav Bolkhovitin
fe84b1f26b The iscsi-scst kernel module does not get compiled even with CONFIG_SCST_ISCSI
set to m or y. The patch below fixes this.

This patch has been verified by rerunning scripts/run-regression-tests -k 2.6.27.3
and by verifying that the kernel build produced a iscsi-scst.ko kernel module.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@548 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-28 20:43:38 +00:00
Vladislav Bolkhovitin
d5dc2fed6a By testing kernel patch generation for the mpt driver I found out that the
Kconfig and Makefile were read from the wrong directory. The patch below fixes
this.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@547 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-28 20:41:29 +00:00
Vladislav Bolkhovitin
7782dc0768 Release/debug/perf patches updated
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@546 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-28 20:38:49 +00:00
Vladislav Bolkhovitin
0411713796 Small improvement
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@545 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-28 20:30:47 +00:00
Vladislav Bolkhovitin
3fc14278b5 Fixed accidentally enabled superfluous warnings.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@544 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-28 20:19:07 +00:00
Vladislav Bolkhovitin
905eb033a4 Release/debug/perf patches updated + cosmetics in scst/src/dev_handlers/Makefile
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@543 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-25 18:49:47 +00:00
Vladislav Bolkhovitin
54b2a0a5b9 -Wno-missing-field-initializers added. Small cleanup.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@542 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-25 17:31:10 +00:00
Vladislav Bolkhovitin
c76083f036 Fixes 2 incorrectly used variables
Signed off by: Richard Sharpe <realrichardsharpe@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@541 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-25 17:14:08 +00:00
Vladislav Bolkhovitin
79e315a82f A typo fixed
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@540 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-24 15:04:20 +00:00
Vladislav Bolkhovitin
2688d2b8c4 The patch below fixes the sparse warnings in ib_srpt.c about missing
declarations by inserting the keyword static where appropriate.

This patch has been verified by rereading the patch carefully, and by verifying
that SCST source code still compiles fine.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@539 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-24 12:14:11 +00:00
Vladislav Bolkhovitin
6077bb04e5 The patch below fixes more checkpatch warnings about lines that are over
eighty columns, and more sparse warnings about missing declarations by
inserting the keyword static where appropriate. A sparse warning about a
shadowed variable (ucmd) is also fixed.

This patch has been verified by rereading the patch carefully, and by verifying
that SCST source code still compiles fine.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@538 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-24 12:11:17 +00:00
Vladislav Bolkhovitin
6544d6716b - Minor context cleanup
- Minor doc update


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@537 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-24 11:52:12 +00:00
Vladislav Bolkhovitin
20658918dc Web updates
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@536 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-24 11:50:36 +00:00
Dotan Barak
d7d2f38d5e Fix missing removal of DECLARE_MUTEX_UNLOCKED noticed by Shai.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@535 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-24 00:19:11 +00:00
Vladislav Bolkhovitin
8e234f8824 Fixes problems spotted by lockdep
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@534 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-23 12:06:39 +00:00
Vladislav Bolkhovitin
7f62d55dde Replace SCSI_TRY_RESET_BUS by SCSI_TRY_RESET_TARGET, which is more appropriate for TARGET RESET TM
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@533 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-23 12:03:22 +00:00
Dotan Barak
d247bbbd5e Get rid of obsolete DECLARE_MUTEX_LOCKED usage.
Call device_create with extra driver data argument (NULL)
on 2.6.27 and later.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@532 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-22 21:45:16 +00:00
Vladislav Bolkhovitin
80ea13642f Patch from Bart Van Assche <bart.vanassche@gmail.com> with some minor changes/additions:
The patch below fixes the checkpatch warnings about lines that are over eighty
columns, and the sparse warnings about missing declarations by inserting the
keyword static where appropriate.

This patch has been tested by rereading the patch carefully, and by verifying
that SCST source code still compiles fine.

Also extracheck in_interrupt() was added in scst_cmd_atomic()



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@531 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-22 18:45:05 +00:00
Vladislav Bolkhovitin
9af236707e The patch below implements the following changes:
- Add a dummy Signed-off-by line to the generated patch, such that checkpatch
  doesn't complain that it's missing.
- Sort the names of source files (through ls) before using these, such that
  the generated patch is the same during each run.
- Fixed a bug in #elif handling (this bug is not triggered by the current SCST
  code).

This patch has been tested by comparing the output of the old and the new
generate-kernel-patch script.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@530 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-22 17:47:28 +00:00
Vladislav Bolkhovitin
1eeffbb3da The first approximation to update to 2.6.27 + minor fixes, particularly remove of unused variable and add full path to depmod in Makefiles. Partially done by Bart Van Assche <bart.vanassche@gmail.com>.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@529 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-21 11:51:52 +00:00
Vladislav Bolkhovitin
66bc3f06a3 The patch below implements the following changes:
- Converted tabs to spaces in the help text.
- Removed command-line option '-s' -- the srpt driver is now always included.
- Recognizes now both kernel versions with three components (x.y.z) and kernel
  versions with four components (x.y.z.p).
- Empty files for Kconfig and Makefile are added for those components that are
  not included in the kernel patch, such that make allyesconfig
  / make allmodconfig keeps working.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@528 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-21 10:23:42 +00:00