Bart Van Assche
efca492e93
fcst: Revert r9181
...
This change is necessary for kernel v5.11 instead of v5.10 so revert it
for now.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9186 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-11-22 03:08:08 +00:00
Bart Van Assche
39b6e87935
scst: Unbreak the build for kernel 4.1.12-124.45.2.el7uek.x86_64
...
Apparently this kernel has kvmalloc_node(), kvmalloc() and kvzalloc()
backports but no kvmalloc_array() backport.
See also the following commits:
* c027b9de7e ("scst: Port to UEK 4")
* 23a2753a9c ("scst/include/backport.h: Add backports for additional kernel functions, constants and data structures")
Reported-by: Gilbert Standen <gilstanden@hotmail.com >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9185 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-11-21 03:04:57 +00:00
Bart Van Assche
a952a3584b
scst: Unbreak the build for kernel versions 3.0..4.16
...
Reported-by: Gilbert Standen <gilstanden@hotmail.com >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9184 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-11-19 03:47:09 +00:00
Bart Van Assche
af0b6a2895
scripts/specialize-patch: Handle _COMPAT_LINUX_MM_H correctly
...
Fixes: 5930b4db71 ("scst: Fix the MOFED build")
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9183 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-11-19 03:46:04 +00:00
Bart Van Assche
ca9d681fd0
scst: Fix the kobj_ns_grab_current() and kobj_ns_drop() backports
...
Reported-by: Gilbert Standen <gilstanden@hotmail.com >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9182 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-11-18 01:30:33 +00:00
Bart Van Assche
1686029f60
fcst: Port to Linux kernel v5.10
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9181 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-11-16 04:34:24 +00:00
Bart Van Assche
ac6485df69
ib_srpt: Port to Linux kernel v5.10
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9180 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-11-16 03:54:37 +00:00
Bart Van Assche
aaf96673e6
scst: Unbreak the UEK 4 build
...
UEK 4 RPMs like kernel-uek-4.14.35-2025.402.2.1.el7uek.x86_64 include a
backport of cpu_to_be32_array() and kvcalloc(). Hence disable the SCST
backports for these functions when building against UEK 4.
Reported-by: Gilbert Standen <gilstanden@hotmail.com >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9179 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-11-14 17:20:30 +00:00
Bart Van Assche
143e9c9684
ib_srpt: Use a workqueue for processing RDMA completions
...
Use a workqueue for processing RDMA completions instead of creating one
kernel thread per RDMA channel. This change improves performance if the
number of RDMA channels is large by reducing the number of context
switches between kernel threads while processing RDMA completions. An
additional change is that srpt_set_ch_state() no longer wakes up the
RDMA completion context but that srpt_cm_rtu_recv() wakes up the RDMA
completion context instead.
See also https://github.com/bvanassche/scst/issues/33 .
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9178 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-11-03 04:56:01 +00:00
Bart Van Assche
0ab62f9527
Fix more issues detected by checkpatch
...
Leave a blank line between declarations and definitions. Remove duplicate
words from comments.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9177 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-11-02 02:07:17 +00:00
Bart Van Assche
98285d10fd
Various fixes for issues detected by checkpatch
...
- Return EOPNOTSUPP instead of ENOTSUPP to user space.
- Do not terminate macro definitions with a trailing semicolon.
- Do not initialize static variables to zero.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9176 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-11-02 02:06:04 +00:00
Bart Van Assche
ed163b4241
nightly build: Update kernel versions
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9175 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-11-01 22:54:47 +00:00
Bart Van Assche
20e0fe94f5
scst: Fix allocation of memory for latency statistics for the GFP_ATOMIC case
...
See also https://sourceforge.net/p/scst/tickets/43/ .
Reported-by: Steven Siwinski <steve-atto@users.sourceforge.net >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9174 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-10-29 03:23:04 +00:00
Bart Van Assche
70fd08dde6
scst: Also install the build_mode.h header file
...
Reported-by: Steven Siwinski <steve-atto@users.sourceforge.net >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9173 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-10-21 03:37:50 +00:00
Bart Van Assche
2fb10fb2ff
scstadmin: Restore support for replacing LUNs that are inside a group
...
Fixes: a3266ca8f2 ("scstadmin: Remove support for the "new" sysfs interface")
Reported-by: Pavel Klevtsov
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9172 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-10-14 03:31:59 +00:00
Bart Van Assche
a4ea5c02e1
iscsi-scst: Fix SHA-1 algorithm number
...
According to
https://www.iana.org/assignments/ppp-numbers/ppp-numbers.xml#ppp-numbers-9
the value of the SHA-1 algorithm is 6 and not 7, as it is now in
iscsi-scst/usr/chap.c. If on a client side node.session.auth.chap_algs is
SHA1, login fails.
Signed-off-by: Lev Vainblat <lev@zadarastorage.com >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9171 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-10-14 02:15:33 +00:00
Bart Van Assche
1b2bdd56b5
nightly build: Update kernel versions
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9170 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-10-02 02:35:39 +00:00
Vladislav Bolkhovitin
de7a490d4a
Minor web fix
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9169 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-23 19:38:11 +00:00
Bart Van Assche
59f38038ab
iscsi-scst: Remove an obsolete comment
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9168 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-19 17:01:31 +00:00
Bart Van Assche
741d1d38dc
scst: Partially revert r9166
...
Apparently the RHEL 8.2 gcc compiler reports an error if
__attribute__((fallthrough)) is used outside a switch statement. Hence this
patch that converts some of these annotations back into comments.
Reported-by: Rob Turk <robtu@rtist.nl >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9167 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-19 00:28:44 +00:00
Bart Van Assche
186798cec4
Use the fallthrough macro instead of a comment
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9166 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-16 14:28:36 +00:00
Bart Van Assche
570a36ffd2
scripts/checkpatch: Only analyze kernel source code
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9165 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-16 14:27:44 +00:00
Bart Van Assche
5969e85967
nightly build: Update kernel versions
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9164 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-16 03:02:36 +00:00
Bart Van Assche
4933f27d8d
scst: Make scst/include/backport.h again compatible with MOFED
...
Fix the following build failure on RHEL 7 + MOFED 5.0:
In file included from <command-line>:0:0:
/usr/src/ofa_kernel/default/include/linux/compat-2.6.h:40:29: warning: "__GCC4_has_attribute___fallthrough__" is not defined [-Wundef]
# define __has_attribute(x) __GCC4_has_attribute_##x
^
/usr/src/packages/BUILD/scst-3.5.0.7946/iscsi-scst/kernel/isert-scst/../../../scst/include/backport.h:250:5: note: in expansion of macro '__has_attribute'
#if __has_attribute(__fallthrough__)
Reported-by: Chesnokov Gleb <Chesnokov.G@raidix.com >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9163 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-16 02:59:28 +00:00
Bart Van Assche
443c7ec5d9
scstadmin: Make argument checking more systematic
...
Additionally, suppress warning messages about 'length(undefined)' on RHEL 6.x.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9162 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-15 03:47:40 +00:00
Bart Van Assche
9d9ae0f153
scst: Restore compatibility with gcc 4.x (RHEL 7.x)
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9161 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-15 03:44:03 +00:00
Bart Van Assche
85fed6fa4a
scst: Restore compatibility with RHEL 6.x
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9160 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-15 03:43:05 +00:00
Bart Van Assche
4023bdadbd
scstadmin: Fix a Perl warning
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9159 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-14 18:00:55 +00:00
Bart Van Assche
6d60231631
scstadmin: Support passing an empty string to set*Attribute()
...
Validate the $value argument of set functions with defined() instead of
length(). Append a newline to the end of $value before writing it into
a sysfs attribute to make sure something gets written if $value eq "".
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9158 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-14 01:56:26 +00:00
Bart Van Assche
7e3fe7a80e
scstadmin: Fix the readOnly() subroutine
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9157 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-14 01:54:26 +00:00
Bart Van Assche
c121a6ded8
scstadmin: Adjust source code formatting
...
Remove a single space that follows a unary negation operator.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9156 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-14 01:53:27 +00:00
Bart Van Assche
7e012f4a80
scstadmin: Improve error reporting
...
Report "Failed to set a SCST attribute" instead of "SCST attribute specified
is static" if modifying of an attribute fails.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9155 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-13 23:29:44 +00:00
Bart Van Assche
3825bf2093
scstadmin Makefile: Show diff if a regression test fails
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9154 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-13 22:42:19 +00:00
Bart Van Assche
95993cd9fd
scstadmin/scstadmin.sysfs/scst-1.0.0/t/07-scstadmin-args.t: Filter out ib_srpt
...
The scstadmin output for the ib_srpt driver depends on whether or not an
RDMA HCA is present and also on the port GUIDs. Hence filter out the
ib_srpt data.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9153 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-13 22:16:05 +00:00
Bart Van Assche
8d3c1cf3a2
scstadmin: Use length($var) to test whether an argument has been specified
...
This patch fixes a bug by making it again possible to use "0" as e.g. the
name of an SCST device group. See also commit 858f50e4d3 ("scstadmin:
Improve robustness").
Reported-by: Pavel Klevtsov
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9152 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-13 03:20:47 +00:00
Bart Van Assche
a3266ca8f2
scstadmin: Remove support for the "new" sysfs interface
...
Around 2011 a sysfs-tree-changes branch was created in the SourceForge
repository because Greg KH asked to rework the SCST sysfs interface. That
interface is called the "new" sysfs interface. The current and only used
API is called the "old" sysfs interface. Since the "new" sysfs interface
never had any users other than myself, remove support for that interface.
See also commit a66cbc4115 ("scstadmin: Add support for the sysfs
interface provided by the code on the sysfs-tree-changes branch").
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9151 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-13 03:12:26 +00:00
Bart Van Assche
ad546b1e68
scst: Add support for wildcard matching to the copy manager
...
Reported-by: L <514005989@qq.com >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9150 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-05 04:21:56 +00:00
Bart Van Assche
bd3aa5d4a5
iscsi-scst: Port to Linux kernel v5.9
...
In Linux kernel v5.9 use of the KERNEL_SOCKPTR() function is mandatory
when calling setsockopt(). Implement that function for kernels before v5.9.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9149 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-29 21:16:47 +00:00
Bart Van Assche
10ede52dd9
nightly build: Update kernel versions
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9148 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-29 16:11:39 +00:00
Bart Van Assche
ac08491d6a
scst/include/backport.h: Backport the fallthrough macro
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9147 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-29 16:11:31 +00:00
Bart Van Assche
bb63af5901
qla2xxx: Fix wrong return value in qla_nvme_register_hba()
...
On an error exit path, a negative error code should be returned instead of
a positive return value.
Link: https://lore.kernel.org/r/20200802111530.5020-1-tianjia.zhang@linux.alibaba.com
Fixes: 8777e4314d39 ("scsi: qla2xxx: Migrate NVME N2N handling into state machine")
Cc: Quinn Tran <quinn.tran@cavium.com >
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
See also upstream commit ca4fb89a3d714a770e9c73c649da830f3f4a5326.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9146 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-29 16:04:14 +00:00
Bart Van Assche
d3c5f58492
qla2x00t-32gbit: Fix wrong return value in qlt_chk_unresolv_exchg()
...
In the case of a failed retry, a positive value EIO is returned here. I
think this is a typo error. It is necessary to return an error value.
[mkp: caller checks != 0 but the rest of the file uses -Exxx so fix this up
to be consistent]
Link: https://lore.kernel.org/r/20200802111528.4974-1-tianjia.zhang@linux.alibaba.com
Fixes: 0691094ff3f2 ("scsi: qla2xxx: Add logic to detect ABTS hang and response completion")
Cc: Quinn Tran <quinn.tran@cavium.com >
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
See also upstream commit bbf2d06a9d767718bfe6028d6288c03edb98554a.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9145 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-29 16:03:37 +00:00
Bart Van Assche
75687c6513
qla2x00t-32gbit: Remove redundant variable initialization
...
The initialization value of `rc` is wrong. It is unnecessary to initialize
`rc` variables, so remove its initialization operation.
Link: https://lore.kernel.org/r/20200802111527.4928-1-tianjia.zhang@linux.alibaba.com
Fixes: 84905dfe78d2 ("scsi: qla2xxx: Fix TMF and Multi-Queue config")
Cc: Quinn Tran <quinn.tran@cavium.com >
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
See also upstream commit 8905cbdae986515c5a4dcd71889672235478f189.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9144 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-29 16:02:48 +00:00
Bart Van Assche
735be2120c
qla2x00t-32gbit: Fix the size used in a 'dma_free_coherent()' call
...
Update the size used in 'dma_free_coherent()' in order to match the one
used in the corresponding 'dma_alloc_coherent()'.
[mkp: removed memset() hunk that has already been addressed]
Link: https://lore.kernel.org/r/20200802110721.677707-1-christophe.jaillet@wanadoo.fr
Fixes: 4161cee52df8 ("[SCSI] qla4xxx: Add host statistics support")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
See also upstream commit 650b323c8e7c3ac4830a20895b1d444fd68dd787.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9143 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-29 16:02:06 +00:00
Bart Van Assche
9b6e29baff
qla2x00t-32gbit: Remove pci-dma-compat wrapper API
...
Link: https://lore.kernel.org/r/24627a86cf1e67fd229bc323316523d1ba0811f9.1596045683.git.usuraj35@gmail.com
Signed-off-by: Suraj Upadhyay <usuraj35@gmail.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
See also upstream commit 8d1f1ffaeb27ca81ea0dd24e238015efee7b5924.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9142 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-29 16:01:22 +00:00
Bart Van Assche
22ca3580da
qla2x00t-32gbit: Remove superfluous memset()
...
Fixes coccicheck warning:
./drivers/scsi/qla2xxx/qla_mbx.c:4928:15-33: WARNING: dma_alloc_coherent use in els_cmd_map already zeroes out memory, so memset is not needed
dma_alloc_coherent() already zeroes out memory so memset() is not needed.
Link: https://lore.kernel.org/r/1596079918-41115-3-git-send-email-liheng40@huawei.com
Signed-off-by: Li Heng <liheng40@huawei.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
See also upstream commit bef93fbfcf4ae9ecaa50e38d32cf6b8dbce4a797.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9141 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-29 16:00:15 +00:00
Bart Van Assche
f872ffa8a9
iscsi-scst/kernel/isert-scst/Kbuild: Fix the isert-scst build
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9140 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-29 15:52:09 +00:00
Bart Van Assche
d923eed64b
qla2x00t-32gbit: Use fallthrough pseudo keyword
...
Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.
[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org >
See also upstream commit dca93232b361d260413933903cd4bdbd92ebcc7f.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9139 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-29 15:47:45 +00:00
Bart Van Assche
9b2f2a4a71
qla2x00t-32gbit: Revert "Disable T10-DIF feature with FC-NVMe during probe"
...
FCP T10-PI and NVMe features are independent of each other. This patch
allows both features to co-exist.
This reverts commit 5da05a26b8305a625bc9d537671b981795b46dab.
Link: https://lore.kernel.org/r/20200806111014.28434-12-njavali@marvell.com
Fixes: 5da05a26b830 ("scsi: qla2xxx: Disable T10-DIF feature with FC-NVMe during probe")
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com >
Signed-off-by: Quinn Tran <qutran@marvell.com >
Signed-off-by: Nilesh Javali <njavali@marvell.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
See also upstream commit dca93232b361d260413933903cd4bdbd92ebcc7f.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9138 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-29 15:46:48 +00:00
Bart Van Assche
e2451f62db
qla2x00t-32gbit: Revert "Fix crash on qla2x00_mailbox_command"
...
FCoE adapter initialization failed for ISP8021 with the following patch
applied. In addition, reproduction of the issue the patch originally tried
to address has been unsuccessful.
This reverts commit 3cb182b3fa8b7a61f05c671525494697cba39c6a.
Link: https://lore.kernel.org/r/20200806111014.28434-11-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com >
Signed-off-by: Saurav Kashyap <skashyap@marvell.com >
Signed-off-by: Nilesh Javali <njavali@marvell.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
See also upstream commit de7e6194301ad31c4ce95395eb678e51a1b907e5.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9137 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-29 15:46:03 +00:00