Commit Graph

1629 Commits

Author SHA1 Message Date
Vladislav Bolkhovitin
fdbb5fcc7f Minor cleanups
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1794 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-28 18:07:11 +00:00
Vladislav Bolkhovitin
13dea2fd6a - Fix possible buffer overflow in the iSNS code.
- Cleanups.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1793 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-28 18:03:10 +00:00
Bart Van Assche
c7369b432b Micro-optimized srpt_completion().
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1792 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-26 10:42:06 +00:00
Vladislav Bolkhovitin
54c98834cd BE changes to keep sparse happy pointed out by Bart Van Assche <bvanassche@acm.org>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1791 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-25 18:14:13 +00:00
Bart Van Assche
e61d66a0c0 Whitespace-only changes to fix recently introduced checkpatch complaints.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1790 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-25 18:00:39 +00:00
Vladislav Bolkhovitin
bb21149a73 Fix possible crash if AEN is sent to a being shutdown session, because after unreg_done_fn() called the target driver's part of the session
should be already freed.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1789 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-25 17:25:18 +00:00
Vladislav Bolkhovitin
8d4d13fdb1 Fix cdb_len handling to avoid crashes on attempts to copy negative cdb_len bytes + minor scst_user residual fix
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1788 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-25 17:05:36 +00:00
Vladislav Bolkhovitin
a15199e2ed The patch below fixes / suppresses all iscsi-scst related endianness warnings
reported by sparse (make C=2 CF=-D__CHECK_ENDIAN__ iscsi).

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>

with some improvements



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1787 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-25 11:47:28 +00:00
Vladislav Bolkhovitin
07818cf573 Docs update
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1786 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-25 10:24:24 +00:00
Vladislav Bolkhovitin
0d21ef4e23 Fix for wrong endianness in scst_cmd_set_tgt_sn() call. Reported by Phil White <phil@scalecomputing.com>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1785 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-25 10:23:20 +00:00
Vladislav Bolkhovitin
9f5938cccc It's better to perform target redirection only for allowed initiators.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1784 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-24 18:58:25 +00:00
Vladislav Bolkhovitin
af5e8e3f79 Web updates
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1783 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-24 18:44:54 +00:00
Vladislav Bolkhovitin
82141783f8 Patch from Ido Benda <Ido.Benda@kaminario.com> fixing a small bug in PR read keys which causes the last key to be omitted.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1782 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-24 18:21:54 +00:00
Vladislav Bolkhovitin
eb16bf9163 Implement qlini_mode qla2xxx module parameter with ini_mode_force_reverse sysfs attribute instead of CONFIG_SCSI_QLA2XXX_TARGET_DISABLE_INI_MODE compile-time option for better flexibility.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1781 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-24 18:03:27 +00:00
Vladislav Bolkhovitin
78edc5afb9 Various cleanups and fixes after some errors injection tests. Particularly:
- ISCSI preliminary completed commands handling fixes
 - Write residuals cleanups and fixes
 - Interface to handle residuals and received from initiators data changed
 - BIDI cleanups and fixes.
 - All BIDI IN fields and functions renamed to OUT to be in line with the in-kernel convention

+ 

Docs updated



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1780 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-23 13:57:35 +00:00
Bart Van Assche
e730fac09d Fixed sparse warnings.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1779 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-18 19:29:19 +00:00
Bart Van Assche
0efa1826b0 Fixed a compiler warning.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1778 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-17 17:44:29 +00:00
Bart Van Assche
d3a2a54d48 Made sure endianness of ch->max_ti_iu_len is correct. The previous
implementation could result in e.g. the following message in /var/log/messages:

       ib_srpt: Received SRP_LOGIN_REQ with i_port_id 0x200b000453000581:0x4538330005811, t_port_id 0x66a00980074b8:0x66a00980074b8 and it_iu_len 996 on port 1 (guid=0xfe80000000000000:0x66a00a00074b8)
       ...
       ib_srpt: ***WARNING***: truncated sense data from 18 to -469565476 bytes

This patch was submitted by Chas Williams.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1777 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-17 16:33:37 +00:00
Mark Buechler
b151a59182 - Handle removing virtual targets on -clear_config.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1776 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-15 19:22:31 +00:00
Mark Buechler
ef331b97d5 - More work on dynamic attributes. Both hardware and virtual targets/drivers
should be working at this point.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1775 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-15 19:06:38 +00:00
Mark Buechler
2cab37c2c2 - Better handling on 'enabled' attribute.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1774 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-15 17:12:16 +00:00
Mark Buechler
2da1657b43 - Fix for calls to driverIsVirtualCapable().
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1773 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-15 16:48:56 +00:00
Mark Buechler
3016232224 - Small fix to driverIsVirtualCapable().
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1772 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-15 16:46:17 +00:00
Mark Buechler
d6053c491b - Changes to scstadmin.sysfs necessary for the recent module changes.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1771 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-15 15:08:39 +00:00
Mark Buechler
935f9f3e6a - Finish up dynamic attribute adding/deleting for virtual capable
drivers & targets.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1770 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-15 15:07:54 +00:00
Bart Van Assche
eb8dd24115 Added fcst to the nightly build.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1769 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-13 17:36:17 +00:00
Bart Van Assche
443250144b Fixed sparse warnings about functions that were defined but not declared.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1768 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-13 17:35:37 +00:00
Bart Van Assche
d8392af840 Apparently sparse ignores __attribute__((packed)) when applied to an enum
while gcc honors this attribute. The result is that
sizeof(struct fcoe_rcv_info) is 48 when the header include/scsi/fc_frame.h is
compiled with gcc and that sizeof(struct fcoe_rcv_info) > 48 when the same
header is compiled by sparse. As a result, compilation with sparse fails due
to the BUILD_BUG_ON() statement in the function fcoe_dev_from_skb(), even
when checking a vanilla Linux kernel with sparse. The patch below slightly
modifies include/scsi/fc_frame.h such that gcc and sparse interpret this header
in the same way.

Note: it is fine to revert this patch once the behavior of gcc and sparse is
again in sync.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1767 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-13 17:34:40 +00:00
Bart Van Assche
56538f02d5 Removed a trailing whitespace because checkpatch complained about it.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1766 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-12 06:17:22 +00:00
Bart Van Assche
4366b4ee83 Fixed checkpatch complaints about whitespace (removed space before tab twice).
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1765 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-12 05:57:49 +00:00
Bart Van Assche
b97a6bbbf2 Don't run patch -p1 --dry-run on the generated kernel patch because this fails
for patches that depend on each other, e.g. the fcst in-tree patches.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1764 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-12 05:55:48 +00:00
Bart Van Assche
566050b610 Obtain fcst in-tree kernel patch filenames from fcst/linux-patches/series-2.6.33-rc8.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1763 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-12 05:54:14 +00:00
Vladislav Bolkhovitin
2da20cee9e Add listing attributes of various types in the help string to help manegement utilities. Added on request from Mark Buechler <mark.buechler@gmail.com>.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1762 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-11 18:40:14 +00:00
Joe Eykholt
7a12737c9d Simplify README by eliminating example using of ini_groups.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1761 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-11 17:59:26 +00:00
Bart Van Assche
493ad888d5 Added in-tree fcst patches.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1760 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-11 16:12:54 +00:00
Joe Eykholt
546647be44 Support for persistent reservations.
Add a method for template get_initiator_port_transport_id()
to allow persistent reservations to work. 

Initialize struct ft_sess more fully before scst_register_session()
so that ft_get_transport_id() can use it.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1759 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-10 21:47:17 +00:00
Joe Eykholt
64a5ad5169 Updated README to refer to linux 2.6.34.
The same libfc patches apply, but I copied the series file for 2.6.34.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1758 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-10 20:40:45 +00:00
Bart Van Assche
cd57597f7f Removed trailing whitespace because checkpatch complained about it.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1757 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-10 18:59:45 +00:00
Joe Eykholt
f947cd2f43 Fix compile error by removing debug prints of deleted fields.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1756 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-10 18:38:58 +00:00
Vladislav Bolkhovitin
ccad0cc016 Updates
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1755 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-10 10:01:55 +00:00
Mark Buechler
dcc73eb66b - More "parameter" to "attribute" changes.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1754 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-09 18:51:03 +00:00
Mark Buechler
664a307edc - Small type fix in session().
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1753 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-09 18:43:45 +00:00
Mark Buechler
1ea25d2975 - Rename "parameters" for "attributes" to be more inline with
SCST terminology.
- Support adding attributes to drivers & targets.
- Support adding virtual targets.
- Support luns outside of ini groups.
- New option -nonkey to allow writing of non-key attributes to
  the config file.

TODO: Cleanup writeConfiguration() - it has a LOT of redundant code.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1752 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-09 18:35:09 +00:00
Mark Buechler
eba08eadf5 - Rename "parameters" for "attributes" to be more inline with
SCST terminology.
- Renumbered error codes.
- Added ability to create attributes for drivers & targets.
- Make distinction between key attributes and normal attributes.
- Force attribute "enabled" to be a key attribute.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1751 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-09 18:31:42 +00:00
Vladislav Bolkhovitin
9cc65b544c Minor type fixed
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1750 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-09 15:36:16 +00:00
Vladislav Bolkhovitin
9ae870eb44 Update on attribute names with digits on the end.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1749 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-09 15:27:11 +00:00
Bart Van Assche
165bcc0f64 Use tabs instead of spaces for indentation.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1748 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-06 07:09:39 +00:00
Bart Van Assche
7268591baf Added support for persistent reservations.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1747 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-05 18:29:57 +00:00
Bart Van Assche
a66ac34685 Added missing semicolon.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1746 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-05 18:26:06 +00:00
Bart Van Assche
ca97893240 Fixed checkpatch complaints about whitespace and one sparse warning.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1745 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-05 16:44:27 +00:00