mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-08-18 13:16:34 +00:00
Code Issues Packages Projects Releases Wiki Activity
3,461 Commits 26 Branches 11 Tags
ff45bf36a605c4839cbdb6bbbfe1440bc37a16bc
Commit Graph
493 Commits
Author SHA1 Message Date
Vladislav Bolkhovitin 54ffcc75c8 Fix incorrect check for TSIH wrap around 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4606 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-11-07 22:03:07 +00:00
Vladislav Bolkhovitin 7ecc784143 Add forgotten list_del() on session creation error path 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4569 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-11-03 02:08:40 +00:00
Vladislav Bolkhovitin 5cdfbd1817 Make CHAP random number generator stronger 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4568 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-11-03 02:03:15 +00:00
Bart Van Assche 3e639ad97a scst/README: Move information from the SCST wiki into the Subversion tree 
The wiki has been announced to be shut down in 2012Q4 toghether with all
other hosted SourceForge apps, so move the information from there into the
SCST source tree.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4563 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-10-17 17:53:48 +00:00
Vladislav Bolkhovitin a698883844 Switch to the new and preferred approach for printing kernel messages 
From: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4558 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-10-10 03:01:34 +00:00
Vladislav Bolkhovitin 0b8bd29208 Single-statement macros should not use do { } while (0) 
From: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4557 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-10-10 02:57:07 +00:00
Vladislav Bolkhovitin 73c992f7dd Convert sizeof expr into sizeof(expr) 
Avoids that the checkpatch tool included in kernel 3.6 emits the
following warning:

WARNING: sizeof *attr should be sizeof(*attr)

This patch has been generated by running the following command over
the SCST source tree and by reviewing these changes manually:

find -name '*.[ch]' |
  xargs -d\\n sed -i.tmp -e 's/sizeof  *\([^(][^(),; ]*\)/sizeof(\1)/g'

From: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4556 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-10-10 02:55:31 +00:00
Vladislav Bolkhovitin 05bff10f05 During nexus loss reservations should not be cleared + add possibility for device specific states be retained during nexus loss as well. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4546 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-10-04 20:32:59 +00:00
Vladislav Bolkhovitin 57d7bcd809 Fix 2 bugs in iscsi_attr_replace() sent by Lev Vainblat <lev@zadarastorage.com>: 
1. After attr was found in the attrs_list, it is inserted again back into the same list. As a result the list becomes corrupted.

The bug can be reproduced for example by the following sequence:

    $ echo add_attribute IncomingUser user secret111111 > /sys/kernel/scst_tgt/targets/iscsi/mgmt
    $ echo user secret222222 > /sys/kernel/scst_tgt/targets/iscsi/IncomingUser
    $ echo del_attribute IncomingUser user > /sys/kernel/scst_tgt/targets/iscsi/mgmt
    $ iscsiadm -m discovery -t st -p 127.0.0.1

Discovery fails and in syslog there is a message

    Oct  2 18:58:37 vsa-00000611 iscsi-scstd: [1059] cmnd_exec_login:940: ERROR: Authentication of initiator iqn.2011-04.com.zadarastorage:1553:vc-0 failed

2. Small memory leak in error recovery path.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4545 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-10-04 18:34:25 +00:00
Vladislav Bolkhovitin 1a8577c59c Update for 3.6 kernels 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4538 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-10-01 22:10:47 +00:00
Vladislav Bolkhovitin 96f498e9c8 Add support patch for rebuilding RHEL 6.3 kernel RPM 
Add put_page_callback-2.6.32-279.patch (a copy of the RHEL 6.2 version
of the same patch) such that scripts/rebuild-rhel-kernel-rpm can rebuild
the RHEL 6.3 kernel RPM.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4535 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-09-29 22:34:58 +00:00
Vladislav Bolkhovitin 7b1f00d2cb Increase version to -pre2. Pre1 was staying for too long. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4519 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-09-14 01:33:58 +00:00
Vladislav Bolkhovitin 8ce28aaba2 Avoid that enabling a target too quickly triggers a crash 
The sysfs attributes of a target can be accessed before scst_tgt.tgt_priv
has been set. Avoid that such an access triggers a crash.

Symptom:
BUG: unable to handle kernel NULL pointer dereference at 000000000000004c
IP: [<ffffffffa1345848>] iscsi_is_target_enabled+0x8/0x20 [iscsi_scst]
PGD 150a4c067 PUD 13cacb067 PMD 0
Oops: 0000 [#1] SMP
CPU 1
Modules linked in: zfs(P) iscsi_scst(O) scst_vdisk(O) scst(O) zcommon(P) znvpair(P) zavl(P) zunicode(P) spl(O) [last unloaded: zfs]
Pid: 3974, comm: scst_uid1864 Tainted: P           O 3.2.23-zfsiscsi-std-ipv6-64 #3 Supermicro X6DVA/X6DVA
RIP: 0010:[<ffffffffa1345848>]  [<ffffffffa1345848>] iscsi_is_target_enabled+0x8/0x20 [iscsi_scst]
RSP: 0018:ffff88015071ddc0  EFLAGS: 00010282
RAX: 0000000000000000 RBX: ffff880181fdaa00 RCX: ffff88012d41f380
RDX: ffff88015071c010 RSI: 0000000000000000 RDI: ffff880181fdaa00
RBP: ffff88015071ddc0 R08: 0000000000000000 R09: 0000000000000001
R10: 0000000000000001 R11: 0000000000000001 R12: ffffffffa134a608
R13: 0000000000000000 R14: 0000000000000129 R15: ffffffffa134a4c0
FS:  0000000000000000(0000) GS:ffff88019fc80000(0000)
knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
CR2: 000000000000004c CR3: 0000000151927000 CR4: 00000000000006e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
Process scst_uid1864 (pid: 3974, threadinfo ffff88015071c000, task ffff880194d57500)
Stack:
 ffff88015071de10 ffffffffa12ee89a 00000000fffffffc 01ff88015071de98
 ffff88015071de80 ffff8801932a48d8 00000000fffffffc ffff88015071de98
 ffff88015071de80 ffff880194d57500 ffff88015071de30 ffffffffa12f582e
Call Trace:
 [<ffffffffa12ee89a>] __scst_is_relative_target_port_id_unique+0x6a/0xc0 [scst]
 [<ffffffffa12f582e>] gen_relative_target_port_id+0x6e/0xd0 [scst]
 [<ffffffffa12fdb8a>] scst_tgt_enable_store_work_fn+0x3a/0xe0 [scst]
 [<ffffffffa12f9397>] sysfs_work_thread_fn+0xc7/0x2e0 [scst]
 [<ffffffffa12f92d0>] ? scst_tgtt_release+0x20/0x20 [scst]
 [<ffffffffa12f92d0>] ? scst_tgtt_release+0x20/0x20 [scst]
 [<ffffffff810b44f6>] kthread+0x96/0xa0
 [<ffffffff81b8ed74>] kernel_thread_helper+0x4/0x10
 [<ffffffff810b4460>] ? kthread_worker_fn+0x180/0x180
 [<ffffffff81b8ed70>] ? gs_change+0xb/0xb
Code: 42 c8 74 0f 39 78 48 75 ea c9 c3 0f 1f 84 00 00 00 00 00 31 c0 c9 c3 66 66 66 2e 0f 1f 84 00 00 00 00 00 48 8b 47 48 55 48 89 e5 <0f> b6 40 4c c9 83 e0 01 c3 66 66 66 66 66 66 2e 0f 1f 84 00 00
RIP  [<ffffffffa1345848>] iscsi_is_target_enabled+0x8/0x20 [iscsi_scst]
 RSP <ffff88015071ddc0>
CR2: 000000000000004c
---[ end trace 6311d4069703be07 ]---

Reported-by: Etienne Dechamps <e-t172@akegroup.org>
Signed-off-by: Bart Van Assche <bvanassche@acm.org> with some modifications



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4515 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-09-12 22:13:43 +00:00
Vladislav Bolkhovitin e9008a5b12 Fix possible BUG_ON() on multiple forced commands release 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4513 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-09-11 20:38:57 +00:00
Vladislav Bolkhovitin 155cde35ae Increase MAX_NR_QUEUED_CMNDS to better handle multu-LUs per target cases 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4496 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-08-28 19:26:43 +00:00
Vladislav Bolkhovitin 3861a12da5 Fix incorrect errors handling. Detected by smatch. 
Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4492 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-08-27 22:12:15 +00:00
Vladislav Bolkhovitin eb4f05aafe This patch addresses a minor stylistic issue: use the value 
returned by mutex_lock_interruptible() instead of explicitly
assigning -EINTR to res.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4481 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-08-27 20:42:58 +00:00
Vladislav Bolkhovitin fda632ae0b iscsi-scst: Eliminate a cast 
Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4479 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-08-27 20:38:37 +00:00
Vladislav Bolkhovitin 7b77e66b07 Workaround (leftover?) events after disable iSNS server 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4472 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-08-24 18:54:35 +00:00
Vladislav Bolkhovitin 5f662059a7 Update for 3.5 kernel 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4458 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-08-09 02:19:31 +00:00
Vladislav Bolkhovitin 955113f493 Sense handling improvements 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4408 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-07-18 21:28:57 +00:00
Vladislav Bolkhovitin 564b36903b Update for kernel 3.4 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4320 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-05-24 18:56:44 +00:00
Vladislav Bolkhovitin 5221238b13 Fix strtoul() overflow handling 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4318 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-05-23 21:41:45 +00:00
Vladislav Bolkhovitin cacf9046d8 Update iSCSI HOWTO 
Bring the iSCSI-SCST how-to in sync with scstadmin. Applies to trunk
and 2.2 branch.

Reported-by: Kenneth Wong <kenwong@marvell.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4302 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-05-17 01:10:10 +00:00
Vladislav Bolkhovitin d3b4b46223 Patch improving handling of errors during passing connection to the kernel. 
From Lev Vainblat <lev@zadarastorage.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4295 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-05-11 01:20:26 +00:00
Vladislav Bolkhovitin a913a223f9 iSCSI-SCST: Add scstadmin example todocumentation 
Add an scstadmin iSNSServer configuration example to the iSCSI-SCST
documentation.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4253 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-04-30 19:32:30 +00:00
Vladislav Bolkhovitin e1d73542b2 iSCSI-SCST: Fix a typo in an error message 
Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4251 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-04-30 19:29:47 +00:00
Vladislav Bolkhovitin 921e533528 Rename scst_alloc()/scst_free() to scst_alloc_sg()/scst_free_sg() 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4247 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-04-28 00:25:41 +00:00
Vladislav Bolkhovitin 462974b410 SCSTLun: bug fix on t10 dev id assignment 
By Riccardo <r.bicelli@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4218 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-04-21 02:59:38 +00:00
Vladislav Bolkhovitin eb95049061 Copyrights updated + cleanups 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4216 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-04-18 02:26:39 +00:00
Vladislav Bolkhovitin f742ae018e scst_vdisk: Add zero-copy file I/O readsupport 
Speeds up reading from a RAM disk via ib_srpt by about 30%.
Tested with iSCSI-SCST, ib_srpt and scst_local.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>

In it:

- Fixed NULLIO, which the original patch breaks

- Changed on all fast paths sBUG_ON() on EXTRACHECKS_BUG_ON()

- Fixed errors path in non_fileio_exec() and fileio_alloc_data_buf().

- Renamed zero_copy_read to just zero_copy.

- Docs and change log updated

- Some cleanups




git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4213 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-04-18 01:19:28 +00:00
Vladislav Bolkhovitin 0dd7573989 Fix for missed mempool_destroy() in case when CONFIG_TCP_ZERO_COPY_TRANSFER_COMPLETION_NOTIFICATION not defined noticed by Bart Van Assche <bvanassche@acm.org> 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4208 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-04-13 20:28:50 +00:00
Vladislav Bolkhovitin 88881a1459 iSCSI resource agents written by Riccardo Bicelli <r.bicelli@gmail.com> 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4177 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-03-30 20:59:48 +00:00
Vladislav Bolkhovitin 49c56244a1 Fix 3.3 checkpatch warnings about min()and max() 
Fix three occurrences of the following warnings reported by the checkpatch
script included with Linux kernel version 3.3:
WARNING: min() should probably be min_t()
WARNING: max() should probably be max_t()

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4172 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-03-27 01:46:51 +00:00
Vladislav Bolkhovitin 90670b1c83 scst_rx_mgmt_fn_lun(): Change 3rd arg from u8 * into void * 
This change allows to remove several casts and hence improves
source code readability.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4169 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-03-27 01:40:45 +00:00
Vladislav Bolkhovitin d5ffb2234b Cleanup mgmt parameters initialization. 
It's better to do it via a single function.

Patch from Alexey Obitotskiy <alexeyo1@open-e.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4165 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-03-23 22:03:22 +00:00
Vladislav Bolkhovitin 937b2d550d Update for kernel 3.3 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4164 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-03-23 21:48:11 +00:00
Vladislav Bolkhovitin 7a87bf25a6 Cleanup + implement conditional logging 
This patch:
* fixes signatures for log_debug and log_pdu macros
* collapses __log_<LEVEL> functions into one
* adds conditional logging

Here conditional logging means that the logging priority and logging level may
vary depending on some dynamic parameters. This is helpful when software is
able to recover from errors which occur periodically and hence, there is no
need to pollute system logs with tons of repetitive non-critical lines.

The following macros are added to support this feature:
* log_info_cond
* log_warning_cond
* log_error_cond

They take an additional first parameter called "level". If it is 0 then they
act as their non-cond counterparts, otherwise they act like log_debug with the
specified level.

Those who are not interested in conditional logging are not affected: they can
continue using plain old logging macros without any changes.

Signed-off-by: Sergey Myasnikov <tigra564@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4161 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-03-12 22:31:13 +00:00
Vladislav Bolkhovitin 5c2cde6757 Cleanup: move misc routines in misc.c 
This patch moves the following utility functions from iscsi_scstd.c to misc.c
and makes them public (i.e. non-static):
* set_non_blocking
* sock_set_keepalive

Signed-off-by: Sergey Myasnikov <tigra564@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4160 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-03-12 21:52:35 +00:00
Vladislav Bolkhovitin 50120c37b3 scst_cmd_aborted() is a bad and ambiguous name. Rename it to scst_cmd_aborted_on_xmit() and create a new version, which truly reflects its semantic. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4143 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-02-24 02:24:06 +00:00
Vladislav Bolkhovitin 659e6ea6e8 Install man pages as well. Noticed by Bart Van Assche <bvanassche@acm.org>. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4133 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-02-17 01:38:16 +00:00
Vladislav Bolkhovitin 37cbdb03df Minor docs update based on experience of Rommer <rommer@active.by> 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4119 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-02-11 03:01:00 +00:00
Bart Van Assche f944799e42 iscsi-scst: Port to RHEL 5.7 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4112 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-02-04 16:41:21 +00:00
Bart Van Assche 85b89521f8 iscsi-scstd: Make really sure that the buffer allocated for nl_read() is large enough 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4110 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-02-04 16:39:26 +00:00
Bart Van Assche fdeea7c916 iscsi-scstd: Follow-up for r4077 - avoid that reading from the netlink socket can cause data corruption 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4109 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-02-04 12:39:26 +00:00
Vladislav Bolkhovitin 8e5eafb7c3 Forgotten tcp_zero_copy.c added 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4080 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-01-20 03:13:11 +00:00
Vladislav Bolkhovitin 9da517bae1 Update for kernel 3.2. Netlink part in iSCSI-SCST done by Bart Van Assche <bvanassche@acm.org> 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4077 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-01-18 23:48:02 +00:00
Vladislav Bolkhovitin b31865ea69 Update of put_page_callback-2.6.32-220.patch from Patrick Zwahlen <paz@navixia.com> 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4064 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-01-12 03:22:09 +00:00
Vladislav Bolkhovitin f6ba6aaf43 Patch from Richard Sharpe <realrichardsharpe@gmail.com> implementing put_page_callback patch for CentOS 6.2/RHEL 6.2 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4057 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2012-01-10 03:02:24 +00:00
Vladislav Bolkhovitin 7872837b6b Replace list_entry((a)->next, b, c) by list_first_entry(a, b, c). 
BSD-signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3965 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2011-12-10 03:50:24 +00:00