Testing whether a pointer is not NULL after it has been dereferenced is not
useful. Hence remove the if (fcport) test. This was detected by Coverity.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8291 d57e44dd-8a1f-0410-8b47-8ef2f437770f
Since qla2x00_init_timer() is not used for I/O commands there is no need to
inline this function. Hence uninline this function.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8290 d57e44dd-8a1f-0410-8b47-8ef2f437770f
The previous patch moved all qla2x00_is_reserved_id() callers into
qla_init.c. Hence also move the qla2x00_is_reserved_id() definition into
qla_init.c.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8289 d57e44dd-8a1f-0410-8b47-8ef2f437770f
Since all qla2x00_find_new_loop_id() calls occur in the same source file as
the definition of this function, move that function to just before its
first caller and declare it static. Convert the header above this function
into kernel-doc format.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8286 d57e44dd-8a1f-0410-8b47-8ef2f437770f
Since qla2x00_set_reserved_loop_ids() only has a single caller, move it
into the source file from where it is called.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8285 d57e44dd-8a1f-0410-8b47-8ef2f437770f
Change one occurrence of "*(" into "()". Fix the reference to
qla_tgt_handle_cmd_for_atio(): there has never been a function with
that name.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8284 d57e44dd-8a1f-0410-8b47-8ef2f437770f
Submitting the NEXUS LOSS task management function is not required when
freeing an SCST session.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8276 d57e44dd-8a1f-0410-8b47-8ef2f437770f
ELS IOCB done message should be moved to verbose logging
to prevent confusion about the error case v/s sucessful
submission case.
Signed-off-by: Himanshu Madhani <hmadhani@marvell.com>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8274 d57e44dd-8a1f-0410-8b47-8ef2f437770f
From: Quinn Tran <qtran@marvell.com>
This patch fixes issue reported by some of the customers,
who discovered that after cable pull scenario the devices
disappear and path seems to remain in blocked state. Once
the device reappears, driver does not seem to update path
to online. This issue appears because of the defer flag
creating race condition where the same session reappears.
This patch fixes this issue by indicating SCSI-ML of device
lost when qlt_free_session_done() is called from qlt_unreg_sess().
Fixes: "qla2xxx: Improve RSCN handling in driver"
Signed-off-by: Quinn Tran <qtran@marvell.com>
Signed-off-by: Himanshu Madhani <hmadhani@marvell.com>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8273 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This patch avoids that the build_mode file is read when applying the
generate-kernel-patch output to the kernel tree and when building the
kernel tree.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8272 d57e44dd-8a1f-0410-8b47-8ef2f437770f
Avoid that the compiler complains that the assert() expression compares a
signed with an unsigned integer.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8269 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This driver is obsolete and is no longer supported since a long time, so
remove it. From the README of this driver (this note was added in 2009):
"From other side, qla2x00t is simpler, smaller and much better tested
on 22xx and 23xx, hence perform more reliable and, thus, is recommended
for these adapters. Since 24xx/25xx become fully supported on qla2x00t
we encourage users to switch to this driver."
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8260 d57e44dd-8a1f-0410-8b47-8ef2f437770f
In the *_done() functions, instead of returning early if sp->ref_count >= 2,
only decrement sp->ref_count. In qla2xxx_eh_abort(), instead of deciding
what to do based on the value of sp->ref_count, decide which action to take
depending on the completion status of the firmware abort.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8240 d57e44dd-8a1f-0410-8b47-8ef2f437770f
Due to the previous patch this backport is no longer needed. Note: the
wait_event_lock_irq_timeout() needs more work.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8238 d57e44dd-8a1f-0410-8b47-8ef2f437770f
Since r8226 is not a full solution and since it relies on
wait_event_lock_irq_timeout(), revert it.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8237 d57e44dd-8a1f-0410-8b47-8ef2f437770f
Make sure that resources are only unregistered after the users of these
resources have been unregistered. Only unregister the character device if
registration of it succeeded.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8236 d57e44dd-8a1f-0410-8b47-8ef2f437770f
