Gleb Chesnokov
9671b117cb
The saved Coccinelle null/kmerr.cocci report flags the unchecked fallback allocation in sqa_init_scst_tgt before the resource-helper refactoring: qla2x00t-32gbit/qla2x00-target/scst_qla2xxx.c:1354:1-22: alloc with no test, possible model on line 1368 PTR_ERR_OR_ZERO(NULL) returns success, so allocation failure is treated as an initialized tag pool. Later command allocation dereferences NULL. Check the allocation result explicitly and return -ENOMEM instead. Manual review also found that BITS_TO_LONGS(tag_num) is passed as a byte count; the diagnostic above does not report this size error. For 2048 tags on a 64-bit kernel this allocates 32 bytes instead of 256, allowing bitmap operations to access beyond the allocation. Use kcalloc with sizeof(unsigned long) to allocate and zero the complete bitmap. Keep the fallback allocation helper available to KUnit on modern kernels. Cover one tag, word boundaries, the default 2048-tag pool, zeroed storage and injected allocation failure. Check ksize before touching the last bit so an undersized allocation is detected even without KASAN.
Overview
This is the source code repository of the SCST project. SCST is a collection of Linux kernel drivers that implement SCSI target functionality. The SCST project includes:
- The SCST core in the scst/ subdirectory.
- A tool for loading, saving and modifying the SCST configuration in directory scstadmin/.
- Several SCSI target drivers in the directories iscsi-scst/, qla2x00t-32gbit/, qla2x00t/, srpt/, scst_local/ and fcst/.
- User space programs in the usr/ subdirectory, e.g. fileio_tgt.
- Various documentation in the doc/ subdirectory.
Documentation
- Building and installing SCST.
- Build options: Clang, cross-compilation, and kernel module signing.
- Configuration and administration: targets, devices,
LUNs, and
/etc/scst.conf. - Core and device handlers: operating modes, module parameters, and sysfs configuration.
- Target drivers: iSCSI, iSER, QLogic Fibre Channel, SRP, FCoE, and local loopback.
- Performance tuning.
- Clustered persistent reservations: synchronization through DLM.
- T10 protection information: data integrity modes and configuration.
- Developer references: architecture and userspace handler interface (SGML sources), and sysfs interface rules.
- Contributing: code style, commit conventions, local checks, and guides to KUnit and component testing.
Current master packages
Prebuilt x86_64 packages from the latest successfully published master
build are available in the rolling
master-rpm prerelease.
These are development snapshots, not SCST releases.
The snapshot contains RPM bundles for selected Rocky Linux and Oracle Linux
UEK kernels. It also contains Ubuntu LTS bundles with scst-dkms, scstadmin
and iscsi-scst binary packages and their Debian source package files. Exact
distribution releases and RPM kernel versions are included in the asset names.
Every .tar.gz bundle has a matching .sha256 file. The complete snapshot is
replaced after each successful package workflow for the current master
commit.
QLogic target driver
Two QLogic target drivers are included in the SCST project.
The default driver is located in the qla2x00t-32gbit directory. It is the newer one.
May anyone wish to switch back to the older driver that only supported up to
16 Gb/s adapters, it is located in qla2x00t directory. To make use of the
older driver build scst with environment variable QLA_32GBIT=no set.
Vladislav Bolkhovitin vst@vlnb.net, http://scst.sourceforge.net
Sourceforge achievements
