mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-05-31 12:06:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

mv: avoid unnecessary copies of existing rows in generate_updates()

Browse Source 
In the existing-only tail block of generate_updates(), the clustering
row and static row were extracted from the fragment using a deep copy
constructor (e.g. clustering_row(*_schema, fragment.as_clustering_row()))
even though the fragment is not used afterwards. Replace with moves,
matching the pattern used in all other cases.
This commit is contained in:
Wojciech Mitros
2026-04-15 18:50:18 +02:00
parent 74902dceac
commit 00be36e08f
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
db/view/view.cc
View File

@@ -1584,12 +1584,12 @@ future<stop_iteration> view_update_builder::generate_updates() {
if (_existing_fragment->is_range_tombstone_change()) {
_existing_current_tombstone = _existing_fragment->as_range_tombstone_change().tombstone();
} else if (_existing_fragment->is_clustering_row()) {
auto existing = clustering_row(*_schema, _existing_fragment->as_clustering_row());
auto existing = std::move(*_existing_fragment).as_clustering_row();
existing.apply(std::max(_existing_partition_tombstone, _existing_current_tombstone));
auto update = clustering_row(existing.key(), row_tombstone(std::move(tombstone)), row_marker(), ::row());
generate_update(std::move(update), { std::move(existing) });
} else if (_existing_fragment->is_static_row()) {
auto existing = static_row(*_schema, _existing_fragment->as_static_row());
auto existing = std::move(*_existing_fragment).as_static_row();
auto update = static_row();
generate_update(std::move(update), _update_partition_tombstone, { std::move(existing) }, _existing_partition_tombstone);
}