mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-05-12 19:02:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Introduce TABLET_KEYSPACE event to differentiate processing path of a vnode vs tablets ks"

Browse Source 
This reverts commit 80ed442be2.

This logic was replaced in previous commit by dynamic cast.
Hopefully even this cast will be eliminated in the future.
This commit is contained in:
Marcin Maliszkiewicz
2024-06-03 15:08:34 +02:00
parent 0573fee2a9
commit 01fb43e35f
4 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
test/boost/transport_test.cc
View File

@@ -90,7 +90,6 @@ SEASTAR_THREAD_TEST_CASE(test_response_request_reader) {
res.serialize({sc::change_type::CREATED, sc::target_type::TYPE, "foo", "bar"}, version);
res.serialize({sc::change_type::CREATED, sc::target_type::FUNCTION, "foo", "bar", "zed"}, version);
res.serialize({sc::change_type::CREATED, sc::target_type::AGGREGATE, "foo", "bar", "zed"}, version);
res.serialize({sc::change_type::CREATED, sc::target_type::TABLET_KEYSPACE, "foo"}, version);
auto msg = res.make_message(version, cql_transport::cql_compression::none).release();
auto total_length = msg.len();

1
transport/event.cc
View File

@@ -57,7 +57,6 @@ event::schema_change::schema_change(change_type change, target_type target, sstr
{
switch (target) {
case event::schema_change::target_type::KEYSPACE:
case event::schema_change::target_type::TABLET_KEYSPACE:
assert(this->arguments.empty());
break;
case event::schema_change::target_type::TYPE:

2
transport/event.hh
View File

@@ -61,7 +61,7 @@ public:
class event::schema_change : public event {
public:
enum class change_type { CREATED, UPDATED, DROPPED };
enum class target_type { KEYSPACE, TABLE, TYPE, FUNCTION, AGGREGATE, TABLET_KEYSPACE };
enum class target_type { KEYSPACE, TABLE, TYPE, FUNCTION, AGGREGATE };
const change_type change;
const target_type target;

2
transport/server.cc
View File

@@ -170,7 +170,6 @@ sstring to_string(const event::schema_change::target_type t) {
case event::schema_change::target_type::TYPE: return "TYPE";
case event::schema_change::target_type::FUNCTION: return "FUNCTION";
case event::schema_change::target_type::AGGREGATE:return "AGGREGATE";
case event::schema_change::target_type::TABLET_KEYSPACE: return "KEYSPACE";
}
assert(false && "unreachable");
}
@@ -1668,7 +1667,6 @@ void cql_server::response::serialize(const event::schema_change& event, uint8_t
write_string(event.keyspace);
switch (event.target) {
case event::schema_change::target_type::KEYSPACE:
case event::schema_change::target_type::TABLET_KEYSPACE:
break;
case event::schema_change::target_type::TYPE:
case event::schema_change::target_type::TABLE: