mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-04-22 09:30:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: drop at_exit() destruction of the test environment

Browse Source 
We already have a ->stop() call in a finally() clause, so the at_exit()
registrations lead to a use-after-free.
This commit is contained in:
Avi Kivity
2015-04-06 13:00:59 +03:00
parent d53a1abc7c
commit 1017ebf2aa
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/urchin/cql_test_env.hh
View File

@@ -151,14 +151,11 @@ static inline
future<::shared_ptr<cql_test_env>> make_env_for_test() {
auto db = ::make_shared<distributed<database>>();
return db->start().then([db] {
engine().at_exit([db] { return db->stop(); });
auto proxy = ::make_shared<service::storage_proxy>(std::ref(*db));
auto qp = ::make_shared<distributed<cql3::query_processor>>();
return qp->start(std::ref(*proxy), std::ref(*db)).then([db, proxy, qp] {
engine().at_exit([qp] { return qp->stop(); });
auto env = ::make_shared<cql_test_env>(db, qp, proxy);
return env->start().then([env] {
engine().at_exit([env] { return env->stop(); });
return env;
});
});