mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-06-07 15:33:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

tablets: Generalize transition mutations preparation

Browse Source 
Tablet transition handlers prepare two mutations -- one for tablets
table, that sets transition state, transition mode and few others; and
another one for topology table that "activates" the tablet_migration
state for topology coordinator.

The latter is common to all three handlers.

Signed-off-by: Pavel Emelyanov <xemul@scylladb.com>
This commit is contained in:
Pavel Emelyanov
2024-04-17 10:49:07 +03:00
parent 3beccb8165
commit 1b2cd56bcc
1 changed files with 5 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
service/storage_service.cc
View File

@@ -5754,10 +5754,6 @@ future<> storage_service::move_tablet(table_id table, dht::token token, locator:
.set_stage(last_token, locator::tablet_transition_stage::allow_write_both_read_old)
.set_transition(last_token, locator::tablet_transition_kind::migration)
.build());
updates.emplace_back(topology_mutation_builder(write_timestamp)
.set_transition_state(topology::transition_state::tablet_migration)
.set_version(_topology_state_machine._topology.version + 1)
.build());
sstring reason = format("Moving tablet {} from {} to {}", gid, src, dst);
@@ -5802,10 +5798,6 @@ future<> storage_service::add_tablet_replica(table_id table, dht::token token, l
.set_stage(last_token, locator::tablet_transition_stage::allow_write_both_read_old)
.set_transition(last_token, locator::tablet_transition_kind::rebuild)
.build());
updates.emplace_back(topology_mutation_builder(write_timestamp)
.set_transition_state(topology::transition_state::tablet_migration)
.set_version(_topology_state_machine._topology.version + 1)
.build());
sstring reason = format("Adding replica to tablet {}, node {}", gid, dst);
@@ -5851,10 +5843,6 @@ future<> storage_service::del_tablet_replica(table_id table, dht::token token, l
.set_stage(last_token, locator::tablet_transition_stage::allow_write_both_read_old)
.set_transition(last_token, locator::tablet_transition_kind::rebuild)
.build());
updates.emplace_back(topology_mutation_builder(write_timestamp)
.set_transition_state(topology::transition_state::tablet_migration)
.set_version(_topology_state_machine._topology.version + 1)
.build());
sstring reason = format("Removing replica from tablet {}, node {}", gid, dst);
@@ -5962,6 +5950,11 @@ future<> storage_service::transit_tablet(table_id table, dht::token token, nonco
rtlogger.info("{}", reason);
rtlogger.trace("do update {} reason {}", updates, reason);
updates.emplace_back(topology_mutation_builder(guard.write_timestamp())
.set_transition_state(topology::transition_state::tablet_migration)
.set_version(_topology_state_machine._topology.version + 1)
.build());
topology_change change{std::move(updates)};
group0_command g0_cmd = _group0->client().prepare_command(std::move(change), guard, reason);
try {