mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-06-05 06:23:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

sstables: use make_component_sink for stream sink output

Browse Source 
sstable_stream_sink_impl::output() used open_file() followed by
make_file_output_stream() to create the writable stream. For object
storage (S3/GCS) backends, open_file() always returns a readable_file
(read-only), so any write through file::dma_write() throws
std::logic_error("unsupported operation on s3 readable file"). This
broke all tablet migration streaming with S3-backed storage.

Replace the open_file() + make_file_output_stream() path with
make_component_sink() + output_stream<char>(), which correctly
produces an upload sink for object storage and a file_data_sink for
local filesystem. This is consistent with how save_metadata() already
writes to object storage in the same class. The maybe_wrap_sink()
call inside make_component_sink preserves file_io_extensions support
(e.g., encryption).
This commit is contained in:
Ernest Zaslavsky
2026-04-29 09:50:25 +03:00
parent 75a05fc2b3
commit 2b8f90e107
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
sstables/sstables.cc
View File

@@ -4318,15 +4318,18 @@ public:
if (load_save_meta) {
co_await load_metadata();
}
// now we can open the component file. any extensions applied should write info into metadata
auto f = co_await _sst->open_file(_type, open_flags::wo | open_flags::create, foptions);
// now we can open the component sink. any extensions applied should write info into metadata.
// We use make_component_sink rather than open_file + make_file_output_stream because
// object storage (S3) backends only support writing through upload sinks, not through
// file::write_dma (readable_file is read-only).
auto sink = co_await _sst->_storage->make_component_sink(*_sst, _type, open_flags::wo | open_flags::create, stream_options);
// Save back to disk.
if (load_save_meta) {
co_await save_metadata();
}
co_return co_await make_file_output_stream(std::move(f), stream_options);
co_return output_stream<char>(std::move(sink));
}
future<shared_sstable> close() override {
if (_last_component) {