mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-05-30 03:30:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

main: verify sufficient memory per shard

Browse Source 
Refuse to boot if we don't have at least 1 GiB per shard, unless in developer
mode.

The primary violator here is docker, but since it starts in developer mode,
it won't get fixed.  We need some extra logic for this case.
Message-Id: <20161221090222.28677-1-avi@scylladb.com>
This commit is contained in:
Avi Kivity
2016-12-21 11:02:22 +02:00
committed by Pekka Enberg
parent 868b4d110c
commit 339cc0c2fa
1 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
main.cc
View File

@@ -296,6 +296,25 @@ verify_seastar_io_scheduler(bool has_max_io_requests, bool developer_mode) {
});
}
static
void
verify_adequate_memory_per_shard(bool developer_mode) {
auto mem = memory::stats().total_memory();
auto shards = smp::count;
auto shard_mem = mem / shards;
if (shard_mem >= (1 << 30)) {
return;
}
if (developer_mode) {
startlog.warn("Only {} MiB per shard; this is below the recommended minimum of 1 GiB/shard;"
" continuing since running in developer mode", shard_mem >> 20);
} else {
startlog.error("Only {} MiB per shard; this is below the recommended minimum of 1 GiB/shard; terminating."
"Configure more memory (--memory option) or decrease shard count (--smp option).");
throw std::runtime_error("configuration (memory per shard too low)");
}
}
int main(int ac, char** av) {
int return_value = 0;
try {
@@ -361,6 +380,7 @@ int main(int ac, char** av) {
apply_logger_settings(cfg->default_log_level(), cfg->logger_log_level(),
cfg->log_to_stdout(), cfg->log_to_syslog());
verify_rlimit(cfg->developer_mode());
verify_adequate_memory_per_shard(cfg->developer_mode());
dht::set_global_partitioner(cfg->partitioner(), cfg->murmur3_partitioner_ignore_msb_bits());
auto start_thrift = cfg->start_rpc();
uint16_t api_port = cfg->api_port();