mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-04-19 16:15:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

compaction_test: fix use-after-move issue

Browse Source 
We were moving `compaction_type_options` inside a loop, so on the
second iteration the test received an already moved-from instance.
This commit is contained in:
Ernest Zaslavsky
2026-03-17 11:31:48 +02:00
parent 437a581b04
commit 405c032f48
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/boost/sstable_compaction_test.cc
View File

@@ -508,7 +508,7 @@ SEASTAR_TEST_CASE(compact_02) {
template <typename ExceptionType>
static void compact_corrupted_by_compression_mode(const std::string& tname,
compress_sstable compress,
compaction::compaction_type_options&& options,
compaction::compaction_type_options options,
const sstring& error_msg)
{
test_env::do_with_async([&] (test_env& env) {
@@ -577,7 +577,7 @@ static void compact_corrupted_by_compression_mode(const std::string& tname,
template <typename ExceptionType>
static void compact_corrupted(const std::string& tname, compaction::compaction_type_options&& options, const sstring& error_msg) {
for (const auto& compress : {compress_sstable::no, compress_sstable::yes}) {
compact_corrupted_by_compression_mode<ExceptionType>(tname, compress, std::move(options), error_msg);
compact_corrupted_by_compression_mode<ExceptionType>(tname, compress, options, error_msg);
}
}