mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-06-08 16:03:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge 'repair: Load repair history in background' from Asias He

Browse Source 
Currently, we load the repair history during boot up. If the number of
repair history entries is high, it might take a while to load them.

In my test, to load 10M entries, it took around 60 seconds.

It is not a must to load the entries during boot up. It is better to
load them in the background to speed up the boot time.

Fixes #17993

Closes scylladb/scylladb#17994

* github.com:scylladb/scylladb:
  repair: Load repair history in background
  repair: Abort load_history process in shutdown
This commit is contained in:
Botond Dénes
2024-04-02 10:53:10 +03:00
parent fd12052c89 99b7ccfa8b
commit 469ff4f290
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
repair/row_level.cc
View File

@@ -3188,12 +3188,13 @@ repair_service::repair_service(distributed<gms::gossiper>& gossiper,
}
future<> repair_service::start() {
co_await load_history();
_load_history_done = load_history();
co_await init_ms_handlers();
}
future<> repair_service::stop() {
co_await _repair_module->stop();
co_await std::move(_load_history_done);
co_await uninit_ms_handlers();
if (this_shard_id() == 0) {
co_await _gossiper.local().unregister_(_gossip_helper);
@@ -3251,6 +3252,7 @@ future<> repair_service::load_history() {
rlogger.info("Loading repair history for keyspace={}, table={}, table_uuid={}",
table->schema()->ks_name(), table->schema()->cf_name(), table_uuid);
co_await _sys_ks.local().get_repair_history(table_uuid, [this] (const auto& entry) -> future<> {
get_repair_module().check_in_shutdown();
auto start = entry.range_start == std::numeric_limits<int64_t>::min() ? dht::minimum_token() : dht::token::from_int64(entry.range_start);
auto end = entry.range_end == std::numeric_limits<int64_t>::min() ? dht::maximum_token() : dht::token::from_int64(entry.range_end);
auto range = dht::token_range(dht::token_range::bound(start, false), dht::token_range::bound(end, true));

2
repair/row_level.hh
View File

@@ -110,6 +110,8 @@ class repair_service : public seastar::peering_sharded_service<repair_service> {
seastar::semaphore _memory_sem;
seastar::named_semaphore _load_parallelism_semaphore = {16, named_semaphore_exception_factory{"Load repair history parallelism"}};
future<> _load_history_done = make_ready_future<>();
future<> init_ms_handlers();
future<> uninit_ms_handlers();