mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-05-28 10:41:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

database: snapshot_on_all: flush before snapshot if needed

Browse Source 
flush_on_all shards before taking the snapshot if !skip_flush
so we can get rid of flushing in table::snapshot.

Refs #10500

Signed-off-by: Benny Halevy <bhalevy@scylladb.com>
This commit is contained in:
Benny Halevy
2022-05-07 17:05:45 +03:00
parent 33bd52921e
commit 46c950fb31
1 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
replica/database.cc
View File

@@ -2097,20 +2097,26 @@ future<> database::flush_on_all(std::string_view ks_name) {
}
future<> database::snapshot_on_all(std::string_view ks_name, std::vector<sstring> table_names, sstring tag, bool skip_flush) {
co_await coroutine::parallel_for_each(table_names, [this, ks_name, tag = std::move(tag), skip_flush] (const auto& table_name) {
return container().invoke_on_all([ks_name, &table_name, tag, skip_flush] (replica::database& db) {
co_await coroutine::parallel_for_each(table_names, [this, ks_name, tag = std::move(tag), skip_flush] (const auto& table_name) -> future<> {
if (!skip_flush) {
co_await flush_on_all(ks_name, table_name);
}
co_await container().invoke_on_all([ks_name, &table_name, tag, skip_flush] (replica::database& db) {
auto& t = db.find_column_family(ks_name, table_name);
return t.snapshot(db, tag, skip_flush);
return t.snapshot(db, tag, true);
});
});
}
future<> database::snapshot_on_all(std::string_view ks_name, sstring tag, bool skip_flush) {
auto& ks = find_keyspace(ks_name);
co_await coroutine::parallel_for_each(ks.metadata()->cf_meta_data(), [this, tag = std::move(tag), skip_flush] (const auto& pair) {
return container().invoke_on_all([id = pair.second, tag, skip_flush] (replica::database& db) {
co_await coroutine::parallel_for_each(ks.metadata()->cf_meta_data(), [this, tag = std::move(tag), skip_flush] (const auto& pair) -> future<> {
if (!skip_flush) {
co_await flush_on_all(pair.second->id());
}
co_await container().invoke_on_all([id = pair.second, tag, skip_flush] (replica::database& db) {
auto& t = db.find_column_family(id);
return t.snapshot(db, tag, skip_flush);
return t.snapshot(db, tag, true);
});
});
}