mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-06-02 13:06:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

sstable_test: Open-code do_with_cloned_tmp_directory

Browse Source 
The statistics_rewrite case uses the helper that creates a copy of the
provided static directory, but it's the only user of this helper. It's
better to open-code it into the test case.

Signed-off-by: Pavel Emelyanov <xemul@scylladb.com>
This commit is contained in:
Pavel Emelyanov
2023-02-09 16:55:46 +03:00
parent 19c1afb20a
commit 47022bf750
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
test/boost/sstable_test.cc
View File

@@ -482,8 +482,15 @@ test_sstable_exists(sstring dir, unsigned long generation, bool exists) {
}
SEASTAR_TEST_CASE(statistics_rewrite) {
return test_setup::do_with_cloned_tmp_directory(uncompressed_dir(), [] (test_env& env, sstring uncompressed_dir, sstring generation_dir) {
auto sstp = env.reusable_sst(uncompressed_schema(), uncompressed_dir, 1).get0();
return test_env::do_with_async([] (test_env& env) {
auto uncompressed_dir_copy = env.tempdir().path();
for (const auto& entry : std::filesystem::directory_iterator(uncompressed_dir().c_str())) {
std::filesystem::copy(entry.path(), uncompressed_dir_copy / entry.path().filename());
}
auto generation_dir = (uncompressed_dir_copy / sstables::staging_dir).native();
std::filesystem::create_directories(generation_dir);
auto sstp = env.reusable_sst(uncompressed_schema(), uncompressed_dir_copy.native(), 1).get0();
test::create_links(*sstp, generation_dir).get();
test_sstable_exists(generation_dir, 1, true).get();
@@ -493,8 +500,6 @@ SEASTAR_TEST_CASE(statistics_rewrite) {
sstp = env.reusable_sst(uncompressed_schema(), generation_dir, 1).get0();
BOOST_REQUIRE(sstp->get_sstable_level() == 10);
return make_ready_future<>();
});
}