mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-06-02 21:17:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

types: validate tuples without linearizing

Browse Source 
We can validate tuples directly from fragmented buffers now.
This commit is contained in:
Michał Chojnowski
2020-11-27 12:47:58 +01:00
parent a7dd736d03
commit 4fe41b69fd
1 changed files with 7 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
types.cc
View File

@@ -1401,16 +1401,15 @@ tuple_type_impl::get_instance(std::vector<data_type> types) {
return intern::get_instance(std::move(types));
}
static void validate_aux(const tuple_type_impl& t, bytes_view v, cql_serialization_format sf) {
template <FragmentedView View>
static void validate_aux(const tuple_type_impl& t, View v, cql_serialization_format sf) {
auto ti = t.all_types().begin();
auto vi = tuple_deserializing_iterator::start(v);
auto end = tuple_deserializing_iterator::finish(v);
while (ti != t.all_types().end() && vi != end) {
if (*vi) {
(*ti)->validate(**vi, sf);
while (ti != t.all_types().end() && v.size_bytes()) {
std::optional<View> e = read_tuple_element(v);
if (e) {
(*ti)->validate(*e, sf);
}
++ti;
++vi;
}
}
@@ -1577,9 +1576,7 @@ struct validate_visitor {
});
}
void operator()(const tuple_type_impl& t) {
with_linearized(v, [this, &t] (bytes_view bv) {
validate_aux(t, bv, sf);
});
validate_aux(t, v, sf);
}
};
}