mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-05-29 11:10:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

row_cache: Improve trace-level logging

Browse Source 
Print MVCC snapshot to help distinguish reads which use different snapshots.

Also, print the whole cursor, not just its position. This helps in
determining which MVCC version the iterator comes from.
This commit is contained in:
Tomasz Grabiec
2021-10-08 00:14:55 +02:00
parent 65a1a0247a
commit 5196d450bd
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
cache_flat_mutation_reader.hh
View File

@@ -202,7 +202,8 @@ public:
, _read_context(ctx) // ctx is owned by the caller, who's responsible for closing it.
, _next_row(*_schema, *_snp, false, _read_context.is_reversed())
{
clogger.trace("csm {}: table={}.{}, reversed={}", fmt::ptr(this), _schema->ks_name(), _schema->cf_name(), _read_context.is_reversed());
clogger.trace("csm {}: table={}.{}, reversed={}, snap={}", fmt::ptr(this), _schema->ks_name(), _schema->cf_name(), _read_context.is_reversed(),
fmt::ptr(&*_snp));
push_mutation_fragment(*_schema, _permit, partition_start(std::move(dk), _snp->partition_tombstone()));
}
cache_flat_mutation_reader(schema_ptr s,
@@ -356,7 +357,7 @@ future<> cache_flat_mutation_reader::do_fill_buffer() {
}
}
_next_row.maybe_refresh();
clogger.trace("csm {}: next={}, cont={}", fmt::ptr(this), _next_row.position(), _next_row.continuous());
clogger.trace("csm {}: next={}", fmt::ptr(this), _next_row);
_lower_bound_changed = false;
while (_state == state::reading_from_cache) {
copy_from_cache_to_buffer();