mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-05-28 10:41:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

topology_coordinator: Add action_failed() helper

Browse Source 
It checks if the action holder holds a failed action.

Signed-off-by: Pavel Emelyanov <xemul@scylladb.com>
This commit is contained in:
Pavel Emelyanov
2024-02-20 12:54:03 +03:00
parent c5f01349b1
commit 79b5a75ded
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
service/topology_coordinator.cc
View File

@@ -835,6 +835,10 @@ class topology_coordinator : public endpoint_lifecycle_subscriber {
seastar::gate _async_gate;
bool action_failed(background_action_holder& holder) const {
return holder && holder->failed();
}
// This function drives background_action_holder towards "executed successfully"
// by starting the action if it is not already running or if the previous instance
// of the action failed. If the action is already running, it does nothing.
@@ -842,7 +846,7 @@ class topology_coordinator : public endpoint_lifecycle_subscriber {
bool advance_in_background(locator::global_tablet_id gid, background_action_holder& holder, const char* name,
std::function<future<>()> action) {
if (!holder || holder->failed()) {
if (holder && holder->failed()) {
if (action_failed(holder)) {
// Prevent warnings about abandoned failed future. Logged below.
holder->ignore_ready_future();
}
@@ -1043,7 +1047,7 @@ class topology_coordinator : public endpoint_lifecycle_subscriber {
[] { throw std::runtime_error("stream_tablet failed due to error injection"); });
}
if (tablet_state.streaming && tablet_state.streaming->failed()) {
if (action_failed(tablet_state.streaming)) {
if (check_excluded_replicas()) {
transition_to_with_barrier(locator::tablet_transition_stage::cleanup_target);
break;