mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-06-04 22:13:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

kl sstable reader: replace switch with standard flow control

Browse Source 
We get rid of the switch by using the infinite loop around the
switch for jumping to the first case, adding an infinite loop
around the second case (one break from the switch with the
state of the first case becomes a break of the new while),
and adding an if around the first case (because we never break
in the first case).
This commit is contained in:
Wojciech Mitros
2021-07-06 15:46:45 +02:00
parent cfe6a46a60
commit 7a6729159f
1 changed files with 6 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
sstables/kl/reader_impl.hh
View File

@@ -215,8 +215,7 @@ public:
private:
processing_result_generator do_process_state() {
while (true) {
switch (_state) {
case state::ROW_START:
if (_state == state::ROW_START) {
if (read_short_length_bytes(*_processing_data, _key) != read_status::ready) {
_state = state::DELETION_TIME;
co_yield row_consumer::proceed::yes;
@@ -243,7 +242,8 @@ private:
co_yield row_consumer::proceed::no;
}
}
case state::ATOM_START:
}
while (true) {
if (read_short_length_bytes(*_processing_data, _key) != read_status::ready) {
_state = state::ATOM_START_2;
co_yield row_consumer::proceed::yes;
@@ -251,11 +251,7 @@ private:
if (_u16 == 0) {
// end of row marker
_state = state::ROW_START;
if (_consumer.consume_row_end() ==
row_consumer::proceed::no) {
co_yield row_consumer::proceed::no;
continue;
}
co_yield _consumer.consume_row_end();
break;
} else {
_state = state::ATOM_MASK;
@@ -294,11 +290,8 @@ private:
_key.release();
_val.release();
_state = state::ATOM_START;
if (ret == row_consumer::proceed::no) {
co_yield row_consumer::proceed::no;
continue;
}
break;
co_yield ret;
continue;
}
} else if ((mask & column_mask::counter) != column_mask::none) {
_deleted = false;
@@ -377,13 +370,8 @@ private:
_val_fragmented.remove_prefix(_val_fragmented.size_bytes());
_state = state::ATOM_START;
co_yield ret;
continue;
}
default:
__builtin_unreachable();
}
co_yield row_consumer::proceed::yes;
}
}
public: