mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-06-03 21:47:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

storage_proxy: Avoid shard_of() use in mutate_counter_on_leader_and_replicate()

Browse Source 
Cunters are not supported with tablets, so we should not reach this path.
This commit is contained in:
Tomasz Grabiec
2024-04-16 09:20:40 +02:00
parent db2809317d
commit 7c3291b5ea
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
service/storage_proxy.cc
View File

@@ -3126,7 +3126,9 @@ future<>
storage_proxy::mutate_counter_on_leader_and_replicate(const schema_ptr& s, frozen_mutation fm, db::consistency_level cl, clock_type::time_point timeout,
tracing::trace_state_ptr trace_state, service_permit permit) {
auto erm = _db.local().find_column_family(s).get_effective_replication_map();
auto shard = erm->get_sharder(*s).shard_of(fm.token(*s));
// FIXME: This does not handle intra-node tablet migration properly.
// Refs https://github.com/scylladb/scylladb/issues/18180
auto shard = erm->get_sharder(*s).shard_for_reads(fm.token(*s));
bool local = shard == this_shard_id();
get_stats().replica_cross_shard_ops += !local;
return _db.invoke_on(shard, {_write_smp_service_group, timeout}, [&proxy = container(), gs = global_schema_ptr(s), fm = std::move(fm), cl, timeout, gt = tracing::global_trace_state_ptr(std::move(trace_state)), permit = std::move(permit), local] (replica::database& db) {