mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-05-20 23:02:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

transport: fix process_startup cert-auth path missing connection-ready setup

Browse Source 
When authenticate() returns a user directly (certificate-based auth,
introduced in 20e9619bb1), process_startup was missing the same
post-authentication bookkeeping that the no-auth and SASL paths perform:

  - update_scheduling_group(): without it, the connection runs under the
    default scheduling group instead of the one mapped to the user's
    service level.

  - _authenticating = false / _ready = true: without them,
    system.clients reports connection_stage = AUTHENTICATING forever
    instead of READY.

  - on_connection_ready(): without it, the connection never releases its
    slot in the uninitialized-connections concurrency semaphore (acquired
    at connection creation), leaking one unit per cert-authenticated
    connection for the lifetime of the connection.

The omission was introduced when on_connection_ready() was added to the
else and SASL branches in 474e84199c but the cert-auth branch was missed.

Fixes: 20e9619bb1 ("auth: support certificate-based authentication")

Signed-off-by: Pavel Emelyanov <xemul@scylladb.com>
Co-authored-by: Marcin Maliszkiewicz <marcinmal@scylladb.com>
(cherry picked from commit 2d8540f1ee)
This commit is contained in:
Pavel Emelyanov
2026-03-24 18:02:46 +03:00
committed by Marcin Maliszkiewicz
parent 9be759828f
commit 82179667bb
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
transport/server.cc
View File

@@ -1016,6 +1016,10 @@ future<std::unique_ptr<cql_server::response>> cql_server::connection::process_st
client_state.set_login(std::move(*opt_user));
co_await client_state.check_user_can_login();
co_await client_state.maybe_update_per_service_level_params();
update_scheduling_group();
_authenticating = false;
_ready = true;
on_connection_ready();
res = make_ready(stream, trace_state);
} else {
res = make_autheticate(stream, a.qualified_java_name(), trace_state);