mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-04-24 18:40:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: vector_search: check [[nodiscard]] return values of expected<> types

Browse Source 
Clang 22 verifies [[nodiscard]] for co_await,
causing compilation failures where return values of expected<> were
silently discarded.

These call sites were discarding the return value of client::request()
and vector_store_client::ann(), both of which return expected<> types
marked [[nodiscard]]. Rather than suppressing the warning with (void)
casts, properly check the return values using the established test
patterns: BOOST_CHECK(result) where the call is expected to succeed,
and BOOST_CHECK(!result) where the call is expected to fail.

Closes scylladb/scylladb#29297
This commit is contained in:
Avi Kivity
2026-03-31 20:25:56 +03:00
committed by Botond Dénes
parent 176f6fb59e
commit 8c629d55b0
2 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
test/vector_search/client_test.cc
View File

@@ -181,7 +181,8 @@ SEASTAR_TEST_CASE(remains_down_when_server_status_is_not_serving) {
auto down_server = co_await make_unavailable_server();
client client{client_test_logger, make_endpoint(down_server), REQUEST_TIMEOUT, shared_ptr<seastar::tls::certificate_credentials>{}};
co_await client.request(operation_type::POST, PATH, CONTENT, as.reset());
auto res = co_await client.request(operation_type::POST, PATH, CONTENT, as.reset());
BOOST_CHECK(!res);
auto server = co_await make_available(down_server);
server->next_status_response(vs_mock_server::response{seastar::http::reply::status_type::ok, rjson::quote_json_string(status)});

12
test/vector_search/vector_store_client_test.cc
View File

@@ -583,7 +583,8 @@ SEASTAR_TEST_CASE(vector_store_client_uri_update) {
// Wait until requests are handled by s2
// To avoid race condition we wait twice long as DNS refresh interval before checking the result.
BOOST_CHECK(co_await repeat_until(DNS_REFRESH_INTERVAL * 2, [&]() -> future<bool> {
co_await vs.ann("ks", "idx", schema, std::vector<float>{0.1, 0.2, 0.3}, 2, rjson::empty_object(), as.reset());
auto keys = co_await vs.ann("ks", "idx", schema, std::vector<float>{0.1, 0.2, 0.3}, 2, rjson::empty_object(), as.reset());
BOOST_CHECK(keys);
co_return s2->ann_requests().size() > 0;
}));
},
@@ -647,7 +648,8 @@ SEASTAR_TEST_CASE(vector_store_client_multiple_ips_load_balancing) {
// The load balancing algorithm is random, so we send requests in a loop
// until both servers have received at least one, verifying that load is distributed.
BOOST_CHECK(co_await repeat_until([&]() -> future<bool> {
co_await vs.ann("ks", "idx", schema, std::vector<float>{0.1, 0.2, 0.3}, 2, rjson::empty_object(), as.reset());
auto keys = co_await vs.ann("ks", "idx", schema, std::vector<float>{0.1, 0.2, 0.3}, 2, rjson::empty_object(), as.reset());
BOOST_CHECK(keys);
co_return !s1->ann_requests().empty() && !s2->ann_requests().empty();
}));
},
@@ -711,7 +713,8 @@ SEASTAR_TEST_CASE(vector_store_client_multiple_uris_load_balancing) {
// The load balancing algorithm is random, so we send requests in a loop
// until both servers have received at least one, verifying that load is distributed.
BOOST_CHECK(co_await repeat_until([&]() -> future<bool> {
co_await vs.ann("ks", "idx", schema, std::vector<float>{0.1, 0.2, 0.3}, 2, rjson::empty_object(), as.reset());
auto keys = co_await vs.ann("ks", "idx", schema, std::vector<float>{0.1, 0.2, 0.3}, 2, rjson::empty_object(), as.reset());
BOOST_CHECK(keys);
co_return !s1->ann_requests().empty() && !s2->ann_requests().empty();
}));
},
@@ -920,7 +923,8 @@ SEASTAR_TEST_CASE(vector_store_client_updates_backoff_max_time_from_read_request
// Set request timeout to 100ms, hence max backoff time is 2x100ms = 200ms.
cfg.db_config->read_request_timeout_in_ms.set(100);
// Trigger status checking by making ANN request to unavailable server.
co_await vs.ann("ks", "idx", schema, std::vector<float>{0.1, 0.2, 0.3}, 2, rjson::empty_object(), as.reset());
auto result = co_await vs.ann("ks", "idx", schema, std::vector<float>{0.1, 0.2, 0.3}, 2, rjson::empty_object(), as.reset());
BOOST_CHECK(!result);
co_await repeat_until([&unavail_s]() -> future<bool> {
// Wait for 1 ANN request + 4 status check connections (5 total)
co_return unavail_s->connections().size() > 4;