mirrors/scylladb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

utils: loading_cache: tighten clock sampling

Browse Source 
Sample the clock once to avoid the filter returning different results.

Range algorithms may use multiple passes, so it's better to return
consistent results.

Closes scylladb/scylladb#21400
This commit is contained in:
Avi Kivity
2024-10-31 19:38:11 +02:00
committed by Pavel Emelyanov
parent 50fbab29ca
commit 9e67649fe5
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
utils/loading_cache.hh
View File

@@ -658,11 +658,12 @@ private:
// Future is waited on indirectly in `stop()` (via `_timer_reads_gate`).
// FIXME: error handling
(void)with_gate(_timer_reads_gate, [this] {
auto now = loading_cache_clock_type::now();
auto to_reload = std::array<lru_list_type*, 2>({&_unprivileged_lru_list, &_lru_list})
| std::views::transform([] (auto* list_ptr) -> decltype(auto) { return *list_ptr; })
| std::views::join
| std::views::filter([this] (ts_value_lru_entry& lru_entry) {
return lru_entry.timestamped_value().loaded() + _cfg.refresh < loading_cache_clock_type::now();
| std::views::filter([this, now] (ts_value_lru_entry& lru_entry) {
return lru_entry.timestamped_value().loaded() + _cfg.refresh < now;
})
| std::views::transform([] (ts_value_lru_entry& lru_entry) {
return lru_entry.timestamped_value_ptr();