mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-05-29 11:10:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

compaction: don't rule out compacting sstables in validate-mode scrub

Browse Source 
even sstables being compacted must be validated. otherwise scrub
validate may return false negative.

Signed-off-by: Raphael S. Carvalho <raphaelsc@scylladb.com>
This commit is contained in:
Raphael S. Carvalho
2021-08-27 17:35:17 -03:00
committed by Benny Halevy
parent 58a9a24ff0
commit a145ffcf52
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
compaction/compaction_manager.cc
View File

@@ -765,7 +765,9 @@ future<> compaction_manager::rewrite_sstables(column_family* cf, sstables::compa
}
future<> compaction_manager::perform_sstable_scrub_validate_mode(column_family* cf) {
return run_custom_job(cf, sstables::compaction_type::Scrub, [this, &cf = *cf, sstables = get_candidates(*cf)] () mutable -> future<> {
// All sstables must be included, even the ones being compacted, such that everything in table is validated.
auto all_sstables = boost::copy_range<std::vector<sstables::shared_sstable>>(*cf->get_sstables());
return run_custom_job(cf, sstables::compaction_type::Scrub, [this, &cf = *cf, sstables = std::move(all_sstables)] () mutable -> future<> {
class pending_tasks {
compaction_manager::stats& _stats;
size_t _n;