messaging_service: don't use parameter defaults in constructor

This commit is contained in:
Kamil Braun
2023-06-20 12:31:18 +02:00
parent 7f3ad6bd25
commit a78cc17bd4
3 changed files with 3 additions and 4 deletions

View File

@@ -322,8 +322,7 @@ private:
public:
using clock_type = lowres_clock;
messaging_service(gms::inet_address ip = gms::inet_address("0.0.0.0"),
uint16_t port = 7000);
messaging_service(gms::inet_address ip, uint16_t port);
messaging_service(config cfg, scheduling_config scfg, std::shared_ptr<seastar::tls::credentials_builder>);
~messaging_service();

View File

@@ -68,7 +68,7 @@ int main(int ac, char ** av) {
token_metadata.start([] () noexcept { return db::schema_tables::hold_merge_lock(); }, locator::token_metadata::config{}).get();
auto stop_token_mgr = defer([&] { token_metadata.stop().get(); });
messaging.start(listen).get();
messaging.start(listen, 7000).get();
auto stop_messaging = deferred_stop(messaging);
gms::gossip_config gcfg;

View File

@@ -171,7 +171,7 @@ int main(int ac, char ** av) {
const gms::inet_address listen = gms::inet_address(config["listen-address"].as<std::string>());
utils::fb_utilities::set_broadcast_address(listen);
seastar::sharded<netw::messaging_service> messaging;
return messaging.start(listen).then([config, stay_alive, &messaging] () {
return messaging.start(listen, 7000).then([config, stay_alive, &messaging] () {
auto testers = new distributed<tester>;
return testers->start(std::ref(messaging)).then([testers]{
auto port = testers->local().port();