mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-05-12 19:02:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge 'gms: inet_address: drop unused raw_addr method and modernize comperators' from Benny Halevy

Browse Source 
Drop the unused `gms::inet_address::raw_addr` method
and modernize operator== and operator< as class methods

* Cleanup only, no backport needed

Closes scylladb/scylladb#20681

* github.com:scylladb/scylladb:
  gms: inet_address: modernize comparison operators
  gms: inet_address: drop unused raw_addr method
This commit is contained in:
Avi Kivity
2024-09-19 21:20:11 +03:00
parent 7e7701d436 5ccdf1cf1c
commit b015c85d31
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
gms/inet_address.hh
View File

@@ -58,13 +58,9 @@ public:
bytes_view bytes() const noexcept {
return bytes_view(reinterpret_cast<const int8_t*>(_addr.data()), _addr.size());
}
// TODO remove
uint32_t raw_addr() const {
return addr().as_ipv4_address().ip;
}
friend inline bool operator==(const inet_address& x, const inet_address& y) noexcept = default;
friend inline bool operator<(const inet_address& x, const inet_address& y) noexcept {
return x.bytes() < y.bytes();
constexpr bool operator==(const inet_address&) const noexcept = default;
constexpr auto operator<=>(const inet_address& o) const noexcept {
return bytes() <=> o.bytes();
}
friend struct std::hash<inet_address>;