mirrors/scylladb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

config: drop reversed_reads_auto_bypass_cache

Browse Source 
Reverse reads have already been with us for a while, thus this back
door option to bypass in-memory data cache for reversed queries can
be retired.
This commit is contained in:
Łukasz Paszkowski
2024-05-28 10:31:23 +02:00
parent 80df313f49
commit b270097f1f
6 changed files with 1 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
conf/scylla.yaml
View File

@@ -539,9 +539,6 @@ commitlog_total_space_in_mb: -1
# Keep at 12 for new clusters.
murmur3_partitioner_ignore_msb_bits: 12
# Bypass in-memory data cache (the row cache) when performing reversed queries.
# reversed_reads_auto_bypass_cache: false
# Use on a new, parallel algorithm for performing aggregate queries.
# Set to `false` to fall-back to the old algorithm.
# enable_parallelized_aggregation: true

2
db/config.cc
View File

@@ -1066,8 +1066,6 @@ db::config::config(std::shared_ptr<db::extensions> exts)
"To preserve backwards compatibility on old clusters, Scylla's default setting is `warn`. "
"New clusters have this option set to `true` by scylla.yaml (which overrides the default `warn`), "
"to make sure that trying to create an invalid view causes an error.")
, reversed_reads_auto_bypass_cache(this, "reversed_reads_auto_bypass_cache", liveness::LiveUpdate, value_status::Used, false,
"Bypass in-memory data cache (the row cache) when performing reversed queries.")
, enable_cql_config_updates(this, "enable_cql_config_updates", liveness::LiveUpdate, value_status::Used, true,
"Make the system.config table UPDATEable.")
, enable_parallelized_aggregation(this, "enable_parallelized_aggregation", liveness::LiveUpdate, value_status::Used, true,

1
db/config.hh
View File

@@ -396,7 +396,6 @@ public:
named_value<bool> cdc_dont_rewrite_streams;
named_value<tri_mode_restriction> strict_allow_filtering;
named_value<tri_mode_restriction> strict_is_not_null_in_views;
named_value<bool> reversed_reads_auto_bypass_cache;
named_value<bool> enable_cql_config_updates;
named_value<bool> enable_parallelized_aggregation;

1
replica/database.cc
View File

@@ -1257,7 +1257,6 @@ keyspace::make_column_family_config(const schema& s, const database& db) const {
cfg.statement_scheduling_group = _config.statement_scheduling_group;
cfg.enable_metrics_reporting = db_config.enable_keyspace_column_family_metrics();
cfg.enable_node_aggregated_table_metrics = db_config.enable_node_aggregated_table_metrics();
cfg.reversed_reads_auto_bypass_cache = db_config.reversed_reads_auto_bypass_cache;
cfg.tombstone_warn_threshold = db_config.tombstone_warn_threshold();
cfg.view_update_concurrency_semaphore_limit = _config.view_update_concurrency_semaphore_limit;
cfg.data_listeners = &db.data_listeners();

3
replica/database.hh
View File

@@ -416,9 +416,6 @@ public:
bool enable_node_aggregated_table_metrics = true;
size_t view_update_concurrency_semaphore_limit;
db::data_listeners* data_listeners = nullptr;
// Not really table-specific (it's a global configuration parameter), but stored here
// for easy access from `table` member functions:
utils::updateable_value<bool> reversed_reads_auto_bypass_cache{false};
uint32_t tombstone_warn_threshold{0};
unsigned x_log2_compaction_groups{0};
utils::updateable_value<bool> enable_compacting_data_for_streaming_and_repair;

2
replica/table.cc
View File

@@ -246,7 +246,7 @@ table::make_reader_v2(schema_ptr s,
});
const auto bypass_cache = slice.options.contains(query::partition_slice::option::bypass_cache);
if (cache_enabled() && !bypass_cache && !(slice.is_reversed() && _config.reversed_reads_auto_bypass_cache())) {
if (cache_enabled() && !bypass_cache) {
if (auto reader_opt = _cache.make_reader_opt(s, permit, range, slice, &_compaction_manager.get_tombstone_gc_state(), std::move(trace_state), fwd, fwd_mr)) {
readers.emplace_back(std::move(*reader_opt));
}