mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-05-12 19:02:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: memtable_test: replace BOOST_ASSERT with BOOST_REQURE

Browse Source 
before this change, we verify the behavior of design under test using
`BOOST_ASSERT()`, which is a wrapper around `assert()`, so if a test
fails, the test just aborts. this is not very helpful for postmortem
debugging.

after this change, we use `BOOST_REQUIRE` macro for verifying the
behavior, so that Boost.Test prints out the condition if it does not
hold when we test it.

Refs #19034
Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
(cherry picked from commit 2df4e9cfc2)
This commit is contained in:
Kefu Chai
2024-06-12 13:18:54 +08:00
committed by Mergify
parent 3eb15e841a
commit b3de65a8fb
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test/boost/memtable_test.cc
View File

@@ -1090,15 +1090,15 @@ SEASTAR_TEST_CASE(failed_flush_prevents_writes) {
// Trigger flush
auto f = t.flush();
BOOST_ASSERT(eventually_true([&] {
BOOST_REQUIRE(eventually_true([&] {
return db.cf_stats()->failed_memtables_flushes_count - failed_memtables_flushes_count >= 4;
}));
// The flush failed, make sure there is still data in memtable.
BOOST_ASSERT(t.min_memtable_timestamp() < api::max_timestamp);
BOOST_REQUIRE_LT(t.min_memtable_timestamp(), api::max_timestamp);
utils::get_local_injector().disable("table_seal_active_memtable_reacquire_write_permit");
BOOST_ASSERT(eventually_true([&] {
BOOST_REQUIRE(eventually_true([&] {
// The error above is no longer being injected, so
// seal_active_memtable retry loop should eventually succeed
return t.min_memtable_timestamp() == api::max_timestamp;