mirrors/scylladb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

future: disable inline continuations in debug mode

Browse Source 
Inline continuations can hide bugs where a stack variable is captured by
reference.  Disable them in debug mode.
This commit is contained in:
Avi Kivity
2015-06-02 13:22:35 +03:00
parent f9dd73d57f
commit ba0e4e45bc
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
core/future.hh
View File

@@ -327,6 +327,13 @@ struct continuation final : task {
future_state<T...> _state;
Func _func;
};
#ifndef DEBUG
static constexpr unsigned max_inlined_continuations = 256;
#else
static constexpr unsigned max_inlined_continuations = 1;
#endif
/// \endcond
/// \brief promise - allows a future value to be made available at a later time.
@@ -586,7 +593,7 @@ private:
futurize_t<Ret> then(Func&& func, Param&& param) noexcept {
using futurator = futurize<Ret>;
using P = typename futurator::promise_type;
if (state()->available() && (++future_avail_count % 256)) {
if (state()->available() && (++future_avail_count % max_inlined_continuations)) {
try {
return futurator::apply(std::forward<Func>(func), param(std::move(*state())));
} catch (...) {