mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-06-05 14:33:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

shared_token_metadata: set: check version monotonicity

Browse Source 
Setting the ring version backwards means it got out of sync.
Possibly concurrent updates weren't serialized properly
using token_metadata_lock / mutate_token_metadata.

Signed-off-by: Benny Halevy <bhalevy@scylladb.com>
This commit is contained in:
Benny Halevy
2021-09-30 20:11:57 +03:00
parent 43160abaec
commit bb0ea0b1c0
2 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
locator/token_metadata.cc
View File

@@ -1424,6 +1424,13 @@ const endpoint_dc_rack& topology::get_location(const inet_address& ep) const {
/////////////////// class topology end /////////////////////////////////////////
void shared_token_metadata::set(mutable_token_metadata_ptr tmptr) noexcept {
if (_shared->get_ring_version() >= tmptr->get_ring_version()) {
on_internal_error(tlogger, format("shared_token_metadata: must not set non-increasing version: {} -> {}", _shared->get_ring_version(), tmptr->get_ring_version()));
}
_shared = std::move(tmptr);
}
future<> shared_token_metadata::mutate_token_metadata(seastar::noncopyable_function<future<> (token_metadata&)> func) {
auto lk = co_await get_lock();
auto tm = co_await _shared->clone_async();

4
locator/token_metadata.hh
View File

@@ -379,9 +379,7 @@ public:
return _shared;
}
void set(mutable_token_metadata_ptr tmptr) noexcept {
_shared = std::move(tmptr);
}
void set(mutable_token_metadata_ptr tmptr) noexcept;
// Token metadata changes are serialized
// using the schema_tables merge_lock.