mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-06-02 13:06:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

sstables: compress: Use libdeflate for crc32

Browse Source 
Improves memtable flush performance by 10% in a CPU-bound case.

Unlike the zlib implementation, libdeflate is optimized for modern
CPUs. It utilizes the PCLMUL instruction.
This commit is contained in:
Tomasz Grabiec
2018-11-16 09:42:19 +01:00
parent 0ac1905f4f
commit bf0164cdaf
1 changed files with 22 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
sstables/checksum_utils.hh
View File

@@ -23,6 +23,7 @@
#include <zlib.h>
#include <seastar/util/gcc6-concepts.hh>
#include "libdeflate/libdeflate.h"
GCC6_CONCEPT(
template<typename Checksum>
@@ -85,6 +86,26 @@ struct zlib_crc32_checksummer {
static constexpr bool prefer_combine() { return false; } // crc32_combine() is very slow
};
struct libdeflate_crc32_checksummer {
static uint32_t init_checksum() {
return 0;
}
static uint32_t checksum(const char* input, size_t input_len) {
return checksum(init_checksum(), input, input_len);
}
static uint32_t checksum(uint32_t prev, const char* input, size_t input_len) {
return libdeflate_crc32(prev, input, input_len);
}
static uint32_t checksum_combine(uint32_t first, uint32_t second, size_t input_len2) {
return zlib_crc32_checksummer::checksum_combine(first, second, input_len2);
}
static constexpr bool prefer_combine() { return false; }
};
template<typename Checksum>
inline uint32_t checksum_combine_or_feed(uint32_t first, uint32_t second, const char* input, size_t input_len) {
if constexpr (Checksum::prefer_combine()) {
@@ -94,4 +115,4 @@ inline uint32_t checksum_combine_or_feed(uint32_t first, uint32_t second, const
}
}
using crc32_utils = zlib_crc32_checksummer;
using crc32_utils = libdeflate_crc32_checksummer;